pi-crew 0.9.1 → 0.9.2

package/CHANGELOG.md

@@ -1,5 +1,42 @@
 # Changelog
 
+## [v0.9.2] — package cleanup: remove scratch scripts leaked into npm tarball (2026-06-22)
+
+Patch release. **No code changes.** Purely a published-package hygiene fix.
+
+### What was wrong
+
+The `package.json` `files` field includes a root-level `*.mjs` glob, intended
+for the legit `install.mjs` (postinstall script). It accidentally also picked
+up three ad-hoc scratch scripts that were committed at the repo root during
+earlier development:
+
+- `test-tp.mjs` — a 12-line `tool-progress` format smoke print
+- `test-bugs-all.mjs` — an 89-line string-matching bug-fix verifier
+- `test-lastActivityAt.mjs` — a manual `node:test` for a heartbeat fallback
+
+All three shipped in the published npm tarball (v0.9.0 and v0.9.1) even though
+they are not part of `npm test` and have no runtime value for consumers.
+
+### Fix
+
+- `git rm`'d the three scratch scripts. The behavior they checked is covered by
+  the real unit suite (`test/unit/`), which does NOT ship to npm.
+- After the fix, the only `.mjs` in the tarball is the intended `install.mjs`.
+
+### Verification
+
+- tsc: 0
+- `npm pack --dry-run` confirms `install.mjs` is the only `.mjs` shipped
+- regression suite (env-allowlist, goal-p1d-schema): 11/11 pass
+- No behavior change — consumers see no functional difference
+
+### Breaking changes
+
+None.
+
+---
+
 ## [v0.9.1] — Windows essentials fix + cross-platform CI green (2026-06-22)
 
 Patch release. No new features. Fixes a real Windows bug reported by a user,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-crew",
-  "version": "0.9.1",
+  "version": "0.9.2",
   "description": "Pi extension for coordinated AI teams, workflows, worktrees, and async task orchestration",
   "author": "baphuongna",
   "license": "MIT",

package/test-bugs-all.mjs

@@ -1,89 +0,0 @@
-import fs from "node:fs";
-import path from "node:path";
-
-console.log("=== PI-CREW BUG FIXES VERIFICATION ===\n");
-
-let allPassed = true;
-
-// Bug #17: Check killAsync is commented out
-console.log("Bug #17: Background runner session shutdown fix");
-const registerContent = fs.readFileSync("src/extension/register.ts", "utf-8");
-const killAsyncMatch = registerContent.match(/\/\/\s*for\s*\(\s*const\s+manifest\s+of\s+manifestCache\.list\(50\)/);
-if (killAsyncMatch) {
-    console.log("  ✅ killAsync loop is commented out");
-} else if (registerContent.includes("for (const manifest of manifestCache.list(50))") && !registerContent.includes("// for (const manifest")) {
-    console.log("  ❌ killAsync loop is NOT commented out - BUG NOT FIXED");
-    allPassed = false;
-} else {
-    console.log("  ✅ killAsync pattern not found (may have been refactored)");
-}
-
-// Bug #18: Check stdio is ["ignore", "pipe", "pipe"]
-console.log("\nBug #18: Child-pi stdin fix");
-const childPiContent = fs.readFileSync("src/runtime/child-pi.ts", "utf-8");
-const stdioMatch = childPiContent.match(/stdio:\s*\[\s*"ignore"\s*,\s*"pipe"\s*,\s*"pipe"\s*\]/);
-if (stdioMatch) {
-    console.log("  ✅ stdio is ['ignore', 'pipe', 'pipe']");
-} else if (childPiContent.includes('stdio: ["pipe", "pipe", "pipe"]')) {
-    console.log("  ❌ stdio is still ['pipe', 'pipe', 'pipe'] - BUG NOT FIXED");
-    allPassed = false;
-} else {
-    console.log("  ⚠️  stdio pattern not found in expected format");
-}
-
-// Bug #19: Check temp workspace cleanup
-console.log("\nBug #19: Phantom runs temp workspace fix");
-const runIndexContent = fs.readFileSync("src/extension/run-index.ts", "utf-8");
-const tempDirCheck = runIndexContent.includes("isTempRoot") || runIndexContent.includes("tmpdir") || runIndexContent.includes("tmpDir");
-const activeRunContent = fs.readFileSync("src/state/active-run-registry.ts", "utf-8");
-const timeoutCheck = activeRunContent.includes("30 * 60 * 1000") || activeRunContent.includes("30*60*1000");
-if (tempDirCheck && timeoutCheck) {
-    console.log("  ✅ Temp workspace detection and 30-min timeout present");
-} else if (!tempDirCheck) {
-    console.log("  ❌ Temp workspace detection NOT found - BUG NOT FIXED");
-    allPassed = false;
-} else if (!timeoutCheck) {
-    console.log("  ❌ 30-min timeout NOT found - BUG NOT FIXED");
-    allPassed = false;
-}
-
-// Bug #20: Check needs_attention in completedIds
-console.log("\nBug #20: Infinite retry loop fix");
-const teamRunnerContent = fs.readFileSync("src/runtime/team-runner.ts", "utf-8");
-const needsAttentionMatch = teamRunnerContent.match(/status\s*===\s*"needs_attention"/g);
-if (needsAttentionMatch && needsAttentionMatch.length >= 3) {
-    console.log("  ✅ needs_attention status checks found (" + needsAttentionMatch.length + " places)");
-} else {
-    console.log("  ❌ needs_attention status check NOT found or insufficient - BUG NOT FIXED");
-    allPassed = false;
-}
-
-// Check the specific completedIds fix
-const completedIdsFix = teamRunnerContent.includes('status === "completed" || t.status === "needs_attention"');
-if (completedIdsFix) {
-    console.log("  ✅ completedIds includes needs_attention");
-} else {
-    console.log("  ❌ completedIds does NOT include needs_attention - BUG NOT FIXED");
-    allPassed = false;
-}
-
-// Check dist file
-console.log("\n=== Checking dist/index.mjs ===");
-if (fs.existsSync("dist/index.mjs")) {
-	const distContent = fs.readFileSync("dist/index.mjs", "utf-8");
-	const distNeedsAttention = distContent.includes('t2.status === "completed" || t2.status === "needs_attention"');
-	if (distNeedsAttention) {
-		console.log("  ✅ Bug #20 fix is in dist/index.mjs");
-	} else {
-		console.log("  ❌ Bug #20 fix NOT in dist/index.mjs - rebuild needed");
-		allPassed = false;
-	}
-} else {
-	console.log("  ⚠️  dist/index.mjs not found - run npm run build first");
-}
-
-console.log("\n" + "=".repeat(40));
-console.log(allPassed ? "✅ ALL BUGS ARE FIXED" : "❌ SOME BUGS ARE NOT FIXED");
-console.log("=".repeat(40));
-
-process.exit(allPassed ? 0 : 1);

package/test-lastActivityAt.mjs

@@ -1,167 +0,0 @@
-/**
- * Test for lastActivityAt fallback in heartbeat-watcher
- * Verifies that tasks with stale heartbeat but recent lastActivityAt are not marked dead
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import * as fs from "node:fs";
-import * as os from "node:os";
-import * as path from "node:path";
-import { createMetricRegistry } from "./src/observability/metric-registry.ts";
-import { HeartbeatWatcher } from "./src/runtime/heartbeat-watcher.ts";
-import { createRunManifest, saveRunTasks, updateRunStatus } from "./src/state/state-store.ts";
-import { createManifestCache } from "./src/runtime/manifest-cache.ts";
-
-const team = { name: "t", description: "", source: "test", filePath: "t", roles: [{ name: "r", agent: "a" }] };
-const workflow = { name: "w", description: "", source: "test", filePath: "w", steps: [{ id: "s", role: "r", task: "x" }] };
-
-test("HeartbeatWatcher uses lastActivityAt fallback - task NOT dead when heartbeat stale but activity recent", () => {
-	const cwd = fs.mkdtempSync(path.join(os.tmpdir(), "pi-crew-lastactivity-at-"));
-	try {
-		fs.writeFileSync(path.join(cwd, "package.json"), "{}", "utf-8");
-		const created = createRunManifest({ cwd, team, workflow, goal: "hb" });
-		const manifest = updateRunStatus(created.manifest, "running", "running");
-		
-		// Create task with STALE heartbeat (old lastSeenAt) but RECENT lastActivityAt
-		// Heartbeat is from Jan 1, 2026 (stale - 10 minutes old)
-		// lastActivityAt is from Jan 1, 2026 00:08:00 (2 minutes old - within dead threshold of 5 minutes)
-		const tasksWithHeartbeat = created.tasks.map((task) => ({
-			...task,
-			status: "running",
-			heartbeat: { workerId: task.id, lastSeenAt: "2026-01-01T00:00:00.000Z", alive: true },
-			// Agent is still active - lastActivityAt is recent (within dead threshold)
-			agentProgress: { 
-				lastActivityAt: "2026-01-01T00:08:00.000Z",  // 2 minutes ago
-				currentTool: "working",
-				toolCount: 5,
-				tokens: 1000,
-				turns: 2
-			}
-		}));
-		
-		saveRunTasks(manifest, tasksWithHeartbeat);
-		const cache = createManifestCache(cwd, { watch: false, debounceMs: 0 });
-		const notifications = [];
-		let deadletters = 0;
-		const watcher = new HeartbeatWatcher({ 
-			cwd, 
-			manifestCache: cache, 
-			registry: createMetricRegistry(), 
-			router: { enqueue: (n) => { notifications.push(n.id ?? ""); return true; } }, 
-			deadletterTickThreshold: 3, 
-			onDeadletterTrigger: () => { deadletters += 1; } 
-		});
-		
-		// Simulate time at 00:10:00 - 10 minutes after heartbeat, 2 minutes after activity
-		// With fallback: activity age = 2 minutes < dead threshold (5 minutes) -> should be warn/stale, not dead
-		watcher.tick(Date.parse("2026-01-01T00:10:00.000Z"));
-		watcher.tick(Date.parse("2026-01-01T00:10:05.000Z"));
-		watcher.tick(Date.parse("2026-01-01T00:10:10.000Z"));
-		
-		// Should NOT have any dead notifications because lastActivityAt is recent
-		assert.equal(notifications.length, 0, "Should NOT mark task dead when lastActivityAt is recent (within dead threshold)");
-		assert.equal(deadletters, 0, "Should NOT trigger deadletter when lastActivityAt is recent");
-		
-		watcher.dispose();
-		cache.dispose();
-	} finally {
-		fs.rmSync(cwd, { recursive: true, force: true });
-	}
-});
-
-test("HeartbeatWatcher marks task dead when BOTH heartbeat and lastActivityAt are stale", () => {
-	const cwd = fs.mkdtempSync(path.join(os.tmpdir(), "pi-crew-both-stale-"));
-	try {
-		fs.writeFileSync(path.join(cwd, "package.json"), "{}", "utf-8");
-		const created = createRunManifest({ cwd, team, workflow, goal: "hb" });
-		const manifest = updateRunStatus(created.manifest, "running", "running");
-		
-		// Create task with BOTH stale heartbeat AND stale lastActivityAt
-		// Heartbeat is from Jan 1, 2026 00:00:00 (10 minutes old)
-		// lastActivityAt is also from Jan 1, 2026 00:00:00 (also 10 minutes old - beyond dead threshold)
-		const tasksWithHeartbeat = created.tasks.map((task) => ({
-			...task,
-			status: "running",
-			heartbeat: { workerId: task.id, lastSeenAt: "2026-01-01T00:00:00.000Z", alive: true },
-			agentProgress: { 
-				lastActivityAt: "2026-01-01T00:00:00.000Z",  // 10 minutes old - beyond dead threshold
-				currentTool: "done",
-				toolCount: 5,
-				tokens: 1000,
-				turns: 2
-			}
-		}));
-		
-		saveRunTasks(manifest, tasksWithHeartbeat);
-		const cache = createManifestCache(cwd, { watch: false, debounceMs: 0 });
-		const notifications = [];
-		let deadletters = 0;
-		const watcher = new HeartbeatWatcher({ 
-			cwd, 
-			manifestCache: cache, 
-			registry: createMetricRegistry(), 
-			router: { enqueue: (n) => { notifications.push(n.id ?? ""); return true; } }, 
-			deadletterTickThreshold: 3, 
-			onDeadletterTrigger: () => { deadletters += 1; } 
-		});
-		
-		// Simulate time at 00:10:00 - both heartbeat and activity are 10 minutes old
-		watcher.tick(Date.parse("2026-01-01T00:10:00.000Z"));
-		watcher.tick(Date.parse("2026-01-01T00:10:05.000Z"));
-		watcher.tick(Date.parse("2026-01-01T00:10:10.000Z"));
-		
-		// SHOULD have dead notifications because BOTH are stale (> 5 minutes)
-		assert.ok(notifications.length > 0, "Should mark task dead when BOTH heartbeat and lastActivityAt are stale");
-		assert.ok(deadletters > 0, "Should trigger deadletter when BOTH are stale");
-		
-		watcher.dispose();
-		cache.dispose();
-	} finally {
-		fs.rmSync(cwd, { recursive: true, force: true });
-	}
-});
-
-test("HeartbeatWatcher without lastActivityAt still marks stale heartbeat as dead", () => {
-	const cwd = fs.mkdtempSync(path.join(os.tmpdir(), "pi-crew-no-activity-"));
-	try {
-		fs.writeFileSync(path.join(cwd, "package.json"), "{}", "utf-8");
-		const created = createRunManifest({ cwd, team, workflow, goal: "hb" });
-		const manifest = updateRunStatus(created.manifest, "running", "running");
-		
-		// Create task with stale heartbeat but NO lastActivityAt
-		const tasksWithHeartbeat = created.tasks.map((task) => ({
-			...task,
-			status: "running",
-			heartbeat: { workerId: task.id, lastSeenAt: "2026-01-01T00:00:00.000Z", alive: true },
-			// No agentProgress at all
-		}));
-		
-		saveRunTasks(manifest, tasksWithHeartbeat);
-		const cache = createManifestCache(cwd, { watch: false, debounceMs: 0 });
-		const notifications = [];
-		let deadletters = 0;
-		const watcher = new HeartbeatWatcher({ 
-			cwd, 
-			manifestCache: cache, 
-			registry: createMetricRegistry(), 
-			router: { enqueue: (n) => { notifications.push(n.id ?? ""); return true; } }, 
-			deadletterTickThreshold: 3, 
-			onDeadletterTrigger: () => { deadletters += 1; } 
-		});
-		
-		// Simulate time at 00:10:00 - heartbeat is 10 minutes old
-		watcher.tick(Date.parse("2026-01-01T00:10:00.000Z"));
-		watcher.tick(Date.parse("2026-01-01T00:10:05.000Z"));
-		watcher.tick(Date.parse("2026-01-01T00:10:10.000Z"));
-		
-		// SHOULD have dead notifications because heartbeat is stale and no fallback
-		assert.ok(notifications.length > 0, "Should mark task dead when heartbeat stale and no lastActivityAt");
-		assert.ok(deadletters > 0, "Should trigger deadletter when no fallback available");
-		
-		watcher.dispose();
-		cache.dispose();
-	} finally {
-		fs.rmSync(cwd, { recursive: true, force: true });
-	}
-});

package/test-tp.mjs

@@ -1,12 +0,0 @@
-import { formatToolProgress, formatCurrentToolLine } from "./src/runtime/tool-progress.ts";
-
-const progress = {
-  recentTools: [{ tool: "bash", args: "ls", endedAt: "2024-01-01T00:00:00.000Z" }],
-  toolCount: 1,
-  activityState: "active"
-};
-
-const display = formatToolProgress(progress);
-console.log("currentTool:", display.currentTool);
-console.log("toolCount:", display.toolCount);
-console.log("TEST PASSED if no errors above");