pi-crew 0.8.7 → 0.8.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-crew",
-  "version": "0.8.7",
+  "version": "0.8.9",
   "description": "Pi extension for coordinated AI teams, workflows, worktrees, and async task orchestration",
   "author": "baphuongna",
   "license": "MIT",

package/src/extension/registration/compaction-guard.ts

@@ -1,5 +1,6 @@
 import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { listRecentRuns } from "../run-index.ts";
+import { findRepoRoot } from "../../utils/paths.ts";
 import { extractSessionId } from "../../utils/session-utils.ts";
 import type { ArtifactDescriptor, TeamRunManifest } from "../../state/types.ts";
 
@@ -69,6 +70,29 @@ function formatCrewArtifactIndex(entries: CrewArtifactIndexEntry[]): string {
 	return lines.join("\n");
 }
 
+/**
+ * Project-scope filter: keep `run` only if it belongs to the SAME repo as
+ * `queryCwd` (or is a user-level / legacy run with no repo). This is the
+ * version-independent, reliable barrier against cross-project leaks: even
+ * when the session-id filter below cannot fire (ctx.sessionId is absent on
+ * some pi versions — observed on pi 0.79.6 ExtensionContext), the cwd filter
+ * stops another project's in-flight runs (e.g. edge-ai-agent) from bleeding
+ * into this project's ambient status or compaction-resume directive.
+ *
+ * Note: listRecentRuns already scopes its filesystem scan via scopedRunRoots,
+ * BUT it ALSO merges the GLOBAL activeRunEntries() registry (the cross-
+ * project dashboard view). That global merge is intentional for the
+ * dashboard but wrong for "what should THIS project's session do" — hence
+ * this filter at the consumption site.
+ */
+function isInProjectScope(run: TeamRunManifest, queryCwd: string): boolean {
+	const queryRepo = findRepoRoot(queryCwd);
+	if (queryRepo === undefined) return true; // viewer not in a repo → user-level view
+	const runRepo = typeof run.cwd === "string" && run.cwd.length > 0 ? findRepoRoot(run.cwd) : undefined;
+	if (runRepo === undefined) return true; // run is user-level / legacy / not a repo → include
+	return runRepo === queryRepo; // same project only
+}
+
 /**
  * Collect in-flight (non-terminal) crew runs that must be resumable after
  * compaction. These are runs the agent was actively working on or awaiting.
@@ -88,7 +112,13 @@ function formatCrewArtifactIndex(entries: CrewArtifactIndexEntry[]): string {
 export function collectInFlightRuns(cwd: string, currentSessionId?: string): TeamRunManifest[] {
 	return listRecentRuns(cwd, MAX_ARTIFACT_INDEX_RUNS).filter((run) => {
 		if (!IN_FLIGHT_RUN_STATUSES.has(run.status)) return false;
-		if (currentSessionId === undefined) return true; // no filter → back-compat
+		// Reliable barrier (2026-06-17): never leak another project's runs into
+		// THIS project's resume directive / ambient status, regardless of
+		// whether the session-id filter is available. This fixes the live
+		// cross-session leak that persisted after 4bd6f5b because ctx.sessionId
+		// is absent on pi 0.79.6.
+		if (!isInProjectScope(run, cwd)) return false;
+		if (currentSessionId === undefined) return true; // no session filter → back-compat (still project-scoped)
 		return run.ownerSessionId === currentSessionId; // strict: legacy ownerless runs excluded
 	});
 }

package/src/extension/run-index.ts

@@ -76,7 +76,7 @@ function scopedRunRoots(cwd: string): string[] {
 	return [...roots];
 }
 
-function collectActiveRuns(): TeamRunManifest[] {
+function collectActiveRuns(cwd?: string): TeamRunManifest[] {
 	return activeRunEntries()
 		.map((entry) => readManifest(entry.manifestPath))
 		.filter((manifest): manifest is TeamRunManifest => manifest !== undefined);

package/src/extension/team-tool/run.ts

@@ -29,6 +29,31 @@ import { appendEventAsync, readEvents } from "../../state/event-log.ts";
 import { resolveCrewRuntime, runtimeResolutionState } from "../../runtime/runtime-resolver.ts";
 import { normalizeSkillOverride } from "../../runtime/skill-instructions.ts";
 import { expandParallelResearchWorkflow } from "../../runtime/parallel-research.ts";
+
+/**
+ * Module-scoped latch for the crew-init dynamic import.
+ *
+ * `crew-init.ts` is dynamically `await import()`'d from `handleRun` below, which
+ * N concurrent subagents hit simultaneously (every `team` tool call runs it).
+ * Under the tsx/jiti loader, concurrent first-imports race module-record
+ * instantiation → top-level `const` initializers (e.g. CREW_README) hit TDZ
+ * (`Cannot access 'CREW_README' before initialization`) and namespace bindings
+ * arrive as `undefined` (`reading 'existsSync'`). crew-init.ts's own header
+ * documents this for the `path` binding; the race persists for other top-level
+ * consts because module-body evaluation itself races.
+ *
+ * The latch makes concurrent callers share ONE in-flight import promise, so the
+ * module body evaluates exactly once regardless of fanout. Same pattern as
+ * runtime-warmup.ts / the v0.8.1 peer-dep latch, applied to this specific
+ * dynamic-import race site.
+ */
+let crewInitPromise: Promise<typeof import("../../state/crew-init.ts")> | undefined;
+function loadCrewInit(): Promise<typeof import("../../state/crew-init.ts")> {
+	if (!crewInitPromise) {
+		crewInitPromise = import("../../state/crew-init.ts");
+	}
+	return crewInitPromise;
+}
 import { checkProcessLiveness, isActiveRunStatus } from "../../runtime/process-status.ts";
 import { waitForRun } from "../../runtime/run-tracker.ts";
 import { hasAsyncStartMarker } from "../../runtime/async-marker.ts";
@@ -81,9 +106,11 @@ export async function handleRun(params: TeamToolParamsValue, ctx: TeamContext):
 	const intentPrefix = goal.length > 60 ? `${goal.slice(0, 57)}...` : goal;
 
 	// P0: Ensure .crew directory structure exists before creating any manifests.
-	// Dynamic import to avoid module binding issues in child-process contexts.
+	// Latched dynamic import (loadCrewInit) — concurrent `team` tool calls from
+	// N subagents share ONE in-flight promise so crew-init.ts's module body
+	// evaluates exactly once (avoids the cold-start race on CREW_README / path / fs).
 	const workingDir = ctx.cwd ?? process.cwd();
-	const { ensureCrewDirectory } = await import("../../state/crew-init.ts");
+	const { ensureCrewDirectory } = await loadCrewInit();
 	await ensureCrewDirectory(workingDir);
 
 	// WORKTREE FIX: If worktree mode is needed but cwd is not a git repo,

package/src/runtime/runtime-warmup.ts

@@ -54,6 +54,7 @@ const HOT_MODULE_SPECIFIERS = [
 	"./task-runner.ts",
 	"../extension/team-tool.ts",
 	"../extension/validate-resources.ts",
+	"../state/crew-init.ts", // TDZ-prone top-level consts (CREW_README); dynamically imported by team-tool/run.ts
 ] as const;
 
 /** Additional bare-specifier peer deps to warm. */