pi-crew 0.6.1 → 0.6.4

package/src/runtime/async-runner.ts

@@ -6,6 +6,10 @@ import { fileURLToPath, pathToFileURL } from "node:url";
 import { logInternalError } from "../utils/internal-error.ts";
 import { appendEvent } from "../state/event-log.ts";
 import { sanitizeEnvSecrets } from "../utils/env-filter.ts";
+import {
+	registerWorker,
+	unregisterWorker,
+} from "./orphan-worker-registry.ts";
 import type { TeamRunManifest } from "../state/types.ts";
 
 
@@ -179,15 +183,24 @@ export async function spawnBackgroundTeamRun(manifest: TeamRunManifest): Promise
 			"NPM_CONFIG_REGISTRY",
 			"NPM_CONFIG_USERCONFIG",
 			"NPM_CONFIG_GLOBALCONFIG",
-			"PI_*",
-			"PI_CREW_*",
-			"PI_TEAMS_*",
+			// FIX: explicit list matches child-pi.ts to prevent regression.
+			// PI_CREW_PARENT_PID is needed for parent-guard (liveness check).
+			"PI_CREW_DEPTH",
+			"PI_CREW_MAX_DEPTH",
+			"PI_CREW_INHERIT_PROJECT_CONTEXT",
+			"PI_CREW_INHERIT_SKILLS",
+			"PI_CREW_PARENT_PID",
+			"PI_TEAMS_DEPTH",
+			"PI_TEAMS_MAX_DEPTH",
+			"PI_TEAMS_INHERIT_PROJECT_CONTEXT",
+			"PI_TEAMS_INHERIT_SKILLS",
+			"PI_TEAMS_PI_BIN",
+			"PI_TEAMS_MOCK_CHILD_PI",
+			"PI_CREW_ALLOW_MOCK",
 		],
 	});
-	// Block execution control vars from leaking
-	delete filteredEnv.PI_CREW_PARENT_PID;
-	delete filteredEnv.PI_CREW_EXECUTE_WORKERS;
-	delete filteredEnv.PI_TEAMS_EXECUTE_WORKERS;
+	// FIX: removed delete workarounds — with explicit allowlist, these vars
+	// are no longer auto-leaked. Matches child-pi.ts.
 
 	const loader = resolveTypeScriptLoader();
 	if (!loader) {
@@ -223,6 +236,21 @@ export async function spawnBackgroundTeamRun(manifest: TeamRunManifest): Promise
 	});
 	child.unref();
 
+	// Track this worker in the orphan registry so it can be killed on
+	// session_start of a future session if the parent pi process is killed.
+	if (child.pid) {
+		registerWorker(
+			child.pid,
+			manifest.ownerSessionId ?? "unknown",
+			manifest.runId,
+			process.pid, // parentPid — used by cleanup to verify session is dead
+		);
+		// Best-effort: unregister when child exits. Background-runner writes
+		// the marker file before it dies, so we unregister on the next
+		// cleanup tick. But the child "exit" event won't fire because we
+		// unref'd and the stdio is piped + ignored.
+	}
+
 	return { pid: child.pid, logPath };
 }