pi-crew 0.5.14 → 0.5.16

package/src/state/schedule.ts

@@ -7,6 +7,9 @@
  *   - parseRelativeTime(): "+10m" → ISO timestamp
  *   - parseInterval(): "5m" → milliseconds
  */
+import * as fs from "node:fs";
+import * as path from "node:path";
+import { logInternalError } from "../utils/internal-error.ts";
 
 import type { ScheduleStoreData, ScheduledTask } from "./types.ts";
 
@@ -88,8 +91,8 @@ export class ScheduleStore {
 		this.path = path;
 		this.data = { version: 1, jobs: [] };
 		try {
-			if (require("node:fs").existsSync(path)) {
-				const content = require("node:fs").readFileSync(path, "utf-8");
+			if (fs.existsSync(path)) {
+				const content = fs.readFileSync(path, "utf-8");
 				const parsed = JSON.parse(content);
 				if (parsed && typeof parsed === "object" && "version" in parsed && "jobs" in parsed) {
 					this.data = parsed as ScheduleStoreData;
@@ -102,10 +105,15 @@ export class ScheduleStore {
 
 	private save(): void {
 		try {
-			require("node:fs").mkdirSync(require("node:path").dirname(this.path), { recursive: true });
-			require("node:fs").writeFileSync(this.path, JSON.stringify(this.data, null, 2), "utf-8");
+			fs.mkdirSync(path.dirname(this.path), { recursive: true });
+			fs.writeFileSync(this.path, JSON.stringify(this.data, null, 2), "utf-8");
 		} catch (error) {
-			console.warn(`[pi-crew] Failed to save schedule store: ${error instanceof Error ? error.message : String(error)}`);
+			// FIX (Round 21, L1): Use logInternalError for consistency with
+			// the rest of the codebase. Previously console.warn may not be
+			// visible in all environments (e.g. JSON-RPC mode, redirected
+			// stderr). Also import the dependency properly at the top of
+			// the file (this method used the legacy require() pattern).
+			logInternalError("schedule.save", error, `path=${this.path}`);
 		}
 	}
 

package/src/state/state-store.ts

@@ -1,7 +1,7 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
 import type { TeamRunManifest, TeamTaskState } from "./types.ts";
-import { canTransitionRunStatus, isTerminalRunStatus } from "./contracts.ts";
+import { canTransitionRunStatus } from "./contracts.ts";
 import { unregisterActiveRun } from "./active-run-registry.ts";
 import { atomicWriteJson, atomicWriteJsonAsync, atomicWriteJsonCoalesced, readJsonFile } from "./atomic-write.ts";
 import { appendEvent } from "./event-log.ts";

package/src/tools/safe-bash.ts

@@ -4,7 +4,6 @@
  * Uses linear-time scanning to prevent ReDoS attacks
  */
 
-import { Type } from "@sinclair/typebox";
 
 // Backward-compatible pattern array (kept for getPatterns API)
 // IMPORTANT: Line 8 (rm pattern with nested quantifiers) has been replaced

package/src/ui/crew-widget.ts

@@ -9,8 +9,8 @@ import { getTaskUsage } from "../runtime/usage-tracker.ts";
 import type { TeamRunManifest } from "../state/types.ts";
 import type { ManifestCache } from "../runtime/manifest-cache.ts";
 import { reconcileAllStaleRuns } from "../runtime/crash-recovery.ts";
-import { colorForStatus, iconForStatus, type RunStatus } from "./status-colors.ts";
-import { pad, truncate } from "../utils/visual.ts";
+import { iconForStatus } from "./status-colors.ts";
+import { truncate } from "../utils/visual.ts";
 import type { CrewTheme } from "./theme-adapter.ts";
 import { asCrewTheme, subscribeThemeChange } from "./theme-adapter.ts";
 import { Box, Text } from "./layout-primitives.ts";

package/src/ui/render-diff.ts

@@ -18,7 +18,7 @@ function parseDiffLine(line: string): ParsedDiffLine | null {
 	return { prefix: match[1], lineNum: match[2], content: match[3] };
 }
 
-function replaceTabs(text: string): string {
+export function replaceTabs(text: string): string {
 	return text.replace(/\t/g, "   ");
 }
 

package/src/ui/run-dashboard.ts

@@ -1,7 +1,7 @@
 import * as fs from "node:fs";
 import type { TeamRunManifest, TeamTaskState, UsageState } from "../state/types.ts";
 import { readCrewAgents } from "../runtime/crew-agent-records.ts";
-import { getLiveAgentContextPercent, listLiveAgents } from "../runtime/live-agent-manager.ts";
+import { getLiveAgentContextPercent } from "../runtime/live-agent-manager.ts";
 import type { CrewAgentRecord } from "../runtime/crew-agent-runtime.ts";
 import { isDisplayActiveRun, isLikelyOrphanedActiveRun } from "../runtime/process-status.ts";
 import { readJsonFileCoalesced } from "../utils/file-coalescer.ts";
@@ -11,7 +11,6 @@ import { applyStatusColor, iconForStatus, type RunStatus } from "./status-colors
 import { pad, truncate, sanitizeLine } from "../utils/visual.ts";
 import { Box, Text } from "./layout-primitives.ts";
 import { DynamicCrewBorder } from "./dynamic-border.ts";
-import { CrewFooter } from "./crew-footer.ts";
 import { aggregateUsage } from "../state/usage.ts";
 import { logInternalError } from "../utils/internal-error.ts";
 import { renderAgentsPane } from "./dashboard-panes/agents-pane.ts";

package/src/ui/tool-render.ts

@@ -5,6 +5,7 @@
  */
 import { Container, Spacer, Text, visibleWidth } from "@earendil-works/pi-tui";
 import type { CrewAgentRecord } from "../runtime/crew-agent-runtime.ts";
+import { replaceTabs } from "./render-diff.ts";
 
 // ── Types ──────────────────────────────────────────────────────────────
 export interface Theme {
@@ -185,7 +186,15 @@ export function renderAgentProgress(
 	}
 
 	// Error
-	if (record.error) addLine(theme.fg("error", `Error: ${record.error}`));
+	// FIX (Round 20, render-utils sanitization): Sanitize tool-error display so
+	// embedded tabs / control chars / newlines / very long strings cannot break
+	// the terminal layout. Mirrors the upstream oh-my-pi pattern at
+	// packages/coding-agent/src/tools/render-utils.ts:177-185:
+	//   formatErrorMessage = replaceTabs(truncateToWidth(clean, LINE_CAP))
+	if (record.error) {
+		const clean = truncLine(replaceTabs(String(record.error)), innerW);
+		addLine(theme.fg("error", `Error: ${clean}`));
+	}
 
 	// Usage line
 	const usage = record.usage;
@@ -300,7 +309,12 @@ export function renderAgentToolResult(
 			const label = item.agentId || "agent";
 			c.addChild(new Text(`${icon}  ${theme.fg("toolTitle", theme.bold(label))}`, 0, 0));
 			if (item.error) {
-				c.addChild(new Text(theme.fg("error", `  Error:  ${item.error}`), 0, 0));
+				// FIX (Round 20, render-utils sanitization): Sanitize tool-error
+				// display so embedded tabs / newlines / very long strings cannot
+				// break the TUI border alignment. Mirrors upstream oh-my-pi
+				// render-utils.ts:177-185.
+				const clean = truncLine(replaceTabs(String(item.error)), w - 2);
+				c.addChild(new Text(theme.fg("error", `  Error:  ${clean}`), 0, 0));
 			} else if (item.output) {
 				for (const line of item.output.split("\n").slice(0, 5))
 					c.addChild(new Text(theme.fg("dim", `  ${truncLine(line, w - 2)}`), 0, 0));
@@ -318,7 +332,10 @@ export function renderAgentToolResult(
 		const label = d.agentId;
 		c.addChild(new Text(`${icon}  ${theme.fg("toolTitle", theme.bold(label))}`, 0, 0));
 		if (d.error) {
-			c.addChild(new Text(theme.fg("error", `  Error:  ${d.error}`), 0, 0));
+			// FIX (Round 20, render-utils sanitization): Same sanitization as
+			// above — see renderAgentToolResult header comment.
+			const clean = truncLine(replaceTabs(String(d.error)), w - 2);
+			c.addChild(new Text(theme.fg("error", `  Error:  ${clean}`), 0, 0));
 		} else if (d.output) {
 			for (const line of d.output.split("\n").slice(0, 5))
 				c.addChild(new Text(theme.fg("dim", `  ${truncLine(line, w - 2)}`), 0, 0));

package/src/utils/conflict-detect.ts

@@ -20,7 +20,6 @@
  * merely start with `<` or `=` never match.
  */
 import * as fs from "node:fs";
-import * as path from "node:path";
 
 const OURS_PREFIX = "<<<<<<<";
 const BASE_PREFIX = "|||||||";

package/src/utils/gh-protocol.ts

@@ -22,8 +22,6 @@
  * Repo resolution: git remote get-url origin from cwd.
  */
 import { execFileSync } from "node:child_process";
-import { readFileSync } from "node:fs";
-import * as path from "node:path";
 
 /** Resolve the default repo from `git remote get-url origin` in cwd. */
 export function resolveDefaultRepo(cwd: string): string {