pi-crew 0.2.3 → 0.2.4

package/src/config/resilient-parser.ts

@@ -1,108 +1,109 @@
-/**
- * Per-field resilient config parsing — continues on error, collects all field-level issues.
- */
-
-import { PiTeamsConfigSchema } from "../schema/config-schema.ts";
-import { Value } from "typebox/value";
-import { suggestConfigKey } from "./suggestions.ts";
-import {
-	parseConfig,
-	type PiTeamsConfig,
-} from "./config.ts";
-
-// ---------------------------------------------------------------------------
-// Types
-// ---------------------------------------------------------------------------
-
-export interface FieldError {
-	field: string;
-	message: string;
-	value: unknown;
-	suggestion?: string;
-}
-
-export interface ResilientParseResult {
-	config: Record<string, unknown>;
-	errors: FieldError[];
-	warnings: string[];
-	valid: boolean;
-}
-
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-
-const KNOWN_TOP_LEVEL_KEYS: readonly string[] = Object.keys(PiTeamsConfigSchema.properties ?? {});
-
-function isObject(value: unknown): value is Record<string, unknown> {
-	return value !== null && typeof value === "object" && !Array.isArray(value);
-}
-
-// ---------------------------------------------------------------------------
-// Implementation
-// ---------------------------------------------------------------------------
-
-/**
- * Parse a raw config value field-by-field.
- *
- * - Each top-level key is validated independently via TypeBox sub-schemas.
- * - Fields that fail are recorded as errors but do not block others.
- * - Unknown keys get a fuzzy suggestion via Levenshtein distance.
- * - The returned `config` contains only successfully-parsed fields (via `parseConfig`).
- */
-export function parseConfigResilient(raw: unknown): ResilientParseResult {
-	const errors: FieldError[] = [];
-	const warnings: string[] = [];
-
-	if (!isObject(raw)) {
-		return { config: {}, errors: [{ field: "config", message: "config must be an object", value: raw }], warnings, valid: false };
-	}
-
-	// Collect unknown top-level keys with suggestions
-	for (const key of Object.keys(raw)) {
-		if (!KNOWN_TOP_LEVEL_KEYS.includes(key)) {
-			const suggestion = suggestConfigKey(key, KNOWN_TOP_LEVEL_KEYS);
-			errors.push({
-				field: key,
-				message: `unknown config key '${key}'`,
-				value: raw[key],
-				suggestion: suggestion ?? undefined,
-			});
-		}
-	}
-
-	// Use TypeBox per-field validation for known keys
-	for (const key of KNOWN_TOP_LEVEL_KEYS) {
-		if (!(key in raw)) continue;
-		const value = raw[key];
-		const subSchema = (PiTeamsConfigSchema.properties as Record<string, unknown>)[key];
-		if (subSchema && !Value.Check(subSchema as { [key: string]: unknown }, value)) {
-			// Collect the first error for this field
-			const fieldErrors = [...Value.Errors(subSchema as { [key: string]: unknown }, value)];
-			if (fieldErrors.length > 0) {
-				const first = fieldErrors[0] as unknown as Record<string, unknown>;
-				const msg = typeof first.message === "string" ? first.message : "invalid value";
-				errors.push({
-					field: key,
-					message: msg,
-					value,
-				});
-			}
-		}
-	}
-
-	// Build the valid subset using existing parseConfig (which silently drops invalid fields)
-	const parsed: PiTeamsConfig = parseConfig(raw);
-	const config: Record<string, unknown> = {};
-	for (const key of Object.keys(parsed)) {
-		const val = (parsed as Record<string, unknown>)[key];
-		if (val !== undefined) config[key] = val;
-	}
-
-	return {
-		config,
-		errors,
-		warnings,
-		valid: errors.length === 0,
-	};
-}
+/**
+ * Per-field resilient config parsing — continues on error, collects all field-level issues.
+ */
+
+import { PiTeamsConfigSchema } from "../schema/config-schema.ts";
+import { type TSchema } from "@sinclair/typebox";
+import { Value } from "@sinclair/typebox/value";
+import { suggestConfigKey } from "./suggestions.ts";
+import {
+	parseConfig,
+	type PiTeamsConfig,
+} from "./config.ts";
+
+// ---------------------------------------------------------------------------
+// Types
+// ---------------------------------------------------------------------------
+
+export interface FieldError {
+	field: string;
+	message: string;
+	value: unknown;
+	suggestion?: string;
+}
+
+export interface ResilientParseResult {
+	config: Record<string, unknown>;
+	errors: FieldError[];
+	warnings: string[];
+	valid: boolean;
+}
+
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+
+const KNOWN_TOP_LEVEL_KEYS: readonly string[] = Object.keys(PiTeamsConfigSchema.properties ?? {});
+
+function isObject(value: unknown): value is Record<string, unknown> {
+	return value !== null && typeof value === "object" && !Array.isArray(value);
+}
+
+// ---------------------------------------------------------------------------
+// Implementation
+// ---------------------------------------------------------------------------
+
+/**
+ * Parse a raw config value field-by-field.
+ *
+ * - Each top-level key is validated independently via TypeBox sub-schemas.
+ * - Fields that fail are recorded as errors but do not block others.
+ * - Unknown keys get a fuzzy suggestion via Levenshtein distance.
+ * - The returned `config` contains only successfully-parsed fields (via `parseConfig`).
+ */
+export function parseConfigResilient(raw: unknown): ResilientParseResult {
+	const errors: FieldError[] = [];
+	const warnings: string[] = [];
+
+	if (!isObject(raw)) {
+		return { config: {}, errors: [{ field: "config", message: "config must be an object", value: raw }], warnings, valid: false };
+	}
+
+	// Collect unknown top-level keys with suggestions
+	for (const key of Object.keys(raw)) {
+		if (!KNOWN_TOP_LEVEL_KEYS.includes(key)) {
+			const suggestion = suggestConfigKey(key, KNOWN_TOP_LEVEL_KEYS);
+			errors.push({
+				field: key,
+				message: `unknown config key '${key}'`,
+				value: raw[key],
+				suggestion: suggestion ?? undefined,
+			});
+		}
+	}
+
+	// Use TypeBox per-field validation for known keys
+	for (const key of KNOWN_TOP_LEVEL_KEYS) {
+		if (!(key in raw)) continue;
+		const value = raw[key];
+		const subSchema = (PiTeamsConfigSchema.properties as Record<string, unknown>)[key];
+		if (subSchema && !Value.Check(subSchema as TSchema, value)) {
+			// Collect the first error for this field
+			const fieldErrors = [...Value.Errors(subSchema as TSchema, value)];
+			if (fieldErrors.length > 0) {
+				const first = fieldErrors[0] as unknown as Record<string, unknown>;
+				const msg = typeof first.message === "string" ? first.message : "invalid value";
+				errors.push({
+					field: key,
+					message: msg,
+					value,
+				});
+			}
+		}
+	}
+
+	// Build the valid subset using existing parseConfig (which silently drops invalid fields)
+	const parsed: PiTeamsConfig = parseConfig(raw);
+	const config: Record<string, unknown> = {};
+	for (const key of Object.keys(parsed)) {
+		const val = (parsed as Record<string, unknown>)[key];
+		if (val !== undefined) config[key] = val;
+	}
+
+	return {
+		config,
+		errors,
+		warnings,
+		valid: errors.length === 0,
+	};
+}

package/src/config/suggestions.ts

@@ -1,74 +1,74 @@
-/**
- * Fuzzy config key suggestions — Levenshtein-based typo correction for pi-crew config keys.
- */
-
-/**
- * Classic Levenshtein edit distance between two strings.
- */
-export function levenshtein(a: string, b: string): number {
-	const la = a.length;
-	const lb = b.length;
-	if (la === 0) return lb;
-	if (lb === 0) return la;
-
-	// Single-row DP to keep memory O(min(n,m))
-	let prev = new Uint32Array(lb + 1);
-	let curr = new Uint32Array(lb + 1);
-
-	for (let j = 0; j <= lb; j++) prev[j] = j;
-
-	for (let i = 1; i <= la; i++) {
-		curr[0] = i;
-		for (let j = 1; j <= lb; j++) {
-			const cost = a[i - 1] === b[j - 1] ? 0 : 1;
-			curr[j] = Math.min(
-				prev[j] + 1,       // deletion
-				curr[j - 1] + 1,   // insertion
-				prev[j - 1] + cost // substitution
-			);
-		}
-		const swap = prev;
-		prev = curr;
-		curr = swap;
-	}
-
-	return prev[lb];
-}
-
-const DEFAULT_MAX_DISTANCE = 3;
-
-/**
- * Find the closest matching key from a list of valid keys.
- * Case-insensitive. Returns null if no match within `maxDistance`.
- */
-export function findClosestKey(
-	input: string,
-	validKeys: readonly string[],
-	maxDistance: number = DEFAULT_MAX_DISTANCE,
-): string | null {
-	if (validKeys.length === 0) return null;
-
-	const lower = input.toLowerCase();
-	let bestKey: string | null = null;
-	let bestDist = maxDistance + 1;
-
-	for (const key of validKeys) {
-		const dist = levenshtein(lower, key.toLowerCase());
-		if (dist < bestDist) {
-			bestDist = dist;
-			bestKey = key;
-		}
-	}
-
-	return bestDist <= maxDistance ? bestKey : null;
-}
-
-/**
- * Convenience wrapper — suggest the closest known config key for a potentially mistyped input.
- */
-export function suggestConfigKey(
-	input: string,
-	knownKeys: readonly string[],
-): string | null {
-	return findClosestKey(input, knownKeys);
-}
+/**
+ * Fuzzy config key suggestions — Levenshtein-based typo correction for pi-crew config keys.
+ */
+
+/**
+ * Classic Levenshtein edit distance between two strings.
+ */
+export function levenshtein(a: string, b: string): number {
+	const la = a.length;
+	const lb = b.length;
+	if (la === 0) return lb;
+	if (lb === 0) return la;
+
+	// Single-row DP to keep memory O(min(n,m))
+	let prev = new Uint32Array(lb + 1);
+	let curr = new Uint32Array(lb + 1);
+
+	for (let j = 0; j <= lb; j++) prev[j] = j;
+
+	for (let i = 1; i <= la; i++) {
+		curr[0] = i;
+		for (let j = 1; j <= lb; j++) {
+			const cost = a[i - 1] === b[j - 1] ? 0 : 1;
+			curr[j] = Math.min(
+				prev[j] + 1,       // deletion
+				curr[j - 1] + 1,   // insertion
+				prev[j - 1] + cost // substitution
+			);
+		}
+		const swap = prev;
+		prev = curr;
+		curr = swap;
+	}
+
+	return prev[lb];
+}
+
+const DEFAULT_MAX_DISTANCE = 3;
+
+/**
+ * Find the closest matching key from a list of valid keys.
+ * Case-insensitive. Returns null if no match within `maxDistance`.
+ */
+export function findClosestKey(
+	input: string,
+	validKeys: readonly string[],
+	maxDistance: number = DEFAULT_MAX_DISTANCE,
+): string | null {
+	if (validKeys.length === 0) return null;
+
+	const lower = input.toLowerCase();
+	let bestKey: string | null = null;
+	let bestDist = maxDistance + 1;
+
+	for (const key of validKeys) {
+		const dist = levenshtein(lower, key.toLowerCase());
+		if (dist < bestDist) {
+			bestDist = dist;
+			bestKey = key;
+		}
+	}
+
+	return bestDist <= maxDistance ? bestKey : null;
+}
+
+/**
+ * Convenience wrapper — suggest the closest known config key for a potentially mistyped input.
+ */
+export function suggestConfigKey(
+	input: string,
+	knownKeys: readonly string[],
+): string | null {
+	return findClosestKey(input, knownKeys);
+}

package/src/config/types.ts

@@ -0,0 +1,199 @@
+// 2.9 — config interface types extracted from src/config/config.ts.
+//
+// All public surface types live here so that hot-path callers (loadConfig,
+// merging helpers, schema validators) can import just the types without
+// pulling in the parser graph. config.ts re-exports every name from this
+// file for backwards compat — existing `import { CrewUiConfig } from "../config/config.ts"`
+// continues to work.
+
+export type PiTeamsAutonomyProfile = "manual" | "suggested" | "assisted" | "aggressive";
+
+export interface PiTeamsAutonomousConfig {
+	profile?: PiTeamsAutonomyProfile;
+	enabled?: boolean;
+	injectPolicy?: boolean;
+	preferAsyncForLongTasks?: boolean;
+	allowWorktreeSuggestion?: boolean;
+	magicKeywords?: Record<string, string[]>;
+}
+
+export interface CrewLimitsConfig {
+	maxConcurrentWorkers?: number;
+	allowUnboundedConcurrency?: boolean;
+	maxTaskDepth?: number;
+	maxChildrenPerTask?: number;
+	maxRunMinutes?: number;
+	maxRetriesPerTask?: number;
+	maxTasksPerRun?: number;
+	heartbeatStaleMs?: number;
+}
+
+export type CrewRuntimeMode = "auto" | "scaffold" | "child-process" | "live-session";
+
+export type CompletionMutationGuardMode = "off" | "warn" | "fail";
+export type EffectivenessGuardMode = "off" | "warn" | "block" | "fail";
+
+export interface CrewRuntimeConfig {
+	mode?: CrewRuntimeMode;
+	preferLiveSession?: boolean;
+	allowChildProcessFallback?: boolean;
+	maxTurns?: number;
+	graceTurns?: number;
+	inheritContext?: boolean;
+	promptMode?: "replace" | "append";
+	groupJoin?: "off" | "group" | "smart";
+	groupJoinAckTimeoutMs?: number;
+	requirePlanApproval?: boolean;
+	completionMutationGuard?: CompletionMutationGuardMode;
+	effectivenessGuard?: EffectivenessGuardMode;
+	yield?: { enabled?: boolean; maxReminders?: number; reminderPrompt?: string };
+	/** Policy for per-role runtime selection. Not sensitive — safe to keep in project config. */
+	isolationPolicy?: {
+		/** Roles that should use child-process for crash isolation. Default: no roles. */
+		isolatedRoles?: string[];
+		/** Default runtime for roles not in isolatedRoles. Default: "live-session" (uses live-session). */
+		defaultRuntime?: "live-session" | "child-process";
+	};
+}
+
+export interface CrewControlConfig {
+	enabled?: boolean;
+	needsAttentionAfterMs?: number;
+}
+
+export interface CrewWorktreeConfig {
+	setupHook?: string;
+	setupHookTimeoutMs?: number;
+	linkNodeModules?: boolean;
+}
+
+export interface CrewUiConfig {
+	widgetPlacement?: "aboveEditor" | "belowEditor";
+	widgetMaxLines?: number;
+	powerbar?: boolean;
+	dashboardPlacement?: "center" | "right";
+	dashboardWidth?: number;
+	dashboardLiveRefreshMs?: number;
+	autoOpenDashboard?: boolean;
+	autoOpenDashboardForForegroundRuns?: boolean;
+	showModel?: boolean;
+	showTokens?: boolean;
+	showTools?: boolean;
+	transcriptTailBytes?: number;
+	mascotStyle?: "cat" | "armin";
+	mascotEffect?: "random" | "none" | "typewriter" | "scanline" | "rain" | "fade" | "crt" | "glitch" | "dissolve";
+}
+
+export interface AgentOverrideConfig {
+	disabled?: boolean;
+	model?: string | false;
+	fallbackModels?: string[] | false;
+	thinking?: string | false;
+	tools?: string[] | false;
+	skills?: string[] | false;
+}
+
+export interface CrewAgentsConfig {
+	disableBuiltins?: boolean;
+	overrides?: Record<string, AgentOverrideConfig>;
+}
+
+export interface CrewToolsConfig {
+	enableClaudeStyleAliases?: boolean;
+	enableSteer?: boolean;
+	terminateOnForeground?: boolean;
+}
+
+export interface CrewTelemetryConfig {
+	enabled?: boolean;
+}
+
+export interface CrewPolicyConfig {
+	requireIntentForDestructiveActions?: boolean;
+	disabledCapabilities?: string[];
+}
+
+export type CrewNotificationSeverity = "info" | "warning" | "error" | "critical";
+
+export interface CrewNotificationsConfig {
+	enabled?: boolean;
+	severityFilter?: CrewNotificationSeverity[];
+	dedupWindowMs?: number;
+	batchWindowMs?: number;
+	quietHours?: string;
+	sinkRetentionDays?: number;
+}
+
+export interface CrewObservabilityConfig {
+	enabled?: boolean;
+	pollIntervalMs?: number;
+	metricRetentionDays?: number;
+}
+
+export interface CrewRetryPolicyConfig {
+	maxAttempts?: number;
+	backoffMs?: number;
+	jitterRatio?: number;
+	exponentialFactor?: number;
+	retryableErrors?: string[];
+}
+
+export interface CrewReliabilityConfig {
+	autoRetry?: boolean;
+	retryPolicy?: CrewRetryPolicyConfig;
+	autoRecover?: boolean;
+	deadletterThreshold?: number;
+}
+
+export interface CrewOtlpConfig {
+	enabled?: boolean;
+	endpoint?: string;
+	headers?: Record<string, string>;
+	intervalMs?: number;
+}
+
+export interface PiTeamsConfig {
+	asyncByDefault?: boolean;
+	executeWorkers?: boolean;
+	notifierIntervalMs?: number;
+	requireCleanWorktreeLeader?: boolean;
+	ignoreMethod?: "gitignore" | "exclude";
+	autonomous?: PiTeamsAutonomousConfig;
+	limits?: CrewLimitsConfig;
+	runtime?: CrewRuntimeConfig;
+	control?: CrewControlConfig;
+	worktree?: CrewWorktreeConfig;
+	agents?: CrewAgentsConfig;
+	tools?: CrewToolsConfig;
+	telemetry?: CrewTelemetryConfig;
+	policy?: CrewPolicyConfig;
+	notifications?: CrewNotificationsConfig;
+	observability?: CrewObservabilityConfig;
+	reliability?: CrewReliabilityConfig;
+	otlp?: CrewOtlpConfig;
+	ui?: CrewUiConfig;
+}
+
+export interface LoadedPiTeamsConfig {
+	config: PiTeamsConfig;
+	path: string;
+	paths: string[];
+	error?: string;
+	warnings?: string[];
+}
+
+export interface ConfigValidationResult {
+	config: PiTeamsConfig;
+	warnings: string[];
+}
+
+export interface SavedPiTeamsConfig {
+	config: PiTeamsConfig;
+	path: string;
+}
+
+export interface UpdateConfigOptions {
+	cwd?: string;
+	scope?: "user" | "project";
+	unsetPaths?: string[];
+}