pi-crew 0.2.11 → 0.2.13

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-crew",
-  "version": "0.2.11",
+  "version": "0.2.13",
   "description": "Pi extension for coordinated AI teams, workflows, worktrees, and async task orchestration",
   "author": "baphuongna",
   "license": "MIT",

package/src/extension/registration/commands.ts

@@ -204,7 +204,7 @@ export function registerTeamCommands(pi: ExtensionAPI, deps: RegisterTeamCommand
 	pi.registerCommand("team-run", {
 		description: "Manually start a pi-crew run (agent may also use the team tool autonomously)",
 		handler: async (args: string, ctx: ExtensionCommandContext) => {
-			const result = await handleTeamTool(parseRunArgs(args), { ...teamCommandContext(ctx), metricRegistry: deps.getMetricRegistry?.(), startForegroundRun: (runner, runId) => deps.startForegroundRun(ctx as ExtensionContext, runner, runId), abortForegroundRun: deps.abortForegroundRun, onRunStarted: (runId) => deps.openLiveSidebar(ctx as ExtensionContext, runId) });
+			const result = await handleTeamTool(parseRunArgs(args), { ...teamCommandContext(ctx), metricRegistry: deps.getMetricRegistry?.(), startForegroundRun: (runner, runId) => deps.startForegroundRun(ctx as ExtensionContext, runner, runId), abortForegroundRun: deps.abortForegroundRun, onRunStarted: undefined });
 			await notifyCommandResult(ctx, commandText(result));
 		},
 	});
@@ -387,12 +387,14 @@ export function registerTeamCommands(pi: ExtensionAPI, deps: RegisterTeamCommand
 
 	pi.registerCommand("team-dashboard", { description: "Open a pi-crew run dashboard overlay", handler: async (_args: string, ctx: ExtensionCommandContext) => {
 		for (;;) {
+			// Extract sessionId for workspace-scoped filtering
+			const sessionId = ctx.sessionManager?.getSessionId?.();
 			const runs = deps.getManifestCache(ctx.cwd).list(50);
 			const uiConfig = loadConfig(ctx.cwd).config.ui;
 			const rightPanel = (uiConfig?.dashboardPlacement ?? DEFAULT_UI.dashboardPlacement) === "right";
 			const width = rightPanel ? Math.min(90, Math.max(40, uiConfig?.dashboardWidth ?? DEFAULT_UI.dashboardWidth)) : "90%";
 			const { RunDashboard } = await ui();
-			const selection = await ctx.ui.custom<RunDashboardSelection | undefined>((tui, theme, _keybindings, done) => new RunDashboard(runs, done, theme, { placement: rightPanel ? "right" : "center", showModel: uiConfig?.showModel, showTokens: uiConfig?.showTokens, showTools: uiConfig?.showTools, snapshotCache: deps.getRunSnapshotCache?.(ctx.cwd), runProvider: () => deps.getManifestCache(ctx.cwd).list(50), registry: deps.getMetricRegistry?.(), requestRender: () => requestRenderTarget(tui) }), { overlay: true, overlayOptions: rightPanel ? { width, minWidth: 40, maxHeight: "100%", anchor: "top-right", offsetX: 0, offsetY: 0, margin: { top: 0, right: 0, bottom: 0, left: 0 } } : { width, maxHeight: "90%", anchor: "center", margin: 2 } });
+			const selection = await ctx.ui.custom<RunDashboardSelection | undefined>((tui, theme, _keybindings, done) => new RunDashboard(runs, done, theme, { placement: rightPanel ? "right" : "center", showModel: uiConfig?.showModel, showTokens: uiConfig?.showTokens, showTools: uiConfig?.showTools, snapshotCache: deps.getRunSnapshotCache?.(ctx.cwd), runProvider: () => deps.getManifestCache(ctx.cwd).list(50), registry: deps.getMetricRegistry?.(), workspaceId: sessionId, requestRender: () => requestRenderTarget(tui) }), { overlay: true, overlayOptions: rightPanel ? { width, minWidth: 40, maxHeight: "100%", anchor: "top-right", offsetX: 0, offsetY: 0, margin: { top: 0, right: 0, bottom: 0, left: 0 } } : { width, maxHeight: "90%", anchor: "center", margin: 2 } });
 			if (!selection) return;
 			if (selection.action === "reload") continue;
 			if (selection.action === "notifications-dismiss") {

package/src/ui/crew-widget.ts

@@ -152,7 +152,13 @@ function agentStats(agent: CrewAgentRecord, liveHandle?: LiveAgentHandle): strin
 			const ctxPct = stats?.contextUsage?.percent;
 			if (ctxPct != null) parts.push(`${Math.round(ctxPct)}% ctx`);
 		} catch { /* ignore */ }
-		const ms = (act.completedAtMs ?? Date.now()) - act.startedAtMs;
+		const completedMs = act.completedAtMs || 0;
+		const startedMs = act.startedAtMs || 0;
+		// Validate: startedAtMs should be within reasonable bounds (not seconds, not far future)
+		const nowMs = Date.now();
+		const isValidStarted = startedMs > 0 && startedMs < nowMs + 60000 && startedMs > nowMs - 3155692600000;
+		const isValidCompleted = completedMs === 0 || (completedMs > 0 && completedMs < nowMs + 60000);
+		const ms = (isValidCompleted ? completedMs : nowMs) - (isValidStarted ? startedMs : nowMs);
 		parts.push(`${(ms / 1000).toFixed(1)}s`);
 	} else {
 		if (agent.toolUses) parts.push(`${agent.toolUses} tools`);
@@ -175,7 +181,7 @@ function agentsFor(run: TeamRunManifest): CrewAgentRecord[] {
 let lastStaleReconcileAt = 0;
 const STALE_RECONCILE_INTERVAL_MS = 60_000;
 
-export function activeWidgetRuns(cwd: string, manifestCache?: ManifestCache, snapshotCache?: RunSnapshotCache, preloadedManifests?: TeamRunManifest[]): WidgetRun[] {
+export function activeWidgetRuns(cwd: string, manifestCache?: ManifestCache, snapshotCache?: RunSnapshotCache, preloadedManifests?: TeamRunManifest[], workspaceId?: string): WidgetRun[] {
 	// Evict stale live-agent handles (terminal status >10min, or running >30min with no update)
 	evictStaleLiveAgentHandles();
 	// Periodic stale reconciliation: detect ghost runs on disk with dead PIDs
@@ -185,7 +191,11 @@ export function activeWidgetRuns(cwd: string, manifestCache?: ManifestCache, sna
 		lastStaleReconcileAt = now;
 		try { reconcileAllStaleRuns(cwd, manifestCache); } catch { /* non-critical background maintenance */ }
 	}
-	const runs = preloadedManifests ?? (manifestCache ? manifestCache.list(20) : listRecentRuns(cwd, 20));
+	let runs = preloadedManifests ?? (manifestCache ? manifestCache.list(20) : listRecentRuns(cwd, 20));
+	// Filter by workspaceId for session isolation
+	if (workspaceId) {
+		runs = runs.filter((run) => !run.ownerSessionId || run.ownerSessionId === workspaceId);
+	}
 	return runs
 		.map((run) => {
 			try {
@@ -409,7 +419,7 @@ class CrewWidgetComponent implements WidgetComponent {
 }
 
 export function updateCrewWidget(
-	ctx: Pick<ExtensionContext, "cwd" | "hasUI" | "ui">,
+	ctx: Pick<ExtensionContext, "cwd" | "hasUI" | "ui" | "sessionManager">,
 	state: CrewWidgetState,
 	config?: CrewUiConfig,
 	manifestCache?: ManifestCache,
@@ -419,7 +429,14 @@ export function updateCrewWidget(
 	if (!ctx.hasUI) return;
 	state.frame += 1;
 	const maxLines = config?.widgetMaxLines ?? MAX_LINES_DEFAULT;
-	const runs = activeWidgetRuns(ctx.cwd, manifestCache, snapshotCache, preloadedManifests);
+	// Get workspaceId from sessionManager, fallback to ownerSessionId from active runs
+	let workspaceId = ctx.sessionManager?.getSessionId?.();
+	if (!workspaceId && manifestCache) {
+		const runs = manifestCache.list(20);
+		const active = runs.find((r) => r.status === "running" || r.status === "queued");
+		if (active?.ownerSessionId) workspaceId = active.ownerSessionId;
+	}
+	const runs = activeWidgetRuns(ctx.cwd, manifestCache, snapshotCache, preloadedManifests, workspaceId);
 	const lines = buildCrewWidgetLines(ctx.cwd, state.frame, maxLines, runs, state.notificationCount ?? 0);
 	const placement = config?.widgetPlacement ?? DEFAULT_UI.widgetPlacement;
 	ctx.ui.setStatus(STATUS_KEY, lines.length ? statusSummary(runs) : undefined);

package/src/ui/dashboard-panes/agents-pane.ts

@@ -3,7 +3,7 @@ import { iconForStatus } from "../status-colors.ts";
 import type { RunUiSnapshot } from "../snapshot-types.ts";
 import { spinnerFrame } from "../spinner.ts";
 import type { CrewAgentRecord } from "../../runtime/crew-agent-runtime.ts";
-import { listLiveAgents, type LiveAgentHandle } from "../../runtime/live-agent-manager.ts";
+import { listLiveAgents, listLiveAgentsByWorkspace, type LiveAgentHandle } from "../../runtime/live-agent-manager.ts";
 
 /**
  * Returns true if this agent did real work (LLM call, tool use, or non-trivial duration).
@@ -52,7 +52,11 @@ function describeActivity(handle: LiveAgentHandle): string {
 export function renderAgentsPane(snapshot: RunUiSnapshot | undefined, options: RunDashboardOptions = {}): string[] {
 	if (!snapshot) return ["(snapshot unavailable)"];
 	if (!snapshot.agents.length) return ["(no agents)"];
-	const liveForRun = listLiveAgents().filter(h => h.runId === snapshot.runId);
+	// Filter live agents by workspaceId for session isolation
+	const allLive = options.workspaceId
+		? listLiveAgentsByWorkspace(options.workspaceId)
+		: listLiveAgents();
+	const liveForRun = allLive.filter(h => h.runId === snapshot.runId);
 	const { completed, total } = snapshot.progress;
 
 	const lines: string[] = [];

package/src/ui/live-conversation-overlay.ts

@@ -63,9 +63,17 @@ export class LiveConversationOverlay {
 
 	private static readonly SUMMARY_PREFIX = "\u200B"; // zero-width space as summary sentinel
 
+	private safeElapsedMs(act: typeof this.handle.activity): number {
+		const completedMs = act.completedAtMs || 0;
+		const startedMs = act.startedAtMs || 0;
+		const nowMs = Date.now();
+		const isValidStarted = startedMs > 0 && startedMs < nowMs + 60000 && startedMs > nowMs - 3155692600000;
+		const isValidCompleted = completedMs === 0 || (completedMs > 0 && completedMs < nowMs + 60000);
+		return (isValidCompleted ? completedMs : nowMs) - (isValidStarted ? startedMs : nowMs);
+	}
 	private refreshSummary(): void {
 		const act = this.handle.activity;
-		const summary = `${LiveConversationOverlay.SUMMARY_PREFIX}[${act.turnCount} turns · ${act.toolUses} tools · ${((act.completedAtMs ?? Date.now()) - act.startedAtMs) / 1000}s]`;
+		const summary = `${LiveConversationOverlay.SUMMARY_PREFIX}[${act.turnCount} turns · ${act.toolUses} tools · ${(this.safeElapsedMs(act) / 1000).toFixed(1)}s]`;
 		const lastLine = this.cachedLines[this.cachedLines.length - 1];
 		if (lastLine?.startsWith(LiveConversationOverlay.SUMMARY_PREFIX)) {
 			this.cachedLines[this.cachedLines.length - 1] = summary;
@@ -100,7 +108,7 @@ export class LiveConversationOverlay {
 			: iconForStatus(this.handle.status);
 		const name = this.handle.agent ?? this.handle.taskId;
 		const act = this.handle.activity;
-		const elapsed = `${((act.completedAtMs ?? Date.now()) - act.startedAtMs) / 1000}s`;
+		const elapsed = `${(this.safeElapsedMs(act) / 1000).toFixed(1)}s`;
 		const headerParts: string[] = [];
 		if (act.maxTurns != null) headerParts.push(`turn ${act.turnCount}/${act.maxTurns}`);
 		else if (act.turnCount > 0) headerParts.push(`turn ${act.turnCount}`);

package/src/ui/live-run-sidebar.ts

@@ -65,6 +65,8 @@ export class LiveRunSidebar {
 	private cachedLines: string[] = [];
 	private cachedWidth = 0;
 	private cachedSignature = "";
+	private autoCloseTimeout?: NodeJS.Timeout;
+	private hasAutoClosed = false;
 
 	constructor(input: { cwd: string; runId: string; done: Done; theme?: unknown; config?: CrewUiConfig; snapshotCache?: RunSnapshotCache }) {
 		this.cwd = input.cwd;
@@ -167,6 +169,24 @@ export class LiveRunSidebar {
 			lines.push(border("├", "─", "┤", w));
 			for (const entry of formatTaskGraphLines(tasks).slice(0, 6)) lines.push(line(entry, w));
 			lines.push(line("q close · /team-dashboard details", w), border("╰", "─", "╯", w));
+			// Auto-close logic: if run is terminal and no active agents, close after delay
+			const isTerminal = ["completed", "failed", "cancelled", "blocked"].includes(run.status);
+			const hasActiveAgents = agents.some((a) => a.status === "running");
+			if (isTerminal && !hasActiveAgents && !this.hasAutoClosed) {
+				const autoCloseMs = (this.config?.autoCloseDashboardMs ?? 3000);
+				if (autoCloseMs > 0) {
+					this.autoCloseTimeout = setTimeout(() => {
+						this.hasAutoClosed = true;
+						this.done(undefined);
+					}, autoCloseMs);
+					lines.push(line(`auto-close in ${Math.round(autoCloseMs / 1000)}s…`, w));
+				}
+			}
+			// Clear timeout if conditions change
+			else if (this.autoCloseTimeout) {
+				clearTimeout(this.autoCloseTimeout);
+				this.autoCloseTimeout = undefined;
+			}
 			this.cachedLines = renderLines(lines.map((entry) => this.colorLine(entry)), w);
 			this.cachedSignature = signature;
 			this.cachedWidth = w;

package/src/ui/run-dashboard.ts

@@ -41,6 +41,12 @@ export interface RunDashboardOptions {
 	snapshotCache?: RunSnapshotCache;
 	runProvider?: () => TeamRunManifest[];
 	registry?: MetricRegistry;
+	/**
+	 * Workspace/session ID for filtering runs and live agents. When provided,
+	 * only runs with matching ownerSessionId and live agents with matching
+	 * workspaceId are shown. This ensures session isolation in the UI.
+	 */
+	workspaceId?: string;
 	/**
 	 * Poke the host TUI to repaint after a state change. Must be wired from
 	 * `commands.ts` (`() => requestRenderTarget(tui)`) so keypresses and event-bus
@@ -279,7 +285,12 @@ export class RunDashboard implements DashboardComponent {
 		theme: unknown = {},
 		options: RunDashboardOptions = {},
 	) {
-		this.runs = runs;
+		// Filter runs by workspaceId for session isolation
+		// If workspaceId is provided, only show runs owned by that session or runs with no owner (legacy)
+		const filteredRuns = options.workspaceId
+			? runs.filter((run) => !run.ownerSessionId || run.ownerSessionId === options.workspaceId)
+			: runs;
+		this.runs = filteredRuns;
 		this.done = done;
 		this.theme = asCrewTheme(theme);
 		this.options = options;