pi-crew 0.11.7 → 0.11.9

package/src/extension/command-completions.ts

@@ -53,31 +53,53 @@ function statusIcon(status: TeamRunManifest["status"]): string {
  * process cwd matches the session cwd.
  */
 export function suggestRunIds(_prefix: string, cwd?: string): AutocompleteItem[] | null {
-	const resolvedCwd = cwd ?? process.cwd();
-	const runs = listRecentRuns(resolvedCwd, MAX_RUN_SUGGESTIONS);
-	if (runs.length === 0) return null;
-	const items: AutocompleteItem[] = runs.map((run) => ({
-		value: run.runId,
-		label: run.runId,
-		description: `${statusIcon(run.status)} ${run.status} · ${run.team} · ${(run.goal ?? "").slice(0, 48)}`,
-	}));
-	return filterByPrefix(items, _prefix);
+	// L-crash (2026-10-08): completion callbacks run inside pi's autocomplete
+	// provider, which does not catch extension errors — never throw here.
+	try {
+		const resolvedCwd = cwd ?? process.cwd();
+		const runs = listRecentRuns(resolvedCwd, MAX_RUN_SUGGESTIONS);
+		if (runs.length === 0) return null;
+		const items: AutocompleteItem[] = runs.map((run) => ({
+			value: run.runId,
+			label: run.runId,
+			description: `${statusIcon(run.status)} ${run.status} · ${run.team} · ${(run.goal ?? "").slice(0, 48)}`,
+		}));
+		return filterByPrefix(items, _prefix);
+	} catch {
+		return null;
+	}
 }
 
-/** Suggest task IDs within a specific run (for /team-result <runId> <taskId>). */
+/**
+ * Suggest task IDs within a specific run (for /team-result <runId> <taskId>).
+ *
+ * L-crash (2026-10-08, P0): this runs inside pi's autocomplete provider
+ * (`CombinedAutocompleteProvider.getSuggestions`), which does NOT catch
+ * extension errors — a throw here kills the whole pi process (live-caught:
+ * uncaught_exception "Invalid runId: team_x/team-transcript" after the
+ * autocomplete popup raced typed input and glued a "/…" suffix onto the
+ * runId token; assertSafePathId correctly rejected it, but the throw
+ * escaped). Completion callbacks must NEVER throw: any failure -> null.
+ */
 export async function suggestTaskIds(runId: string, prefix: string, cwd?: string): Promise<AutocompleteItem[] | null> {
-	const resolvedCwd = cwd ?? process.cwd();
-	// Dynamic import to avoid pulling state-store into the hot command-registration path.
-	// LAZY: defer dynamic import of ../state/stores/state-store.ts to its call site.
-	const { loadRunManifestById } = await import("../state/stores/state-store.ts");
-	const loaded = loadRunManifestById(resolvedCwd, runId);
-	if (!loaded) return null;
-	const items: AutocompleteItem[] = loaded.tasks.map((task) => ({
-		value: task.id,
-		label: task.id,
-		description: `${task.status} · ${task.role} · ${task.title?.slice(0, 40) ?? ""}`,
-	}));
-	return filterByPrefix(items, prefix);
+	try {
+		const resolvedCwd = cwd ?? process.cwd();
+		// Dynamic import to avoid pulling state-store into the hot command-registration path.
+		// LAZY: defer dynamic import of ../state/stores/state-store.ts to its call site.
+		const { loadRunManifestById } = await import("../state/stores/state-store.ts");
+		const loaded = loadRunManifestById(resolvedCwd, runId);
+		if (!loaded) return null;
+		const items: AutocompleteItem[] = loaded.tasks.map((task) => ({
+			value: task.id,
+			label: task.id,
+			description: `${task.status} · ${task.role} · ${task.title?.slice(0, 40) ?? ""}`,
+		}));
+		return filterByPrefix(items, prefix);
+	} catch {
+		// Invalid runId (path-unsafe chars), import/state-store/cache failure —
+		// degrade to "no suggestions" instead of crashing the host process.
+		return null;
+	}
 }
 
 /** Suggest available teams for /team-run <team>. */

package/src/extension/registration/foreground-run-controller.ts

@@ -92,6 +92,15 @@ function startForegroundRunImpl(
 	runId?: string,
 ): void {
 	const ownerGeneration = ctx.captureSessionGeneration();
+	// Issue #62: tool-dispatched runs receive a SPREAD COPY of the session
+	// context (withSessionId() always returns { ...ctx }), so the object-
+	// identity check (isContextCurrent) was false from the very first moment
+	// and the whole completion block below was silently skipped for every
+	// foreground run started via the team/subagent tools — stale working
+	// message, no crew:run-completed entry, no crew.run.* metrics. Liveness
+	// for the reporting half is therefore session-ID based; the UI clear is
+	// unconditional (try/catch guards a disposed ctx).
+	const ownerSessionId = extensionCtx.sessionManager?.getSessionId?.();
 	const controller = new AbortController();
 	const key = runId ?? Symbol();
 	ctx.foregroundTeamRunControllers.set(key, controller);
@@ -130,7 +139,7 @@ function startForegroundRunImpl(
 						logInternalError("register.foreground-run-failure", statusError, `runId=${runId}`);
 					}
 				}
-				if (ctx.isContextCurrent(extensionCtx, ownerGeneration)) {
+				if (ctx.isOwnerSessionCurrent(ownerGeneration, ownerSessionId)) {
 					extensionCtx.ui.notify(`pi-crew foreground run failed: ${message}`, "error");
 				} else {
 					logInternalError("register.foreground-run-failure", error, `runId=${runId} context disposed`);
@@ -145,18 +154,18 @@ function startForegroundRunImpl(
 						})
 						.catch((error) => logInternalError("register.foreground-watchdog", error, `runId=${runId}`));
 				}
-				const ownerCurrent = ctx.isContextCurrent(extensionCtx, ownerGeneration);
-				// The owner ctx can go stale while the run is in flight (e.g. the
-				// user opened an agent session view via /crew-view and the run
-				// finishes there): the `hasUI` getter THROWS on a stale ctx, so
-				// it must only be touched for the still-current owner.
-				if (ownerCurrent && extensionCtx.hasUI) {
-					try {
+				const ownerCurrent = ctx.isOwnerSessionCurrent(ownerGeneration, ownerSessionId);
+				// Issue #62: clear the working message UNCONDITIONALLY. The `hasUI`
+				// getter THROWS on a disposed ctx, so touch it inside try/catch —
+				// a stale ctx just means the host already reset its UI; a live one
+				// must never keep spinning a finished run's label.
+				try {
+					if (extensionCtx.hasUI) {
 						setWorkingIndicator(extensionCtx);
 						extensionCtx.ui.setWorkingMessage();
-					} catch {
-						/* ignore */
 					}
+				} catch {
+					/* disposed ctx — host-side UI reset already happened */
 				}
 				if (ownerCurrent && runId) {
 					const loaded = loadRunManifestById(extensionCtx.cwd, runId);