pi-crew 0.11.25 → 0.11.26
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +11 -0
- package/agents/verifier.md +1 -1
- package/dist/index.mjs +55 -55
- package/package.json +1 -1
- package/src/runtime/goal-workflow/plan-templates.ts +2 -2
- package/src/runtime/task-runner/post-execution.ts +10 -4
- package/workflows/default.workflow.md +1 -1
- package/workflows/fast-fix.workflow.md +1 -1
- package/workflows/plan-execute.workflow.md +1 -1
- package/workflows/review.workflow.md +1 -1
- package/workflows/strict-fast-fix.workflow.md +1 -1
package/package.json
CHANGED
|
@@ -141,7 +141,7 @@ registerPlanTemplate({
|
|
|
141
141
|
name: "verify",
|
|
142
142
|
role: "verifier",
|
|
143
143
|
taskTemplate:
|
|
144
|
-
"Verify that all review findings are addressed. Run FAST checks (completes in <2 min): `npm run test:critical && npx tsc --noEmit`. Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Confirm: {{goal}} is achieved.",
|
|
144
|
+
"Verify that all review findings are addressed. Run FAST checks (completes in <2 min): `npm run test:critical && npx tsc --noEmit`. Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Confirm: {{goal}} is achieved. Start the report with the verdict line `PASS: <what verified> — <evidence>` or `FAIL: <what failed> — <reason>` (the green-contract consumer reads it; no verdict line = UNVERIFIED).",
|
|
145
145
|
maxTasks: 1,
|
|
146
146
|
dependsOn: ["review"],
|
|
147
147
|
verificationCommand: "npm run test:critical && npx tsc --noEmit",
|
|
@@ -189,7 +189,7 @@ registerPlanTemplate({
|
|
|
189
189
|
name: "verify",
|
|
190
190
|
role: "verifier",
|
|
191
191
|
taskTemplate:
|
|
192
|
-
"Verify the complete implementation of: {{goal}}. Run FAST checks (`npm run test:critical && npx tsc --noEmit`, completes in <2 min). Do NOT run `npm run test:unit` or `npm test` — too slow for in-loop verification (642 files, >4 min). Validate all acceptance criteria.",
|
|
192
|
+
"Verify the complete implementation of: {{goal}}. Run FAST checks (`npm run test:critical && npx tsc --noEmit`, completes in <2 min). Do NOT run `npm run test:unit` or `npm test` — too slow for in-loop verification (642 files, >4 min). Validate all acceptance criteria. Start the report with the verdict line `PASS: <what verified> — <evidence>` or `FAIL: <what failed> — <reason>` (the green-contract consumer reads it; no verdict line = UNVERIFIED).",
|
|
193
193
|
maxTasks: 1,
|
|
194
194
|
dependsOn: ["review"],
|
|
195
195
|
verificationCommand: "npm run test:critical && npx tsc --noEmit",
|
|
@@ -127,11 +127,17 @@ export type VerifierVerdict = "pass" | "fail" | "none";
|
|
|
127
127
|
* (`live-session-runtime.ts` buildOutputContract → "PASS: <what verified> —
|
|
128
128
|
* <evidence>" / "FAIL: <what failed> — <reason>"). Tolerates the markdown
|
|
129
129
|
* decorations real workers emit (`**PASS:**`, `- FAIL:`, `> PASS:`,
|
|
130
|
-
* `` `PASS:` ``, `# PASS:`)
|
|
131
|
-
*
|
|
132
|
-
*
|
|
130
|
+
* `` `PASS:` ``, `# PASS:`) AND the bare-prose verdicts the child-process
|
|
131
|
+
* workflow prompts used to ask for ("Give PASS or FAIL with evidence" →
|
|
132
|
+
* `PASS`, `**PASS**`, `PASS — evidence`, `PASS. Evidence: …`): a wave-6 T7
|
|
133
|
+
* live probe caught a FAILED-gate run blocking as `green_unsatisfied /
|
|
134
|
+
* observed=none` because the verifier followed its prose prompt and wrote a
|
|
135
|
+
* bare verdict. A token only counts at LINE START and only when followed by
|
|
136
|
+
* punctuation/EOL/`(` — a bare mention inside prose ("the verifier said
|
|
137
|
+
* PASS: that") still does NOT count, and a word continuation ("PASSED all
|
|
138
|
+
* checks") does not either.
|
|
133
139
|
*/
|
|
134
|
-
const VERIFIER_VERDICT_LINE = /^[\s*_>#`=-]*(PASS|FAIL)\s
|
|
140
|
+
const VERIFIER_VERDICT_LINE = /^[\s*_>#`=-]*(PASS|FAIL)[\s*_`]*(?=[:.\u2014\u2013-]|$|\()/i;
|
|
135
141
|
|
|
136
142
|
/**
|
|
137
143
|
* M3-2 (R47-3/V4, fix-wave 6): read the verifier verdict out of the
|
|
@@ -36,6 +36,6 @@ Rules:
|
|
|
36
36
|
- **MAXIMIZE PARALLELISM**: Put independent tasks in the SAME phase so they run concurrently. Never create sequential phases when tasks are independent.
|
|
37
37
|
- Task titles name the concrete piece of work — they become the task list the user watches.
|
|
38
38
|
- Choose the smallest effective number of tasks per phase; a simple goal may have 1-2 phases with 1-2 tasks.
|
|
39
|
-
- End implementation plans with a verification phase (`verifier` role): run FAST targeted checks only (e.g. the affected test files), never the full suite.
|
|
39
|
+
- End implementation plans with a verification phase (`verifier` role): run FAST targeted checks only (e.g. the affected test files), never the full suite. The verifier's report MUST start with the verdict line — `PASS: <what verified> — <evidence>` or `FAIL: <what failed> — <reason>` (the green-contract consumer reads it; a report with no verdict line is treated as UNVERIFIED).
|
|
40
40
|
- Tasks within the same phase run in parallel; phases run sequentially.
|
|
41
41
|
- Do not include more than 12 tasks per phase; split or summarize oversized plans instead.
|
|
@@ -21,4 +21,4 @@ dependsOn: execute
|
|
|
21
21
|
verify: true
|
|
22
22
|
|
|
23
23
|
Verify the fix with available evidence.
|
|
24
|
-
Run FAST checks ONCE and cache output WITH provenance to `.crew/cache/` (per `agents/verifier.md`: unique per-attempt filename, `set -o pipefail` so the recorded exit code is the command's — not `tee`'s — and a sibling `.meta` recording command, git revision, tree fingerprint): `npm run test:critical && npx tsc --noEmit` (completes in <60s; if this repo lacks these scripts, use its fastest documented check instead). Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Cross-reference cached output with the fix — reuse a cached log only when its provenance matches. Do NOT re-run tests.
|
|
24
|
+
Run FAST checks ONCE and cache output WITH provenance to `.crew/cache/` (per `agents/verifier.md`: unique per-attempt filename, `set -o pipefail` so the recorded exit code is the command's — not `tee`'s — and a sibling `.meta` recording command, git revision, tree fingerprint): `npm run test:critical && npx tsc --noEmit` (completes in <60s; if this repo lacks these scripts, use its fastest documented check instead). Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Cross-reference cached output with the fix — reuse a cached log only when its provenance matches. Do NOT re-run tests. Start your report with the verdict line — `PASS: <what verified> — <evidence>` or `FAIL: <what failed> — <reason>` (exact single-line format; the leader's green-contract consumer reads this line — a report with no verdict line is treated as UNVERIFIED). Then give details.
|
|
@@ -27,4 +27,4 @@ dependsOn: execute
|
|
|
27
27
|
verify: true
|
|
28
28
|
|
|
29
29
|
Verify completion for: {goal}
|
|
30
|
-
Run FAST checks ONCE and cache output WITH provenance to `.crew/cache/` (per `agents/verifier.md`: unique per-attempt filename, `set -o pipefail` so the recorded exit code is the command's — not `tee`'s — and a sibling `.meta` recording command, git revision, tree fingerprint): `npm run test:critical && npx tsc --noEmit` (completes in <60s; if this repo lacks these scripts, use its fastest documented check instead). Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Cross-reference cached output with the changes — reuse a cached log only when its provenance matches. Do NOT re-run tests.
|
|
30
|
+
Run FAST checks ONCE and cache output WITH provenance to `.crew/cache/` (per `agents/verifier.md`: unique per-attempt filename, `set -o pipefail` so the recorded exit code is the command's — not `tee`'s — and a sibling `.meta` recording command, git revision, tree fingerprint): `npm run test:critical && npx tsc --noEmit` (completes in <60s; if this repo lacks these scripts, use its fastest documented check instead). Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Cross-reference cached output with the changes — reuse a cached log only when its provenance matches. Do NOT re-run tests. Start your report with the verdict line — `PASS: <what verified> — <evidence>` or `FAIL: <what failed> — <reason>` (exact single-line format; the leader's green-contract consumer reads this line — a report with no verdict line is treated as UNVERIFIED). Then give details.
|
|
@@ -28,4 +28,4 @@ role: verifier
|
|
|
28
28
|
dependsOn: code-review, security-review
|
|
29
29
|
verify: true
|
|
30
30
|
|
|
31
|
-
Run FAST checks ONCE and cache output WITH provenance to `.crew/cache/` (per `agents/verifier.md`: unique per-attempt filename, `set -o pipefail` so the recorded exit code is the command's — not `tee`'s — and a sibling `.meta` recording command, git revision, tree fingerprint): `npm run test:critical && npx tsc --noEmit` (completes in <60s; if this repo lacks these scripts, use its fastest documented check instead). Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Cross-reference cached output with reviewer and security-reviewer findings — reuse a cached log only when its provenance matches. Confirm each finding against real test output.
|
|
31
|
+
Run FAST checks ONCE and cache output WITH provenance to `.crew/cache/` (per `agents/verifier.md`: unique per-attempt filename, `set -o pipefail` so the recorded exit code is the command's — not `tee`'s — and a sibling `.meta` recording command, git revision, tree fingerprint): `npm run test:critical && npx tsc --noEmit` (completes in <60s; if this repo lacks these scripts, use its fastest documented check instead). Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Cross-reference cached output with reviewer and security-reviewer findings — reuse a cached log only when its provenance matches. Confirm each finding against real test output. Start your report with the verdict line — `PASS: <what verified> — <evidence>` or `FAIL: <what failed> — <reason>` (exact single-line format; the leader's green-contract consumer reads this line — a report with no verdict line is treated as UNVERIFIED). Then give details.
|
|
@@ -23,4 +23,4 @@ dependsOn: execute
|
|
|
23
23
|
verify: true
|
|
24
24
|
|
|
25
25
|
Verify the fix with available evidence, AND cross-reference the SPEC-EVIDENCE footer from explore+execute against the spec's requirements (machine-check the citations vs the spec id set).
|
|
26
|
-
Run FAST checks ONCE and cache output WITH provenance to `.crew/cache/` (per `agents/verifier.md`: unique per-attempt filename, `set -o pipefail` so the recorded exit code is the command's — not `tee`'s — and a sibling `.meta` recording command, git revision, tree fingerprint): `npm run test:critical && npx tsc --noEmit` (completes in <60s; if this repo lacks these scripts, use its fastest documented check instead). Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Cross-reference cached output with the fix — reuse a cached log only when its provenance matches. Do NOT re-run tests.
|
|
26
|
+
Run FAST checks ONCE and cache output WITH provenance to `.crew/cache/` (per `agents/verifier.md`: unique per-attempt filename, `set -o pipefail` so the recorded exit code is the command's — not `tee`'s — and a sibling `.meta` recording command, git revision, tree fingerprint): `npm run test:critical && npx tsc --noEmit` (completes in <60s; if this repo lacks these scripts, use its fastest documented check instead). Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Cross-reference cached output with the fix — reuse a cached log only when its provenance matches. Do NOT re-run tests. Start your report with the verdict line — `PASS: <what verified> — <evidence>` or `FAIL: <what failed> — <reason>` (exact single-line format; the leader's green-contract consumer reads this line — a report with no verdict line is treated as UNVERIFIED). Then give details. Include the spec-gate verdict too.
|