pi-crew 0.11.0 → 0.11.2

package/CHANGELOG.md

@@ -1,7 +1,153 @@
 # Changelog
 
+## [Unreleased]
+
+## [0.11.2] — runtime hygiene, in-process async test seam, slash-command fixes (2026-09-26)
+
+### runtime: ambient-noise + temp-workspace hygiene + in-process async test seam
+
+- **Ambient notification false-positives (guest `gc-*` subagents)**: the heartbeat watcher and the UI heartbeat aggregator no longer treat delegate-owned guest tasks as worker heartbeats — guests have no heartbeat channel (their lifecycle is `delegate.requested/admitted/completed`); fires were observed 52ms after admit. Skipped at both independent layers (`heartbeat-watcher.ts`, `heartbeat-aggregator.ts`), each with a guard-test proving a genuinely-missing real worker is still flagged.
+- **Temp-workspace hygiene** (live triage: health `running=144`, ~3.4k `pi-crew-*` tmpdirs, frozen reconciler): the orphan sweep batch now rotates statelessly (`floor(now/60s) % batches`) so an alphabetically-first stuck cluster can no longer starve the dirs behind it; abandoned `.cleanup-in-progress` sentinels older than 10 minutes are reclaimed; the test runner sweeps pre-existing `pi-crew-*` debris (mtime < suiteStart−30min) after every suite — one choke point covering ~320 mkdtemp-using test files (opt-out `PI_CREW_TEST_NO_TMP_SWEEP=1`).
+- **In-process async test seam**: `PI_CREW_TEST_ASYNC_INLINE=1` + `PI_CREW_ALLOW_MOCK=1` (double gate; production sets neither) executes async runs in-process instead of spawning a detached background-runner — the run logic is now an exported `executeBackgroundRun()` core shared verbatim by the detached runner and the seam, and `main()` is entry-guarded (`PI_CREW_BACKGROUND_RUNNER_ENTRY` or argv entry check) so importing the module runs nothing. Kills the Windows Defender first-spawn stall (`subagent-tools-integration`: 5+min stall-prone → 14/14 in 37s) and the orphan-runner tmpdir leak (in-process runs die with the test process). See `docs/decisions/2026-09-26-inline-async-test-seam.md`.
+
+### slash-commands usability fixes
+
+- `/team-respond` now guards its arguments (`<runId> <taskId|--all> <message>`) with a usage message instead of surfacing an opaque tool error.
+- `/team-goal` metadata is honest: description lists the real sub-actions (`cancel`, `reset`, default `status`) and first-argument completions suggest them.
+- `/team-metrics` appends a hint when the snapshot is empty — naming observability as the likely cause and the `observability: true` enable path.
+- `/team-dashboard` in a headless session now notifies that it needs a UI (suggesting `/team-status`) instead of silently doing nothing.
+- Notification truncation is explicit: clipped output ends with `… [truncated]`, still capped at 800 chars; `/team-events` appends the on-disk events log path when truncated so the full log stays reachable.
+- `/skill-create` resolution is ESM-safe (`import.meta.url` walk-up replacing `require.resolve`/`__dirname`) and works identically under strip-types and the bundle; missing/unknown template ids now list the available template ids.
+- `/team-help` resynced to the real command surface (all 38 team commands + pointer to the 5 non-team commands).
+- `docs/commands-reference.md` truth-synced: phantom `/team-cleanup` removed, `/team-respond`//`/team-follow-up`//`/team-invalidate` args fixed, `/team-vibes` reduced to its real `[on|off]` surface, `/schedules`//`/skill-list`//`/skill-create`//`/crew-brief`//`/team-cleanup-menu` documented — locked by a new docs↔code set-equality parity test.
+- New handler tests: team-respond guard, team-goal metadata, command output hints (truncation/dashboard/metrics), skill-create ESM resolution, team-vibes (status/on/off/usage-error).
+
+### docs: lean docs tree
+
+- README rewritten as a lean landing page (1099 → 206 lines): the changelog-duplicate section, full config dump, and action/command tables are replaced by links to their single sources; stale claims corrected (55 actions, 18 agents). The "⚠️ IMPORTANT — Read before using" warning is restored as a compact callout (same honest framing, details delegated to trust-model/security-issues/limitations).
+- Dated point-in-time docs (audits, plans, fix specs, roadmaps, migration guides) moved to `docs/archive/`; perf analyses to `docs/perf/`; `docs/README.md` rebuilt as a three-group index (Start here / Reference / Records).
+- `runtime-flow.md` folded into `architecture.md` ("Runtime flow"); the stale `v0.10.3` version header dropped.
+- Error-code range corrected to E001–E013 everywhere (E013 `ModelOutOfScope` shipped undocumented).
+- Cross-references updated repo-wide (docs, src/test comments, runtime warning string, tarball whitelist); `migration-v0.4-v0.5.md` and `runtime-flow.md` dropped from the npm file whitelist.
+
 > **Note:** `atomic-write-v2.ts` / `AtomicWriter` mentioned in historical entries below was consolidated into `atomic-write.ts` as of v0.9.42. This changelog is preserved as historical record — the migration was completed (the v2 class was never adopted; v1 won on simplicity + symlink-safety + link+unlink atomicity). See `docs/migration/atomic-write-v2-migration.md` for the decision rationale.
 
+## [0.11.1] — RAIL: one UI design language for every surface + UI-audit fixes (2026-09-16)
+
+### feat(ui): RAIL — a single visual language for the whole product
+
+- **New shared design system.** `src/ui/rail.ts` owns every glyph and helper —
+  rail `┏ ┣ ┃ ┗`, the `NAME ▸ SUBJECT` canopy, dot leaders `······`, the
+  eighth-block gauge `▕████▎░░▏`, status slot/badge/icon maps, `overflowHint`,
+  `formatHint`/`keyToken`, `CURSOR`/`ACTIVE` — and `docs/UI-DESIGN-SYSTEM.md`
+  documents the grammar, the seven surface classes and the width contract.
+  `src/ui/tool-renderers/index.ts` now imports from it instead of declaring its
+  own copies.
+- **Tool card (team + subagent) redesigned**: width-deferred through
+  `AdaptiveCard` (a frame built for 116 columns no longer tears at 100), one
+  unified identity canopy (`┏ CREW ▸ <team>`, `┏ AGENT ▸ <name>`,
+  `┏ LIST`), agent name surfaced while the run is still streaming, fail-visible
+  outcome on three levels, `done`/`succeeded` alias handling, merged
+  tally+gauge with the elapsed segment right-aligned, and `role/agent`
+  duplication collapsed (`verifier/verifier` → `verifier`).
+- **Every other surface migrated**: crew widget (still exactly ONE row:
+  `┃ ⠧ CREW ▸ fast-fix · 2 running · 3/5 done · ⏰ 1 sched ···· ↓·enter`, idle row
+  `┃ CREW ▸ idle · …`, focused `❯` marker), plan/task list (`┏ PLAN ▸ <title>`),
+  live-run sidebar (`┏ LIVE ▸ <runId8>` + `┣ ACTIVE ▸ n`), team dashboard,
+  Agents & Jobs browser, settings overlay, transcript viewer, live-conversation
+  / help / confirm / mailbox-detail / mailbox-compose / agent-picker overlays,
+  dashboard panes and `/team-mascot`. The rounded box `╭─╮│╰─╯├┤` and the inline
+  `── label ──` rule are retired (sections are `┣ NAME ▸ x`).
+- **One dialect per concept**: cursor `›`, active/section marker `▸`, overflow
+  `▲ n above` / `▼ m below` (was four dialects), hints `keys label · …` with the
+  close/cancel action last and canonical key spelling (`Esc`, `Enter`, `Tab`) —
+  including an `exactKeys` mode for the case-sensitive plan-approval keyspace
+  (`A` approve vs `n` deny).
+
+### fix(ui): bugs found by the audit, the cold-verify pass and live runs
+
+- **`undefined — ↓·enter` in the widget after a run finished** — the zero-runs
+  branch built its row without checking `schedLine`; with no active runs and no
+  schedules it painted the literal `undefined`. It now renders nothing.
+- **No `undefined` can reach a string**: every interpolated field on records read
+  from disk (`agents.json`, schedules, metrics) is guarded — role/agent/model
+  routing in the sidebar and agent picker, every persisted job field in the
+  schedules pane, metric label values, and the settings `Edit` title.
+- `1 tools` → `1 tool` (one `formatCount` helper, five surfaces).
+- Help cheatsheet no longer prints a raw TAB (`keyToken` missed `\t`).
+- `role->agent` → `role▸agent` everywhere, including the producer
+  (`task-display.ts`) rather than only at one render boundary.
+- Settings overlay: the edit submenu hint is built by `formatHint` and no longer
+  advertises a key that is not bound.
+
+### fix(ui): phantom affordances, schema drift and theme discovery (P0)
+
+- **`/team-settings theme <name>` works again**: `theme-discovery.ts` used bare
+  `require("node:fs")` inside a module loaded by dynamic import, so discovery
+  could fail silently and only the builtin themes were selectable. Now a
+  top-level import, with a HOME-sandboxed test (13 themes discovered, active
+  theme read from `settings.json`, `setPiTheme()` writes).
+- Removed the phantom `p` (progressToggle) binding/action/help entry, the no-op
+  `placement` option, and the non-existent `/team-cleanup` / `/team-health`
+  commands from help.
+- Schema/docs drift: `ui.widgetRowStyle`, `ui.inlinePanel`,
+  `ui.autoCloseDashboardMs` added to `schema.json` + configuration schema so
+  editors stop flagging valid keys; brief-mode command description scoped to
+  what it really does; help overlay gained the Schedules and Plan key groups;
+  keyboard reference and command docs corrected.
+- `LiveConversationOverlay` gained a real `handleInput` (scroll, auto-scroll
+  toggle, close) so its advertised footer keys are reachable.
+- **Terminal status restored**: the documented tab-title + Ghostty `OSC 9;4`
+  progress integration is now wired (`installTerminalStatus`) instead of the
+  no-op dispose handler; best-effort, debounced, headless-safe.
+
+### chore: dead code removed
+
+- Deleted `overlay-stack.ts`, `ui/loaders.ts`, `crew-vibes/figures.ts`,
+  `crew-vibes/font-detect.ts`, `dynamic-border.ts` and `boxLine()` plus their
+  tests (~1.7k lines net), together with the dead `compactAgentRow` chain.
+- Removed the orphaned `ui.widgetRowStyle` config chain (default, type,
+  parser, TypeBox schema, `schema.json`, KNOWN_KEYS, `model.rowStyle` field,
+  `WidgetRowStyle` type): the M4 RAIL dock renders exactly one layout, so the
+  key had no reader left. The strict schema now rejects it as unknown;
+  schema-sync + settings tests pin the removal in both directions so it cannot
+  resurface.
+
+### fix(ui): defects found by rendering a REAL team run
+
+Rendering the live run `team_20260916110100` through every surface (tool card,
+widget dock, plan card, sidebar, dashboard, agents & jobs browser) exposed seven
+defects the review passes had missed:
+
+- **The dock spun forever.** `┃ ⠹ CREW ▸ fast-fix · 0 running · 3/3 done` — a
+  spinner with nothing to spin for, because the header always received a braille
+  frame. The leading glyph now reflects state (`⠋…` only while a worker is
+  running, otherwise `✓`/`✗`); zero counts (`0 running`) are no longer printed.
+- **The dock lost its key hint on a narrow terminal.** At 50 columns the row
+  ended in `···· ↓…`; the leader budget now shrinks with the width so the left
+  segment is trimmed (with `…`) and `↓·enter` always survives.
+- **The run dashboard truncated the status into `complete…`.** The narrow-width
+  fallback clipped `head · meta` as one string, cutting the very token the run
+  list exists to show. Meta now yields first, then the goal; the head (run id +
+  status) is only clipped if it cannot fit at all.
+- **Sidebar printed an invented `· right default` string** — replaced with the
+  run's real `workspaceMode` (`single` / `worktree`).
+- **`fast-fix/fast-fix`** in the sidebar and dashboard — one shared
+  `teamWorkflowLabel()` collapses the workflow half when it repeats the team.
+- **Raw usage rows** (`input=2780, output=3715, cacheRead=57216, cost=0.000000,
+  turns=0`) — the sidebar now uses the compact `↑2.8k ↓3.7k` form the tool card
+  already had (the `key=value` form stays for CLI/status output).
+- **`314.7s` instead of `5m44s`**, `1 runs` instead of `1 run`, `3 agents` /
+  `N runs` without pluralisation, and `┃ - none` for empty sections — all
+  normalised through `formatDuration` / `formatCount`.
+
+### verification
+
+- `test:unit` full suite, `test:critical` (117/117), `test:bundle` (2/2), biome,
+  `format:check`, `tsc --noEmit` and bundle size/staleness gates all run on the
+  release tree; UI migration verified by an independent verifier rendering real
+  surfaces at 40/60/80/100/160 columns.
+
 ## [0.11.0] — Scheduled Jobs UI + Agents & Jobs browser + kitty CSI-u hardening (2026-09-15)
 
 ### feat(ui): Agents & Jobs browser — the crew widget's ↓+Enter popup
@@ -744,7 +890,7 @@ waiting-producer-ask, spec-system (+ round-1 errata).
 Branch `refactor/maintainability`: 16-round audit → 5-phase refactor →
 finding-by-finding sweep → full remediation of every open finding (Waves
 1A/1B/2A/2B/B/C). Full execution log with commit map:
-`docs/refactor-plan.md`. Audit inventory: `docs/refactor-plan.review.md`.
+`docs/archive/refactor-plan.md`. Audit inventory: `docs/archive/refactor-plan.review.md`.
 
 ### Security (config tiering)
 - Schema-driven project-config sanitize: `sensitive:true` drop-list +
@@ -807,8 +953,8 @@ finding-by-finding sweep → full remediation of every open finding (Waves
 
 ## [0.9.68] — RLM fixes after deep-review verification (2026-08-12)
 
-Fixes from `docs/rlm-deep-review-2026-08-12.md` (verified) +
-`docs/rlm-fixes-implementation-plan.md`. Each code part loop-reviewed (3
+Fixes from `docs/archive/rlm-deep-review-2026-08-12.md` (verified) +
+`docs/archive/rlm-fixes-implementation-plan.md`. Each code part loop-reviewed (3
 parallel reviewers: security/correctness/tests, read-only) before merge here.
 
 ### Fixes
@@ -855,7 +1001,7 @@ parallel reviewers: security/correctness/tests, read-only) before merge here.
 
 ## [0.9.67] — RLM/scratchpad adoption batch (I1–I7) (2026-08-11)
 
-First shippable slice of `improvement-plan-2026-08-11.md` — the scratchpad was
+First shippable slice of `docs/archive/improvement-plan-2026-08-11.md` — the scratchpad was
 armed-but-unused (0 cells in 14 runs); this batch fixes the doctrine, adds an
 adoption/value metric, and ports the pattern-12 shell guard. Each item was
 loop-reviewed (iterative-audit) before commit; `test:critical` 101/0, 129
@@ -1105,10 +1251,10 @@ Six fixes distilled from the `real-test-pi-crew` 9-tier battery (run 2026-08-10)
   - **Notifier/session-summary (`src/extension/async-notifier.ts`, `session-summary.ts`)**: filter `listRuns` theo `ownerSessionId` trước notify — session B không còn toast về run của A.
   - **Health filter (#3)**: `ctx.currentCtx?.sessionManager?.getSessionId()` + bỏ dead clause `ownerSessionGeneration` (field không tồn tại trên `TeamRunManifest`) — trước đó silently drop tất cả owned runs.
   - Verified end-to-end theo skill `real-test-pi-crew`: `test:critical` 101/101, 3-path kill-switch green, typecheck + bundle + md5 sync OK, live TUI (tmux + pty) render không crash, smoke verifier 52s (<300s, no hang), full feature battery (team tool 9a–9f + subagent tools) clean — zero `Unknown type`/`Validation failed`. 6837 unit + 214 integration tests pass.
-- Lưu ý: `#12` (DeliveryCoordinator) infrastructure staged nhưng inert — `deliver*` không có production caller, nên queue không bao giờ được feed. Documented trong `docs/cross-session-leak-fix-plan.md`.
+- Lưu ý: `#12` (DeliveryCoordinator) infrastructure staged nhưng inert — `deliver*` không có production caller, nên queue không bao giờ được feed. Documented trong `docs/archive/cross-session-leak-fix-plan.md`.
 
 ### Docs
-- `docs/cross-session-leak-audit.md` (audit re-verify: 2/2 root cause CONFIRMED, 12/13 vector CONFIRMED, #3 REFUTED) + `docs/cross-session-leak-fix-plan.md` (phased plan, reviewed).
+- `docs/archive/cross-session-leak-audit.md` (audit re-verify: 2/2 root cause CONFIRMED, 12/13 vector CONFIRMED, #3 REFUTED) + `docs/archive/cross-session-leak-fix-plan.md` (phased plan, reviewed).
 
 ## [0.9.58] — fix load crash on stale hoisted typebox: defensive guard + bundle vendoring (survives `pi update`) + round-1/round-2 fixes (2026-08-04)
 
@@ -6464,7 +6610,7 @@ Note: `src/runtime/parent-guard.ts:37` left as-is — that's an exit-time log th
 - **CHANGELOG.md** — Added the v0.5.5 entry covering all 13 rounds of code review hardening (this entry).
 - **SECURITY-ISSUES.md** — Bumped to v2.0, added v0.5.5 round-13 findings table (8 new issues closed).
 - **docs/architecture.md** — Cross-references v0.5.5 and `docs/pi-crew-v0.5.5-audit-fix-plan.md`.
-- **docs/migration-v0.4-v0.5.md** — Added v0.5.5 highlights (no breaking changes; drop-in replacement).
+- **docs/archive/migration-v0.4-v0.5.md** — Added v0.5.5 highlights (no breaking changes; drop-in replacement).
 
 ### Fixes
 
@@ -6633,7 +6779,7 @@ correctness+error-handling, and performance+architecture audits across 77 source
 - Improved consistency in section naming
 
 ### Documentation
-- Added `docs/migration-v0.4-v0.5.md` - comprehensive migration guide
+- Added `docs/archive/migration-v0.4-v0.5.md` - comprehensive migration guide
 - Updated `docs/deep-review-report.md` - complete issue tracking
 
 ### Dependencies
@@ -7315,7 +7461,7 @@ correctness+error-handling, and performance+architecture audits across 77 source
 - docs/pi-crew-bugs.md: v0.5.22 + historical note
 - docs/TEST_MATRIX.md: test count updated to 2703
 - docs/deep-review-report.md: marked historical
-- docs/migration-v0.4-v0.5.md: drop-in replacement note
+- docs/archive/migration-v0.4-v0.5.md: drop-in replacement note
 
 ### CI
 - `.github/workflows/ci.yml`: typecheck step re-enabled (was disabled since v0.3.x)