pi-crew 0.11.0 → 0.11.1

package/src/extension/registration/subagent-tools.ts

@@ -291,7 +291,7 @@ export function registerSubagentTools(
 							}),
 							t("agent.retrieveHint"),
 						].join("\n"),
-						{ agentId: record.id, status: record.status },
+						{ agentId: record.id, agentName: record.type, status: record.status },
 					),
 					terminate: true,
 				};
@@ -322,6 +322,7 @@ export function registerSubagentTools(
 				].join("\n"),
 				{
 					agentId: record.id,
+					agentName: record.type,
 					runId: record.runId,
 					status: record.status,
 				},
@@ -459,6 +460,7 @@ export function registerSubagentTools(
 				text,
 				{
 					agentId: current.id,
+					agentName: current.type,
 					runId: current.runId,
 					status: current.status,
 				},
@@ -531,14 +533,14 @@ export function registerSubagentTools(
 			if (!manifestTask) {
 				return subagentToolResult(
 					`Task '${taskId}' not found in the owning run; cannot steer.`,
-					{ agentId: record.id, runId: record.runId, taskId, status: record.status },
+					{ agentId: record.id, agentName: record.type, runId: record.runId, taskId, status: record.status },
 					true,
 				);
 			}
 			if (TEAM_TERMINAL_TASK_STATUSES.has(manifestTask.status)) {
 				return subagentToolResult(
 					`Task '${taskId}' is ${manifestTask.status}; cannot steer.`,
-					{ agentId: record.id, runId: record.runId, taskId, status: record.status },
+					{ agentId: record.id, agentName: record.type, runId: record.runId, taskId, status: record.status },
 					true,
 				);
 			}
@@ -560,7 +562,7 @@ export function registerSubagentTools(
 				if (existingBytes + Buffer.byteLength(line) > MAX_STEERING_BYTES) {
 					return subagentToolResult(
 						`Steering file for task '${taskId}' has reached its size cap (${(MAX_STEERING_BYTES / 1024).toFixed(0)}KiB); steer refused.`,
-						{ agentId: record.id, runId: record.runId, taskId, status: record.status },
+						{ agentId: record.id, agentName: record.type, runId: record.runId, taskId, status: record.status },
 						true,
 					);
 				}
@@ -579,7 +581,7 @@ export function registerSubagentTools(
 				);
 				return subagentToolResult(
 					`Steer write failed for task '${taskId}': ${err instanceof Error ? err.message : String(err)} (see pi-crew error log)`,
-					{ agentId: record.id, runId: record.runId, taskId, status: record.status },
+					{ agentId: record.id, agentName: record.type, runId: record.runId, taskId, status: record.status },
 					true,
 				);
 			}
@@ -590,6 +592,7 @@ export function registerSubagentTools(
 				].join("\n"),
 				{
 					agentId: record.id,
+					agentName: record.type,
 					runId: record.runId,
 					taskId,
 					status: record.status,
@@ -666,7 +669,14 @@ function startAgentToolProgress(cwd: string, agentRecordId: string, onUpdate: On
 				agents,
 				error: record.error,
 			});
-			onUpdate({ content: [{ type: "text", text }] });
+			// W2: carry identity in the partial payload too — the renderer's
+			// streaming branch reads `result.details.agentName` to label the
+			// card. Pi's onUpdate TYPE is content-only; extra keys pass through
+			// to renderResult at runtime, hence the deliberate cast.
+			onUpdate({
+				content: [{ type: "text", text }],
+				details: { agentId: record.id, agentName: record.type, runId: record.runId, status: record.status },
+			} as never);
 		} catch (error) {
 			logInternalError("subagent-tools.progress", error, `agentId=${agentRecordId}`);
 		}

package/src/extension/registration/team-tool.ts

@@ -10,7 +10,7 @@ import type { createManifestCache } from "../../runtime/manifest-cache.ts";
 import { TeamToolParams, type TeamToolParamsValue } from "../../schema/team-tool-schema.ts";
 import { updatePiCrewPowerbar } from "../../ui/powerbar-publisher.ts";
 import type { createRunSnapshotCache } from "../../ui/run-snapshot-cache.ts";
-import { statusIcon, type ToolRenderContext, teamToolRenderer } from "../../ui/tool-renderers/index.ts";
+import { type ToolRenderContext, teamToolRenderer } from "../../ui/tool-renderers/index.ts";
 import type { CrewWidgetState } from "../../ui/widget/index.ts";
 import { updateCrewWidget } from "../../ui/widget/index.ts";
 import { safeAbort } from "../../utils/safe-abort.ts";
@@ -260,6 +260,11 @@ export function registerTeamTool(pi: ExtensionAPI, deps: RegisterTeamToolDeps):
 					onJsonEvent: deps.onJsonEvent,
 					getRunSnapshotCache: deps.getRunSnapshotCache,
 				});
+				// W5: surface the team name on the collapsed run card — the renderer
+				// reads `details.team`; enrich (non-destructively) for run results.
+				if (resolved.action === "run" && !output.isError && output.details && typeof output.details === "object") {
+					(output.details as unknown as Record<string, unknown>).team ??= resolved.team ?? resolved.agent ?? "";
+				}
 				if (resolved.action === "run" && !output.isError && typeof output.details?.runId === "string") {
 					pi.appendEntry("crew:run-started", {
 						runId: output.details.runId,
@@ -296,8 +301,10 @@ export function registerTeamTool(pi: ExtensionAPI, deps: RegisterTeamToolDeps):
 					theme,
 					context as ToolRenderContext,
 				);
-			} catch {
-				return new Text(statusIcon("completed", theme) + " done", 0, 0);
+			} catch (e) {
+				// W1: fail-visible at the adapter layer too — never fake a "done".
+				const msg = e instanceof Error ? e.message : String(e);
+				return new Text(theme.fg("error", `✖ team render error: ${msg.slice(0, 60)}`), 0, 0);
 			}
 		},
 	};

package/src/extension/registration/terminal-status-wiring.ts

@@ -0,0 +1,172 @@
+/**
+ * M3-1 (UI-AUDIT P0-2/P1-1): wire the terminal-status controller (tab title +
+ * Ghostty OSC 9;4 progress) to the runEventBus.
+ *
+ * History: `src/ui/terminal-status.ts` shipped in v0.8.3 (819d71ad) with unit
+ * tests but NO construction site — `ctx.terminalStatus` was never assigned, so
+ * the feature never ran. This module is the missing wire, installed once from
+ * `register.ts` in place of the old no-op cleanup handler.
+ *
+ * Design:
+ *   - Subscribe to `runEventBus.onAny` and debounce evaluation (250ms) so a
+ *     burst of task events collapses into one state transition.
+ *   - State is derived from `listLiveAgents()`: >0 live → active; 0 → idle.
+ *     `ctx.terminalStatusActive` (already in RegistrationContext) is the single
+ *     source of truth for the current phase, so `runtime-cleanup.ts` resetting
+ *     it also resets this state machine on the next event.
+ *   - On the idle transition, `onRunCompleted()` fires the green Ghostty flash
+ *     and `onIdle()` runs COMPLETE_FLASH_MS later (title restore + re-assert
+ *     loop), so the flash is visible before the bar clears.
+ *   - The `TerminalStatusUi` adapter reads `ctx.currentCtx` dynamically (getter
+ *     + call-time lookup), so a session swap never leaves the controller
+ *     holding a stale session's `ui.setTitle` (the P1-10 class of bug).
+ *   - Everything is best-effort and guarded by `hasUI`: headless / subagent
+ *     contexts evaluate to a no-op and write nothing.
+ *   - All timers are `unref()`-ed; dispose unsubscribes, clears timers and
+ *     disposes the controller (registered via `registerCleanupHandler`, which
+ *     replaces the old no-op `disposeTerminalStatus` handler in register.ts).
+ */
+
+import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import { listLiveAgents } from "../../runtime/live-session/live-agent-manager.ts";
+import { runEventBus } from "../../ui/run-event-bus.ts";
+import {
+	buildCrewTitleSegment,
+	COMPLETE_FLASH_MS,
+	createTerminalStatusController,
+	setTerminalTitle,
+	type TerminalStatusController,
+	type TerminalStatusUi,
+} from "../../ui/terminal-status.ts";
+import { registerCleanupHandler } from "../crew-cleanup.ts";
+
+/**
+ * Structural subset of RegistrationContext this module needs. Declared
+ * locally (not imported) so tests can pass a 3-field fake without building
+ * the full context, while `register.ts` passes the real context unchanged.
+ */
+export interface TerminalStatusWiringDeps {
+	currentCtx: { hasUI: boolean; ui: { setTitle(title: string): void } } | undefined;
+	terminalStatus: TerminalStatusController | undefined;
+	terminalStatusActive: boolean;
+}
+
+/** Debounce window that collapses an event burst into one evaluation. */
+const EVAL_DEBOUNCE_MS = 250;
+
+/**
+ * Live-agent probe (dependency inversion for tests). Production reads the real
+ * registry; tests inject a deterministic count source.
+ */
+let liveAgentProbe: () => number = () => listLiveAgents().length;
+
+/** @internal Re-subscribe guard: unsubscribe fn from a previous registration. */
+let currentUnsubscribe: (() => void) | undefined;
+/** @internal Latest install's full dispose (unsubscribe + timers + controller). */
+let currentDispose: (() => void) | undefined;
+
+/** Test seam: override the live-agent source (restore with `() => default`). */
+export function __test__setLiveAgentProbe(probe: () => number): void {
+	liveAgentProbe = probe;
+}
+
+/** Test seam: fully dispose any wiring left by a previous install in this process. */
+export function __test__resetTerminalStatusWiring(): void {
+	currentDispose?.();
+	currentDispose = undefined;
+	currentUnsubscribe = undefined;
+}
+
+export function installTerminalStatus(pi: ExtensionAPI, deps: TerminalStatusWiringDeps): void {
+	// A previous registration in this process must not leave a second
+	// subscription behind (registerCleanupHandler only keeps the latest
+	// dispose fn, so an older subscription would leak otherwise).
+	currentUnsubscribe?.();
+
+	// Dynamic adapter: resolves the CURRENT session's UI at call time, so the
+	// controller never captures a session-scoped reference.
+	const adapter: TerminalStatusUi = {
+		get hasUI(): boolean {
+			return deps.currentCtx?.hasUI ?? false;
+		},
+		ui: {
+			setTitle(title: string): void {
+				deps.currentCtx?.ui.setTitle(title);
+			},
+		},
+	};
+
+	let evalTimer: ReturnType<typeof setTimeout> | undefined;
+	let idleTimer: ReturnType<typeof setTimeout> | undefined;
+	let lastSegment = "";
+
+	const clearTimers = (): void => {
+		if (evalTimer) {
+			clearTimeout(evalTimer);
+			evalTimer = undefined;
+		}
+		if (idleTimer) {
+			clearTimeout(idleTimer);
+			idleTimer = undefined;
+		}
+	};
+
+	const evaluate = (): void => {
+		evalTimer = undefined;
+		if (!adapter.hasUI) return;
+		if (!deps.terminalStatus) deps.terminalStatus = createTerminalStatusController(adapter);
+		const controller = deps.terminalStatus;
+
+		if (liveAgentProbe() > 0) {
+			// Active: cancel any pending idle transition, then (re)assert.
+			if (idleTimer) {
+				clearTimeout(idleTimer);
+				idleTimer = undefined;
+			}
+			if (!deps.terminalStatusActive) {
+				deps.terminalStatusActive = true;
+				controller.onRunsActive(); // title (best-effort) + Ghostty INDETERMINATE
+				lastSegment = buildCrewTitleSegment();
+				return;
+			}
+			// Still active: refresh the title only when the role summary changed
+			// (never re-emit the OSC sequence — state 3 persists on its own).
+			const segment = buildCrewTitleSegment();
+			if (segment && segment !== lastSegment) {
+				lastSegment = segment;
+				setTerminalTitle(adapter, segment);
+			}
+			return;
+		}
+
+		if (deps.terminalStatusActive) {
+			deps.terminalStatusActive = false;
+			lastSegment = "";
+			controller.onRunCompleted(); // green flash, self-re-evaluates after COMPLETE_FLASH_MS
+			idleTimer = setTimeout(() => {
+				idleTimer = undefined;
+				controller.onIdle(); // title restore + idle re-assert loop + Ghostty CLEAR
+			}, COMPLETE_FLASH_MS);
+			idleTimer.unref?.();
+		}
+	};
+
+	const unsubscribe = runEventBus.onAny(() => {
+		if (evalTimer) return;
+		evalTimer = setTimeout(evaluate, EVAL_DEBOUNCE_MS);
+		evalTimer.unref?.();
+	});
+	currentUnsubscribe = unsubscribe;
+	const dispose = (): void => {
+		unsubscribe();
+		currentUnsubscribe = undefined;
+		currentDispose = undefined;
+		clearTimers();
+		deps.terminalStatus?.dispose();
+		deps.terminalStatus = undefined;
+		deps.terminalStatusActive = false;
+	};
+	currentDispose = dispose;
+
+	registerCleanupHandler(pi, { disposeTerminalStatus: dispose });
+}

package/src/extension/registration/viewers.ts

@@ -90,10 +90,16 @@ export async function openLiveConversation(
 					return overlay.render(width);
 				},
 				handleInput(data: string) {
+					// Close keys stay exactly as they were: close the overlay and
+					// resolve the custom() promise.
 					if (matchesKey(data, "escape") || matchesKey(data, "q")) {
 						overlay.close();
 						done(undefined);
+						return;
 					}
+					// Everything else scrolls the live transcript (P1-3):
+					// j/k, ↓/↑, g/G, PgUp/PgDn and the `a` auto-scroll toggle.
+					overlay.handleInput(data);
 				},
 				invalidate() {
 					/* overlay polls */

package/src/extension/team-tool/handle-settings.ts

@@ -245,11 +245,19 @@ const KNOWN_KEYS = new Set([
 	// ui
 	"ui.widgetPlacement",
 	"ui.widgetMaxLines",
+	// M1-9/P1-8: inlinePanel is a schema key (config-schema.ts
+	// PiTeamsUiConfigSchema) and ui.autoCloseDashboardMs is parsed by
+	// parseUiConfig — keep this list mirroring the schema's ui block so
+	// `team-settings schema` lists what the schema actually accepts.
+	// (ui.widgetRowStyle was REMOVED 2026-09-16: the RAIL dock renders one
+	// layout; the key no longer has any reader.)
+	"ui.inlinePanel",
 	"ui.dashboardPlacement",
 	"ui.dashboardWidth",
 	"ui.dashboardLiveRefreshMs",
 	"ui.autoOpenDashboard",
 	"ui.autoOpenDashboardForForegroundRuns",
+	"ui.autoCloseDashboardMs",
 	"ui.showModel",
 	"ui.showTokens",
 	"ui.showTools",
@@ -440,9 +448,13 @@ export function handleSettings(params: { config?: Record<string, unknown> }, ctx
 		const key = args.slice(4).trim();
 		if (!key) return result("Usage: team-settings get <key>\nUse 'team-settings schema' to see all known keys.", { ...ERR }, true);
 		const value = getNested(effective, key);
-		// Try to provide helpful note for unknown keys
+		// Try to provide helpful note for unknown keys.
+		// M1-9/P1-8: `ui.*` is exempt exactly like the `set` path below (:497) —
+		// every ui.* key is accepted by the schema's ui block, so `get
+		// ui.<key>` must not answer "(unknown key — may not take
+		// effect)" for a key the config layer actually honours.
 		let note = "";
-		if (!KNOWN_KEYS.has(key) && !key.startsWith("agents.overrides.")) {
+		if (!KNOWN_KEYS.has(key) && !key.startsWith("agents.overrides.") && !key.startsWith("ui.")) {
 			const suggestion = suggestConfigKey(key, KNOWN_SORTED);
 			if (suggestion) note = `\n(did you mean '${suggestion}'?)`;
 			else note = "\n(unknown key — may not take effect)";

package/src/runtime/task-display.ts

@@ -47,6 +47,6 @@ export function formatTaskGraphLines(tasks: TeamTaskState[]): string[] {
 								? "⚠"
 								: "◦";
 		const wait = waitingReason(task, tasks);
-		return `- ${icon} ${task.id} [${task.status}] ${task.role}->${task.agent}${wait && wait !== "ready" ? ` (${wait})` : ""}`;
+		return `- ${icon} ${task.id} [${task.status}] ${task.role}▸${task.agent}${wait && wait !== "ready" ? ` (${wait})` : ""}`;
 	});
 }

package/src/schema/config-schema.ts

@@ -298,6 +298,10 @@ export const PiTeamsUiConfigSchema = Type.Object(
 	{
 		widgetPlacement: Type.Optional(Type.Union([Type.Literal("aboveEditor"), Type.Literal("belowEditor"), Type.Literal("bottom")])),
 		widgetMaxLines: Type.Optional(Type.Integer({ minimum: 1, maximum: 50 })),
+		/** Inline panel (editor-wrapper agent rows). M1-9/P1-8: parsed + read
+		 *  (src/ui/inline-panel/index.ts) + defaulted (true), but absent from this
+		 *  schema → same unknown-key warning. */
+		inlinePanel: Type.Optional(Type.Boolean()),
 		powerbar: Type.Optional(Type.Boolean()),
 		dashboardPlacement: Type.Optional(Type.Union([Type.Literal("center"), Type.Literal("right")])),
 		dashboardWidth: Type.Optional(Type.Integer({ minimum: 32, maximum: 120 })),

package/src/ui/adaptive-card.ts

@@ -0,0 +1,65 @@
+/**
+ * AdaptiveCard — a width-deferred card component (R2, 2026-09-16).
+ *
+ * Problem it fixes: pi-crew's tool-renderer cards used to be BUILT as a
+ * pre-formatted string at a guessed width (`ctx.width || process.stdout.columns
+ * || 116`) and handed to `new Text(...)`. Pi's ToolRenderContext carries NO
+ * width field — neither the TUI nor export-html pass one — so the guess could
+ * never match the real render column. `Text.render(width)` WRAPS lines wider
+ * than the column, which tore the box frame apart (top border split mid-line,
+ * right border vanished). This hit HTML export hardest: export renders every
+ * card at width=100 while a non-TTY export process builds at the 116 fallback.
+ *
+ * Design: build the frame at RENDER time, at the width the caller actually
+ * provides. The card receives a `builder(width) => string`; `render(width)`
+ * invokes it and delegates line-wrapping/padding to a zero-padding `Text`.
+ * Results are cached per width (mirroring Text's own cache) so repeated
+ * renders of an unchanged card cost nothing.
+ *
+ * Fail-visible: a builder exception surfaces as a red `✖ card render error`
+ * line instead of propagating into the TUI render loop (which has no per-
+ * component catch). Construction-time errors in the ToolRenderer wrappers
+ * keep their own catch — this is the third and final layer.
+ */
+
+import { Text } from "@earendil-works/pi-tui";
+import type { CrewComponent } from "./component.ts";
+
+export class AdaptiveCard implements CrewComponent {
+	#builder: (width: number) => string;
+	#errorStyle: (text: string) => string;
+	#text = new Text("", 0, 0);
+	#cachedWidth: number | undefined;
+	#cachedLines: string[] | null = null;
+
+	/**
+	 * @param builder produces the full card text (frame included) for a width.
+	 *   Must keep every line within `width` visual columns — the same contract
+	 *   the old fixed-width builders already obeyed for their baked width.
+	 * @param errorStyle theme.fg("error", …) adapter for the fail-visible line.
+	 */
+	constructor(builder: (width: number) => string, errorStyle: (text: string) => string = (t) => t) {
+		this.#builder = builder;
+		this.#errorStyle = errorStyle;
+	}
+
+	invalidate(): void {
+		this.#cachedLines = null;
+		this.#cachedWidth = undefined;
+	}
+
+	render(width: number): string[] {
+		if (this.#cachedLines !== null && this.#cachedWidth === width) return this.#cachedLines;
+		let text: string;
+		try {
+			text = this.#builder(width);
+		} catch (e) {
+			const msg = e instanceof Error ? e.message : String(e);
+			text = this.#errorStyle(`✖ card render error: ${msg.slice(0, 60)}`);
+		}
+		this.#text.setText(text);
+		this.#cachedLines = this.#text.render(width);
+		this.#cachedWidth = width;
+		return this.#cachedLines;
+	}
+}