pi-crew 0.1.46 → 0.1.49

package/src/runtime/async-marker.ts

@@ -1,26 +1,26 @@
-import * as fs from "node:fs";
-import * as path from "node:path";
-import { atomicWriteJson } from "../state/atomic-write.ts";
-import type { TeamRunManifest } from "../state/types.ts";
-
-export interface AsyncStartMarker {
-	pid: number;
-	startedAt: string;
-}
-
-export function asyncStartMarkerPath(manifest: Pick<TeamRunManifest, "stateRoot">): string {
-	return path.join(manifest.stateRoot, "async.pid");
-}
-
-export function writeAsyncStartMarker(manifest: Pick<TeamRunManifest, "stateRoot">, marker: AsyncStartMarker): void {
-	atomicWriteJson(asyncStartMarkerPath(manifest), marker);
-}
-
-export function hasAsyncStartMarker(manifest: Pick<TeamRunManifest, "stateRoot">): boolean {
-	try {
-		const raw = JSON.parse(fs.readFileSync(asyncStartMarkerPath(manifest), "utf-8")) as Partial<AsyncStartMarker>;
-		return typeof raw.pid === "number" && Number.isInteger(raw.pid) && raw.pid > 0 && typeof raw.startedAt === "string" && raw.startedAt.length > 0;
-	} catch {
-		return false;
-	}
-}
+import * as fs from "node:fs";
+import * as path from "node:path";
+import { atomicWriteJson } from "../state/atomic-write.ts";
+import type { TeamRunManifest } from "../state/types.ts";
+
+export interface AsyncStartMarker {
+	pid: number;
+	startedAt: string;
+}
+
+export function asyncStartMarkerPath(manifest: Pick<TeamRunManifest, "stateRoot">): string {
+	return path.join(manifest.stateRoot, "async.pid");
+}
+
+export function writeAsyncStartMarker(manifest: Pick<TeamRunManifest, "stateRoot">, marker: AsyncStartMarker): void {
+	atomicWriteJson(asyncStartMarkerPath(manifest), marker);
+}
+
+export function hasAsyncStartMarker(manifest: Pick<TeamRunManifest, "stateRoot">): boolean {
+	try {
+		const raw = JSON.parse(fs.readFileSync(asyncStartMarkerPath(manifest), "utf-8")) as Partial<AsyncStartMarker>;
+		return typeof raw.pid === "number" && Number.isInteger(raw.pid) && raw.pid > 0 && typeof raw.startedAt === "string" && raw.startedAt.length > 0;
+	} catch {
+		return false;
+	}
+}

package/src/runtime/async-runner.ts

@@ -6,6 +6,7 @@ import { fileURLToPath, pathToFileURL } from "node:url";
 import { appendEvent } from "../state/event-log.ts";
 import type { TeamRunManifest } from "../state/types.ts";
 
+
 export type FileExists = (filePath: string) => boolean;
 
 const requireFromHere = createRequire(import.meta.url);
@@ -49,7 +50,7 @@ export function buildBackgroundSpawnOptions(manifest: TeamRunManifest, logFd: nu
 		cwd: manifest.cwd,
 		detached: true,
 		stdio: ["ignore", logFd, logFd],
-		env: { ...process.env },
+		env: { ...process.env, PI_CREW_PARENT_PID: String(process.pid) },
 		windowsHide: true,
 	};
 }
@@ -70,6 +71,7 @@ export function spawnBackgroundTeamRun(manifest: TeamRunManifest): SpawnBackgrou
 		fs.appendFileSync(logPath, `[pi-crew] background loader=${command.loader}\n`, "utf-8");
 		const child = spawn(process.execPath, command.args, buildBackgroundSpawnOptions(manifest, logFd));
 		child.unref();
+
 		return { pid: child.pid, logPath };
 	} finally {
 		fs.closeSync(logFd);

package/src/runtime/attention-events.ts

@@ -1,28 +1,28 @@
-import { appendEvent, readEvents } from "../state/event-log.ts";
-import type { CrewAttentionEventData, TeamRunManifest } from "../state/types.ts";
-
-export interface AppendTaskAttentionInput {
-	manifest: TeamRunManifest;
-	taskId?: string;
-	message: string;
-	data: CrewAttentionEventData;
-}
-
-export function appendTaskAttentionEvent(input: AppendTaskAttentionInput): boolean {
-	const recent = readEvents(input.manifest.eventsPath).slice(-200);
-	const dedupKey = `${input.taskId ?? ""}:${input.data.reason}:${input.data.activityState}`;
-	const duplicate = recent.some(
-		(event) =>
-			event.type === "task.attention" &&
-			`${event.taskId ?? ""}:${event.data?.reason ?? ""}:${event.data?.activityState ?? ""}` === dedupKey,
-	);
-	if (duplicate) return false;
-	appendEvent(input.manifest.eventsPath, {
-		type: "task.attention",
-		runId: input.manifest.runId,
-		taskId: input.taskId,
-		message: input.message,
-		data: { ...input.data },
-	});
-	return true;
-}
+import { appendEvent, readEvents } from "../state/event-log.ts";
+import type { CrewAttentionEventData, TeamRunManifest } from "../state/types.ts";
+
+export interface AppendTaskAttentionInput {
+	manifest: TeamRunManifest;
+	taskId?: string;
+	message: string;
+	data: CrewAttentionEventData;
+}
+
+export function appendTaskAttentionEvent(input: AppendTaskAttentionInput): boolean {
+	const recent = readEvents(input.manifest.eventsPath).slice(-200);
+	const dedupKey = `${input.taskId ?? ""}:${input.data.reason}:${input.data.activityState}`;
+	const duplicate = recent.some(
+		(event) =>
+			event.type === "task.attention" &&
+			`${event.taskId ?? ""}:${event.data?.reason ?? ""}:${event.data?.activityState ?? ""}` === dedupKey,
+	);
+	if (duplicate) return false;
+	appendEvent(input.manifest.eventsPath, {
+		type: "task.attention",
+		runId: input.manifest.runId,
+		taskId: input.taskId,
+		message: input.message,
+		data: { ...input.data },
+	});
+	return true;
+}

package/src/runtime/background-runner.ts

@@ -9,6 +9,16 @@ import { resolveCrewRuntime, runtimeResolutionState } from "./runtime-resolver.t
 import { directTeamAndWorkflowFromRun } from "./direct-run.ts";
 import { expandParallelResearchWorkflow } from "./parallel-research.ts";
 import { writeAsyncStartMarker } from "./async-marker.ts";
+import { startParentGuard, stopParentGuard } from "./parent-guard.ts";
+
+/**
+ * Remove macOS malloc-stack-logging vars that get inherited by child shells.
+ * Without this, every subprocess prints "MallocStackLogging: can't turn off..." to stderr.
+ */
+function scrubProcessEnv(): void {
+	delete process.env.MallocStackLogging;
+	delete process.env.MallocStackLoggingNoCompact;
+}
 
 function argValue(name: string): string | undefined {
 	const index = process.argv.indexOf(name);
@@ -17,6 +27,13 @@ function argValue(name: string): string | undefined {
 }
 
 async function main(): Promise<void> {
+	// Scrub macOS malloc vars BEFORE anything else — must be clean for all child processes
+	scrubProcessEnv();
+
+	// Start parent guard FIRST — if parent is already dead, exit immediately
+	const parentPid = Number(process.env.PI_CREW_PARENT_PID);
+	if (parentPid > 0) startParentGuard(parentPid);
+
 	const cwd = argValue("--cwd");
 	const runId = argValue("--run-id");
 	if (!cwd || !runId) throw new Error("Usage: background-runner.ts --cwd <cwd> --run-id <runId>");
@@ -53,6 +70,8 @@ async function main(): Promise<void> {
 		manifest = updateRunStatus(manifest, "failed", message);
 		appendEvent(manifest.eventsPath, { type: "async.failed", runId: manifest.runId, message });
 		process.exitCode = 1;
+	} finally {
+		stopParentGuard();
 	}
 }
 

package/src/runtime/cancellation-token.ts

@@ -0,0 +1,89 @@
+import { CrewCancellationError, type CancellationReason, cancellationReasonFromUnknown } from "./cancellation.ts";
+
+export interface CancellationTokenState {
+	aborted: boolean;
+	reason?: CancellationReason;
+	lastHeartbeatAt?: string;
+	lastHeartbeatStage?: string;
+}
+
+export interface CancellationTokenOptions {
+	signal?: AbortSignal;
+	onHeartbeat?: (state: CancellationTokenState) => void;
+	now?: () => Date;
+}
+
+export class CancellationToken {
+	readonly #controller = new AbortController();
+	readonly #onHeartbeat?: (state: CancellationTokenState) => void;
+	readonly #now: () => Date;
+	#reason?: CancellationReason;
+	#lastHeartbeatAt?: string;
+	#lastHeartbeatStage?: string;
+
+	constructor(options: CancellationTokenOptions = {}) {
+		this.#onHeartbeat = options.onHeartbeat;
+		this.#now = options.now ?? (() => new Date());
+		if (options.signal?.aborted) this.abort(options.signal.reason);
+		else if (options.signal) options.signal.addEventListener("abort", () => this.abort(options.signal?.reason), { once: true });
+	}
+
+	get signal(): AbortSignal { return this.#controller.signal; }
+	get aborted(): boolean { return this.#controller.signal.aborted; }
+	get reason(): CancellationReason | undefined { return this.#reason; }
+	get lastHeartbeatAt(): string | undefined { return this.#lastHeartbeatAt; }
+	get lastHeartbeatStage(): string | undefined { return this.#lastHeartbeatStage; }
+
+	heartbeat(stage?: string): CancellationTokenState {
+		this.throwIfCancelled();
+		this.#lastHeartbeatAt = this.#now().toISOString();
+		this.#lastHeartbeatStage = stage;
+		const state = this.state();
+		this.#onHeartbeat?.(state);
+		return state;
+	}
+
+	throwIfCancelled(): void {
+		if (this.aborted) throw new CrewCancellationError(this.#reason ?? cancellationReasonFromUnknown(this.#controller.signal.reason));
+	}
+
+	abort(reason?: unknown): void {
+		if (this.aborted) return;
+		this.#reason = cancellationReasonFromUnknown(reason);
+		this.#controller.abort(this.#reason);
+	}
+
+	wait(ms: number): Promise<void> {
+		this.throwIfCancelled();
+		if (ms <= 0) return Promise.resolve();
+		return new Promise((resolve, reject) => {
+			let timeout: NodeJS.Timeout | undefined;
+			const cleanup = (): void => {
+				if (timeout) clearTimeout(timeout);
+				this.signal.removeEventListener("abort", onAbort);
+			};
+			const onAbort = (): void => {
+				cleanup();
+				reject(new CrewCancellationError(this.#reason ?? cancellationReasonFromUnknown(this.signal.reason)));
+			};
+			timeout = setTimeout(() => {
+				cleanup();
+				resolve();
+			}, ms);
+			this.signal.addEventListener("abort", onAbort, { once: true });
+		});
+	}
+
+	state(): CancellationTokenState {
+		return {
+			aborted: this.aborted,
+			...(this.#reason ? { reason: this.#reason } : {}),
+			...(this.#lastHeartbeatAt ? { lastHeartbeatAt: this.#lastHeartbeatAt } : {}),
+			...(this.#lastHeartbeatStage ? { lastHeartbeatStage: this.#lastHeartbeatStage } : {}),
+		};
+	}
+}
+
+export function createCancellationToken(options: CancellationTokenOptions = {}): CancellationToken {
+	return new CancellationToken(options);
+}

package/src/runtime/cancellation.ts

@@ -1,51 +1,61 @@
-export type CancellationReasonCode = "caller_cancelled" | "leader_interrupted" | "provider_timeout" | "worker_timeout" | "tool_timeout" | "shutdown" | "unknown";
-
-export interface CancellationReason {
-	code: CancellationReasonCode;
-	message: string;
-	cause?: unknown;
-}
-
-const KNOWN_CODES: ReadonlySet<string> = new Set(["caller_cancelled", "leader_interrupted", "provider_timeout", "worker_timeout", "tool_timeout", "shutdown", "unknown"]);
-
-export class CrewCancellationError extends Error {
-	readonly reason: CancellationReason;
-
-	constructor(reason: CancellationReason) {
-		super(reason.message);
-		this.name = "CrewCancellationError";
-		this.reason = reason;
-	}
-}
-
-function reasonFromString(value: string): CancellationReason {
-	const trimmed = value.trim();
-	if (KNOWN_CODES.has(trimmed)) return { code: trimmed as CancellationReasonCode, message: `Cancelled: ${trimmed}` };
-	return { code: "caller_cancelled", message: trimmed || "Cancelled by caller." };
-}
-
-export function cancellationReasonFromUnknown(value: unknown): CancellationReason {
-	if (value instanceof CrewCancellationError) return value.reason;
-	if (value instanceof Error) return { code: "caller_cancelled", message: value.message || "Cancelled by caller.", cause: value };
-	if (typeof value === "string") return reasonFromString(value);
-	if (value && typeof value === "object" && !Array.isArray(value)) {
-		const record = value as { code?: unknown; reason?: unknown; message?: unknown; cause?: unknown };
-		const rawCode = typeof record.code === "string" ? record.code : typeof record.reason === "string" ? record.reason : undefined;
-		const code = rawCode && KNOWN_CODES.has(rawCode) ? rawCode as CancellationReasonCode : "caller_cancelled";
-		const message = typeof record.message === "string" && record.message.trim() ? record.message.trim() : `Cancelled: ${code}`;
-		return { code, message, cause: record.cause ?? value };
-	}
-	return { code: "caller_cancelled", message: "Cancelled by caller." };
-}
-
-export function cancellationReasonFromSignal(signal: AbortSignal | undefined): CancellationReason {
-	return cancellationReasonFromUnknown(signal?.reason);
-}
-
-export function cancellationErrorFromSignal(signal: AbortSignal | undefined): CrewCancellationError {
-	return new CrewCancellationError(cancellationReasonFromSignal(signal));
-}
-
-export function throwIfCancelled(signal: AbortSignal | undefined): void {
-	if (signal?.aborted) throw cancellationErrorFromSignal(signal);
-}
+import type { OperationTerminalEvidence } from "../state/types.ts";
+
+export type CancellationReasonCode = "caller_cancelled" | "leader_interrupted" | "provider_timeout" | "worker_timeout" | "tool_timeout" | "shutdown" | "unknown";
+
+export interface CancellationReason {
+	code: CancellationReasonCode;
+	message: string;
+	cause?: unknown;
+}
+
+export function buildSyntheticTerminalEvidence(
+	operation: "worker" | "tool" | "model",
+	reason: CancellationReason,
+	startedAt?: string,
+): OperationTerminalEvidence {
+	return { operation, status: "cancelled", startedAt, finishedAt: new Date().toISOString(), reason };
+}
+
+const KNOWN_CODES: ReadonlySet<string> = new Set(["caller_cancelled", "leader_interrupted", "provider_timeout", "worker_timeout", "tool_timeout", "shutdown", "unknown"]);
+
+export class CrewCancellationError extends Error {
+	readonly reason: CancellationReason;
+
+	constructor(reason: CancellationReason) {
+		super(reason.message);
+		this.name = "CrewCancellationError";
+		this.reason = reason;
+	}
+}
+
+function reasonFromString(value: string): CancellationReason {
+	const trimmed = value.trim();
+	if (KNOWN_CODES.has(trimmed)) return { code: trimmed as CancellationReasonCode, message: `Cancelled: ${trimmed}` };
+	return { code: "caller_cancelled", message: trimmed || "Cancelled by caller." };
+}
+
+export function cancellationReasonFromUnknown(value: unknown): CancellationReason {
+	if (value instanceof CrewCancellationError) return value.reason;
+	if (value instanceof Error) return { code: "caller_cancelled", message: value.message || "Cancelled by caller.", cause: value };
+	if (typeof value === "string") return reasonFromString(value);
+	if (value && typeof value === "object" && !Array.isArray(value)) {
+		const record = value as { code?: unknown; reason?: unknown; message?: unknown; cause?: unknown };
+		const rawCode = typeof record.code === "string" ? record.code : typeof record.reason === "string" ? record.reason : undefined;
+		const code = rawCode && KNOWN_CODES.has(rawCode) ? rawCode as CancellationReasonCode : "caller_cancelled";
+		const message = typeof record.message === "string" && record.message.trim() ? record.message.trim() : `Cancelled: ${code}`;
+		return { code, message, cause: record.cause ?? value };
+	}
+	return { code: "caller_cancelled", message: "Cancelled by caller." };
+}
+
+export function cancellationReasonFromSignal(signal: AbortSignal | undefined): CancellationReason {
+	return cancellationReasonFromUnknown(signal?.reason);
+}
+
+export function cancellationErrorFromSignal(signal: AbortSignal | undefined): CrewCancellationError {
+	return new CrewCancellationError(cancellationReasonFromSignal(signal));
+}
+
+export function throwIfCancelled(signal: AbortSignal | undefined): void {
+	if (signal?.aborted) throw cancellationErrorFromSignal(signal);
+}

package/src/runtime/capability-inventory.ts

@@ -0,0 +1,116 @@
+import type { AgentConfig, ResourceSource } from "../agents/agent-config.ts";
+import { discoverAgents } from "../agents/discover-agents.ts";
+import { discoverTeams } from "../teams/discover-teams.ts";
+import { discoverWorkflows } from "../workflows/discover-workflows.ts";
+import { discoverSkills } from "../skills/discover-skills.ts";
+import type { PiTeamsConfig } from "../config/config.ts";
+
+export type CapabilityKind = "team" | "workflow" | "agent" | "skill" | "tool" | "runtime";
+export type CapabilitySource = "builtin" | "project" | "user" | "package" | "git";
+export type CapabilityState = "active" | "disabled" | "shadowed" | "missing";
+
+export interface CapabilityItem {
+	id: string;
+	kind: CapabilityKind;
+	name: string;
+	description: string;
+	source: CapabilitySource;
+	path?: string;
+	state: CapabilityState;
+	disabledReason?: string;
+	shadowedBy?: string;
+}
+
+function normalizeAgents(agents: AgentConfig[], source: CapabilitySource, disabledIds: Set<string>): CapabilityItem[] {
+	return agents.map((agent) => {
+		const id = `agent:${agent.name}`;
+		const configDisabled = disabledIds.has(id);
+		const agentDisabled = agent.disabled || configDisabled;
+		return {
+			id,
+			kind: "agent" as const,
+			name: agent.name,
+			description: agent.description,
+			source,
+			path: agent.filePath,
+			state: agentDisabled ? "disabled" : "active",
+			disabledReason: configDisabled ? "disabled by policy" : agent.disabled ? "disabled in config" : undefined,
+		};
+	});
+}
+
+function normalizeSkills(cwd: string, disabledIds: Set<string>): CapabilityItem[] {
+	const skills = discoverSkills(cwd);
+	return skills.map((skill) => {
+		const id = `skill:${skill.name}`;
+		const configDisabled = disabledIds.has(id);
+		return {
+			id,
+			kind: "skill" as const,
+			name: skill.name,
+			description: skill.description,
+			source: skill.source as CapabilitySource,
+			path: skill.path,
+			state: configDisabled ? "disabled" : "active",
+			disabledReason: configDisabled ? "disabled by policy" : undefined,
+		};
+	});
+}
+
+function normalizeTeams(cwd: string, disabledIds: Set<string>): CapabilityItem[] {
+	const result = discoverTeams(cwd);
+	return [...result.builtin, ...result.user, ...result.project].map((team) => {
+		const id = `team:${team.name}`;
+		const configDisabled = disabledIds.has(id);
+		return {
+			id,
+			kind: "team" as const,
+			name: team.name,
+			description: team.description,
+			source: team.source as CapabilitySource,
+			path: team.filePath,
+			state: configDisabled ? "disabled" : "active",
+			disabledReason: configDisabled ? "disabled by policy" : undefined,
+		};
+	});
+}
+
+function normalizeWorkflows(cwd: string, disabledIds: Set<string>): CapabilityItem[] {
+	const result = discoverWorkflows(cwd);
+	return [...result.builtin, ...result.user, ...result.project].map((workflow) => {
+		const id = `workflow:${workflow.name}`;
+		const configDisabled = disabledIds.has(id);
+		return {
+			id,
+			kind: "workflow" as const,
+			name: workflow.name,
+			description: workflow.description,
+			source: workflow.source as CapabilitySource,
+			path: workflow.filePath,
+			state: configDisabled ? "disabled" : "active",
+			disabledReason: configDisabled ? "disabled by policy" : undefined,
+		};
+	});
+}
+
+export function buildCapabilityInventory(cwd: string, config?: PiTeamsConfig): CapabilityItem[] {
+	const disabledIds = new Set<string>(config?.policy?.disabledCapabilities ?? []);
+	const agents = discoverAgents(cwd);
+	const items = [
+		...normalizeTeams(cwd, disabledIds),
+		...normalizeWorkflows(cwd, disabledIds),
+		...normalizeAgents([...agents.builtin, ...agents.user, ...agents.project], "builtin", disabledIds),
+		...normalizeSkills(cwd, disabledIds),
+	];
+
+	// Mark shadowed resources: project/user items with same kind:name as a builtin
+	const builtinNames = new Set(items.filter((item) => item.source === "builtin" || item.source === "package").map((item) => `${item.kind}:${item.name}`));
+	for (const item of items) {
+		if (item.source !== "builtin" && item.source !== "package" && builtinNames.has(`${item.kind}:${item.name}`)) {
+			item.state = "shadowed";
+			item.shadowedBy = `builtin:${item.kind}:${item.name}`;
+		}
+	}
+
+	return items.sort((a, b) => a.id.localeCompare(b.id));
+}

package/src/runtime/child-pi.ts

@@ -112,7 +112,7 @@ export interface ChildPiRunResult {
 export function buildChildPiSpawnOptions(cwd: string, env: NodeJS.ProcessEnv): SpawnOptions {
 	return {
 		cwd,
-		env,
+		env: { ...env, PI_CREW_PARENT_PID: String(process.pid) },
 		stdio: ["ignore", "pipe", "pipe"],
 		detached: process.platform !== "win32",
 		windowsHide: true,
@@ -243,6 +243,7 @@ export class ChildPiLineObserver {
 	}
 }
 
+/** Mock-only path — real code path reuses a single observer. */
 function observeStdoutChunk(input: ChildPiRunInput, text: string): void {
 	const observer = new ChildPiLineObserver(input);
 	observer.observe(text);