pi-crew 0.1.41 → 0.1.44

package/src/observability/exporters/otlp-exporter.ts

@@ -11,6 +11,15 @@ export interface OTLPExporterOptions {
 }
 
 function pointValues(snapshot: MetricSnapshot): unknown[] {
+	if (snapshot.type === "histogram") {
+		return snapshot.values.map((value) => ({
+			attributes: Object.entries(value.labels).map(([key, item]) => ({ key, value: { stringValue: String(item) } })),
+			count: "count" in value ? value.count : undefined,
+			sum: "sum" in value ? value.sum : undefined,
+			bucketCounts: "counts" in value ? value.counts : undefined,
+			explicitBounds: "buckets" in value ? value.buckets : undefined,
+		}));
+	}
 	return snapshot.values.map((value) => ({ attributes: Object.entries(value.labels).map(([key, item]) => ({ key, value: { stringValue: String(item) } })), asDouble: "value" in value ? value.value : undefined, count: "count" in value ? value.count : undefined, sum: "sum" in value ? value.sum : undefined }));
 }
 
@@ -40,7 +49,7 @@ export class OTLPExporter implements MetricExporter {
 	start(): void {
 		this.dispose();
 		this.timer = setInterval(() => { void this.push(this.registry.snapshot()); }, this.opts.intervalMs ?? 60_000);
-		this.timer.unref?.();
+		this.timer.unref();
 	}
 
 	async push(snapshots: MetricSnapshot[]): Promise<void> {
@@ -49,7 +58,10 @@ export class OTLPExporter implements MetricExporter {
 			const controller = new AbortController();
 			const timer = setTimeout(() => controller.abort(), timeoutMs);
 			try {
-				await fetch(this.opts.endpoint, { method: "POST", headers: { "content-type": "application/json", ...(this.opts.headers ?? {}) }, body: JSON.stringify(convertToOTLP(snapshots)), signal: controller.signal });
+				const response = await fetch(this.opts.endpoint, { method: "POST", headers: { "content-type": "application/json", ...(this.opts.headers ?? {}) }, body: JSON.stringify(convertToOTLP(snapshots)), signal: controller.signal });
+				if (!response.ok) {
+					logInternalError("otlp-export-http", new Error(`HTTP ${response.status}: ${response.statusText}`), `endpoint=${this.opts.endpoint}`);
+				}
 			} finally {
 				clearTimeout(timer);
 			}

package/src/observability/exporters/prometheus-exporter.ts

@@ -1,7 +1,7 @@
 import type { HistogramPoint, MetricLabels, MetricPoint, MetricSnapshot } from "../metrics-primitives.ts";
 
 function prometheusName(name: string): string {
-	return name.replace(/\./g, "_");
+	return name.replace(/[^a-zA-Z0-9_:]/g, "_").replace(/^[0-9]/, "_$&");
 }
 
 function escapeLabel(value: string): string {
@@ -22,6 +22,13 @@ function isHistogramPoint(value: MetricPoint | HistogramPoint): value is Histogr
 	return "buckets" in value && "counts" in value;
 }
 
+function formatPrometheusValue(num: number): string {
+	if (Number.isNaN(num)) return "Nan";
+	if (num === Number.POSITIVE_INFINITY) return "+Inf";
+	if (num === Number.NEGATIVE_INFINITY) return "-Inf";
+	return String(num);
+}
+
 export function formatPrometheus(snapshots: MetricSnapshot[]): string {
 	const lines: string[] = [];
 	for (const snapshot of snapshots) {
@@ -39,7 +46,7 @@ export function formatPrometheus(snapshots: MetricSnapshot[]): string {
 				lines.push(`${name}_sum${labelsText(value.labels)} ${value.sum}`);
 				lines.push(`${name}_count${labelsText(value.labels)} ${value.count}`);
 			} else {
-				lines.push(`${name}${labelsText(value.labels)} ${value.value}`);
+				lines.push(`${name}${labelsText(value.labels)} ${formatPrometheusValue(value.value)}`);
 			}
 		}
 	}

package/src/observability/metric-registry.ts

@@ -35,21 +35,36 @@ export class MetricRegistry {
 
 	counter(name: string, description: string): Counter {
 		const existing = this.metrics.get(name);
-		if (existing instanceof Counter) return existing;
+		if (existing instanceof Counter) {
+			if (existing.description !== description) {
+				process.stderr.write(`[pi-crew] metric-registry: counter '${name}' description changed; using original: '${existing.description}'\n`);
+			}
+			return existing;
+		}
 		if (existing) throw new Error(`Metric '${name}' is not a counter.`);
 		return this.registerCounter(name, description);
 	}
 
 	gauge(name: string, description: string): Gauge {
 		const existing = this.metrics.get(name);
-		if (existing instanceof Gauge) return existing;
+		if (existing instanceof Gauge) {
+			if (existing.description !== description) {
+				process.stderr.write(`[pi-crew] metric-registry: gauge '${name}' description changed; using original: '${existing.description}'\n`);
+			}
+			return existing;
+		}
 		if (existing) throw new Error(`Metric '${name}' is not a gauge.`);
 		return this.registerGauge(name, description);
 	}
 
 	histogram(name: string, description: string, buckets?: number[]): Histogram {
 		const existing = this.metrics.get(name);
-		if (existing instanceof Histogram) return existing;
+		if (existing instanceof Histogram) {
+			if (existing.description !== description) {
+				process.stderr.write(`[pi-crew] metric-registry: histogram '${name}' description changed; using original: '${existing.description}'\n`);
+			}
+			return existing;
+		}
 		if (existing) throw new Error(`Metric '${name}' is not a histogram.`);
 		return this.registerHistogram(name, description, buckets);
 	}

package/src/observability/metric-retention.ts

@@ -10,6 +10,7 @@ export class TimeWindowedCounter {
 	private events: WindowEvent[] = [];
 	private readonly windowMs: number;
 	private readonly now: () => number;
+	private static readonly MAX_EVENTS = 100_000;
 
 	constructor(windowMs = 3_600_000, now: () => number = () => Date.now()) {
 		this.windowMs = windowMs;
@@ -18,14 +19,17 @@ export class TimeWindowedCounter {
 
 	inc(labels: MetricLabels = {}, delta = 1): void {
 		if (!Number.isFinite(delta)) return;
+		// Cap the event array to prevent unbounded memory growth.
+		if (this.events.length >= TimeWindowedCounter.MAX_EVENTS) this.prune();
 		this.events.push({ timestamp: this.now(), labels: { ...labels }, delta });
 		this.prune();
 	}
 
 	count(labels: MetricLabels = {}, durationMs = this.windowMs): number {
-		this.prune();
+		const now = this.now();
+		this.pruneAt(now);
 		const key = labelKey(labels);
-		const cutoff = this.now() - durationMs;
+		const cutoff = now - durationMs;
 		return this.events.filter((event) => event.timestamp >= cutoff && labelKey(event.labels) === key).reduce((sum, event) => sum + event.delta, 0);
 	}
 
@@ -40,7 +44,11 @@ export class TimeWindowedCounter {
 	}
 
 	private prune(): void {
-		const cutoff = this.now() - this.windowMs;
+		this.pruneAt(this.now());
+	}
+
+	private pruneAt(now: number): void {
+		const cutoff = now - this.windowMs;
 		this.events = this.events.filter((event) => event.timestamp >= cutoff);
 	}
 }

package/src/observability/metric-sink.ts

@@ -36,16 +36,21 @@ export function createMetricFileSink(opts: MetricFileSinkOptions): MetricSink {
 	const retentionDays = opts.retentionDays ?? 7;
 	const writeSnapshot = (snapshots: MetricSnapshot[]): void => {
 		try {
-			const date = new Date().toISOString().slice(0, 10);
+			const now = new Date();
+			const date = now.toISOString().slice(0, 10);
 			fs.mkdirSync(dir, { recursive: true });
 			rotateOldFiles(dir, retentionDays);
-			const redacted = redactSecrets(snapshots) as MetricSnapshot[];
-			fs.appendFileSync(path.join(dir, `${date}.jsonl`), `${JSON.stringify({ exportedAt: new Date().toISOString(), snapshots: redacted })}\n`, "utf-8");
+			const redacted = redactSecrets(snapshots);
+			if (!Array.isArray(redacted)) {
+				logInternalError("metric-sink.type", new Error("redactSecrets did not return an array"), `got=${typeof redacted}`);
+				return;
+			}
+			fs.appendFileSync(path.join(dir, `${date}.jsonl`), `${JSON.stringify({ exportedAt: now.toISOString(), snapshots: redacted as MetricSnapshot[] })}\n`, "utf-8");
 		} catch (error) {
 			logInternalError("metric-sink.write", error);
 		}
 	};
 	const timer = setInterval(() => writeSnapshot(opts.registry.snapshot()), opts.intervalMs ?? 60_000);
-	timer.unref?.();
+	timer.unref();
 	return { writeSnapshot, dispose: () => clearInterval(timer) };
 }

package/src/observability/metrics-primitives.ts

@@ -66,7 +66,7 @@ export class Counter extends Metric {
 	private values = new Map<string, StoredValue>();
 
 	inc(labels: MetricLabels = {}, delta = 1): void {
-		if (!Number.isFinite(delta)) return;
+		if (!Number.isFinite(delta) || delta < 0) return;
 		const key = labelKey(labels);
 		const current = this.values.get(key) ?? { labels: normalizeLabels(labels), value: 0 };
 		this.values.set(key, { labels: current.labels, value: current.value + delta });
@@ -116,12 +116,13 @@ export class Histogram extends Metric {
 	observe(labels: MetricLabels = {}, value: number): void {
 		if (!Number.isFinite(value)) return;
 		const key = labelKey(labels);
-		const current = this.observations.get(key) ?? { labels: normalizeLabels(labels), counts: new Array(this.buckets.length + 1).fill(0) as number[], sum: 0, count: 0 };
+		const existing = this.observations.get(key);
+		const current = existing ?? { labels: normalizeLabels(labels), counts: new Array(this.buckets.length + 1).fill(0) as number[], sum: 0, count: 0 };
 		const bucketIndex = this.buckets.findIndex((bucket) => value <= bucket);
 		current.counts[bucketIndex === -1 ? this.buckets.length : bucketIndex] = (current.counts[bucketIndex === -1 ? this.buckets.length : bucketIndex] ?? 0) + 1;
 		current.sum += value;
 		current.count += 1;
-		this.observations.set(key, current);
+		if (!existing) this.observations.set(key, current);
 	}
 
 	quantile(labels: MetricLabels = {}, q: number): number {

package/src/prompt/prompt-runtime.ts

@@ -1,68 +1,72 @@
-import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
-
-export const PI_TEAMS_INHERIT_PROJECT_CONTEXT_ENV = "PI_TEAMS_INHERIT_PROJECT_CONTEXT";
-export const PI_TEAMS_INHERIT_SKILLS_ENV = "PI_TEAMS_INHERIT_SKILLS";
-export const PI_CREW_INHERIT_PROJECT_CONTEXT_ENV = "PI_CREW_INHERIT_PROJECT_CONTEXT";
-export const PI_CREW_INHERIT_SKILLS_ENV = "PI_CREW_INHERIT_SKILLS";
-
-const PROJECT_CONTEXT_HEADER = "\n\n# Project Context\n\nProject-specific instructions and guidelines:\n\n";
-const SKILLS_HEADER = "\n\nThe following skills provide specialized instructions for specific tasks.";
-const DATE_HEADER = "\nCurrent date:";
-
-function readBooleanEnv(name: string): boolean | undefined {
-	const value = process.env[name];
-	if (value === undefined) return undefined;
-	return value !== "0";
-}
-
-function readBooleanEnvAny(...names: string[]): boolean | undefined {
-	for (const name of names) {
-		const value = readBooleanEnv(name);
-		if (value !== undefined) return value;
-	}
-	return undefined;
-}
-
-function findSectionEnd(prompt: string, startIndex: number, nextHeaders: string[]): number {
-	let endIndex = prompt.length;
-	for (const header of nextHeaders) {
-		const index = prompt.indexOf(header, startIndex);
-		if (index !== -1 && index < endIndex) endIndex = index;
-	}
-	return endIndex;
-}
-
-export function stripProjectContext(prompt: string): string {
-	const startIndex = prompt.indexOf(PROJECT_CONTEXT_HEADER);
-	if (startIndex === -1) return prompt;
-	const endIndex = findSectionEnd(prompt, startIndex + PROJECT_CONTEXT_HEADER.length, [SKILLS_HEADER, DATE_HEADER]);
-	return `${prompt.slice(0, startIndex)}${prompt.slice(endIndex)}`;
-}
-
-export function stripInheritedSkills(prompt: string): string {
-	const startIndex = prompt.indexOf(SKILLS_HEADER);
-	if (startIndex === -1) return prompt;
-	const endIndex = findSectionEnd(prompt, startIndex + SKILLS_HEADER.length, [DATE_HEADER]);
-	return `${prompt.slice(0, startIndex)}${prompt.slice(endIndex)}`;
-}
-
-export function rewriteTeamWorkerPrompt(prompt: string, options: { inheritProjectContext: boolean; inheritSkills: boolean }): string {
-	let rewritten = prompt;
-	if (!options.inheritProjectContext) rewritten = stripProjectContext(rewritten);
-	if (!options.inheritSkills) rewritten = stripInheritedSkills(rewritten);
-	return rewritten;
-}
-
-export default function registerPiTeamsPromptRuntime(pi: ExtensionAPI): void {
-	pi.on("before_agent_start", (event) => {
-		const inheritProjectContext = readBooleanEnvAny(PI_CREW_INHERIT_PROJECT_CONTEXT_ENV, PI_TEAMS_INHERIT_PROJECT_CONTEXT_ENV);
-		const inheritSkills = readBooleanEnvAny(PI_CREW_INHERIT_SKILLS_ENV, PI_TEAMS_INHERIT_SKILLS_ENV);
-		if (inheritProjectContext === undefined && inheritSkills === undefined) return;
-		const rewritten = rewriteTeamWorkerPrompt(event.systemPrompt, {
-			inheritProjectContext: inheritProjectContext ?? true,
-			inheritSkills: inheritSkills ?? true,
-		});
-		if (rewritten === event.systemPrompt) return;
-		return { systemPrompt: rewritten };
-	});
-}
+import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
+
+export const PI_TEAMS_INHERIT_PROJECT_CONTEXT_ENV = "PI_TEAMS_INHERIT_PROJECT_CONTEXT";
+export const PI_TEAMS_INHERIT_SKILLS_ENV = "PI_TEAMS_INHERIT_SKILLS";
+export const PI_CREW_INHERIT_PROJECT_CONTEXT_ENV = "PI_CREW_INHERIT_PROJECT_CONTEXT";
+export const PI_CREW_INHERIT_SKILLS_ENV = "PI_CREW_INHERIT_SKILLS";
+
+const PROJECT_CONTEXT_HEADER = "\n\n# Project Context\n\nProject-specific instructions and guidelines:\n\n";
+const SKILLS_HEADER = "\n\nThe following skills provide specialized instructions for specific tasks.";
+const DATE_HEADER = "\nCurrent date:";
+
+function readBooleanEnv(name: string): boolean | undefined {
+	const value = process.env[name];
+	if (value === undefined) return undefined;
+	const normalized = value.trim().toLowerCase();
+	if (normalized === "1" || normalized === "true" || normalized === "yes") return true;
+	if (normalized === "0" || normalized === "false" || normalized === "no") return false;
+	// Ambiguous value — treat as undefined so callers apply their default.
+	return undefined;
+}
+
+function readBooleanEnvAny(...names: string[]): boolean | undefined {
+	for (const name of names) {
+		const value = readBooleanEnv(name);
+		if (value !== undefined) return value;
+	}
+	return undefined;
+}
+
+function findSectionEnd(prompt: string, startIndex: number, nextHeaders: string[]): number {
+	let endIndex = prompt.length;
+	for (const header of nextHeaders) {
+		const index = prompt.indexOf(header, startIndex);
+		if (index !== -1 && index < endIndex) endIndex = index;
+	}
+	return endIndex;
+}
+
+export function stripProjectContext(prompt: string): string {
+	const startIndex = prompt.indexOf(PROJECT_CONTEXT_HEADER);
+	if (startIndex === -1) return prompt;
+	const endIndex = findSectionEnd(prompt, startIndex + PROJECT_CONTEXT_HEADER.length, [SKILLS_HEADER, DATE_HEADER]);
+	return `${prompt.slice(0, startIndex)}${prompt.slice(endIndex)}`;
+}
+
+export function stripInheritedSkills(prompt: string): string {
+	const startIndex = prompt.indexOf(SKILLS_HEADER);
+	if (startIndex === -1) return prompt;
+	const endIndex = findSectionEnd(prompt, startIndex + SKILLS_HEADER.length, [DATE_HEADER]);
+	return `${prompt.slice(0, startIndex)}${prompt.slice(endIndex)}`;
+}
+
+export function rewriteTeamWorkerPrompt(prompt: string, options: { inheritProjectContext: boolean; inheritSkills: boolean }): string {
+	let rewritten = prompt;
+	if (!options.inheritProjectContext) rewritten = stripProjectContext(rewritten);
+	if (!options.inheritSkills) rewritten = stripInheritedSkills(rewritten);
+	return rewritten;
+}
+
+export default function registerPiTeamsPromptRuntime(pi: ExtensionAPI): void {
+	pi.on("before_agent_start", (event) => {
+		const inheritProjectContext = readBooleanEnvAny(PI_CREW_INHERIT_PROJECT_CONTEXT_ENV, PI_TEAMS_INHERIT_PROJECT_CONTEXT_ENV);
+		const inheritSkills = readBooleanEnvAny(PI_CREW_INHERIT_SKILLS_ENV, PI_TEAMS_INHERIT_SKILLS_ENV);
+		if (inheritProjectContext === undefined && inheritSkills === undefined) return;
+		const rewritten = rewriteTeamWorkerPrompt(event.systemPrompt, {
+			inheritProjectContext: inheritProjectContext ?? true,
+			inheritSkills: inheritSkills ?? true,
+		});
+		if (rewritten === event.systemPrompt) return;
+		return { systemPrompt: rewritten };
+	});
+}

package/src/runtime/agent-control.ts

@@ -1,63 +1,63 @@
-import type { PiTeamsConfig } from "../config/config.ts";
-import type { TeamRunManifest } from "../state/types.ts";
-import { appendTaskAttentionEvent } from "./attention-events.ts";
-import type { CrewAgentRecord } from "./crew-agent-runtime.ts";
-import { upsertCrewAgent } from "./crew-agent-records.ts";
-
-export interface CrewControlConfig {
-	enabled: boolean;
-	needsAttentionAfterMs: number;
-}
-
-const DEFAULT_NEEDS_ATTENTION_MS = 60_000;
-
-function positiveInt(value: unknown): number | undefined {
-	return typeof value === "number" && Number.isInteger(value) && value > 0 ? value : undefined;
-}
-
-export function resolveCrewControlConfig(config: PiTeamsConfig | undefined): CrewControlConfig {
-	const raw = config as PiTeamsConfig & { control?: { enabled?: unknown; needsAttentionAfterMs?: unknown } } | undefined;
-	return {
-		enabled: raw?.control?.enabled === false ? false : true,
-		needsAttentionAfterMs: positiveInt(raw?.control?.needsAttentionAfterMs) ?? DEFAULT_NEEDS_ATTENTION_MS,
-	};
-}
-
-export function activityAgeMs(agent: CrewAgentRecord, now = Date.now()): number | undefined {
-	const timestamp = agent.progress?.lastActivityAt ?? agent.startedAt;
-	if (!timestamp) return undefined;
-	const ms = now - new Date(timestamp).getTime();
-	return Number.isFinite(ms) ? Math.max(0, ms) : undefined;
-}
-
-export function formatActivityAge(agent: CrewAgentRecord, now = Date.now()): string | undefined {
-	const age = activityAgeMs(agent, now);
-	if (age === undefined) return undefined;
-	if (age < 1000) return "active now";
-	const seconds = Math.floor(age / 1000);
-	if (seconds < 60) return agent.progress?.activityState === "needs_attention" ? `no activity for ${seconds}s` : `active ${seconds}s ago`;
-	const minutes = Math.floor(seconds / 60);
-	return agent.progress?.activityState === "needs_attention" ? `no activity for ${minutes}m` : `active ${minutes}m ago`;
-}
-
-export function applyAttentionState(manifest: TeamRunManifest, agent: CrewAgentRecord, config: CrewControlConfig, now = Date.now()): CrewAgentRecord {
-	if (!config.enabled || agent.status !== "running") return agent;
-	const age = activityAgeMs(agent, now);
-	if (age === undefined || age <= config.needsAttentionAfterMs) return agent;
-	if (agent.progress?.activityState === "needs_attention") return agent;
-	const updated: CrewAgentRecord = {
-		...agent,
-		progress: {
-			...(agent.progress ?? { recentTools: [], recentOutput: [], toolCount: agent.toolUses ?? 0 }),
-			activityState: "needs_attention",
-		},
-	};
-	upsertCrewAgent(manifest, updated);
-	appendTaskAttentionEvent({
-		manifest,
-		taskId: agent.taskId,
-		message: `${agent.agent} needs attention (no observed activity for ${Math.floor(age / 1000)}s).`,
-		data: { activityState: "needs_attention", reason: "idle", elapsedMs: age, taskId: agent.taskId, agentName: agent.agent, suggestedAction: "Check worker status, wait, steer, or cancel if needed." },
-	});
-	return updated;
-}
+import type { PiTeamsConfig } from "../config/config.ts";
+import type { TeamRunManifest } from "../state/types.ts";
+import { appendTaskAttentionEvent } from "./attention-events.ts";
+import type { CrewAgentRecord } from "./crew-agent-runtime.ts";
+import { upsertCrewAgent } from "./crew-agent-records.ts";
+
+export interface CrewControlConfig {
+	enabled: boolean;
+	needsAttentionAfterMs: number;
+}
+
+const DEFAULT_NEEDS_ATTENTION_MS = 60_000;
+
+function positiveInt(value: unknown): number | undefined {
+	return typeof value === "number" && Number.isInteger(value) && value > 0 ? value : undefined;
+}
+
+export function resolveCrewControlConfig(config: PiTeamsConfig | undefined): CrewControlConfig {
+	const raw = config as PiTeamsConfig & { control?: { enabled?: unknown; needsAttentionAfterMs?: unknown } } | undefined;
+	return {
+		enabled: raw?.control?.enabled === false ? false : true,
+		needsAttentionAfterMs: positiveInt(raw?.control?.needsAttentionAfterMs) ?? DEFAULT_NEEDS_ATTENTION_MS,
+	};
+}
+
+export function activityAgeMs(agent: CrewAgentRecord, now = Date.now()): number | undefined {
+	const timestamp = agent.progress?.lastActivityAt ?? agent.startedAt;
+	if (!timestamp) return undefined;
+	const ms = now - new Date(timestamp).getTime();
+	return Number.isFinite(ms) ? Math.max(0, ms) : undefined;
+}
+
+export function formatActivityAge(agent: CrewAgentRecord, now = Date.now()): string | undefined {
+	const age = activityAgeMs(agent, now);
+	if (age === undefined) return undefined;
+	if (age < 1000) return "active now";
+	const seconds = Math.floor(age / 1000);
+	if (seconds < 60) return agent.progress?.activityState === "needs_attention" ? `no activity for ${seconds}s` : `active ${seconds}s ago`;
+	const minutes = Math.floor(seconds / 60);
+	return agent.progress?.activityState === "needs_attention" ? `no activity for ${minutes}m` : `active ${minutes}m ago`;
+}
+
+export function applyAttentionState(manifest: TeamRunManifest, agent: CrewAgentRecord, config: CrewControlConfig, now = Date.now()): CrewAgentRecord {
+	if (!config.enabled || agent.status !== "running") return agent;
+	const age = activityAgeMs(agent, now);
+	if (age === undefined || age <= config.needsAttentionAfterMs) return agent;
+	if (agent.progress?.activityState === "needs_attention") return agent;
+	const updated: CrewAgentRecord = {
+		...agent,
+		progress: {
+			...(agent.progress ?? { recentTools: [], recentOutput: [], toolCount: agent.toolUses ?? 0 }),
+			activityState: "needs_attention",
+		},
+	};
+	upsertCrewAgent(manifest, updated);
+	appendTaskAttentionEvent({
+		manifest,
+		taskId: agent.taskId,
+		message: `${agent.agent} needs attention (no observed activity for ${Math.floor(age / 1000)}s).`,
+		data: { activityState: "needs_attention", reason: "idle", elapsedMs: age, taskId: agent.taskId, agentName: agent.agent, suggestedAction: "Check worker status, wait, steer, or cancel if needed." },
+	});
+	return updated;
+}

package/src/runtime/agent-memory.ts

@@ -1,72 +1,72 @@
-import * as fs from "node:fs";
-import * as os from "node:os";
-import * as path from "node:path";
-
-export type AgentMemoryScope = "user" | "project" | "local";
-const MAX_MEMORY_LINES = 200;
-
-export function isUnsafeMemoryName(name: string): boolean {
-	return !name || name.length > 128 || !/^[a-zA-Z0-9][a-zA-Z0-9._-]*$/.test(name);
-}
-
-export function isSymlink(filePath: string): boolean {
-	try {
-		return fs.lstatSync(filePath).isSymbolicLink();
-	} catch {
-		return false;
-	}
-}
-
-export function safeReadMemoryFile(filePath: string): string | undefined {
-	if (!fs.existsSync(filePath) || isSymlink(filePath)) return undefined;
-	try {
-		return fs.readFileSync(filePath, "utf-8");
-	} catch {
-		return undefined;
-	}
-}
-
-export function resolveMemoryDir(agentName: string, scope: AgentMemoryScope, cwd: string): string {
-	if (isUnsafeMemoryName(agentName)) throw new Error(`Unsafe agent name for memory directory: ${agentName}`);
-	if (scope === "user") return path.join(os.homedir(), ".pi", "agent-memory", agentName);
-	if (scope === "project") return path.join(cwd, ".pi", "agent-memory", agentName);
-	return path.join(cwd, ".pi", "agent-memory-local", agentName);
-}
-
-export function ensureMemoryDir(memoryDir: string): void {
-	if (fs.existsSync(memoryDir)) {
-		if (isSymlink(memoryDir)) throw new Error(`Refusing to use symlinked memory directory: ${memoryDir}`);
-		return;
-	}
-	fs.mkdirSync(memoryDir, { recursive: true });
-}
-
-export function readMemoryIndex(memoryDir: string): string | undefined {
-	if (isSymlink(memoryDir)) return undefined;
-	const content = safeReadMemoryFile(path.join(memoryDir, "MEMORY.md"));
-	if (content === undefined) return undefined;
-	const lines = content.split(/\r?\n/);
-	return lines.length > MAX_MEMORY_LINES ? `${lines.slice(0, MAX_MEMORY_LINES).join("\n")}\n... (truncated at 200 lines)` : content;
-}
-
-export function buildMemoryBlock(agentName: string, scope: AgentMemoryScope, cwd: string, writable: boolean): string {
-	const memoryDir = resolveMemoryDir(agentName, scope, cwd);
-	if (writable) ensureMemoryDir(memoryDir);
-	const existing = readMemoryIndex(memoryDir);
-	const mode = writable ? "read-write" : "read-only";
-	return [
-		`# Agent Memory (${mode})`,
-		`Memory scope: ${scope}`,
-		`Memory directory: ${memoryDir}`,
-		writable ? "Use this persistent directory to maintain useful long-term notes for this agent." : "You may reference existing memory, but do not create or modify memory files.",
-		"",
-		existing ? `## Current MEMORY.md\n${existing}` : "No MEMORY.md exists yet.",
-		writable ? [
-			"",
-			"## Memory Instructions",
-			"- Keep MEMORY.md concise (under 200 lines); store details in separate linked files.",
-			"- Reject stale memories; update or remove outdated notes.",
-			"- Use safe relative filenames inside the memory directory only.",
-		].join("\n") : "",
-	].filter(Boolean).join("\n");
-}
+import * as fs from "node:fs";
+import * as os from "node:os";
+import * as path from "node:path";
+
+export type AgentMemoryScope = "user" | "project" | "local";
+const MAX_MEMORY_LINES = 200;
+
+export function isUnsafeMemoryName(name: string): boolean {
+	return !name || name.length > 128 || !/^[a-zA-Z0-9][a-zA-Z0-9._-]*$/.test(name);
+}
+
+export function isSymlink(filePath: string): boolean {
+	try {
+		return fs.lstatSync(filePath).isSymbolicLink();
+	} catch {
+		return false;
+	}
+}
+
+export function safeReadMemoryFile(filePath: string): string | undefined {
+	if (!fs.existsSync(filePath) || isSymlink(filePath)) return undefined;
+	try {
+		return fs.readFileSync(filePath, "utf-8");
+	} catch {
+		return undefined;
+	}
+}
+
+export function resolveMemoryDir(agentName: string, scope: AgentMemoryScope, cwd: string): string {
+	if (isUnsafeMemoryName(agentName)) throw new Error(`Unsafe agent name for memory directory: ${agentName}`);
+	if (scope === "user") return path.join(os.homedir(), ".pi", "agent-memory", agentName);
+	if (scope === "project") return path.join(cwd, ".pi", "agent-memory", agentName);
+	return path.join(cwd, ".pi", "agent-memory-local", agentName);
+}
+
+export function ensureMemoryDir(memoryDir: string): void {
+	if (fs.existsSync(memoryDir)) {
+		if (isSymlink(memoryDir)) throw new Error(`Refusing to use symlinked memory directory: ${memoryDir}`);
+		return;
+	}
+	fs.mkdirSync(memoryDir, { recursive: true });
+}
+
+export function readMemoryIndex(memoryDir: string): string | undefined {
+	if (isSymlink(memoryDir)) return undefined;
+	const content = safeReadMemoryFile(path.join(memoryDir, "MEMORY.md"));
+	if (content === undefined) return undefined;
+	const lines = content.split(/\r?\n/);
+	return lines.length > MAX_MEMORY_LINES ? `${lines.slice(0, MAX_MEMORY_LINES).join("\n")}\n... (truncated at 200 lines)` : content;
+}
+
+export function buildMemoryBlock(agentName: string, scope: AgentMemoryScope, cwd: string, writable: boolean): string {
+	const memoryDir = resolveMemoryDir(agentName, scope, cwd);
+	if (writable) ensureMemoryDir(memoryDir);
+	const existing = readMemoryIndex(memoryDir);
+	const mode = writable ? "read-write" : "read-only";
+	return [
+		`# Agent Memory (${mode})`,
+		`Memory scope: ${scope}`,
+		`Memory directory: ${memoryDir}`,
+		writable ? "Use this persistent directory to maintain useful long-term notes for this agent." : "You may reference existing memory, but do not create or modify memory files.",
+		"",
+		existing ? `## Current MEMORY.md\n${existing}` : "No MEMORY.md exists yet.",
+		writable ? [
+			"",
+			"## Memory Instructions",
+			"- Keep MEMORY.md concise (under 200 lines); store details in separate linked files.",
+			"- Reject stale memories; update or remove outdated notes.",
+			"- Use safe relative filenames inside the memory directory only.",
+		].join("\n") : "",
+	].filter(Boolean).join("\n");
+}