pi-crew 0.1.30 → 0.1.32

package/src/worktree/cleanup.ts

@@ -1,69 +1,71 @@
-import { execFileSync } from "node:child_process";
-import * as fs from "node:fs";
-import * as path from "node:path";
-import type { TeamRunManifest } from "../state/types.ts";
-import { writeArtifact } from "../state/artifact-store.ts";
-
-export interface WorktreeCleanupResult {
-	removed: string[];
-	preserved: Array<{ path: string; reason: string }>;
-	artifactPaths: string[];
-}
-
-function git(cwd: string, args: string[]): string {
-	return execFileSync("git", args, { cwd, encoding: "utf-8", stdio: ["ignore", "pipe", "pipe"] }).trim();
-}
-
-function isDirty(worktreePath: string): boolean {
-	try {
-		return git(worktreePath, ["status", "--porcelain"]).trim().length > 0;
-	} catch {
-		return true;
-	}
-}
-
-function captureDiff(worktreePath: string): string {
-	try {
-		return [git(worktreePath, ["status", "--porcelain"]), "", git(worktreePath, ["diff", "--stat"]), "", git(worktreePath, ["diff"])].join("\n");
-	} catch (error) {
-		const message = error instanceof Error ? error.message : String(error);
-		return `Failed to capture cleanup diff for ${worktreePath}: ${message}`;
-	}
-}
-
-export function cleanupRunWorktrees(manifest: TeamRunManifest, options: { force?: boolean } = {}): WorktreeCleanupResult {
-	const worktreeRoot = path.join(manifest.cwd, ".pi", "teams", "worktrees", manifest.runId);
-	const result: WorktreeCleanupResult = { removed: [], preserved: [], artifactPaths: [] };
-	if (!fs.existsSync(worktreeRoot)) return result;
-
-	for (const entry of fs.readdirSync(worktreeRoot)) {
-		const worktreePath = path.join(worktreeRoot, entry);
-		if (!fs.statSync(worktreePath).isDirectory()) continue;
-		const dirty = isDirty(worktreePath);
-		if (dirty && !options.force) {
-			const artifact = writeArtifact(manifest.artifactsRoot, {
-				kind: "diff",
-				relativePath: `cleanup/${entry}.diff`,
-				content: captureDiff(worktreePath),
-				producer: "worktree-cleanup",
-			});
-			result.artifactPaths.push(artifact.path);
-			result.preserved.push({ path: worktreePath, reason: "dirty worktree preserved" });
-			continue;
-		}
-		try {
-			git(manifest.cwd, ["worktree", "remove", options.force ? "--force" : "", worktreePath].filter(Boolean));
-			result.removed.push(worktreePath);
-		} catch (error) {
-			const message = error instanceof Error ? error.message : String(error);
-			result.preserved.push({ path: worktreePath, reason: message });
-		}
-	}
-
-	try {
-		if (fs.existsSync(worktreeRoot) && fs.readdirSync(worktreeRoot).length === 0) fs.rmSync(worktreeRoot, { recursive: true, force: true });
-	} catch {
-		// Non-critical cleanup.
-	}
-	return result;
-}
+import { execFileSync } from "node:child_process";
+import * as fs from "node:fs";
+import * as path from "node:path";
+import type { TeamRunManifest } from "../state/types.ts";
+import { writeArtifact } from "../state/artifact-store.ts";
+import { projectCrewRoot } from "../utils/paths.ts";
+import { DEFAULT_PATHS } from "../config/defaults.ts";
+
+export interface WorktreeCleanupResult {
+	removed: string[];
+	preserved: Array<{ path: string; reason: string }>;
+	artifactPaths: string[];
+}
+
+function git(cwd: string, args: string[]): string {
+	return execFileSync("git", args, { cwd, encoding: "utf-8", stdio: ["ignore", "pipe", "pipe"] }).trim();
+}
+
+function isDirty(worktreePath: string): boolean {
+	try {
+		return git(worktreePath, ["status", "--porcelain"]).trim().length > 0;
+	} catch {
+		return true;
+	}
+}
+
+function captureDiff(worktreePath: string): string {
+	try {
+		return [git(worktreePath, ["status", "--porcelain"]), "", git(worktreePath, ["diff", "--stat"]), "", git(worktreePath, ["diff"])].join("\n");
+	} catch (error) {
+		const message = error instanceof Error ? error.message : String(error);
+		return `Failed to capture cleanup diff for ${worktreePath}: ${message}`;
+	}
+}
+
+export function cleanupRunWorktrees(manifest: TeamRunManifest, options: { force?: boolean } = {}): WorktreeCleanupResult {
+	const worktreeRoot = path.join(projectCrewRoot(manifest.cwd), DEFAULT_PATHS.state.worktreesSubdir, manifest.runId);
+	const result: WorktreeCleanupResult = { removed: [], preserved: [], artifactPaths: [] };
+	if (!fs.existsSync(worktreeRoot)) return result;
+
+	for (const entry of fs.readdirSync(worktreeRoot)) {
+		const worktreePath = path.join(worktreeRoot, entry);
+		if (!fs.statSync(worktreePath).isDirectory()) continue;
+		const dirty = isDirty(worktreePath);
+		if (dirty && !options.force) {
+			const artifact = writeArtifact(manifest.artifactsRoot, {
+				kind: "diff",
+				relativePath: `cleanup/${entry}.diff`,
+				content: captureDiff(worktreePath),
+				producer: "worktree-cleanup",
+			});
+			result.artifactPaths.push(artifact.path);
+			result.preserved.push({ path: worktreePath, reason: "dirty worktree preserved" });
+			continue;
+		}
+		try {
+			git(manifest.cwd, ["worktree", "remove", options.force ? "--force" : "", worktreePath].filter(Boolean));
+			result.removed.push(worktreePath);
+		} catch (error) {
+			const message = error instanceof Error ? error.message : String(error);
+			result.preserved.push({ path: worktreePath, reason: message });
+		}
+	}
+
+	try {
+		if (fs.existsSync(worktreeRoot) && fs.readdirSync(worktreeRoot).length === 0) fs.rmSync(worktreeRoot, { recursive: true, force: true });
+	} catch {
+		// Non-critical cleanup.
+	}
+	return result;
+}

package/src/worktree/worktree-manager.ts

@@ -2,6 +2,8 @@ import { execFileSync, spawnSync } from "node:child_process";
 import * as fs from "node:fs";
 import * as path from "node:path";
 import { loadConfig } from "../config/config.ts";
+import { projectCrewRoot } from "../utils/paths.ts";
+import { DEFAULT_PATHS } from "../config/defaults.ts";
 import type { TeamRunManifest, TeamTaskState } from "../state/types.ts";
 
 export interface PreparedTaskWorkspace {
@@ -85,7 +87,7 @@ export function prepareTaskWorkspace(manifest: TeamRunManifest, task: TeamTaskSt
 	const repoRoot = findGitRoot(manifest.cwd);
 	const loadedConfig = loadConfig(manifest.cwd);
 	if (loadedConfig.config.requireCleanWorktreeLeader !== false) assertCleanLeader(repoRoot);
-	const worktreeRoot = path.join(repoRoot, ".pi", "teams", "worktrees", manifest.runId);
+	const worktreeRoot = path.join(projectCrewRoot(manifest.cwd), DEFAULT_PATHS.state.worktreesSubdir, manifest.runId);
 	fs.mkdirSync(worktreeRoot, { recursive: true });
 	const worktreePath = path.join(worktreeRoot, task.id);
 	const branch = `pi-crew/${sanitizeBranchPart(manifest.runId)}/${sanitizeBranchPart(task.id)}`;

package/teams/default.team.md

@@ -1,12 +1,12 @@
----
-name: default
-description: Balanced team for ordinary implementation tasks
-defaultWorkflow: default
-workspaceMode: single
-maxConcurrency: 2
----
-
-- explorer: agent=explorer fast discovery
-- planner: agent=planner plan the work
-- executor: agent=executor implement changes
-- verifier: agent=verifier verify completion
+---
+name: default
+description: Balanced team for ordinary implementation tasks
+defaultWorkflow: default
+workspaceMode: single
+maxConcurrency: 2
+---
+
+- explorer: agent=explorer fast discovery
+- planner: agent=planner plan the work
+- executor: agent=executor implement changes
+- verifier: agent=verifier verify completion

package/teams/fast-fix.team.md

@@ -1,11 +1,11 @@
----
-name: fast-fix
-description: Small team for quick bug fixes
-defaultWorkflow: fast-fix
-workspaceMode: single
-maxConcurrency: 1
----
-
-- explorer: agent=explorer find the relevant files
-- executor: agent=executor make the fix
-- verifier: agent=verifier verify the fix
+---
+name: fast-fix
+description: Small team for quick bug fixes
+defaultWorkflow: fast-fix
+workspaceMode: single
+maxConcurrency: 1
+---
+
+- explorer: agent=explorer find the relevant files
+- executor: agent=executor make the fix
+- verifier: agent=verifier verify the fix

package/teams/implementation.team.md

@@ -1,18 +1,18 @@
----
-name: implementation
-description: Full implementation team with parallel specialists, critique, execution, review, and verification
-defaultWorkflow: implementation
-workspaceMode: single
-maxConcurrency: 3
----
-
-- explorer: agent=explorer map the codebase
-- analyst: agent=analyst clarify requirements and constraints
-- planner: agent=planner create execution plan
-- critic: agent=critic challenge and synthesize specialist findings
-- executor: agent=executor implement the plan
-- reviewer: agent=reviewer review the implementation
-- security-reviewer: agent=security-reviewer review security and trust boundaries
-- test-engineer: agent=test-engineer design and run verification
-- verifier: agent=verifier verify done
-- writer: agent=writer summarize documentation or release notes when needed
+---
+name: implementation
+description: Full implementation team with parallel specialists, critique, execution, review, and verification
+defaultWorkflow: implementation
+workspaceMode: single
+maxConcurrency: 3
+---
+
+- explorer: agent=explorer map the codebase
+- analyst: agent=analyst clarify requirements and constraints
+- planner: agent=planner create execution plan
+- critic: agent=critic challenge and synthesize specialist findings
+- executor: agent=executor implement the plan
+- reviewer: agent=reviewer review the implementation
+- security-reviewer: agent=security-reviewer review security and trust boundaries
+- test-engineer: agent=test-engineer design and run verification
+- verifier: agent=verifier verify done
+- writer: agent=writer summarize documentation or release notes when needed

package/teams/parallel-research.team.md

@@ -1,14 +1,14 @@
----
-name: parallel-research
-description: Parallel research team for multi-project/source audits
-workspaceMode: single
-defaultWorkflow: parallel-research
-maxConcurrency: 4
-triggers: đọc sâu, deep read, deep research, source audit, multiple projects, parallel research, pi-*
-category: research
-cost: cheap
----
-
-- explorer: agent=explorer gather source facts in parallel shards
-- analyst: agent=analyst synthesize shard findings
-- writer: agent=writer produce final notes
+---
+name: parallel-research
+description: Parallel research team for multi-project/source audits
+workspaceMode: single
+defaultWorkflow: parallel-research
+maxConcurrency: 4
+triggers: đọc sâu, deep read, deep research, source audit, multiple projects, parallel research, pi-*
+category: research
+cost: cheap
+---
+
+- explorer: agent=explorer gather source facts in parallel shards
+- analyst: agent=analyst synthesize shard findings
+- writer: agent=writer produce final notes

package/teams/research.team.md

@@ -1,11 +1,11 @@
----
-name: research
-description: Team for investigation and documentation
-defaultWorkflow: research
-workspaceMode: single
-maxConcurrency: 2
----
-
-- explorer: agent=explorer gather codebase facts
-- analyst: agent=analyst analyze findings
-- writer: agent=writer produce final notes
+---
+name: research
+description: Team for investigation and documentation
+defaultWorkflow: research
+workspaceMode: single
+maxConcurrency: 2
+---
+
+- explorer: agent=explorer gather codebase facts
+- analyst: agent=analyst analyze findings
+- writer: agent=writer produce final notes

package/teams/review.team.md

@@ -1,12 +1,12 @@
----
-name: review
-description: Team for code review and security review
-defaultWorkflow: review
-workspaceMode: single
-maxConcurrency: 2
----
-
-- explorer: agent=explorer understand changed areas
-- reviewer: agent=reviewer review correctness and maintainability
-- security-reviewer: agent=security-reviewer review security risks
-- verifier: agent=verifier summarize pass/fail
+---
+name: review
+description: Team for code review and security review
+defaultWorkflow: review
+workspaceMode: single
+maxConcurrency: 2
+---
+
+- explorer: agent=explorer understand changed areas
+- reviewer: agent=reviewer review correctness and maintainability
+- security-reviewer: agent=security-reviewer review security risks
+- verifier: agent=verifier summarize pass/fail

package/workflows/default.workflow.md

@@ -1,29 +1,29 @@
----
-name: default
-description: Explore, plan, execute, and verify
----
-
-## explore
-role: explorer
-
-Explore the codebase for the goal: {goal}
-
-## plan
-role: planner
-dependsOn: explore
-output: plan.md
-
-Create a concise implementation plan for: {goal}
-
-## execute
-role: executor
-dependsOn: plan
-
-Implement the plan for: {goal}
-
-## verify
-role: verifier
-dependsOn: execute
-verify: true
-
-Verify completion for: {goal}
+---
+name: default
+description: Explore, plan, execute, and verify
+---
+
+## explore
+role: explorer
+
+Explore the codebase for the goal: {goal}
+
+## plan
+role: planner
+dependsOn: explore
+output: plan.md
+
+Create a concise implementation plan for: {goal}
+
+## execute
+role: executor
+dependsOn: plan
+
+Implement the plan for: {goal}
+
+## verify
+role: verifier
+dependsOn: execute
+verify: true
+
+Verify completion for: {goal}

package/workflows/fast-fix.workflow.md

@@ -1,22 +1,22 @@
----
-name: fast-fix
-description: Minimal workflow for small fixes
----
-
-## explore
-role: explorer
-
-Find the likely source of the issue: {goal}
-
-## execute
-role: executor
-dependsOn: explore
-
-Make the smallest safe fix.
-
-## verify
-role: verifier
-dependsOn: execute
-verify: true
-
-Verify the fix with available evidence.
+---
+name: fast-fix
+description: Minimal workflow for small fixes
+---
+
+## explore
+role: explorer
+
+Find the likely source of the issue: {goal}
+
+## execute
+role: executor
+dependsOn: explore
+
+Make the smallest safe fix.
+
+## verify
+role: verifier
+dependsOn: execute
+verify: true
+
+Verify the fix with available evidence.

package/workflows/implementation.workflow.md

@@ -1,38 +1,38 @@
----
-name: implementation
-description: Adaptive implementation workflow where a planner agent decides the subagent fanout
----
-
-## assess
-role: planner
-output: adaptive-plan.json
-
-Assess this task and decide how many subagents are actually needed for: {goal}
-
-You are the orchestration planner. Inspect the repository enough to choose an efficient crew; do not use a fixed template. Small/simple tasks may need one executor plus one verifier. Risky or broad tasks may need parallel explorers, specialists, implementers, reviewers, security reviewers, or test engineers.
-
-Return a concise rationale, then include exactly one JSON block between these markers:
-
-ADAPTIVE_PLAN_JSON_START
-{
-  "phases": [
-    {
-      "name": "short-phase-name",
-      "tasks": [
-        {
-          "role": "explorer|analyst|planner|critic|executor|reviewer|security-reviewer|test-engineer|verifier|writer",
-          "title": "short task title",
-          "task": "specific autonomous task prompt for this subagent"
-        }
-      ]
-    }
-  ]
-}
-ADAPTIVE_PLAN_JSON_END
-
-Rules:
-- Choose the smallest effective number of subagents.
-- Use parallel tasks in the same phase only when their work is independent.
-- Later phases depend on all tasks in the previous phase.
-- Include verification/review tasks when implementation is requested.
-- Do not include more than 12 total subagents; split or summarize oversized plans instead.
+---
+name: implementation
+description: Adaptive implementation workflow where a planner agent decides the subagent fanout
+---
+
+## assess
+role: planner
+output: adaptive-plan.json
+
+Assess this task and decide how many subagents are actually needed for: {goal}
+
+You are the orchestration planner. Inspect the repository enough to choose an efficient crew; do not use a fixed template. Small/simple tasks may need one executor plus one verifier. Risky or broad tasks may need parallel explorers, specialists, implementers, reviewers, security reviewers, or test engineers.
+
+Return a concise rationale, then include exactly one JSON block between these markers:
+
+ADAPTIVE_PLAN_JSON_START
+{
+  "phases": [
+    {
+      "name": "short-phase-name",
+      "tasks": [
+        {
+          "role": "explorer|analyst|planner|critic|executor|reviewer|security-reviewer|test-engineer|verifier|writer",
+          "title": "short task title",
+          "task": "specific autonomous task prompt for this subagent"
+        }
+      ]
+    }
+  ]
+}
+ADAPTIVE_PLAN_JSON_END
+
+Rules:
+- Choose the smallest effective number of subagents.
+- Use parallel tasks in the same phase only when their work is independent.
+- Later phases depend on all tasks in the previous phase.
+- Include verification/review tasks when implementation is requested.
+- Do not include more than 12 total subagents; split or summarize oversized plans instead.

package/workflows/parallel-research.workflow.md

@@ -1,46 +1,46 @@
----
-name: parallel-research
-description: Parallel research with shard exploration and synthesis
----
-
-## discover
-role: explorer
-
-Discover the relevant files/projects for: {goal}. Return a shard plan with paths grouped by topic. Do not deeply read every file yet; focus on routing the work.
-
-## explore-core
-role: explorer
-parallelGroup: explore
-
-Explore the core/runtime shard from the discover output. Focus on architecture, package config, docs, and reusable patterns for: {goal}
-
-## explore-ui
-role: explorer
-parallelGroup: explore
-
-Explore the UI/TUI/extension-interface shard from the discover output. Focus on widgets, overlays, commands, status bars, package config, docs, and reusable patterns for: {goal}
-
-## explore-runtime
-role: explorer
-parallelGroup: explore
-
-Explore the worker/runtime/subagent/runtime-control shard from the discover output. Focus on process/session/runtime orchestration, event streams, logs, package config, docs, and reusable patterns for: {goal}
-
-## explore-extensions
-role: explorer
-parallelGroup: explore
-
-Explore the extension bundle/small-package shard from the discover output. Focus on package config, extension registration, commands/tools, docs, and reusable patterns for: {goal}
-
-## synthesize
-role: analyst
-dependsOn: explore-core, explore-ui, explore-runtime, explore-extensions
-
-Synthesize all shard findings. Use discover output if available, but do not require it. Identify common patterns, gaps, and concrete recommendations.
-
-## write
-role: writer
-dependsOn: synthesize
-output: research-summary.md
-
-Write a concise final summary with evidence, risks, and actionable next steps.
+---
+name: parallel-research
+description: Parallel research with shard exploration and synthesis
+---
+
+## discover
+role: explorer
+
+Discover the relevant files/projects for: {goal}. Return a shard plan with paths grouped by topic. Do not deeply read every file yet; focus on routing the work.
+
+## explore-core
+role: explorer
+parallelGroup: explore
+
+Explore the core/runtime shard from the discover output. Focus on architecture, package config, docs, and reusable patterns for: {goal}
+
+## explore-ui
+role: explorer
+parallelGroup: explore
+
+Explore the UI/TUI/extension-interface shard from the discover output. Focus on widgets, overlays, commands, status bars, package config, docs, and reusable patterns for: {goal}
+
+## explore-runtime
+role: explorer
+parallelGroup: explore
+
+Explore the worker/runtime/subagent/runtime-control shard from the discover output. Focus on process/session/runtime orchestration, event streams, logs, package config, docs, and reusable patterns for: {goal}
+
+## explore-extensions
+role: explorer
+parallelGroup: explore
+
+Explore the extension bundle/small-package shard from the discover output. Focus on package config, extension registration, commands/tools, docs, and reusable patterns for: {goal}
+
+## synthesize
+role: analyst
+dependsOn: explore-core, explore-ui, explore-runtime, explore-extensions
+
+Synthesize all shard findings. Use discover output if available, but do not require it. Identify common patterns, gaps, and concrete recommendations.
+
+## write
+role: writer
+dependsOn: synthesize
+output: research-summary.md
+
+Write a concise final summary with evidence, risks, and actionable next steps.

package/workflows/research.workflow.md

@@ -1,22 +1,22 @@
----
-name: research
-description: Research and write up findings
----
-
-## explore
-role: explorer
-
-Gather relevant facts for: {goal}
-
-## analyze
-role: analyst
-dependsOn: explore
-
-Analyze and organize the findings.
-
-## write
-role: writer
-dependsOn: analyze
-output: research-summary.md
-
-Write a concise final summary with evidence and open questions.
+---
+name: research
+description: Research and write up findings
+---
+
+## explore
+role: explorer
+
+Gather relevant facts for: {goal}
+
+## analyze
+role: analyst
+dependsOn: explore
+
+Analyze and organize the findings.
+
+## write
+role: writer
+dependsOn: analyze
+output: research-summary.md
+
+Write a concise final summary with evidence and open questions.