pi-compact-tools 0.13.0 → 0.13.2

package/README.md

@@ -79,6 +79,10 @@ npm run check
 pi -e .
 ```
 
+Development dependencies are pinned to Pi 1.0.0; the peer minimum remains Pi 0.85.1. CI checks Pi 0.85.1, 0.99.1, and 1.0.0 on Node 22.19.0 and 24. Schema validation and deterministic test clocks are development-only dependencies, not runtime dependencies. Development scripts and tests are not included in the published package. `npm test` runs the rendering tests first and the resource/packaging checks separately so their subprocesses do not disturb animation tests.
+
+For a local before/after performance comparison, run `npx tsx tests/benchmark.ts <clean-baseline-directory>` with the same host dependencies in both directories. Measurements are informational, not timing-sensitive test assertions.
+
 Renders are pinned in `tests/golden/render.json`. After an intended change to the output, record it with `UPDATE_GOLDEN=1 npm test` and review the diff. Before publishing, add the version's notes to `release-notes.json` (`[]` for none).
 
 ## License

package/extensions/compact-tools-activity.ts

@@ -264,8 +264,16 @@ export class SilentActivityAnimator {
 			else if (type === "thinking_start" || type === "toolcall_start") this.setAnswering(false);
 		});
 		pi.on("tool_execution_start", () => this.setAnswering(false));
-		pi.on("turn_start", () => this.setAnswering(false));
-		pi.on("agent_end", () => {
+		pi.on("turn_start", () => {
+			if (!this.context) return;
+			this.running = true;
+			this.answering = false;
+			this.refresh();
+		});
+		// agent_end closes a low-level run, not retries/compaction/continuations.
+		// Keep the shared clock alive until Pi declares final settlement, as the
+		// working-label controller already does.
+		pi.on("agent_settled", () => {
 			if (!this.context) return;
 			this.running = false;
 			this.refresh();

package/extensions/compact-tools-color.ts

@@ -6,14 +6,18 @@ import * as tui from "@earendil-works/pi-tui";
 export type Rgb = { r: number; g: number; b: number };
 
 /**
- * What Pi 0.99 added to its Theme for extensions. Older Pi has none of it, so each
- * piece is read as optional and the few lines below stand in when it is missing.
+ * What Pi 0.99 added to its Theme for extensions, and what Pi 0.85 to 0.87 keep on
+ * theirs. Each piece is read as optional, and typed here rather than taken from Pi,
+ * so the extension builds and runs against every Pi it supports.
  */
-type HostTheme = Theme & {
-	colors?: Readonly<Record<string, tui.Color | undefined>>;
+type HostColor = object;
+type HostTheme = {
+	colors?: Readonly<Record<string, HostColor | undefined>>;
 	appearance?: "dark" | "light";
+	fgColors?: unknown;
 };
-const colorToRgb = (tui as Partial<typeof tui>).colorToRgb;
+const host = (theme: Theme) => theme as unknown as HostTheme;
+const colorToRgb = (tui as unknown as { colorToRgb?: (color: HostColor) => Rgb }).colorToRgb;
 
 /**
  * A theme token's concrete color. Pi 0.99 resolves every token, including one set
@@ -22,7 +26,7 @@ const colorToRgb = (tui as Partial<typeof tui>).colorToRgb;
  * nothing rather than throwing, since callers compute names from host state.
  */
 export function themeColorRgb(theme: Theme, color: ThemeColor): Rgb | undefined {
-	const { colors } = theme as HostTheme;
+	const { colors } = host(theme);
 	if (colors && colorToRgb) {
 		const concrete = colors[color];
 		if (!concrete) return undefined;
@@ -119,7 +123,7 @@ export function rgbPainter(theme: Theme, color: Rgb): (text: string) => string {
  * neither is told apart by the escape sequences of the colors derived from.
  */
 export function paletteOf(theme: Theme): object {
-	const { colors, fgColors } = theme as HostTheme & { fgColors?: unknown };
+	const { colors, fgColors } = host(theme);
 	if (colors) return colors;
 	if (fgColors instanceof Map) return fgColors;
 	let key = theme.getColorMode?.() ?? "";
@@ -164,7 +168,7 @@ const WHITE: Rgb = { r: 255, g: 255, b: 255 };
 
 /** The theme's declared appearance; before Pi 0.99, a theme with light text is a dark one. */
 function isDark(theme: Theme): boolean {
-	const { appearance } = theme as HostTheme;
+	const { appearance } = host(theme);
 	if (appearance) return appearance === "dark";
 	const text = themeColorRgb(theme, "text");
 	return !text || luminanceRgb(text) > 128;

package/extensions/compact-tools-layout.ts

@@ -358,14 +358,11 @@ function highlightCodeLines(lines: CodeDiffLine[], language: string | undefined,
 		}
 		let end = index;
 		while (end < lines.length && lines[end]!.kind !== "separator") end++;
-		const block = lines.slice(index, end);
-		const contents = block.map((line) => line.content);
+		const contents = lines.slice(index, end).map((line) => line.content);
 		const highlighted = language === "markdown"
 			? highlightMarkdown(contents, theme)
 			: highlightCode(contents.join("\n"), language);
-		block.forEach((line, offset) => {
-			rendered[index + offset] = highlighted[offset] ?? line.content;
-		});
+		for (let offset = 0; offset < contents.length; offset++) rendered[index + offset] = highlighted[offset] ?? contents[offset]!;
 		index = end;
 	}
 	return rendered;
@@ -411,14 +408,18 @@ function renderCodeRows(lines: CodeDiffLine[], path: string, theme: Theme, optio
 	// read at an offset or a diff hunk never reads one out of a comment.
 	const first = lines[0];
 	const shebangLine = first?.lineNumber === 1 && first.kind !== "separator" ? first.content : undefined;
-	const highlighted = highlightCodeLines(lines, resolveLanguage(path, shebangLine), theme);
-	const numberWidth = Math.max(1, ...lines.map((line) => String(line.lineNumber ?? "").length));
+	// ToolExecutionComponent builds result components even when silent mode hides
+	// the row. Defer syntax work until the code is actually drawn, and keep it
+	// across width changes so resize does not highlight the same source again.
+	let highlighted: string[] | undefined;
+	const numberWidth = lines.reduce((maximum, line) => Math.max(maximum, String(line.lineNumber ?? "").length), 1);
 	const prefix = options.rail ?? paintChrome(theme, " \u2502 ");
 	const prefixWidth = visibleWidth(prefix);
 	const gutterWidth = numberWidth + (options.signs ? 3 : 2);
 	const addedTint = options.signs ? diffTintRgb(theme, "toolDiffAdded") : undefined;
 	const removedTint = options.signs ? diffTintRgb(theme, "toolDiffRemoved") : undefined;
 	return new CachedComponent((width) => {
+		highlighted ??= highlightCodeLines(lines, resolveLanguage(path, shebangLine), theme);
 		const bodyWidth = Math.max(1, width - prefixWidth);
 		const codeWidth = Math.max(1, bodyWidth - gutterWidth);
 		const output: string[] = [];
@@ -428,7 +429,7 @@ function renderCodeRows(lines: CodeDiffLine[], path: string, theme: Theme, optio
 				return;
 			}
 			const tint = line.kind === "add" ? addedTint : line.kind === "remove" ? removedTint : undefined;
-			for (const [chunkIndex, chunk] of hardSliceAnsi(highlighted[index] ?? line.content, codeWidth).entries()) {
+			for (const [chunkIndex, chunk] of hardSliceAnsi(highlighted![index] ?? line.content, codeWidth).entries()) {
 				const gutter = codeGutter(
 					line.kind,
 					chunkIndex === 0 ? line.lineNumber : undefined,

package/extensions/compact-tools-runtime.ts

@@ -207,12 +207,14 @@ export class ToolRuntime {
 	 */
 	noteExecutionStart(toolCallId: string): void {
 		if (!this.executionTimings.has(toolCallId)) this.executionTimings.set(toolCallId, { startedAt: Date.now() });
+		this.trimTimings();
 	}
 
 	noteExecutionEnd(toolCallId: string): void {
 		const timing = this.executionTimings.get(toolCallId) ?? { startedAt: Date.now() };
 		timing.endedAt ??= Date.now();
 		this.executionTimings.set(toolCallId, timing);
+		this.trimTimings();
 	}
 
 	createTimedExecute(definition: BuiltInDefinition): TimedExecute {
@@ -222,6 +224,7 @@ export class ToolRuntime {
 			const startedAt = (toolCallId ? this.executionTimings.get(toolCallId)?.startedAt : undefined) ?? Date.now();
 			if (toolCallId && !this.executionTimings.has(toolCallId)) {
 				this.executionTimings.set(toolCallId, { startedAt });
+				this.trimTimings();
 			}
 			try {
 				return await execute.apply(definition, args);
@@ -295,7 +298,20 @@ export class ToolRuntime {
 		timing.startedAt = state.startedAt;
 		if (state.endedAt !== undefined) timing.endedAt = state.endedAt;
 		this.executionTimings.set(toolCallId, timing);
+		this.trimTimings();
+	}
+
+	/** Bound every insertion, including calls never drawn (for example in silent mode). */
+	private trimTimings(): void {
 		if (this.executionTimings.size <= MAX_TRACKED_ROWS) return;
+		// Prefer settled calls so a long-running sibling keeps its start time. If all
+		// 2,001 calls are active, retain the original FIFO fallback to stay bounded.
+		for (const [id, timing] of this.executionTimings) {
+			if (timing.endedAt !== undefined) {
+				this.executionTimings.delete(id);
+				return;
+			}
+		}
 		const oldest = this.executionTimings.keys().next().value;
 		if (oldest !== undefined) this.executionTimings.delete(oldest);
 	}

package/extensions/compact-tools-types.ts

@@ -50,6 +50,7 @@ export interface RowState {
 	lastResultPreview?: boolean;
 	lastResultError?: boolean;
 	lastResultConfigRevision?: object;
+	lastResultPalette?: object;
 }
 
 type BaseRenderContext = Parameters<NonNullable<BuiltInDefinition["renderCall"]>>[2];

package/extensions/compact-tools-viewport.ts

@@ -89,17 +89,15 @@ export function findAnchorTop(
 		else starts.set(line, [index]);
 	});
 	const bottom = Math.min(before.length, top + Math.max(1, height));
-	const candidates: number[] = [];
-	for (let row = top; row < bottom; row++) candidates.push(row);
-	for (let row = top - 1; row >= 0; row--) candidates.push(row);
-	for (const row of candidates) {
-		const window = before.slice(row, row + ANCHOR_LINES);
-		if (window.length < ANCHOR_LINES || !window.some(hasText)) continue;
+	// Visit the viewport first, then preceding rows, without copying candidate windows.
+	for (let candidate = 0; candidate < bottom; candidate++) {
+		const row = candidate < bottom - top ? top + candidate : bottom - candidate - 1;
+		if (row + ANCHOR_LINES > before.length || (!hasText(before[row]) && !hasText(before[row + 1]))) continue;
 		// Several places can match a short window; the one that keeps matching for
 		// longest is the same text, and distance only breaks a remaining tie.
 		let best: number | undefined;
 		let bestRun = 0;
-		for (const start of starts.get(window[0]!) ?? []) {
+		for (const start of starts.get(before[row]!) ?? []) {
 			const run = matchingRun(before, row, after, start, TIE_BREAK_LINES);
 			if (run < ANCHOR_LINES) continue;
 			if (best === undefined || run > bestRun

package/extensions/compact-tools.ts

@@ -19,6 +19,7 @@ import {
 import type { Component } from "@earendil-works/pi-tui";
 import { classifyCallStatus, formatDurationMs, normalizeLineEndings, type RowStatus } from "./compact-tools-core.ts";
 import { loadConfig } from "./compact-tools-config.ts";
+import { paletteOf } from "./compact-tools-color.ts";
 import { installToolRowPatch, setRowResolver, type RowRenderers, type ToolRow } from "./compact-tools-custom.ts";
 import {
 	formatResultLineSummary,
@@ -128,6 +129,7 @@ function canReuseResult<TArgs>(
 	state: RowState,
 	result: AgentToolResult<unknown>,
 	options: ToolRenderResultOptions,
+	theme: Theme,
 	ctx: RenderContext<TArgs>,
 ): ctx is RenderContext<TArgs> & { lastComponent: Component } {
 	return ctx.lastComponent !== undefined
@@ -137,10 +139,11 @@ function canReuseResult<TArgs>(
 		&& state.lastResultExpanded === state.expanded
 		&& state.lastResultPreview === state.preview
 		&& state.lastResultError === ctx.isError
-		&& state.lastResultConfigRevision === state.configRevision;
+		&& state.lastResultConfigRevision === state.configRevision
+		&& state.lastResultPalette === paletteOf(theme);
 }
 
-function rememberResult(state: RowState, result: AgentToolResult<unknown>, options: ToolRenderResultOptions, isError: boolean): void {
+function rememberResult(state: RowState, result: AgentToolResult<unknown>, options: ToolRenderResultOptions, isError: boolean, theme: Theme): void {
 	state.lastResultContent = result.content;
 	state.lastResultDetails = result.details;
 	state.lastResultPartial = options.isPartial;
@@ -148,6 +151,7 @@ function rememberResult(state: RowState, result: AgentToolResult<unknown>, optio
 	state.lastResultPreview = state.preview;
 	state.lastResultError = isError;
 	state.lastResultConfigRevision = state.configRevision;
+	state.lastResultPalette = paletteOf(theme);
 }
 
 function renderControls(
@@ -376,7 +380,7 @@ function renderRowResult(
 ): Component {
 	const state = runtime.syncRow(ctx, !options.isPartial);
 	runtime.syncExpansion(state, ctx.expanded, name);
-	if (canReuseResult(state, result, options, ctx)) return ctx.lastComponent;
+	if (canReuseResult(state, result, options, theme, ctx)) return ctx.lastComponent;
 	const kind = rowKind(name);
 	const output = kind === "file" ? getFileOutput(name, ctx.args, result, ctx.isError) : getTextResult(result);
 	const hasEditDiff = name === "edit" && getEditDiff(result).length > 0;
@@ -402,7 +406,7 @@ function renderRowResult(
 			name === "edit" ? countEditChanges(result) : undefined));
 		component = container;
 	}
-	rememberResult(state, result, options, ctx.isError);
+	rememberResult(state, result, options, ctx.isError, theme);
 	return component;
 }
 
@@ -503,6 +507,14 @@ function noteCalls(message: unknown): void {
 	}
 }
 
+/**
+ * Whether another tool made the call through `ctx.executeTool()`, as codemode scripts
+ * do. Pi 0.99 marks such calls with `parentToolCallId`; older Pi never makes them.
+ */
+function madeByTool(event: object): boolean {
+	return typeof (event as { parentToolCallId?: unknown }).parentToolCallId === "string";
+}
+
 /** Hand the animation Pi's frame request, reached through an invisible widget as the extension API allows. */
 function bindRenderer(ctx: ExtensionContext): void {
 	ctx.ui.setWidget(RENDER_WIDGET_KEY, (tui) => {
@@ -572,12 +584,12 @@ export default function compactTools(pi: ExtensionAPI): void {
 	// their rows, and told to extensions before Pi makes them.
 	pi.on("message_update", (event) => noteCalls(event.message));
 	pi.on("tool_execution_start", (event) => {
-		if (event.parentToolCallId) return runtime.noteNestedCall(event.toolCallId, true);
+		if (madeByTool(event)) return runtime.noteNestedCall(event.toolCallId, true);
 		runtime.noteCall(event.toolCallId);
 		runtime.noteExecutionStart(event.toolCallId);
 	});
 	pi.on("tool_execution_end", (event) => {
-		if (event.parentToolCallId) return runtime.noteNestedCall(event.toolCallId, false);
+		if (madeByTool(event)) return runtime.noteNestedCall(event.toolCallId, false);
 		runtime.noteExecutionEnd(event.toolCallId);
 	});
 	pi.on("session_shutdown", (event) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-compact-tools",
-  "version": "0.13.0",
+  "version": "0.13.2",
   "description": "Compact, expandable tool rows for Pi in its own compact style or Claude Code's, with a silent mode and a GitHub Dark theme.",
   "type": "module",
   "license": "MIT",
@@ -24,14 +24,13 @@
     "extensions",
     "themes",
     "examples",
-    "scripts",
     "schemas",
     "release-notes.json",
     "README.md",
     "LICENSE"
   ],
   "scripts": {
-    "test": "tsx --test tests/*.test.ts",
+    "test": "tsx --test tests/*.test.ts && tsx --test tests/resources.validation.ts",
     "check": "tsc --noEmit && npm test && npm run check:resources",
     "check:resources": "node scripts/check-resources.mjs",
     "prepublishOnly": "npm run check"
@@ -50,9 +49,12 @@
     "@earendil-works/pi-tui": ">=0.85.1"
   },
   "devDependencies": {
-    "@earendil-works/pi-coding-agent": "0.99.1",
-    "@earendil-works/pi-tui": "0.99.1",
+    "@earendil-works/pi-coding-agent": "1.0.0",
+    "@earendil-works/pi-tui": "1.0.0",
+    "@sinonjs/fake-timers": "15.0.0",
     "@types/node": "^24.0.0",
+    "@types/sinonjs__fake-timers": "15.0.1",
+    "ajv": "8.20.0",
     "tsx": "^4.23.13",
     "typescript": "^5.9.0"
   },

package/release-notes.json

@@ -1,4 +1,14 @@
 {
+  "0.13.2": [
+    "Verified on Pi 1.0.0 while keeping compatibility with Pi 0.85.1 and later",
+    "Silent activity keeps animating through retries and follow-up turns until final settlement",
+    "Hidden file results defer syntax highlighting until their code is actually shown",
+    "Completed tool results repaint correctly when the theme changes",
+    "Large file views render without exceeding JavaScript argument limits",
+    "Fullscreen viewport anchoring and code-row layout allocate less work",
+    "Execution timing history stays bounded even when tool rows are not drawn"
+  ],
+  "0.13.1": [],
   "0.13.0": [
     "Follows Pi 0.99's system theme and light terminals: rails, dots, and the working label take their colors from the theme itself",
     "Running dots, rails, and silent mode's activity line are painted once per theme instead of every frame",

package/scripts/check-resources.mjs

@@ -1,82 +0,0 @@
-import { readFile } from "node:fs/promises";
-
-const resources = [
-  "themes/github-dark-pro.json",
-  "examples/compact-tools.json",
-  "examples/compact-tools-2.json",
-  "schemas/compact-tools.schema.json",
-  "release-notes.json",
-];
-
-for (const path of resources) {
-  const value = JSON.parse(await readFile(new URL(`../${path}`, import.meta.url), "utf8"));
-  if (!value || typeof value !== "object" || Array.isArray(value)) {
-    throw new Error(`${path} must contain a JSON object`);
-  }
-}
-
-const theme = JSON.parse(
-  await readFile(new URL("../themes/github-dark-pro.json", import.meta.url), "utf8"),
-);
-if (theme.name !== "github-dark-pro" || !theme.colors || typeof theme.colors !== "object") {
-  throw new Error("themes/github-dark-pro.json is not a valid pi theme document");
-}
-if (!theme.colors.border || !theme.colors.dim || !theme.colors.muted) {
-  throw new Error("github-dark-pro must define separator colors");
-}
-if (!theme.vars?.thinkingText || !theme.colors.thinkingMax) {
-  throw new Error("github-dark-pro must define thinking text and summary colors");
-}
-if (!theme.colors.mdQuote || !theme.colors.mdCodeBlockBorder) {
-  throw new Error("github-dark-pro must define thinking detail and code fence colors");
-}
-
-const example = JSON.parse(
-  await readFile(new URL("../examples/compact-tools.json", import.meta.url), "utf8"),
-);
-if (!example.auto_compact || example.auto_compact.edit !== false) {
-  throw new Error("example auto_compact policy must keep edit diffs visible by default");
-}
-if (Object.values(example.auto_compact).some((enabled) => typeof enabled !== "boolean")) {
-  throw new Error("example auto_compact values must be booleans");
-}
-if (!Number.isInteger(example.previewLines) || example.previewLines < 1 || example.previewLines > 100) {
-  throw new Error("example previewLines must be an integer from 1 to 100");
-}
-const alternateExample = JSON.parse(
-  await readFile(new URL("../examples/compact-tools-2.json", import.meta.url), "utf8"),
-);
-for (const [name, config] of [["compact-tools", example], ["compact-tools-2", alternateExample]]) {
-  if ("durationIndicators" in config) {
-    throw new Error(`${name} must not contain the removed durationIndicators setting`);
-  }
-  if ("spinner" in config) {
-    throw new Error(`${name} must not contain the removed spinner setting`);
-  }
-}
-
-const schema = JSON.parse(
-  await readFile(new URL("../schemas/compact-tools.schema.json", import.meta.url), "utf8"),
-);
-if (schema.properties?.durationIndicators) {
-  throw new Error("schema must not expose the removed durationIndicators setting");
-}
-if (schema.properties?.spinner) {
-  throw new Error("schema must not expose the removed spinner setting");
-}
-if (!schema.properties?.auto_compact?.properties?.edit) {
-  throw new Error("schema must describe per-tool auto_compact policies");
-}
-if (schema.properties?.previewLines?.default !== 10) {
-  throw new Error("schema must expose the bounded previewLines setting");
-}
-
-const manifest = JSON.parse(await readFile(new URL("../package.json", import.meta.url), "utf8"));
-const releaseNotes = JSON.parse(await readFile(new URL("../release-notes.json", import.meta.url), "utf8"));
-// Every published version needs an entry. An empty list is a quiet release that shows no notice.
-if (!Array.isArray(releaseNotes[manifest.version]) ||
-    releaseNotes[manifest.version].some((note) => typeof note !== "string" || !note.trim())) {
-  throw new Error(`release-notes.json must have an entry for v${manifest.version} before publishing; use [] for no notice`);
-}
-
-console.log("Resource checks passed");