pi-cohort 7.2.2 → 7.2.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [7.2.3] - 2026-10-18
+
+### Fixed
+
+- Subagents start from SDK-hosted sessions (Pi Web, standalone SDK scripts) whose `process.argv[1]` is not Pi's CLI. `capturePiRuntime` still identifies the parent from `argv[1]` first; when that entry is not Pi's declared CLI, the executor supplies the installation the extension was loaded from (`getPackageDir()` from `@earendil-works/pi-coding-agent`), validated against that package's `bin.pi` through the same ownership check, so a sibling Pi earlier on `PATH` is never selected. Sessions launched through Pi's CLI capture exactly as before. (#22)
+
 ## [7.2.2] - 2026-10-16
 
 ### Fixed

package/README.md

@@ -39,7 +39,7 @@ pi install npm:pi-cohort
 
 That is the only required step.
 
-Children and detached coordinators use the originating parent's resolved Node executable and Pi entry path directly, bypassing `PATH`. Revival keeps that original runtime even when requested from a different parent installation. Custom hosts whose entry cannot be identified as the installed Pi package's declared CLI are unsupported. These paths are not a version lock: replacing Node or Pi in place changes what runs. If the original installation is removed, restore it at the recorded paths or start a new run; there is no fallback to the current parent's installation. Legacy records without an original runtime identity remain inspectable but cannot be revived - start a new run.
+Children and detached coordinators use the originating parent's resolved Node executable and Pi entry path directly, bypassing `PATH`. Revival keeps that original runtime even when requested from a different parent installation. When the parent is not launched through Pi's CLI (an SDK-hosted session such as Pi Web, where `process.argv[1]` is the host's entry), children use the Pi installation this extension was loaded from: the package directory Pi reports for itself, accepted only when it is `@earendil-works/pi-coding-agent` and its declared `bin.pi` resolves inside that package. Single-file Pi binaries and hosts whose `process.execPath` is not a Node binary remain unsupported. These paths are not a version lock: replacing Node or Pi in place changes what runs. If the original installation is removed, restore it at the recorded paths or start a new run; there is no fallback to the current parent's installation. Legacy records without an original runtime identity remain inspectable but cannot be revived - start a new run.
 
 ## Execution backend extension API
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-cohort",
-  "version": "7.2.2",
+  "version": "7.2.3",
   "description": "Delegate Pi work to focused child agents: code review, scouting, implementation, parallel audits, saved chains, and background jobs.",
   "author": "Jacek Juraszek",
   "license": "MIT",

package/src/runs/foreground/subagent-executor.ts

@@ -3,7 +3,7 @@ import { capturePiRuntime, parsePiRuntime, type PiRuntimeIdentity } from "../sha
 import * as fs from "node:fs";
 import * as path from "node:path";
 import type { AgentToolResult } from "@earendil-works/pi-agent-core";
-import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { getPackageDir, type ExtensionAPI, type ExtensionContext } from "@earendil-works/pi-coding-agent";
 import type { AgentConfig, AgentScope } from "../../agents/agents.ts";
 import { getArtifactsDir } from "../../shared/artifacts.ts";
 import { ChainClarifyComponent, type ChainClarifyResult } from "./chain-clarify.ts";
@@ -2120,7 +2120,8 @@ export function createSubagentExecutor(deps: ExecutorDeps): {
 	let runtime: PiRuntimeIdentity | undefined;
 	let runtimeError: unknown;
 	try {
-		runtime = (deps.captureRuntime ?? capturePiRuntime)();
+		// SDK hosts are not launched through Pi's CLI; the installation this extension was loaded from is the fallback.
+		runtime = (deps.captureRuntime ?? (() => capturePiRuntime({ installRoot: getPackageDir() })))();
 	} catch (error) {
 		runtimeError = error;
 	}

package/src/runs/shared/pi-spawn.ts

@@ -1,36 +1,8 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
-import { fileURLToPath } from "node:url";
 
 export const PI_CODING_AGENT_PACKAGE = "@earendil-works/pi-coding-agent";
 
-export function findPiPackageRootFromEntry(entryPoint: string): string | undefined {
-	let dir = path.dirname(entryPoint);
-	while (true) {
-		const packageJsonPath = path.join(dir, "package.json");
-		if (fs.existsSync(packageJsonPath)) {
-			const pkg = JSON.parse(fs.readFileSync(packageJsonPath, "utf-8")) as { name?: unknown };
-			if (pkg.name === PI_CODING_AGENT_PACKAGE) return dir;
-		}
-		if (dir === path.dirname(dir)) return undefined;
-		dir = path.dirname(dir);
-	}
-}
-
-export function resolveInstalledPiPackageRoot(): string | undefined {
-	return findPiPackageRootFromEntry(fileURLToPath(import.meta.resolve(PI_CODING_AGENT_PACKAGE)));
-}
-
-export function resolvePiPackageRoot(): string | undefined {
-	try {
-		const entry = process.argv[1];
-		return entry ? findPiPackageRootFromEntry(fs.realpathSync(entry)) : undefined;
-	} catch {
-		// Non-launch package inspection is best-effort.
-		return undefined;
-	}
-}
-
 export interface PiRuntimeIdentity {
 	readonly nodeExecPath: string;
 	readonly piEntryPath: string;
@@ -90,13 +62,46 @@ function checkAvailability(file: string, executable: boolean): void {
 	}
 }
 
-export function capturePiRuntime(deps: { execPath?: string; argv1?: string } = {}): PiRuntimeIdentity {
-	const nodeExecPath = canonicalPath(deps.execPath ?? process.execPath, "Node executable");
-	const piEntryPath = canonicalPath(deps.argv1 ?? process.argv[1], "Pi entry");
-	checkAvailability(nodeExecPath, true);
+function identifyFromEntry(entry: string | undefined): { piEntryPath: string; piPackageRoot: string } {
+	const piEntryPath = canonicalPath(entry, "Pi entry");
 	checkAvailability(piEntryPath, false);
 	const piPackageRoot = canonicalPath(owningPackageRoot(piEntryPath), "Pi package root");
-	return { nodeExecPath, piEntryPath, piPackageRoot };
+	return { piEntryPath, piPackageRoot };
+}
+
+function identifyFromInstallRoot(installRoot: string): { piEntryPath: string; piPackageRoot: string } {
+	const piPackageRoot = canonicalPath(installRoot, "Pi installation root");
+	const manifest = path.join(piPackageRoot, "package.json");
+	let bin: unknown;
+	try {
+		const pkg = JSON.parse(fs.readFileSync(manifest, "utf-8"));
+		if (pkg?.name !== PI_CODING_AGENT_PACKAGE) {
+			throw new PiRuntimeLaunchError(`${manifest}: installation is not ${PI_CODING_AGENT_PACKAGE}`);
+		}
+		bin = typeof pkg.bin === "string" ? pkg.bin : pkg.bin?.pi;
+	} catch (error) {
+		if (error instanceof PiRuntimeLaunchError) throw error;
+		throw new PiRuntimeLaunchError(`${manifest}: ${String(error)}`);
+	}
+	if (typeof bin !== "string" || !bin) throw new PiRuntimeLaunchError(`${manifest}: missing declared Pi bin`);
+	const piEntryPath = canonicalPath(path.resolve(piPackageRoot, bin), "Declared Pi bin");
+	checkAvailability(piEntryPath, false);
+	const owner = canonicalPath(owningPackageRoot(piEntryPath), "Pi package root");
+	if (owner !== piPackageRoot) {
+		throw new PiRuntimeLaunchError(`${piEntryPath}: owning package ${owner} does not match installation ${piPackageRoot}`);
+	}
+	return { piEntryPath, piPackageRoot };
+}
+
+export function capturePiRuntime(deps: { execPath?: string; argv1?: string; installRoot?: string } = {}): PiRuntimeIdentity {
+	const nodeExecPath = canonicalPath(deps.execPath ?? process.execPath, "Node executable");
+	checkAvailability(nodeExecPath, true);
+	try {
+		return { nodeExecPath, ...identifyFromEntry(deps.argv1 ?? process.argv[1]) };
+	} catch (error) {
+		if (!(error instanceof PiRuntimeLaunchError) || deps.installRoot === undefined) throw error;
+		return { nodeExecPath, ...identifyFromInstallRoot(deps.installRoot) };
+	}
 }
 
 export function parsePiRuntime(value: unknown, source: string): PiRuntimeIdentity {