pi-cohort 7.2.0 → 7.2.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## [7.2.2] - 2026-10-16
+
+### Fixed
+
+- A background job's result file written while macOS re-arms its FSEvents stream is no longer missed until the next `session_start`. libuv rebuilds one process-wide stream on every new directory `fs.watch` (the watcher's own start, a sibling SDK session's watcher, pi's footer git watchers), and rename events in that gap were lost. The result watcher now rescans the results directory once per second while the native watcher is healthy and consumes any file it never reported; the id-based dedup makes a duplicate hit a no-op and the EMFILE/ENOSPC polling fallback is unchanged. `test/unit/multi-session.test.ts` writes each result once instead of re-publishing it every 250 ms. (#21)
+
+## [7.2.1] - 2026-10-16
+
+### Fixed
+
+- A second pi-cohort instance loaded into the same Node process no longer stops the first instance's result watcher or drops its event subscriptions. The extension factory and `registerSubagentNotify` used to call cleanup callbacks a previous instance stored on `globalThis` (`__piSubagentRuntimeCleanup`, `__piSubagentEventUnsubscribes`, `__pi_subagents_notify_unsubscribe__`), which also retired a live session in another SDK runtime; those hooks are gone and each instance now tears down only itself in its own `session_shutdown` handler, which pi emits on reload, new, resume, fork, and quit. (#20)
+
 ## [7.2.0] - 2026-10-11
 
 ### Changed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-cohort",
-  "version": "7.2.0",
+  "version": "7.2.2",
   "description": "Delegate Pi work to focused child agents: code review, scouting, implementation, parallel audits, saved chains, and background jobs.",
   "author": "Jacek Juraszek",
   "license": "MIT",

package/src/extension/fanout-child.ts

@@ -42,6 +42,7 @@ function createChildSafeState(): SubagentState {
 		completionSeen: new Map(),
 		watcher: null,
 		watcherRestartTimer: null,
+		safetyRescanTimer: null,
 		resultFileCoalescer: {
 			schedule: () => false,
 			clear: () => {},

package/src/extension/index.ts

@@ -246,15 +246,6 @@ export default function registerSubagentExtension(pi: ExtensionAPI): void {
 		return;
 	}
 	const globalStore = globalThis as Record<string, unknown>;
-	const runtimeCleanupStoreKey = "__piSubagentRuntimeCleanup";
-	const previousRuntimeCleanup = globalStore[runtimeCleanupStoreKey];
-	if (typeof previousRuntimeCleanup === "function") {
-		try {
-			previousRuntimeCleanup();
-		} catch {
-			// Best effort cleanup for stale timers from an older reload.
-		}
-	}
 
 	ensureAccessibleDir(RUN_STATE_ROOT_DIR, true);
 	ensureAccessibleDir(RESULTS_DIR);
@@ -280,6 +271,7 @@ export default function registerSubagentExtension(pi: ExtensionAPI): void {
 		completionSeen: new Map(),
 		watcher: null,
 		watcherRestartTimer: null,
+		safetyRescanTimer: null,
 		resultFileCoalescer: {
 			schedule: () => false,
 			clear: () => {},
@@ -296,16 +288,6 @@ export default function registerSubagentExtension(pi: ExtensionAPI): void {
 	startResultWatcher();
 	primeExistingResults();
 
-	const runtimeCleanup = () => {
-		stopResultWatcher();
-		clearPendingForegroundControlNotices(state);
-		if (state.poller) {
-			clearInterval(state.poller);
-			state.poller = null;
-		}
-	};
-	globalStore[runtimeCleanupStoreKey] = runtimeCleanup;
-
 	const { ensurePoller, handleStarted, handleComplete, resetJobs } = createAsyncJobTracker(pi, state, ASYNC_DIR);
 	const executor = createSubagentExecutor({
 		pi,
@@ -491,20 +473,8 @@ DIAGNOSTICS:
 	pi.registerTool(tool);
 	registerSlashCommands(pi, state);
 
-	const eventUnsubscribeStoreKey = "__piSubagentEventUnsubscribes";
 	const controlNoticeSeenStoreKey = "__piSubagentVisibleControlNotices";
-	const previousEventUnsubscribes = globalStore[eventUnsubscribeStoreKey];
-	if (Array.isArray(previousEventUnsubscribes)) {
-		for (const unsubscribe of previousEventUnsubscribes) {
-			if (typeof unsubscribe !== "function") continue;
-			try {
-				unsubscribe();
-			} catch {
-				// Best effort cleanup for stale handlers from an older reload.
-			}
-		}
-	}
-	registerSubagentNotify(pi);
+	const unsubscribeNotify = registerSubagentNotify(pi);
 
 	const existingVisibleControlNotices = globalStore[controlNoticeSeenStoreKey];
 	const visibleControlNotices = existingVisibleControlNotices instanceof Set ? existingVisibleControlNotices as Set<string> : new Set<string>();
@@ -518,6 +488,7 @@ DIAGNOSTICS:
 		});
 	};
 	const eventUnsubscribes = [
+		unsubscribeNotify,
 		pi.events.on(SUBAGENT_ASYNC_STARTED_EVENT, handleStarted),
 		pi.events.on(SUBAGENT_ASYNC_COMPLETE_EVENT, handleComplete),
 		pi.events.on(SUBAGENT_CONTROL_EVENT, controlEventHandler),
@@ -527,7 +498,6 @@ DIAGNOSTICS:
 			}
 		}),
 	];
-	globalStore[eventUnsubscribeStoreKey] = eventUnsubscribes;
 
 	pi.on("message_end", (event, ctx) => {
 		if (event.message.role !== "assistant") return;
@@ -591,9 +561,6 @@ DIAGNOSTICS:
 				// Best effort cleanup during shutdown.
 			}
 		}
-		if (globalStore[eventUnsubscribeStoreKey] === eventUnsubscribes) {
-			delete globalStore[eventUnsubscribeStoreKey];
-		}
 		stopResultWatcher();
 		if (state.poller) clearInterval(state.poller);
 		state.poller = null;
@@ -608,9 +575,6 @@ DIAGNOSTICS:
 		slashBridge.dispose();
 		promptTemplateBridge.cancelAll();
 		promptTemplateBridge.dispose();
-		if (globalStore[runtimeCleanupStoreKey] === runtimeCleanup) {
-			delete globalStore[runtimeCleanupStoreKey];
-		}
 		try {
 			if (state.lastUiContext?.hasUI) {
 				state.lastUiContext.ui.setWidget(WIDGET_KEY, undefined);

package/src/runs/background/notify.ts

@@ -40,18 +40,7 @@ interface SubagentResult {
 	totalTasks?: number;
 }
 
-export default function registerSubagentNotify(pi: ExtensionAPI): void {
-	const unsubscribeStoreKey = "__pi_subagents_notify_unsubscribe__";
-	const globalStore = globalThis as Record<string, unknown>;
-	const previousUnsubscribe = globalStore[unsubscribeStoreKey];
-	if (typeof previousUnsubscribe === "function") {
-		try {
-			previousUnsubscribe();
-		} catch {
-			// Best effort cleanup for stale handlers from an older reload.
-		}
-	}
-
+export default function registerSubagentNotify(pi: ExtensionAPI): () => void {
 	const seen = getGlobalSeenMap("__pi_subagents_notify_seen__");
 	const ttlMs = 10 * 60 * 1000;
 
@@ -104,5 +93,5 @@ export default function registerSubagentNotify(pi: ExtensionAPI): void {
 		);
 	};
 
-	globalStore[unsubscribeStoreKey] = pi.events.on(SUBAGENT_ASYNC_COMPLETE_EVENT, handleComplete);
+	return pi.events.on(SUBAGENT_ASYNC_COMPLETE_EVENT, handleComplete);
 }

package/src/runs/background/result-watcher.ts

@@ -14,6 +14,7 @@ import { projectNestedRegistryForRoot, sanitizeSummary } from "../shared/nested-
 
 const WATCHER_RESTART_DELAY_MS = 3000;
 const POLL_INTERVAL_MS = 3000;
+const SAFETY_RESCAN_INTERVAL_MS = 1000;
 
 type ResultWatcherFs = Pick<typeof fs, "existsSync" | "readFileSync" | "unlinkSync" | "readdirSync" | "mkdirSync" | "watch">;
 
@@ -196,9 +197,15 @@ export function createResultWatcher(
 		}
 	};
 
+	const clearSafetyRescan = () => {
+		if (state.safetyRescanTimer) timers.clearInterval(state.safetyRescanTimer);
+		state.safetyRescanTimer = null;
+	};
+
 	const startPollingFallback = (reason: unknown) => {
 		state.watcher?.close();
 		state.watcher = null;
+		clearSafetyRescan();
 		if (state.watcherRestartTimer) return;
 
 		console.error(
@@ -250,9 +257,14 @@ export function createResultWatcher(
 				console.error(`Subagent result watcher failed for '${resultsDir}':`, error);
 				state.watcher?.close();
 				state.watcher = null;
+				clearSafetyRescan();
 				scheduleRestart();
 			});
 			state.watcher.unref?.();
+			if (!state.safetyRescanTimer) {
+				state.safetyRescanTimer = timers.setInterval(primeExistingResults, SAFETY_RESCAN_INTERVAL_MS);
+				state.safetyRescanTimer.unref?.();
+			}
 		} catch (error) {
 			if (shouldFallBackToPolling(error)) {
 				startPollingFallback(error);
@@ -267,6 +279,7 @@ export function createResultWatcher(
 	const stopResultWatcher = () => {
 		state.watcher?.close();
 		state.watcher = null;
+		clearSafetyRescan();
 		if (state.watcherRestartTimer) {
 			timers.clearTimeout(state.watcherRestartTimer);
 			timers.clearInterval(state.watcherRestartTimer);

package/src/shared/types.ts

@@ -718,6 +718,7 @@ export interface SubagentState {
 	completionSeen: Map<string, number>;
 	watcher: FSWatcher | null;
 	watcherRestartTimer: ReturnType<typeof setTimeout> | null;
+	safetyRescanTimer: ReturnType<typeof setInterval> | null;
 	resultFileCoalescer: {
 		schedule(file: string, delayMs?: number): boolean;
 		clear(): void;