pi-cohort 7.1.2 → 7.2.1

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## [7.2.1] - 2026-10-16
+
+### Fixed
+
+- A second pi-cohort instance loaded into the same Node process no longer stops the first instance's result watcher or drops its event subscriptions. The extension factory and `registerSubagentNotify` used to call cleanup callbacks a previous instance stored on `globalThis` (`__piSubagentRuntimeCleanup`, `__piSubagentEventUnsubscribes`, `__pi_subagents_notify_unsubscribe__`), which also retired a live session in another SDK runtime; those hooks are gone and each instance now tears down only itself in its own `session_shutdown` handler, which pi emits on reload, new, resume, fork, and quit. (#20)
+
+## [7.2.0] - 2026-10-11
+
+### Changed
+
+- Children and detached coordinators launch with the originating parent's Node/Pi paths instead of `PATH`; revival keeps that runtime across parent installations. Run records and nested state use durable profile storage without automatic age expiry. Legacy records remain inspectable in their original paths, but revival requires a recorded original runtime and an available session file; missing installations require restoration or a new run. (#19)
+
 ## [7.1.2] - 2026-09-29
 
 ### Fixed

package/README.md

@@ -39,6 +39,8 @@ pi install npm:pi-cohort
 
 That is the only required step.
 
+Children and detached coordinators use the originating parent's resolved Node executable and Pi entry path directly, bypassing `PATH`. Revival keeps that original runtime even when requested from a different parent installation. Custom hosts whose entry cannot be identified as the installed Pi package's declared CLI are unsupported. These paths are not a version lock: replacing Node or Pi in place changes what runs. If the original installation is removed, restore it at the recorded paths or start a new run; there is no fallback to the current parent's installation. Legacy records without an original runtime identity remain inspectable but cannot be revived - start a new run.
+
 ## Execution backend extension API
 
 External execution backends are currently unsupported on Windows, for both foreground and background runs. Native execution remains supported.
@@ -155,6 +157,10 @@ Full reference: agent/chain authoring in [doc/agents-and-chains.md](doc/agents-a
 
 Most installs need zero configuration. Full env/JSON reference: [doc/configuration.md](doc/configuration.md).
 
+Run history lives under the pinned profile's `pi-cohort/` root and has no automatic age expiry. Status listings can grow without bound as history accumulates. To remove history manually, delete only a terminal top-level run directory after confirming its entire subtree has stopped; never delete queued or running state, individual nested records, or shared route files. This removes that directory's status and resume lookup, not separately stored session files or shared routes. Keep those sessions if you need their context; deleting a run directory is not a complete session purge. Storage details: [doc/observability.md](doc/observability.md#files-logs-and-observability).
+
+A queued start that never publishes running status stays unresolved: pi-cohort does not automatically recover or revive it. Start a new run instead.
+
 Parent extension CLI flags (e.g. pi-lens's `--no-autofix`) are forwarded into spawned children by default, so subagents inherit the same tooling behavior you launched with; toggle with [`forwardParentFlags`](doc/configuration.md#forwardparentflags).
 
 Optional companions:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-cohort",
-  "version": "7.1.2",
+  "version": "7.2.1",
   "description": "Delegate Pi work to focused child agents: code review, scouting, implementation, parallel audits, saved chains, and background jobs.",
   "author": "Jacek Juraszek",
   "license": "MIT",
@@ -40,8 +40,8 @@
   "scripts": {
     "check:agents-core": "node scripts/check-agents-core.mjs",
     "test": "npm run test:unit",
-    "test:unit": "node --test test/unit/*.test.ts",
-    "test:integration": "node --import ./test/support/register-loader.mjs --test test/integration/*.test.ts",
+    "test:unit": "node --import ./test/support/isolate-test-env.mjs --test test/unit/*.test.ts",
+    "test:integration": "node --import ./test/support/isolate-test-env.mjs --import ./test/support/register-loader.mjs --test test/integration/*.test.ts",
     "test:all": "npm run check:agents-core && npm run test:unit && npm run test:integration"
   },
   "pi": {

package/src/execution-backend/child-host-controller.ts

@@ -7,18 +7,20 @@ import { ChildHostFrameDecoder, encodeChildHostMessage, type ChildHostMessage }
 import { PI_COHORT_CHILD_HOST_CONFIG } from "./child-host-runtime.ts";
 import { ensureJitiCliPath } from "../runs/shared/jiti-cli.ts";
 import type { ExecutionBackend, ExecutionBackendLease } from "./types.ts";
+import { getPiSpawnCommand, PiRuntimeLaunchError, type PiRuntimeIdentity } from "../runs/shared/pi-spawn.ts";
 
 export interface ChildHostAttempt { readonly attemptId: string; readonly command: string; readonly args: readonly string[]; readonly cwd: string; readonly environment: Readonly<Record<string, string>>; }
 export interface ChildHostExit { readonly status: number | null; readonly signal: string | null; }
 export interface ChildHostController { readonly lease: ExecutionBackendLease; readonly ready: Promise<void>; startAttempt(attempt: ChildHostAttempt): Promise<ChildHostExit>; shutdown(): Promise<void>; releaseObserver(): Promise<void>; }
-export interface ChildHostControllerOptions { readonly backend: ExecutionBackend; readonly runId: string; readonly childId: string; readonly cwd: string; readonly title?: string; readonly signal: AbortSignal; }
-export interface ChildHostControllerDependencies { readonly fs?: typeof fs; readonly ensureJiti?: () => string | undefined; readonly childHostCommand?: () => { command: string; args: readonly string[] }; readonly platform?: NodeJS.Platform; readonly createServer?: typeof net.createServer; }
+export interface ChildHostControllerOptions { readonly runtime: PiRuntimeIdentity; readonly backend: ExecutionBackend; readonly runId: string; readonly childId: string; readonly cwd: string; readonly title?: string; readonly signal: AbortSignal; }
+export interface ChildHostControllerDependencies { readonly fs?: typeof fs; readonly ensureJiti?: (root: string) => string | undefined; readonly childHostCommand?: () => { command: string; args: readonly string[] }; readonly platform?: NodeJS.Platform; readonly createServer?: typeof net.createServer; }
 
 const HOST_ENVIRONMENT_KEYS = ["PATH", "HOME", "TMPDIR", "SystemRoot"] as const;
-function childHostCommand(ensureJiti: () => string | undefined): { command: string; args: readonly string[] } {
-	const jiti = ensureJiti();
-	if (!jiti) throw new Error("upstream jiti for TypeScript execution could not be found; ensure package dependencies are installed");
-	return { command: process.execPath, args: [jiti, path.resolve(path.dirname(fileURLToPath(import.meta.url)), "child-host-runtime.ts")] };
+function childHostCommand(runtime: PiRuntimeIdentity, ensureJiti: (root: string) => string | undefined): { command: string; args: readonly string[] } {
+	getPiSpawnCommand([], runtime);
+	const jiti = ensureJiti(runtime.piPackageRoot);
+	if (!jiti) throw new PiRuntimeLaunchError(`jiti for selected Pi installation ${runtime.piPackageRoot} could not be found`);
+	return { command: runtime.nodeExecPath, args: [jiti, path.resolve(path.dirname(fileURLToPath(import.meta.url)), "child-host-runtime.ts")] };
 }
 function disconnected(phase: string): Error { return new Error(`child host disconnected ${phase}`); }
 function aborted(): Error { return new Error("child host launch aborted"); }
@@ -90,7 +92,7 @@ export async function createChildHostController(options: ChildHostControllerOpti
 					}
 					if (message.kind === "attempt_started" && active?.attemptId === message.attemptId && !active.started) { active.started = true; continue; }
 					if (message.kind === "attempt_spawn_error" && active?.attemptId === message.attemptId) {
-						const pending = active; active = undefined; pending.reject(new Error("child host attempt spawn error")); continue;
+						const pending = active; active = undefined; pending.reject(new PiRuntimeLaunchError(`child host attempt spawn error for ${options.runtime.nodeExecPath} ${options.runtime.piEntryPath}`)); continue;
 					}
 					if (message.kind === "attempt_exited" && active?.attemptId === message.attemptId && active.started) {
 						const pending = active; active = undefined; pending.resolve({ status: message.status, signal: message.signal }); continue;
@@ -115,9 +117,9 @@ export async function createChildHostController(options: ChildHostControllerOpti
 		await new Promise<void>((resolve, reject) => server!.listen(socketPath!, () => resolve()).once("error", reject));
 		fileSystem.chmodSync(socketPath, 0o600);
 		if (options.signal.aborted) throw aborted();
-		const host = dependencies.childHostCommand?.() ?? childHostCommand(dependencies.ensureJiti ?? ensureJitiCliPath);
 		const environment: Record<string, string> = { [PI_COHORT_CHILD_HOST_CONFIG]: configPath };
 		for (const key of HOST_ENVIRONMENT_KEYS) if (process.env[key]) environment[key] = process.env[key]!;
+		const host = dependencies.childHostCommand?.() ?? childHostCommand(options.runtime, dependencies.ensureJiti ?? ensureJitiCliPath);
 		lease = await options.backend.launch({
 			command: host.command,
 			args: host.args,

package/src/extension/doctor.ts

@@ -1,6 +1,7 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
 import { discoverAgentsAll, type AgentSource } from "../agents/agents.ts";
+import type { PiRuntimeIdentity } from "../runs/shared/pi-spawn.ts";
 import { isAsyncAvailable } from "../runs/background/async-execution.ts";
 import { discoverAvailableSkills, type SkillSource } from "../agents/skills.ts";
 import {
@@ -20,12 +21,14 @@ interface DoctorPaths {
 }
 
 interface DoctorDeps {
-	isAsyncAvailable: () => boolean;
+	isAsyncAvailable: (runtime: PiRuntimeIdentity) => boolean;
 	discoverAgentsAll: typeof discoverAgentsAll;
 	discoverAvailableSkills: typeof discoverAvailableSkills;
 }
 
 interface DoctorReportInput {
+	runtime?: PiRuntimeIdentity;
+	runtimeError?: string;
 	cwd: string;
 	config: ExtensionConfig;
 	state: SubagentState;
@@ -189,7 +192,8 @@ export function buildDoctorReport(input: DoctorReportInput): string {
 		"",
 		"Runtime",
 		`- cwd: ${input.cwd}`,
-		lineFromCheck("async support", () => `- async support: ${deps.isAsyncAvailable() ? "available" : "unavailable"}`),
+		...(input.runtimeError ? [`- runtime capture: failed - ${input.runtimeError}`] : input.runtime ? [] : ["- runtime capture: not available"]),
+		lineFromCheck("async support", () => `- async support: ${input.runtime && deps.isAsyncAvailable(input.runtime) ? "available" : "unavailable"}`),
 		...formatSessionLines(input),
 		"",
 		"Filesystem",

package/src/extension/fanout-child.ts

@@ -10,7 +10,7 @@ import { readNestedControlRequests, resolveNestedRouteFromEnv, writeNestedContro
 import { SubagentParams } from "./schemas.ts";
 import { loadConfig } from "./config.ts";
 import { deriveForwardedFlags } from "../runs/shared/forward-flags.ts";
-import type { Details, SubagentState } from "../shared/types.ts";
+import { RUN_STATE_ROOT_DIR, type Details, type SubagentState } from "../shared/types.ts";
 import { emptyGrandTotal } from "./grand-total.ts";
 
 function getSubagentSessionRoot(parentSessionFile: string | null): string {
@@ -19,7 +19,7 @@ function getSubagentSessionRoot(parentSessionFile: string | null): string {
 		const sessionsDir = path.dirname(parentSessionFile);
 		return path.join(sessionsDir, baseName);
 	}
-	return fs.mkdtempSync(path.join(os.tmpdir(), "pi-subagent-session-"));
+	return path.join(RUN_STATE_ROOT_DIR, "sessions");
 }
 
 function expandTilde(p: string): string {

package/src/extension/index.ts

@@ -43,6 +43,7 @@ import {
 	type Details,
 	type SubagentState,
 	ASYNC_DIR,
+	RUN_STATE_ROOT_DIR,
 	DEFAULT_ARTIFACT_CONFIG,
 	GRAND_TOTAL_STATUS_KEY,
 	RESULTS_DIR,
@@ -68,7 +69,7 @@ export { loadConfig } from "./config.ts";
  * If parent session is ~/.pi/agent/sessions/abc123.jsonl,
  * returns ~/.pi/agent/sessions/abc123/ as the base.
  * Callers add runId to create the actual session root: abc123/{runId}/
- * Falls back to a unique temp directory if no parent session.
+ * Without a parent, uses the durable sessions base; callers append the run UUID.
  */
 function getSubagentSessionRoot(parentSessionFile: string | null): string {
 	if (parentSessionFile) {
@@ -76,19 +77,19 @@ function getSubagentSessionRoot(parentSessionFile: string | null): string {
 		const sessionsDir = path.dirname(parentSessionFile);
 		return path.join(sessionsDir, baseName);
 	}
-	return fs.mkdtempSync(path.join(os.tmpdir(), "pi-subagent-session-"));
+	return path.join(RUN_STATE_ROOT_DIR, "sessions");
 }
 
 function expandTilde(p: string): string {
 	return p.startsWith("~/") ? path.join(os.homedir(), p.slice(2)) : p;
 }
 
-/** Create a directory and verify it is actually accessible. */
-function ensureAccessibleDir(dirPath: string): void {
+function ensureAccessibleDir(dirPath: string, durable = false): void {
 	mkdirWithEpermRetry(dirPath);
 	try {
 		fs.accessSync(dirPath, fs.constants.R_OK | fs.constants.W_OK);
-	} catch {
+	} catch (error) {
+		if (durable) throw error;
 		try {
 			fs.rmSync(dirPath, { recursive: true, force: true });
 		} catch {
@@ -245,18 +246,10 @@ export default function registerSubagentExtension(pi: ExtensionAPI): void {
 		return;
 	}
 	const globalStore = globalThis as Record<string, unknown>;
-	const runtimeCleanupStoreKey = "__piSubagentRuntimeCleanup";
-	const previousRuntimeCleanup = globalStore[runtimeCleanupStoreKey];
-	if (typeof previousRuntimeCleanup === "function") {
-		try {
-			previousRuntimeCleanup();
-		} catch {
-			// Best effort cleanup for stale timers from an older reload.
-		}
-	}
 
+	ensureAccessibleDir(RUN_STATE_ROOT_DIR, true);
 	ensureAccessibleDir(RESULTS_DIR);
-	ensureAccessibleDir(ASYNC_DIR);
+	ensureAccessibleDir(ASYNC_DIR, true);
 	cleanupOldChainDirs();
 
 	const config = loadConfig();
@@ -294,16 +287,6 @@ export default function registerSubagentExtension(pi: ExtensionAPI): void {
 	startResultWatcher();
 	primeExistingResults();
 
-	const runtimeCleanup = () => {
-		stopResultWatcher();
-		clearPendingForegroundControlNotices(state);
-		if (state.poller) {
-			clearInterval(state.poller);
-			state.poller = null;
-		}
-	};
-	globalStore[runtimeCleanupStoreKey] = runtimeCleanup;
-
 	const { ensurePoller, handleStarted, handleComplete, resetJobs } = createAsyncJobTracker(pi, state, ASYNC_DIR);
 	const executor = createSubagentExecutor({
 		pi,
@@ -489,20 +472,8 @@ DIAGNOSTICS:
 	pi.registerTool(tool);
 	registerSlashCommands(pi, state);
 
-	const eventUnsubscribeStoreKey = "__piSubagentEventUnsubscribes";
 	const controlNoticeSeenStoreKey = "__piSubagentVisibleControlNotices";
-	const previousEventUnsubscribes = globalStore[eventUnsubscribeStoreKey];
-	if (Array.isArray(previousEventUnsubscribes)) {
-		for (const unsubscribe of previousEventUnsubscribes) {
-			if (typeof unsubscribe !== "function") continue;
-			try {
-				unsubscribe();
-			} catch {
-				// Best effort cleanup for stale handlers from an older reload.
-			}
-		}
-	}
-	registerSubagentNotify(pi);
+	const unsubscribeNotify = registerSubagentNotify(pi);
 
 	const existingVisibleControlNotices = globalStore[controlNoticeSeenStoreKey];
 	const visibleControlNotices = existingVisibleControlNotices instanceof Set ? existingVisibleControlNotices as Set<string> : new Set<string>();
@@ -516,6 +487,7 @@ DIAGNOSTICS:
 		});
 	};
 	const eventUnsubscribes = [
+		unsubscribeNotify,
 		pi.events.on(SUBAGENT_ASYNC_STARTED_EVENT, handleStarted),
 		pi.events.on(SUBAGENT_ASYNC_COMPLETE_EVENT, handleComplete),
 		pi.events.on(SUBAGENT_CONTROL_EVENT, controlEventHandler),
@@ -525,7 +497,6 @@ DIAGNOSTICS:
 			}
 		}),
 	];
-	globalStore[eventUnsubscribeStoreKey] = eventUnsubscribes;
 
 	pi.on("message_end", (event, ctx) => {
 		if (event.message.role !== "assistant") return;
@@ -589,9 +560,6 @@ DIAGNOSTICS:
 				// Best effort cleanup during shutdown.
 			}
 		}
-		if (globalStore[eventUnsubscribeStoreKey] === eventUnsubscribes) {
-			delete globalStore[eventUnsubscribeStoreKey];
-		}
 		stopResultWatcher();
 		if (state.poller) clearInterval(state.poller);
 		state.poller = null;
@@ -606,9 +574,6 @@ DIAGNOSTICS:
 		slashBridge.dispose();
 		promptTemplateBridge.cancelAll();
 		promptTemplateBridge.dispose();
-		if (globalStore[runtimeCleanupStoreKey] === runtimeCleanup) {
-			delete globalStore[runtimeCleanupStoreKey];
-		}
 		try {
 			if (state.lastUiContext?.hasUI) {
 				state.lastUiContext.ui.setWidget(WIDGET_KEY, undefined);