pi-cohort 5.3.0 → 5.3.2

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## [5.3.2] - 2026-09-06
+
+### Fixed
+
+- Extension startup now retries transient `EPERM` failures while creating completed-result and async-run temporary directories, with a strict limit of three attempts and two one-second waits. ([#10](https://github.com/jjuraszek/pi-cohort/issues/10))
+
+## [5.3.1] - 2026-09-01
+
+### Fixed
+
+- Async (detached) subagent runs no longer crash at boot with `Cannot find module 'typebox/compile'` on consumer installs: `typebox` is now a real runtime dependency (`^1.3.11`). This deliberately re-reverses 2.0.0's move of typebox to peerDependencies - that decision's "match pi's bundled packages" rationale only holds for code running under pi's jiti aliases, and the detached runner runs outside them (same reasoning as `jiti` itself being a real dependency). ([#9](https://github.com/jjuraszek/pi-cohort/issues/9))
+- Acceptance evidence checks now treat present-but-empty `changedFiles`, `testsAddedOrUpdated`, `commandsRun`, and `validationOutput` arrays as reported evidence ("ran and touched nothing") instead of rejecting the run with `evidence missing`; an absent field still fails structurally. No-op async worker runs with all criteria passing now reach `checked` status. ([#9](https://github.com/jjuraszek/pi-cohort/issues/9))
+
 ## [5.3.0] - 2026-09-01
 
 ### Changed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-cohort",
-  "version": "5.3.0",
+  "version": "5.3.2",
   "description": "Delegate Pi work to focused child agents: code review, scouting, implementation, parallel audits, saved chains, and background jobs.",
   "author": "Jacek Juraszek",
   "license": "MIT",
@@ -60,8 +60,7 @@
     "@earendil-works/pi-agent-core": "*",
     "@earendil-works/pi-ai": "*",
     "@earendil-works/pi-coding-agent": "*",
-    "@earendil-works/pi-tui": "*",
-    "typebox": "*"
+    "@earendil-works/pi-tui": "*"
   },
   "peerDependenciesMeta": {
     "@earendil-works/pi-agent-core": {
@@ -75,19 +74,16 @@
     },
     "@earendil-works/pi-tui": {
       "optional": true
-    },
-    "typebox": {
-      "optional": true
     }
   },
   "dependencies": {
-    "jiti": "^2.7.0"
+    "jiti": "^2.7.0",
+    "typebox": "^1.3.11"
   },
   "devDependencies": {
     "@earendil-works/pi-agent-core": "^0.74.0",
     "@earendil-works/pi-ai": "^0.74.0",
     "@earendil-works/pi-coding-agent": "^0.74.0",
-    "@earendil-works/pi-tui": "^0.74.0",
-    "typebox": "^1.1.24"
+    "@earendil-works/pi-tui": "^0.74.0"
   }
 }

package/src/extension/index.ts

@@ -24,6 +24,7 @@ import { resolveCurrentSessionId } from "../shared/session-identity.ts";
 import { cleanupOldChainDirs } from "../shared/settings.ts";
 import { clearLegacyResultAnimationTimer, renderWidget, renderSubagentResult } from "../tui/render.ts";
 import { SubagentParams } from "./schemas.ts";
+import { mkdirWithEpermRetry } from "./mkdir-with-retry.ts";
 import { createSubagentExecutor, type SubagentParamsLike } from "../runs/foreground/subagent-executor.ts";
 import { createAsyncJobTracker } from "../runs/background/async-job-tracker.ts";
 import { createResultWatcher } from "../runs/background/result-watcher.ts";
@@ -82,15 +83,9 @@ function expandTilde(p: string): string {
 	return p.startsWith("~/") ? path.join(os.homedir(), p.slice(2)) : p;
 }
 
-/**
- * Create a directory and verify it is actually accessible.
- * On Windows with Azure AD/Entra ID, directories created shortly after
- * wake-from-sleep can end up with broken NTFS ACLs (null DACL) when the
- * cloud SID cannot be resolved without network connectivity. This leaves
- * the directory completely inaccessible to the creating user.
- */
+/** Create a directory and verify it is actually accessible. */
 function ensureAccessibleDir(dirPath: string): void {
-	fs.mkdirSync(dirPath, { recursive: true });
+	mkdirWithEpermRetry(dirPath);
 	try {
 		fs.accessSync(dirPath, fs.constants.R_OK | fs.constants.W_OK);
 	} catch {
@@ -99,7 +94,7 @@ function ensureAccessibleDir(dirPath: string): void {
 		} catch {
 			// Best effort: retry mkdir/access even if cleanup fails.
 		}
-		fs.mkdirSync(dirPath, { recursive: true });
+		mkdirWithEpermRetry(dirPath);
 		fs.accessSync(dirPath, fs.constants.R_OK | fs.constants.W_OK);
 	}
 }

package/src/extension/mkdir-with-retry.ts

@@ -0,0 +1,34 @@
+import { mkdirSync } from "node:fs";
+
+type MkdirWithEpermRetryDeps = {
+	mkdir?: (path: string) => void;
+	wait?: (milliseconds: number) => void;
+};
+
+const RETRY_DELAY_MS = 1000;
+const MAX_ATTEMPTS = 3;
+const waitArray = new Int32Array(new SharedArrayBuffer(4));
+
+function sleep(delayMs: number): void {
+	Atomics.wait(waitArray, 0, 0, delayMs);
+}
+
+export function mkdirWithEpermRetry(dirPath: string, deps: MkdirWithEpermRetryDeps = {}): void {
+	const mkdir = deps.mkdir ?? ((path) => mkdirSync(path, { recursive: true }));
+	const wait = deps.wait ?? sleep;
+
+	for (let attempt = 1; attempt <= MAX_ATTEMPTS; attempt += 1) {
+		try {
+			mkdir(dirPath);
+			return;
+		} catch (error) {
+			if (
+				!(typeof error === "object" && error !== null && "code" in error && error.code === "EPERM") ||
+				attempt === MAX_ATTEMPTS
+			) {
+				throw error;
+			}
+			wait(RETRY_DELAY_MS);
+		}
+	}
+}

package/src/runs/shared/acceptance.ts

@@ -387,10 +387,10 @@ function checkCriteriaSatisfied(criteria: ResolvedAcceptanceGate[], report: Acce
 
 function reportEvidencePresent(report: AcceptanceReport, kind: AcceptanceEvidenceKind): boolean {
 	switch (kind) {
-		case "changed-files": return isStringArray(report.changedFiles) && report.changedFiles.length > 0;
-		case "tests-added": return isStringArray(report.testsAddedOrUpdated) && report.testsAddedOrUpdated.length > 0;
-		case "commands-run": return Array.isArray(report.commandsRun) && report.commandsRun.length > 0;
-		case "validation-output": return isStringArray(report.validationOutput) && report.validationOutput.length > 0;
+		case "changed-files": return isStringArray(report.changedFiles);
+		case "tests-added": return isStringArray(report.testsAddedOrUpdated);
+		case "commands-run": return Array.isArray(report.commandsRun);
+		case "validation-output": return isStringArray(report.validationOutput);
 		case "residual-risks": return isStringArray(report.residualRisks);
 		case "no-staged-files": return report.noStagedFiles === true;
 		case "diff-summary": return typeof report.diffSummary === "string" && report.diffSummary.trim().length > 0;