pi-cohort 5.0.1 → 5.1.0

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## [5.1.0] - 2026-08-06
+
+### Changed
+
+- subagent tool schema shrunk from 18.0KB to 12.4KB serialized: the acceptance
+  override shape (previously inlined 5x, 44% of the schema) now appears in full
+  only at top-level `acceptance`; the 4 nested sites (tasks items, chain steps,
+  parallel members, dynamic fanout template) carry a compact stub. Gate-level
+  `evidence`/`severity` dropped from the schema (still accepted at runtime).
+  Deep acceptance validation moved to the executor boundary with per-site path
+  labels. Nested `acceptance: false` is no longer schema-accepted - use
+  `level: "none"`. Unknown acceptance keys are now rejected everywhere,
+  including saved `.chain.json` chains that previously loaded with the key
+  silently ignored. ([#6](https://github.com/jjuraszek/pi-cohort/issues/6))
+
 ## [5.0.1] - 2026-08-06
 
 ### Changed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-cohort",
-  "version": "5.0.1",
+  "version": "5.1.0",
   "description": "Delegate Pi work to focused child agents: code review, scouting, implementation, parallel audits, saved chains, and background jobs.",
   "author": "Jacek Juraszek",
   "license": "MIT",

package/src/extension/schemas.ts

@@ -65,12 +65,13 @@ const AcceptanceEvidenceKind = Type.String({
 	],
 });
 
+// Gate-level `evidence`/`severity` are accepted at runtime (normalizeCriteria) but omitted
+// from the schema: dead flexibility from a tool call, and the evidence enum is heavy.
+// additionalProperties stays open so inputs carrying them are not provider-rejected.
 const AcceptanceGateSchema = Type.Object({
 	id: Type.String(),
 	must: Type.String(),
-	evidence: Type.Optional(Type.Array(AcceptanceEvidenceKind)),
-	severity: Type.Optional(Type.String({ enum: ["required", "recommended"] })),
-}, { additionalProperties: false });
+}, { additionalProperties: true });
 
 const AcceptanceVerifyCommandSchema = Type.Object({
 	id: Type.String(),
@@ -121,6 +122,21 @@ const AcceptanceOverride = Type.Unsafe({
 	description: "Acceptance: auto if omitted; verified needs cmds.",
 });
 
+// Nested acceptance sites carry a compact stub instead of the full AcceptanceOverride:
+// inlined 5x it was 44% of the serialized schema. The full shape is documented once at
+// top-level `acceptance`; deep validation happens at the executor boundary
+// (validateAcceptanceInput), not provider-side. The object branch keeps a non-empty
+// `properties` because some providers reject bare {type:"object"} in function
+// declarations - the same wall that rules out $defs/$ref (see issue #6).
+// {const:false} is intentionally absent: deprecated shorthand, use level:"none".
+const AcceptanceOverrideStub = Type.Unsafe({
+	anyOf: [
+		{ type: "string", enum: ["auto", "none", "attested", "checked", "verified", "reviewed"] },
+		{ type: "object", additionalProperties: true, properties: { level: { type: "string" } } },
+	],
+	description: "Acceptance override; same shape as top-level acceptance.",
+});
+
 const TaskItem = Type.Object({
 	agent: Type.String(), 
 	task: Type.String(), 
@@ -132,7 +148,7 @@ const TaskItem = Type.Object({
 	progress: Type.Optional(Type.Boolean({ description: "true enables progress.md tracking; omit or false disables." })),
 	model: Type.Optional(Type.String()),
 	skill: Type.Optional(brief(SkillOverride, "Skill override.")),
-	acceptance: Type.Optional(brief(AcceptanceOverride, "Acceptance override.")),
+	acceptance: Type.Optional(AcceptanceOverrideStub),
 });
 
 // Parallel task item (within a parallel step)
@@ -151,7 +167,7 @@ const ParallelTaskSchema = Type.Object({
 	progress: Type.Optional(Type.Boolean({ description: "Enable progress.md tracking." })),
 	model: Type.Optional(Type.String()),
 	skill: Type.Optional(brief(SkillOverride, "Skill override.")),
-	acceptance: Type.Optional(brief(AcceptanceOverride, "Acceptance override.")),
+	acceptance: Type.Optional(AcceptanceOverrideStub),
 });
 
 const DynamicExpandSchema = Type.Object({
@@ -178,7 +194,7 @@ const DynamicParallelTemplateSchema = Type.Object({
 	progress: Type.Optional(Type.Boolean({ description: "Enable progress.md tracking." })),
 	model: Type.Optional(Type.String()),
 	skill: Type.Optional(brief(SkillOverride, "Skill override.")),
-	acceptance: Type.Optional(brief(AcceptanceOverride, "Acceptance override.")),
+	acceptance: Type.Optional(AcceptanceOverrideStub),
 }, { additionalProperties: false });
 
 const DynamicCollectSchema = Type.Object({
@@ -203,7 +219,7 @@ const ChainItem = Type.Object({
 	progress: Type.Optional(Type.Boolean({ description: "Enable progress.md tracking in {chain_dir}" })),
 	model: Type.Optional(Type.String()),
 	skill: Type.Optional(brief(SkillOverride, "Skill override.")),
-	acceptance: Type.Optional(brief(AcceptanceOverride, "Acceptance override.")),
+	acceptance: Type.Optional(AcceptanceOverrideStub),
 	parallel: Type.Optional(Type.Unsafe({
 		anyOf: [
 			Type.Array(ParallelTaskSchema, { minItems: 1 }),

package/src/runs/foreground/subagent-executor.ts

@@ -17,6 +17,7 @@ import { recordSyncCost, renderGrandTotal, sumNestedCost } from "../../extension
 import { resolveModelCandidate } from "../shared/model-fallback.ts";
 import { aggregateParallelOutputs } from "../shared/parallel-utils.ts";
 import { recordRun } from "../shared/run-history.ts";
+import { validateAcceptanceInput } from "../shared/acceptance.ts";
 import {
 	buildChainInstructions,
 	writeInitialProgressFile,
@@ -858,6 +859,33 @@ function validateExecutionInput(
 		}
 	}
 
+	// Nested acceptance sites only carry a compact stub in the tool schema (see
+	// AcceptanceOverrideStub in extension/schemas.ts); this is the deep-validation boundary.
+	const acceptanceErrors: string[] = [
+		...validateAcceptanceInput(params.acceptance, "acceptance"),
+	];
+	for (const [i, task] of (params.tasks ?? []).entries()) {
+		acceptanceErrors.push(...validateAcceptanceInput(task.acceptance, `tasks[${i}].acceptance`));
+	}
+	for (const [i, rawStep] of (params.chain ?? []).entries()) {
+		const step = rawStep as ChainStep;
+		acceptanceErrors.push(...validateAcceptanceInput((rawStep as { acceptance?: unknown }).acceptance, `chain[${i}].acceptance`));
+		if (isParallelStep(step)) {
+			for (const [j, member] of step.parallel.entries()) {
+				acceptanceErrors.push(...validateAcceptanceInput(member.acceptance, `chain[${i}].parallel[${j}].acceptance`));
+			}
+		} else if (isDynamicParallelStep(step)) {
+			acceptanceErrors.push(...validateAcceptanceInput(step.parallel.acceptance, `chain[${i}].parallel.acceptance`));
+		}
+	}
+	if (acceptanceErrors.length > 0) {
+		return {
+			content: [{ type: "text", text: `Invalid acceptance input:\n${acceptanceErrors.map((error) => `- ${error}`).join("\n")}` }],
+			isError: true,
+			details: { mode: hasChain ? "chain" as const : hasTasks ? "parallel" as const : "single" as const, results: [] },
+		};
+	}
+
 	return null;
 }
 

package/src/runs/shared/acceptance.ts

@@ -131,6 +131,8 @@ function explicitAcceptanceCanDisable(explicit: AcceptanceConfig): boolean {
 	return explicit.level === "none" && typeof explicit.reason === "string" && explicit.reason.trim().length > 0;
 }
 
+const KNOWN_ACCEPTANCE_KEYS = new Set(["level", "criteria", "evidence", "verify", "review", "stopRules", "reason"]);
+
 export function validateAcceptanceInput(input: unknown, pathLabel = "acceptance"): string[] {
 	const errors: string[] = [];
 	if (input === undefined) return errors;
@@ -144,6 +146,11 @@ export function validateAcceptanceInput(input: unknown, pathLabel = "acceptance"
 		return errors;
 	}
 	const value = input as Record<string, unknown>;
+	for (const key of Object.keys(value)) {
+		if (!KNOWN_ACCEPTANCE_KEYS.has(key)) {
+			errors.push(`${pathLabel}.${key} is not a recognized acceptance field (known: level, criteria, evidence, verify, review, stopRules, reason).`);
+		}
+	}
 	if (value.level !== undefined && (typeof value.level !== "string" || !VALID_LEVELS.has(value.level as AcceptanceLevel))) {
 		errors.push(`${pathLabel}.level must be one of auto, none, attested, checked, verified, reviewed.`);
 	}