pi-code 1.0.53 → 1.0.54

package/extensions/commands.ts

@@ -174,10 +174,19 @@ export function shellExecutionDisabled(cwd: string, home: string, trusted: boole
   if (readManagedSettings().disableSkillShellExecution === true) return true
   const files = claudeSettingsChain(cwd, home, trusted)
   return files.some((file) => {
+    let raw: string
     try {
-      return (JSON.parse(fs.readFileSync(file, 'utf-8')) as Record<string, unknown>).disableSkillShellExecution === true
+      raw = fs.readFileSync(file, 'utf-8')
     } catch {
-      return false // missing or invalid file: not a policy statement
+      return false // no such file: genuinely not a policy statement
+    }
+    try {
+      return (JSON.parse(raw) as Record<string, unknown>).disableSkillShellExecution === true
+    } catch {
+      // Present but unreadable: the user may believe this file disables skill shells, so
+      // say so rather than silently leaving them enabled.
+      console.warn(`pi-code: ignoring ${file}: not valid JSON; skill shell execution stays as the other settings leave it`)
+      return false
     }
   })
 }

package/extensions/git-checkpoint.ts

@@ -210,7 +210,7 @@ export default function gitCheckpointExtension(pi: ExtensionAPI) {
     }
     // Written on every start, so repos that predate the sidecar pick it up too.
     rememberWorkTree(shadowDir, ctx.cwd)
-    await mirrorLocalExcludes(ctx.cwd)
+    await mirrorLocalExcludes(ctx)
   }
 
   /** git reads ignore rules from the tree's .gitignore files, the user's global excludes,
@@ -219,7 +219,8 @@ export default function gitCheckpointExtension(pi: ExtensionAPI) {
    * would be snapshotted and restored. Mirror it into the shadow on every start; the
    * global excludes stay untouched (core.excludesFile is single-valued, so pointing it
    * at the repo file would replace them). */
-  async function mirrorLocalExcludes(cwd: string): Promise<void> {
+  async function mirrorLocalExcludes(ctx: ExtensionContext): Promise<void> {
+    const cwd = ctx.cwd
     if (!shadowDir) return
     // Resolved through git so a linked worktree maps to its common dir; outside a repo
     // git exits 128 and there is nothing to mirror.
@@ -233,8 +234,10 @@ export default function gitCheckpointExtension(pi: ExtensionAPI) {
       } else {
         fs.rmSync(target, { force: true })
       }
-    } catch {
-      // A failed mirror only means local excludes are not honored this session.
+    } catch (error) {
+      // Without the mirror, files the user excluded locally are snapshotted into the
+      // checkpoint store and restored by /rewind, so this is not a silent fallback.
+      ctx.ui.notify(`Checkpoints cannot honor this repository's .git/info/exclude: ${error instanceof Error ? error.message : String(error)}`, 'warning')
     }
   }
 

package/extensions/mcp/oauth-flow.ts

@@ -28,6 +28,12 @@ function asOAuthRequiredError(name: string, error: unknown): OAuthRequiredError
  * (stored-token) connects do not pass through here and stay fully parallel. */
 let oauthQueue: Promise<unknown> = Promise.resolve()
 
+/** Test seam: the queue is module state that outlives a test, so one login left pending
+ * would serialize every later login in the same file behind it. */
+export function resetOAuthQueue(): void {
+  oauthQueue = Promise.resolve()
+}
+
 export function serializeInteractiveOAuth<T>(run: () => Promise<T>): Promise<T> {
   const result = oauthQueue.then(run, run)
   oauthQueue = result.then(

package/extensions/mcp/policy.ts

@@ -97,11 +97,19 @@ function parsePolicyEntry(entry: unknown): McpPolicyEntry | undefined {
  * honored scope sets the key; an empty list is an explicit lockdown (deny all). */
 export function mcpAllowDeny(scopeFiles: string[] = [], managedFile: string = managedSettingsFile()): McpPolicy {
   const read = (file: string): Record<string, unknown> => {
+    let raw: string
     try {
-      const parsed = JSON.parse(fs.readFileSync(file, 'utf-8'))
+      raw = fs.readFileSync(file, 'utf-8')
+    } catch {
+      return {} // no such file: genuinely no policy
+    }
+    try {
+      const parsed = JSON.parse(raw)
       return parsed && typeof parsed === 'object' ? parsed : {}
     } catch {
-      // Missing or invalid file contributes no policy.
+      // Present but unreadable: its allow and deny lists are not in force, and a deny list
+      // silently dropped leaves every server allowed.
+      console.warn(`pi-code-mcp: ignoring ${file}: not valid JSON; its MCP allow and deny lists are not applied`)
       return {}
     }
   }

package/extensions/mcp/transport.ts

@@ -336,9 +336,11 @@ export async function connectWithRetries(name: string, config: ServerConfig, aut
  * environment helperEnv built. It runs through the platform shell (/bin/sh; Git Bash
  * or PowerShell on Windows). A failure, a 10s timeout, or a machine with no shell
  * yields no extra headers rather than blocking the connection. */
-function runHeadersHelper(command: string, env: NodeJS.ProcessEnv): Promise<Record<string, string>> {
+export function runHeadersHelper(command: string, env: NodeJS.ProcessEnv, resolve_ = resolveShell): Promise<Record<string, string>> {
   return new Promise((resolve) => {
-    const shell = resolveShell(undefined)
+    // The resolver is a parameter so a test can drive both outcomes on any platform:
+    // stubbing the platform cannot produce a shell-less host on a machine that has one.
+    const shell = resolve_(undefined)
     if (!shell) {
       resolve({})
       return

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-code",
-  "version": "1.0.53",
+  "version": "1.0.54",
   "description": "Claude Code experience for the pi coding agent: reads your .claude config (rules, commands, skills, hooks, output styles, MCP servers, agents) and adds todo, checkpoints, memory, web, subagents, and goals",
   "keywords": [
     "pi",