pi-cockpit 0.6.0 → 0.7.0

package/src/footer.ts

@@ -42,7 +42,21 @@ export function emptyTotals(): UsageTotals {
 	return { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, cost: 0, latestCacheHitRate: undefined };
 }
 
-let usageCache: { key: string; totals: UsageTotals } | undefined;
+interface UsageCacheEntry {
+	key: string;
+	totals: UsageTotals;
+	computedAt: number;
+}
+
+let usageCache: UsageCacheEntry | undefined;
+// Static mode lowers the token refresh cadence. The getter reads live config so
+// a toggle applies on the next render without re-registering.
+let usageThrottleMs: (() => number) | undefined;
+
+/** Set the wall-clock throttle for token totals; 0/undefined means uncapped. */
+export function setUsageThrottle(getMs: () => number): void {
+	usageThrottleMs = getMs;
+}
 
 function entryIdentity(entry: unknown): string {
 	const e = entry as {
@@ -77,9 +91,18 @@ export function invalidateUsageCache(): void {
 }
 
 // Sum assistant-message usage across session entries (shape: entry.message.usage).
-export function getUsageTotals(entries: readonly unknown[]): UsageTotals {
+export function getUsageTotals(entries: readonly unknown[], now: number = Date.now()): UsageTotals {
 	const key = entriesKey(entries);
 	if (usageCache && usageCache.key === key) return usageCache.totals;
+	const throttleMs = Math.max(0, usageThrottleMs?.() ?? 0);
+	if (throttleMs > 0 && usageCache && now - usageCache.computedAt < throttleMs) {
+		// Within the window: keep the previous totals on screen. The cache entry is
+		// deliberately left untouched (key and computedAt stay put) so a later call
+		// past the window with these same entries still mismatches the cached key
+		// and recomputes — rebinding the new key here would pin stale totals to it
+		// forever, since the key-match fast path above would then win every time.
+		return usageCache.totals;
+	}
 
 	const t = emptyTotals();
 	for (const e of entries) {
@@ -98,7 +121,7 @@ export function getUsageTotals(entries: readonly unknown[]): UsageTotals {
 			}
 		}
 	}
-	usageCache = { key, totals: t };
+	usageCache = { key, totals: t, computedAt: now };
 	return t;
 }
 

package/src/icons.ts

@@ -14,6 +14,8 @@ export interface IconGlyphs {
 	arrow: string;
 	/** Points at a dependency/upstream ("blocked by", "waits on"). */
 	depArrow: string;
+	/** Creator-to-assignee transfer indicator in actor labels. */
+	transferArrow: string;
 	/** Tree connectors. Routed through the glyph set so ascii mode stays ascii. */
 	treeBranch: string;
 	treeLast: string;
@@ -60,6 +62,7 @@ const NERD_GLYPHS: IconGlyphs = {
 	barPending: "░",
 	arrow: "»",
 	depArrow: "←",
+	transferArrow: "→",
 	treeBranch: "├─",
 	treeLast: "└─",
 	treeVertical: "│ ",
@@ -92,7 +95,8 @@ const ASCII_GLYPHS: IconGlyphs = {
 	barPending: "-",
 	arrow: ">",
 	depArrow: "<-",
-	treeBranch: "|-",
+	transferArrow: "->",
+	treeBranch: "|",
 	treeLast: "`-",
 	treeVertical: "| ",
 	treeSpace: "  ",

package/src/index.ts

@@ -12,10 +12,11 @@ import { renderBashBgSummary } from "./bash-bg-widget.ts";
 import { registerQuietTools } from "./quiet-tools.ts";
 import { ensureThinkingFolded, readHideThinkingBlock } from "./thinking-fold.ts";
 import { ThinkingFoldTimer } from "./thinking-timer.ts";
+import { shouldAnimateFrames, shouldAnimateSidebar, shouldRunTick, type TickPolicyState } from "./tick-policy.ts";
 import { TodoStore } from "./todo-store.ts";
 import { makeTodoWidget, makeAgentWidget, terminalRows } from "./stack-widget.ts";
 import { activeThemeName, ThemePicker } from "./theme-picker.ts";
-import { getUsageTotals, invalidateUsageCache, renderFooter, type PaintTheme, type WidthUtils } from "./footer.ts";
+import { getUsageTotals, invalidateUsageCache, renderFooter, setUsageThrottle, type PaintTheme, type WidthUtils } from "./footer.ts";
 import { collectExtensionStatuses } from "./extension-status.ts";
 import { ANIMATION_PERIOD_MS, resolveGlyphs, spinFrame } from "./icons.ts";
 import { ensureConfigExists, loadConfig, saveConfig } from "./config.ts";
@@ -47,6 +48,8 @@ const BASH_BG_OVERLAY_KEY = "alt+j";
 const SIDEBAR_RESIZE_KEY = "ctrl+shift+r";
 const COCKPIT_STATUS_KEY = "cockpit";
 const WIDTH_POLL_INTERVAL_MS = 250;
+// Static mode keeps token totals fresh enough without recomputing on every message.
+const USAGE_REFRESH_THROTTLE_MS = 10_000;
 // Quiet mode's rename of pi's hidden-thinking label. The live thinking timer
 // derives its final "thoughts · 8.4s" labels from the same word.
 const QUIET_THINKING_LABEL = "thoughts";
@@ -80,6 +83,33 @@ function formatCwd(cwd: string): string {
 	return rel === "" ? "~" : `~${sep}${rel}`;
 }
 
+function isRecord(value: unknown): value is Record<string, unknown> {
+	return typeof value === "object" && value !== null;
+}
+
+function isStartedPayload(value: unknown): value is StartedPayload {
+	return isRecord(value)
+		&& typeof value.correlationId === "string"
+		&& value.correlationId.length > 0
+		&& typeof value.agent === "string";
+}
+
+function isProgressPayload(value: unknown): value is MessagePayload {
+	return isRecord(value)
+		&& value.isSend !== true
+		&& value.isInteraction !== true
+		&& typeof value.correlationId === "string"
+		&& value.correlationId.length > 0;
+}
+
+function isCompletePayload(value: unknown): value is CompletePayload {
+	return isRecord(value)
+		&& typeof value.correlationId === "string"
+		&& value.correlationId.length > 0
+		&& typeof value.exitCode === "number"
+		&& Number.isFinite(value.exitCode);
+}
+
 export default function (pi: ExtensionAPI): void {
 	const agents = new AgentsStore();
 	const bashBg = new BashBgStore();
@@ -92,7 +122,8 @@ export default function (pi: ExtensionAPI): void {
 	let dockEffectiveVisible = false;
 	let surfaceState: CockpitSurfaceState = "disabled";
 	let running = false;
-	const activeTools = new Map<string, string>();
+	let runningStartedAt: number | undefined;
+	const activeTools = new Map<string, { name: string; startedAt: number }>();
 	let tick: ReturnType<typeof setInterval> | undefined;
 	// Persisted rather than toasted: a config that failed to load silently downgrades
 	// the whole session to defaults, so it belongs in a slot that does not scroll away.
@@ -109,14 +140,15 @@ export default function (pi: ExtensionAPI): void {
 	// AgentSession construction — before renderInitialMessages runs.
 	ensureConfigExists();
 	config = loadConfig();
+	// Reads config live, so toggling static mode re-throttles without re-registering.
+	setUsageThrottle(() => (config.staticMode ? USAGE_REFRESH_THROTTLE_MS : 0));
 	if (config.quietMode) {
 		registerQuietTools(pi, () => config);
 		quietToolsRegistered = true;
 	}
 
-	// Live labels for folded thinking rows: a spinner with running elapsed
-	// time while the model thinks, then the actual duration once it settles.
-	// Pi owns the fold; this only renames the label it already renders.
+	// Live elapsed for folded thinking rows — no spinner, just a running timer
+	// while the model thinks, then the settled duration. Pi owns the fold.
 	const thinkingTimer = new ThinkingFoldTimer({
 		getTui: () => capturedTui,
 		requestRender: () => {
@@ -130,6 +162,7 @@ export default function (pi: ExtensionAPI): void {
 		getGlyphs: () => resolveGlyphs(config.icons.mode),
 		isThinkingHidden: () => (lastCtx ? readHideThinkingBlock(lastCtx.cwd) : false),
 		isEnabled: () => config.enabled,
+		isStatic: () => config.staticMode,
 		setGlobalLabel: (label) => {
 			const ctx = lastCtx;
 			if (!ctx || !isTuiContext(ctx)) return;
@@ -153,16 +186,20 @@ export default function (pi: ExtensionAPI): void {
 				ctx.ui.setStatus(COCKPIT_STATUS_KEY, undefined);
 				return;
 			}
+			const activeTool = [...activeTools.values()].at(-1);
 			const state: AmbientState = {
 				todos: todos.snapshot(),
 				agents: agents.snapshot(),
 				jobs: bashBg.snapshot(),
 				running,
 				cwd: formatCwd(ctx.sessionManager.getCwd()),
-				activeTool: [...activeTools.values()].at(-1),
+				activeTool: activeTool?.name,
+				workingStartedAt: activeTool?.startedAt ?? runningStartedAt,
+				hideLiveDuration: config.staticMode,
+				separator: ` ${g.separator} `,
 			};
 			ctx.ui.setWorkingMessage(workingMessage(state));
-			ctx.ui.setTitle(titleFor(state, { ok: g.check, fail: g.cross }));
+			ctx.ui.setTitle(titleFor(state, { ok: g.check, fail: g.cross }, g.separator));
 			ctx.ui.setStatus(COCKPIT_STATUS_KEY, statusText(configProblem, g.blocked));
 		} catch {
 			// ambient surfaces are best-effort; never let them break a render
@@ -178,18 +215,39 @@ export default function (pi: ExtensionAPI): void {
 			// tui may be gone between sessions
 		}
 	};
+	const policy = (): TickPolicyState => ({
+		staticMode: config.staticMode,
+		running,
+		bashActive: bashBg.hasActive(),
+		lingering: agents.hasLingering(),
+		ticking: tick !== undefined,
+	});
 	// True only while a redraw loop is actually running; widgets use it to avoid
 	// painting a frozen spinner frame that reads as a hung UI.
-	const isAnimating = (): boolean => tick !== undefined && (running || bashBg.hasActive());
+	const isAnimating = (): boolean => shouldAnimateFrames(policy());
 	// A failed agent lingers for a while after it completes, and the loop has to
 	// outlive the session that produced it — otherwise the row would sit there
-	// until some unrelated event happened to expire it.
-	const needsTick = (): boolean => running || bashBg.hasActive() || agents.hasLingering();
+	// until some unrelated event happened to expire it. Static mode still keeps
+	// that loop alive: failure retention is correctness, not animation. What it
+	// drops is the running/job churn that used to repaint every quarter second.
+	const needsTick = (): boolean => shouldRunTick(policy());
 	const startTick = (): void => {
 		if (tick) return;
 		tick = setInterval(() => {
-			if (needsTick()) req();
-			else syncTick();
+			if (needsTick()) {
+				// Static mode keeps the loop alive only so lingering rows can expire
+				// (prune is read-driven). The rows themselves are static, so skip the
+				// full repaint and repaint just once when a prune removed something.
+				if (config.staticMode) {
+					const before = agents.size;
+					agents.snapshot();
+					if (agents.size !== before) req();
+				} else {
+					req();
+				}
+			} else {
+				syncTick();
+			}
 		}, ANIMATION_PERIOD_MS);
 		tick.unref?.();
 	};
@@ -267,6 +325,7 @@ export default function (pi: ExtensionAPI): void {
 		}
 	};
 
+
 	const clearWidgets = (ctx: ExtensionContext): void => {
 		ctx.ui.setWidget(STACK_WIDGET_KEY, undefined);
 		ctx.ui.setWidget(AGENT_WIDGET_KEY, undefined);
@@ -319,6 +378,7 @@ export default function (pi: ExtensionAPI): void {
 			getAgents: () => agents.snapshot(),
 			getJobs: () => bashBg.snapshot(),
 			getConfig: () => config,
+			shouldAnimate: () => shouldAnimateSidebar(policy()),
 			onVisibilityChange: (visible) => {
 				dockEffectiveVisible = visible;
 				const activeCtx = lastCtx;
@@ -366,6 +426,7 @@ export default function (pi: ExtensionAPI): void {
 			// Leaving these set would strand a title and a status line owned by an
 			// extension that is no longer painting anything.
 			ctx.ui.setWorkingMessage(undefined);
+			ctx.ui.setWorkingIndicator();
 			ctx.ui.setStatus(COCKPIT_STATUS_KEY, undefined);
 		} catch {
 			// ambient surfaces are best-effort
@@ -380,15 +441,30 @@ export default function (pi: ExtensionAPI): void {
 			uninstallUi(ctx);
 			return;
 		}
+		ctx.ui.setWorkingIndicator({ frames: [] });
 		ctx.ui.setFooter((tui, theme, footerData) => {
 			capturedTui = tui;
 			let observedWidth = tui.terminal.columns;
 			const widthTimer = setInterval(() => {
-				const nextWidth = tui.terminal.columns;
-				if (!Number.isFinite(nextWidth) || nextWidth <= 0 || nextWidth === observedWidth) return;
-				observedWidth = nextWidth;
-				tui.invalidate();
-				tui.requestRender(true);
+				try {
+					const nextWidth = tui.terminal.columns;
+					if (!Number.isFinite(nextWidth) || nextWidth <= 0 || nextWidth === observedWidth) return;
+					observedWidth = nextWidth;
+					// Deliberately skip tui.invalidate(): upstream pi 0.83.0 has a bug
+					// where ToolExecutionComponent.updateDisplay() can push undefined
+					// into Container.children (renderer returns undefined for a
+					// "working" tool).  Container.invalidate() then does
+					// `child.invalidate?.()` on that undefined child → TypeError →
+					// uncaughtException in this timer callback → pi process exit.
+					// requestRender(true) already clears previousLines and forces a
+					// full re-render with the new width, which is all we need here.
+					tui.requestRender(true);
+				} catch {
+					// Last-resort guard: a synchronous exception in this timer
+					// callback would become an uncaughtException and kill the pi
+					// process.  Swallow it so the session survives; the next tick
+					// will retry.
+				}
 			}, WIDTH_POLL_INTERVAL_MS);
 			widthTimer.unref?.();
 			const unsubscribeBranch = footerData.onBranchChange(() => tui.requestRender());
@@ -409,6 +485,7 @@ export default function (pi: ExtensionAPI): void {
 							glyphs,
 							spin: spinFrame(glyphs, now, isAnimating()),
 							now,
+							hideLiveDuration: config.staticMode,
 						},
 					)[0];
 					return renderFooter({
@@ -444,16 +521,19 @@ export default function (pi: ExtensionAPI): void {
 	};
 
 	// --- teammate lifecycle (custom event bus; subscribed once for the extension lifetime) ---
-	pi.events.on(TEAMMATE_STARTED_EVENT, (d) => {
-		agents.applyStarted(d as StartedPayload);
+	pi.events.on(TEAMMATE_STARTED_EVENT, (payload) => {
+		if (!isStartedPayload(payload)) return;
+		agents.applyStarted(payload);
 		req();
 	});
-	pi.events.on(TEAMMATE_MESSAGE_EVENT, (d) => {
-		agents.applyMessage(d as MessagePayload);
+	pi.events.on(TEAMMATE_MESSAGE_EVENT, (payload) => {
+		if (!isProgressPayload(payload)) return;
+		agents.applyMessage(payload);
 		req();
 	});
-	pi.events.on(TEAMMATE_COMPLETE_EVENT, (d) => {
-		agents.applyComplete(d as CompletePayload);
+	pi.events.on(TEAMMATE_COMPLETE_EVENT, (payload) => {
+		if (!isCompletePayload(payload)) return;
+		agents.applyComplete(payload);
 		// A failure that arrives after the session went idle still needs a loop to
 		// expire it, so the tick is re-evaluated rather than assumed to be running.
 		syncTick();
@@ -478,7 +558,7 @@ export default function (pi: ExtensionAPI): void {
 
 	// --- foreground tool label + todo changes ---
 	pi.on("tool_execution_start", (e) => {
-		activeTools.set(e.toolCallId, e.toolName);
+		activeTools.set(e.toolCallId, { name: e.toolName, startedAt: Date.now() });
 		req();
 	});
 	pi.on("tool_execution_end", (e, ctx) => {
@@ -557,6 +637,7 @@ export default function (pi: ExtensionAPI): void {
 		pi.events.emit(COCKPIT_UI_OWNERSHIP_EVENT, released);
 		lastCtx = undefined;
 		running = false;
+		runningStartedAt = undefined;
 		activeTools.clear();
 		thinkingTimer.reset();
 		invalidateUsageCache();
@@ -567,26 +648,28 @@ export default function (pi: ExtensionAPI): void {
 
 	pi.on("agent_start", () => {
 		running = true;
+		runningStartedAt = Date.now();
 		startTick();
 		req();
 	});
 	pi.on("agent_end", () => {
 		running = false;
+		runningStartedAt = undefined;
 		activeTools.clear();
 		thinkingTimer.stop();
 		syncTick();
 		req();
 	});
 
-	// --- live labels for folded thinking rows ---
+	// --- live elapsed for folded thinking rows ---
 	pi.on("message_update", (e) => {
 		thinkingTimer.onAssistantMessageEvent(e.assistantMessageEvent);
 	});
 
 	// --- redraw triggers for the footer's live data ---
 	pi.on("message_end", (e, ctx) => {
-		// Settle an interrupted thinking run: message_end fires for aborted
-		// and failed messages too, while the row is still mounted.
+		// Settle an interrupted thinking run: message_end fires for aborted and
+		// failed messages too, while the row is still mounted.
 		if (e.message.role === "assistant") thinkingTimer.onAssistantMessageEnd();
 		invalidateUsageCache();
 		if (isTuiContext(ctx)) req();
@@ -609,6 +692,7 @@ export default function (pi: ExtensionAPI): void {
 				close: () => done(undefined),
 				theme,
 				glyphs: resolveGlyphs(config.icons.mode),
+				hideLiveDuration: config.staticMode,
 				getTerminalRows: () => terminalRows(tui),
 			}), {
 			overlay: true,
@@ -715,6 +799,23 @@ export default function (pi: ExtensionAPI): void {
 		req();
 	};
 
+	const setStaticMode = (target: boolean): boolean => {
+		if (config.staticMode === target) return true;
+		config = { ...config, staticMode: target };
+		const result = saveConfig(config);
+		if (!result.ok) {
+			configProblem = `static mode save failed: ${result.error ?? "unknown error"}`;
+		} else if (configProblem?.startsWith("static mode save failed:")) {
+			configProblem = undefined;
+		}
+		// Restart or stop the animation loop for the new mode: turning static on
+		// must kill a running tick, turning it off must revive one mid-run.
+		syncTick();
+		thinkingTimer.syncMode();
+		req();
+		return result.ok;
+	};
+
 	pi.registerShortcut(BASH_BG_OVERLAY_KEY, {
 		description: "Open background Bash jobs — live status, command, cwd, duration and output tail",
 		async handler(ctx) {
@@ -741,6 +842,7 @@ export default function (pi: ExtensionAPI): void {
 			const candidates = [
 				"quiet", "quiet on", "quiet off", "bg", "jobs", "todo", "todo expand", "todo collapse",
 				"sidebar", "sidebar auto", "sidebar on", "sidebar off", "sidebar resize",
+				"static", "static on", "static off",
 			];
 			const matches = candidates.filter((c) => c.startsWith(query));
 			return matches.length > 0 ? matches.map((c) => ({ value: c, label: c })) : null;
@@ -795,6 +897,28 @@ export default function (pi: ExtensionAPI): void {
 				req();
 				return;
 			}
+			if (action === "static" || action === "static toggle") {
+				const ok = setStaticMode(!config.staticMode);
+				ctx.ui.notify(
+					ok
+						? `Cockpit static mode ${config.staticMode ? "on — live updates reduced" : "off"}`
+						: "Cockpit static mode kept for this session; save failed",
+					ok ? "info" : "warning",
+				);
+				return;
+			}
+			if (action === "static on" || action === "static off") {
+				const target = action === "static on";
+				if (config.staticMode === target) return;
+				const ok = setStaticMode(target);
+				ctx.ui.notify(
+					ok
+						? `Cockpit static mode ${target ? "on — live updates reduced" : "off"}`
+						: "Cockpit static mode kept for this session; save failed",
+					ok ? "info" : "warning",
+				);
+				return;
+			}
 			await openSettings(ctx);
 		},
 	});
@@ -821,6 +945,7 @@ export default function (pi: ExtensionAPI): void {
 			const apply = (key: string): void => {
 				const wasEnabled = config.enabled;
 				const wasQuiet = config.quietMode;
+				const wasStatic = config.staticMode;
 				const wasSidebarMode = config.sidebar.mode;
 				if (key === "theme") {
 					// Delegate: the picker previews live and reverts on Esc, neither of
@@ -870,6 +995,10 @@ export default function (pi: ExtensionAPI): void {
 				if (wasQuiet !== config.quietMode) {
 					applyQuietMode(ctx, wasQuiet, config.quietMode);
 				}
+				if (wasStatic !== config.staticMode) {
+					syncTick();
+					thinkingTimer.syncMode();
+				}
 				req();
 			};
 			const ui = {