pi-chrome 0.15.12 → 0.15.14

package/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 All notable user-facing changes to `pi-chrome`.
 
+## 0.15.14 — 2026-05-14
+
+- **Clearer consent wait state.** After the Chrome approval page opens, Pi now says “Approve or deny the Chrome approval page to continue” instead of looking stuck at the launch step.
+
+## 0.15.13 — 2026-05-14
+
+- **Fix Chrome-side consent hang.** `/chrome authorize` now launches the browser consent page as a short command, then polls for the decision. This avoids holding one long extension command open while the user reads/clicks the page, which could leave Pi stuck at “Opening Chrome approval page…”.
+
 ## 0.15.12 — 2026-05-14
 
 - **Docs accuracy.** Clarified that the bundled Chrome extension currently polls `127.0.0.1:17318`; custom bridge ports are not supported without editing/reloading the extension source. Also softened the unpacked-extension rationale to avoid overstating Web Store limitations and fixed stale strict-CSP guidance for `chrome_evaluate`.

package/extensions/chrome-profile-bridge/browser-extension/manifest.json

@@ -1,7 +1,7 @@
 {
   "manifest_version": 3,
   "name": "Pi Chrome Connector",
-  "version": "0.15.12",
+  "version": "0.15.14",
   "description": "Lets Pi control tabs in Chrome via a local connector at 127.0.0.1.",
   "permissions": [
     "tabs",

package/extensions/chrome-profile-bridge/browser-extension/service_worker.js

@@ -4,7 +4,8 @@ const POLL_ERROR_BACKOFF_MS = 2000;
 const CONSENT_TIMEOUT_MS = 5 * 60 * 1000;
 let polling = false;
 let nextConsentRequestId = 1;
-const pendingConsentRequests = new Map(); // id -> { request, resolve, timer, tabId }
+const pendingConsentRequests = new Map(); // id -> { request, timer, tabId }
+const completedConsentRequests = new Map(); // id -> { approved, reason, id, decidedAt }
 
 // =================== Chrome input (CDP) layer ===================
 // Tracks which tabs we have attached chrome.debugger to.
@@ -607,35 +608,45 @@ function consentRequestSnapshot(id, request) {
   };
 }
 
+function completeBrowserConsent(id, approved, reason, closeTab = true) {
+  const pending = pendingConsentRequests.get(id);
+  if (!pending) return completedConsentRequests.get(id) || null;
+  pendingConsentRequests.delete(id);
+  clearTimeout(pending.timer);
+  if (closeTab && pending.tabId) chrome.tabs.remove(pending.tabId).catch(() => undefined);
+  const result = { approved, reason, id, decidedAt: Date.now() };
+  completedConsentRequests.set(id, result);
+  setTimeout(() => completedConsentRequests.delete(id), 10 * 60 * 1000);
+  return result;
+}
+
 async function requestBrowserConsent(params) {
   const id = String(nextConsentRequestId++);
   const request = {
     ...params,
     requestedAt: Date.now(),
   };
+  const timer = setTimeout(() => completeBrowserConsent(id, false, "timed out waiting for browser approval"), CONSENT_TIMEOUT_MS);
+  pendingConsentRequests.set(id, { request, timer, tabId: null });
   const url = chrome.runtime.getURL(`consent.html?id=${encodeURIComponent(id)}`);
-  const decision = new Promise((resolve) => {
-    const finish = (approved, reason) => {
-      const pending = pendingConsentRequests.get(id);
-      if (!pending) return;
-      pendingConsentRequests.delete(id);
-      clearTimeout(pending.timer);
-      if (pending.tabId) chrome.tabs.remove(pending.tabId).catch(() => undefined);
-      resolve({ approved, reason, id, decidedAt: Date.now() });
-    };
-    const timer = setTimeout(() => finish(false, "timed out waiting for browser approval"), CONSENT_TIMEOUT_MS);
-    pendingConsentRequests.set(id, { request, resolve: finish, timer, tabId: null });
-  });
   try {
     const tab = await chrome.tabs.create({ url, active: true });
     if (tab.windowId !== undefined) await chrome.windows.update(tab.windowId, { focused: true }).catch(() => undefined);
     const pending = pendingConsentRequests.get(id);
     if (pending) pending.tabId = tab.id;
   } catch (error) {
-    const pending = pendingConsentRequests.get(id);
-    if (pending) pending.resolve(false, `could not open consent tab: ${error?.message || error}`);
+    completeBrowserConsent(id, false, `could not open consent tab: ${error?.message || error}`, false);
   }
-  return await decision;
+  return { id, opened: pendingConsentRequests.has(id), timeoutMs: CONSENT_TIMEOUT_MS };
+}
+
+function browserConsentStatus(params) {
+  const id = String(params?.id || "");
+  const completed = completedConsentRequests.get(id);
+  if (completed) return { state: "done", ...completed };
+  const pending = pendingConsentRequests.get(id);
+  if (pending) return { state: "pending", id, requestedAt: pending.request.requestedAt, timeoutMs: CONSENT_TIMEOUT_MS };
+  return { state: "missing", id, approved: false, reason: "consent request expired or not found" };
 }
 
 chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {
@@ -648,12 +659,11 @@ chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {
   }
   if (message.type === "piChromeConsentDecision") {
     const id = String(message.id || "");
-    const pending = pendingConsentRequests.get(id);
-    if (!pending) {
+    const result = completeBrowserConsent(id, message.approved === true, message.approved === true ? "approved in Chrome" : "denied in Chrome");
+    if (!result) {
       sendResponse({ ok: false, error: "Consent request expired or not found" });
       return true;
     }
-    pending.resolve(message.approved === true, message.approved === true ? "approved in Chrome" : "denied in Chrome");
     sendResponse({ ok: true });
     return true;
   }
@@ -662,11 +672,7 @@ chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {
 
 chrome.tabs.onRemoved.addListener((tabId) => {
   for (const [id, pending] of pendingConsentRequests) {
-    if (pending.tabId === tabId) {
-      pending.resolve(false, "consent tab closed");
-      pendingConsentRequests.delete(id);
-      clearTimeout(pending.timer);
-    }
+    if (pending.tabId === tabId) completeBrowserConsent(id, false, "consent tab closed", false);
   }
 });
 
@@ -767,6 +773,8 @@ async function dispatch(action, params) {
       };
     case "consent.request":
       return requestBrowserConsent(params);
+    case "consent.status":
+      return browserConsentStatus(params);
     case "tab.list":
       return (await chrome.tabs.query({})).map(formatTab);
     case "tab.new": {

package/extensions/chrome-profile-bridge/index.ts

@@ -463,6 +463,8 @@ export default function (pi: ExtensionAPI): void {
 		return bridge.send(action, params, timeoutMs);
 	};
 
+	const sleep = (ms: number) => new Promise((resolveSleep) => setTimeout(resolveSleep, ms));
+
 	// Translate the public `background` parameter (default false = visible/foreground) into the
 	// service worker's wire-level `foreground` flag, accepting legacy `foreground` as a fallback.
 	const withBackground = <T extends Record<string, unknown>>(params: T): T => {
@@ -610,14 +612,14 @@ Usage rules:
 
 	const authorizeFor = async (ctx: ExtensionContext, label: string, until: number | "indefinite") => {
 		ctx.ui.notify("Opening Chrome approval page…", "info");
-		let consent: { approved?: boolean; reason?: string };
+		let request: { id?: string; opened?: boolean; timeoutMs?: number };
 		try {
-			consent = (await bridge.send("consent.request", {
+			request = (await bridge.send("consent.request", {
 				durationLabel: label,
 				workspace: workspaceCwd(ctx),
 				pid: process.pid,
 				piChromeVersion: PI_CHROME_VERSION,
-			}, 5 * 60_000 + 5_000)) as { approved?: boolean; reason?: string };
+			}, 10_000)) as { id?: string; opened?: boolean; timeoutMs?: number };
 		} catch (error) {
 			const message = (error as Error).message;
 			const hint = message.includes("Unknown action: consent.request")
@@ -626,12 +628,37 @@ Usage rules:
 			ctx.ui.notify(`Chrome approval failed: ${message}\n${hint}`, "warning");
 			return;
 		}
-		if (!consent.approved) {
-			ctx.ui.notify(`Chrome control remains locked${consent.reason ? ` (${consent.reason})` : ""}.`, "info");
+		if (!request.id) {
+			ctx.ui.notify("Chrome approval failed: companion extension did not return a consent request id.", "warning");
+			return;
+		}
+		if (!request.opened) {
+			ctx.ui.notify("Chrome approval failed: companion extension could not open the consent page.", "warning");
 			return;
 		}
-		chromeAuthorizedUntil = until;
-		ctx.ui.notify(`Chrome control authorized for ${label}.`, "info");
+		ctx.ui.notify("Approve or deny the Chrome approval page to continue.", "info");
+
+		const deadline = Date.now() + (request.timeoutMs ?? 5 * 60_000);
+		while (Date.now() < deadline + 2_000) {
+			await sleep(700);
+			let status: { state?: string; approved?: boolean; reason?: string };
+			try {
+				status = (await bridge.send("consent.status", { id: request.id }, 5_000)) as { state?: string; approved?: boolean; reason?: string };
+			} catch (error) {
+				ctx.ui.notify(`Chrome approval failed: ${(error as Error).message}`, "warning");
+				return;
+			}
+			if (status.state !== "pending") {
+				if (!status.approved) {
+					ctx.ui.notify(`Chrome control remains locked${status.reason ? ` (${status.reason})` : ""}.`, "info");
+					return;
+				}
+				chromeAuthorizedUntil = until;
+				ctx.ui.notify(`Chrome control authorized for ${label}.`, "info");
+				return;
+			}
+		}
+		ctx.ui.notify("Chrome control remains locked (timed out waiting for browser approval).", "info");
 	};
 
 	const parseAuthorizeArg = (arg: string): { label: string; until: number | "indefinite" } | undefined => {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-chrome",
-	"version": "0.15.12",
+	"version": "0.15.14",
 	"scripts": {
 		"version": "node scripts/sync-manifest-version.js",
 		"prepublishOnly": "node scripts/sync-manifest-version.js"