pi-bro 0.23.1 → 0.24.0

package/src/doctor.ts

@@ -10,8 +10,9 @@ import {
 	readAdvisorSteering,
 	resolveAdvisorState,
 } from "./advisor.ts";
-import { agyFailureMessage, reviewBackendError } from "./backend.ts";
+import { agyFailureMessage, reviewBackendNotice } from "./backend.ts";
 import { createConfigModal } from "./config-ui.ts";
+import { openBroOverlay } from "./modal-kit.ts";
 import {
 	type AgyEffort,
 	type AgyModelFamily,
@@ -399,15 +400,19 @@ export async function doctorReport(pi: ExtensionAPI, ctx: ExtensionCommandContex
 			const override = capabilityOverride(settings, capability);
 			const backend = capabilityBackend(settings, capability);
 			const pair = capabilityPair(settings, capability);
-			const reviewError = capability === "review" ? reviewBackendError(backend) : undefined;
-			if (reviewError) { lines.push(`- ℹ **${label}:** needs a Claude or Muse override in \`/bro config\` for model calls; saved reviews remain readable.`); continue; }
+			// Review on a shell-capable sandbox is informational, never a failure: report the capability
+			// normally, then append one advisory line. Every branch below goes through here.
+			const reviewNotice = capability === "review" ? reviewBackendNotice(backend) : undefined;
+			const passCapability = (detail: string) => {
+				pass(label, detail);
+				if (reviewNotice) lines.push(`- ℹ **${label}:** ${reviewNotice}`);
+			};
 			if (backend === "claude") {
 				if (!isClaudeEffort(pair.effort)) {
 					fail(label, `\`${pair.effort}\` is unsupported for claude \`${pair.model}\`. Run \`/bro config\` to fix this.`);
 					continue;
 				}
-				pass(
-					label,
+				passCapability(
 					override
 						? `override claude \`${pair.model}\`${pair.effort === "default" ? "" : ` (${pair.effort})`}`
 						: `claude \`${pair.model}\`${pair.effort === "default" ? "" : ` (${pair.effort})`} · using the shared default`,
@@ -419,8 +424,7 @@ export async function doctorReport(pi: ExtensionAPI, ctx: ExtensionCommandContex
 					fail(label, `\`${pair.effort}\` is unsupported for grok \`${pair.model}\`. Run \`/bro config\` to fix this.`);
 					continue;
 				}
-				pass(
-					label,
+				passCapability(
 					override
 						? `override grok \`${pair.model}\`${pair.effort === "default" ? "" : ` (${pair.effort})`}`
 						: `grok \`${pair.model}\`${pair.effort === "default" ? "" : ` (${pair.effort})`} · using the shared default`,
@@ -432,8 +436,7 @@ export async function doctorReport(pi: ExtensionAPI, ctx: ExtensionCommandContex
 					fail(label, `\`${pair.effort}\` is unsupported for codex \`${pair.model}\`. Run \`/bro config\` to fix this.`);
 					continue;
 				}
-				pass(
-					label,
+				passCapability(
 					override
 						? `override codex \`${pair.model}\`${pair.effort === "default" ? "" : ` (${pair.effort})`}`
 						: `codex \`${pair.model}\`${pair.effort === "default" ? "" : ` (${pair.effort})`} · using the shared default`,
@@ -445,15 +448,19 @@ export async function doctorReport(pi: ExtensionAPI, ctx: ExtensionCommandContex
 					fail(label, `\`${pair.effort}\` is unsupported for muse \`${pair.model}\`. Run \`/bro config\` to fix this.`);
 					continue;
 				}
-				pass(
-					label,
+				passCapability(
 					override
 						? `override muse \`${pair.model}\`${pair.effort === "default" ? "" : ` (${pair.effort})`}`
 						: `muse \`${pair.model}\`${pair.effort === "default" ? "" : ` (${pair.effort})`} · using the shared default`,
 				);
 				continue;
 			}
-			if (!models) continue;
+			// No Agy catalog available: the Agy branch above is the only one that gets here, so there is
+			// nothing to validate, but a shell-capable review override still deserves its advisory.
+			if (!models) {
+				if (reviewNotice) lines.push(`- ℹ **${label}:** ${reviewNotice}`);
+				continue;
+			}
 			const resolved = resolveCapabilitySettings(settings, capability, models);
 			if (!resolved.family) {
 				fail(label, `\`${resolved.pair.model}\` is unavailable. Run \`/bro config\` to fix this override.`);
@@ -466,8 +473,7 @@ export async function doctorReport(pi: ExtensionAPI, ctx: ExtensionCommandContex
 				fail(label, `\`${resolved.pair.effort}\` is unsupported for \`${resolved.family.id}\`. Run \`/bro config\` to fix this.`);
 				continue;
 			}
-			pass(
-				label,
+			passCapability(
 				override
 					? `override agy \`${resolved.family.id}\`${resolved.pair.effort === "default" ? "" : ` (${resolved.pair.effort})`}`
 					: "using the shared default",
@@ -528,14 +534,5 @@ export async function showBroConfigModal(ctx: ExtensionCommandContext, pi: Exten
 		families = [];
 		ctx.ui.notify("Agy model catalog unavailable — showing other backend settings without Agy choices.", "warning");
 	}
-	await ctx.ui.custom<void>(createConfigModal(settings, families, writeSettings), {
-		overlay: true,
-		overlayOptions: {
-			width: "78%",
-			minWidth: 48,
-			maxHeight: "78%",
-			anchor: "top-center",
-			margin: { top: 1, left: 2, right: 2 },
-		},
-	});
+	await openBroOverlay<void>(ctx, createConfigModal(settings, families, writeSettings));
 }