pi-bro 0.19.0 → 0.19.1

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to pi-bro are documented here.
 
+## [0.19.1] - 2026-09-30
+
+### Fixed
+
+- Always enforce Bro's restrictive content policy on generated HTML, including when model output contains a permissive policy or CSP-looking comment (#69).
+- Isolate smoke-test temporary artifacts and block real backend CLIs during offline tests. Order settings mutations by RPC acknowledgements instead of fixed sleeps, and support spaces in settings-test checkout paths (#70).
+
 ## [0.19.0] - 2026-09-25
 
 ### Added

package/README.md

@@ -5,6 +5,7 @@ plain-language explanation — or open a separate side conversation with
 `/bro btw` — without adding anything to your main agent's context.
 
 `pi-bro` is an extension for [Earendil Pi](https://github.com/earendil-works/pi).
+Experimental [PiG 0.3.0 compatibility](docs/pig-compatibility.md) uses the same npm package and requires Node.js. See the compatibility notes for verified coverage and the PiG RPC tool-exclusion limitation.
 It opens explanations in a separate modal and runs them through a CLI backend
 you already have installed and signed in to. Explain, show, BTW, and the
 advisor all work across five backends:

package/bro.ts

@@ -5,12 +5,12 @@ import { mkdir, mkdtemp, readdir, readFile, realpath, rm, stat, writeFile } from
 import { request as httpRequest, type IncomingMessage } from "node:http";
 import { request as httpsRequest } from "node:https";
 import { BlockList, isIP } from "node:net";
-import { homedir, tmpdir } from "node:os";
+import { tmpdir } from "node:os";
 import { extname, isAbsolute, join, relative, resolve, sep } from "node:path";
 import { stripVTControlCharacters } from "node:util";
 import type { ExtensionAPI, ExtensionCommandContext, ExtensionContext, SessionEntry } from "@earendil-works/pi-coding-agent";
 import { Container, Editor, Input, Markdown, SettingsList, SelectList, Text, matchesKey, truncateToWidth, visibleWidth, type Component, type EditorTheme, type Focusable, type SelectItem, type SettingItem, type TUI } from "@earendil-works/pi-tui";
-import { convertToLlm, copyToClipboard, getMarkdownTheme, getSelectListTheme, getSettingsListTheme } from "@earendil-works/pi-coding-agent";
+import { convertToLlm, copyToClipboard, getAgentDir, getMarkdownTheme, getSelectListTheme, getSettingsListTheme } from "@earendil-works/pi-coding-agent";
 import { Defuddle } from "defuddle/node";
 import { parseHTML } from "linkedom";
 import mammoth from "mammoth";
@@ -35,7 +35,7 @@ import {
 
 export { agyFailureMessage, agySelection, advisorFlagErrorHint, parseBtwAgyLine };
 
-const AGENT_DIR = process.env.PI_CODING_AGENT_DIR ?? join(homedir(), ".pi", "agent");
+const AGENT_DIR = getAgentDir();
 const ENV_MODEL = process.env.PI_BRO_MODEL?.trim();
 const DEFAULT_MODEL = ENV_MODEL || "gemini-3.7-flash";
 const PROMPT_FILE = join(AGENT_DIR, "bro-prompt.md");
@@ -57,7 +57,7 @@ const REDIRECT_STATUSES = new Set([301, 302, 303, 307, 308]);
 type Theme = ExtensionCommandContext["ui"]["theme"];
 type TuiLike = {
 	readonly mode: "regular" | "fullscreen";
-	readonly terminal?: { write?: (data: string) => void };
+	readonly terminal?: { rows?: number; write?: (data: string) => void };
 	requestRender(): void;
 };
 type ModalKind = "loading" | "streaming" | "result" | "help" | "empty" | "error";
@@ -1561,10 +1561,12 @@ export function showHtmlDirectory(): string {
 
 function withShowCsp(html: string): string {
 	// Defense in depth: the prompt forbids external resources and scripts;
-	// a meta CSP blocks them anyway if the model slips.
+	// a meta CSP blocks them anyway if the model slips. Always inserted: multiple
+	// policies are enforced together, so a model-supplied CSP can only tighten it.
+	// Skip only simple leading comments: browsers accept comment terminators that
+	// a general regex misses. Ambiguous markup gets the policy prepended instead.
 	const meta = '<meta http-equiv="Content-Security-Policy" content="default-src \'none\'; style-src \'unsafe-inline\'; img-src data:;">';
-	if (/http-equiv=["']?Content-Security-Policy/i.test(html)) return html;
-	return html.replace(/^(\s*(?:<!doctype[^>]*>\s*)?)/i, `$1\n${meta}\n`);
+	return html.replace(/^(\s*(?:<!--[^<>]*-->\s*)*(?:<!doctype[^>]*>\s*)?)/i, `$1\n${meta}\n`);
 }
 
 export async function writeShowHtml(html: string): Promise<string> {
@@ -2798,7 +2800,7 @@ class BroModal implements Focusable {
 	render(width: number): string[] {
 		const dialogWidth = Math.max(24, width);
 		const innerWidth = Math.max(22, dialogWidth - 2);
-		const terminalRows = process.stdout.rows ?? 30;
+		const terminalRows = this.tui.terminal?.rows ?? process.stdout.rows ?? 30;
 		const dialogHeight = Math.min(32, Math.max(7, Math.floor(terminalRows * 0.78)));
 		this.bodyHeight = Math.max(1, dialogHeight - 6);
 
@@ -3231,7 +3233,7 @@ class BtwModal implements Focusable {
 	render(width: number): string[] {
 		const dialogWidth = Math.max(24, width);
 		const innerWidth = Math.max(22, dialogWidth - 2);
-		const terminalRows = process.stdout.rows ?? 30;
+		const terminalRows = this.tui.terminal?.rows ?? process.stdout.rows ?? 30;
 		const dialogHeight = Math.min(34, Math.max(8, Math.floor(terminalRows * 0.82)));
 		this.bodyHeight = Math.max(1, dialogHeight - 7);
 

package/docs/README.md

@@ -0,0 +1,8 @@
+# pi-bro docs
+
+- [README](../README.md) — the user guide (authoritative for behavior).
+- [DEVELOPMENT.md](DEVELOPMENT.md) — code map, settings and BTW continuation model, invariants, test commands.
+- [TESTING.md](TESTING.md) — the manual end-to-end checklist across backends.
+- [plans/](plans/README.md) — historical design notes and plans; not the current spec.
+- [images/](images/) — screenshots used by the README.
+- [benchmark/README.md](../benchmark/README.md) — the manual, live prompt benchmark.

package/docs/pig-compatibility.md

@@ -0,0 +1,42 @@
+# PiG compatibility
+
+Bro uses one TypeScript package on Pi and Pi-in-Go (PiG). PiG runs Bro in a Node subprocess; it is not a Go port or a fused native extension.
+
+## Target and installation
+
+PiG **0.3.0+0.87.1**, Node **>=22.19.0**. Compatibility is experimental; the checks below are not a guarantee for every PiG release or platform.
+
+Install the PiG binary from https://github.com/MichaelKinsy/PiG/releases/tag/v0.3.0, then:
+
+```sh
+pig install npm:pi-bro
+```
+
+That command installs the published Bro version; these compatibility changes take effect only after a Bro release containing them. To test this checkout now, install dependencies and use `pig -e ./bro.ts`.
+
+At initial verification, `@pi-in-go/pig@0.3.0` was not available from npm. CI therefore downloads the pinned GitHub binary and verifies its published SHA-256 checksum.
+
+Bro follows the host's `getAgentDir()`: normally `~/.pi/agent` on Pi and `~/.pig/agent` on PiG. PiG supports `PIG_CODING_AGENT_DIR`, `PIG_HOME`, XDG configuration and explicit `PIG_USE_PI_DIRS=1` sharing. No automatic migration or copying of existing Bro settings takes place. `PI_BRO_MODEL` remains the same Bro-specific override on both hosts.
+
+## Known limitations
+
+- **PiG 0.3.0 RPC does not enforce `--exclude-tools`.** Excluded tools may remain active and reach provider requests. This is not a sandbox boundary. Use an explicit `--tools` allowlist instead; do not rely on `/bro doctor` to prove exclusion. Bro does not mask this defect by falsely reporting an active tool as unavailable.
+- The smoke suite retains Pi's strict exclusion assertion. The PiG lane has an explicit version-specific expected failure; a changed result fails the lane so the exception must be reviewed/removed.
+- Mouse-wheel forwarding is not qualified; use keyboard scrolling.
+- Remote/SSH OSC 52 clipboard forwarding is not qualified. Local clipboard behavior depends on the host and installed platform utilities.
+- Windows support is not qualified by these checks.
+
+## Verification and release gate
+
+```sh
+npm test
+PIG_BIN=/absolute/path/to/pig sh pig-test.sh
+```
+
+The PiG lane checks the exact binary version, real host settings isolation, advisor snapshot compaction/branch projection, and the existing fake-backend RPC smoke suite. Existing Node tests cover backend cancellation/process cleanup and modal geometry, but are not substitutes for real-host interactive tests.
+
+CI and publishing call `.github/workflows/pig.yml`; publication requires both host lanes. A green PiG job includes the clearly printed RPC exclusion expected failure, not a claim of complete parity.
+
+Manual macOS terminal checks confirmed help rendering/scrolling/resize, opening the BTW composer and switching `/mode`, and the advisor-steering editor displaying `Saved` after a correctly encoded Ctrl+S. Full end-to-end advisor model execution, interactive configuration persistence, clipboard, and host reload/shutdown with active backend processes still require qualification. No paid backend calls are part of CI.
+
+Tracking: https://github.com/tranhoangnguyen03/pi-bro/issues/64 and the original loading fix https://github.com/MichaelKinsy/PiG/issues/88.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-bro",
-  "version": "0.19.0",
+  "version": "0.19.1",
   "description": "An Earendil Pi extension that explains pasted text, assistant responses, local documents, public webpages, and recent session turns (as shapes) in a context-isolated window, opens a sandboxed side conversation with /bro btw, and provides a second-opinion advisor tool for executor agents.",
   "type": "module",
   "license": "MIT",
@@ -42,7 +42,8 @@
     "README.md",
     "CHANGELOG.md",
     "LICENSE",
-    "THIRD_PARTY_NOTICES.md"
+    "THIRD_PARTY_NOTICES.md",
+    "docs/pig-compatibility.md"
   ],
   "publishConfig": {
     "access": "public"
@@ -52,7 +53,7 @@
   },
   "scripts": {
     "typecheck": "tsc --noEmit",
-    "test": "npm run typecheck && node --test prompt.test.ts backend.test.ts claude.test.ts grok.test.ts codex.test.ts muse.test.ts settings.test.ts benchmark/*.test.ts && sh ./smoke-test.sh",
+    "test": "npm run typecheck && node --test prompt.test.ts backend.test.ts claude.test.ts grok.test.ts codex.test.ts muse.test.ts settings.test.ts show-html.test.ts smoke-rpc.test.ts benchmark/*.test.ts && sh ./smoke-test.sh",
     "benchmark:dry-run": "node benchmark/run.ts dry-run",
     "benchmark:run": "node benchmark/run.ts run",
     "benchmark:report": "node benchmark/run.ts report",