pi-bridge 0.2.4 → 0.2.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-bridge",
-  "version": "0.2.4",
+  "version": "0.2.6",
   "description": "Transparent filesystem bridge that makes pi run natively on a remote machine over SSH",
   "type": "commonjs",
   "bin": {

package/src/local/child-process-patch.js

@@ -29,11 +29,33 @@ function patchChildProcess(fakeRoot, remote) {
     return typeof c === 'string' ? path.resolve(c) : c.toString();
   }
 
+  /**
+   * On Windows, pi may call spawn with a full exe path like
+   * C:\Program Files\Git\bin\bash.exe. Strip it to the bare command name
+   * ('bash') so the remote Linux shell can find it.
+   */
+  function normalizeCmd(file) {
+    if (process.platform !== 'win32') return file;
+    return path.basename(String(file)).replace(/\.exe$/i, '');
+  }
+
+  /**
+   * Returns true for commands that must always run locally, never over SSH.
+   * - node / node.exe: pi's internal tooling (session export, compaction, …)
+   *   spawns Node with large payloads as args; redirecting those over SSH would
+   *   produce an ENAMETOOLONG error on Windows and is never correct anyway.
+   */
+  function isLocalOnly(file) {
+    const name = normalizeCmd(file).toLowerCase();
+    return name === 'node';
+  }
+
   /**
    * Build the SSH-redirected command: cd to remote cwd, then run the
    * original command with its arguments, all shell-quoted.
    */
   function buildSshArgs(file, args, opts) {
+    file = normalizeCmd(file);
     const fakeCwd    = effectiveCwd(opts);
     const remoteCwd  = toRemotePath(fakeCwd, fakeRoot);
 
@@ -54,7 +76,7 @@ function patchChildProcess(fakeRoot, remote) {
     opts = opts || {};
 
     const cwd = effectiveCwd(opts);
-    if (!isFakePath(cwd, fakeRoot)) return origSpawn(file, args, opts);
+    if (!isFakePath(cwd, fakeRoot) || isLocalOnly(file)) return origSpawn(file, args, opts);
 
     return origSpawn('ssh', buildSshArgs(file, args, opts), Object.assign({}, opts, { cwd: undefined }));
   };
@@ -66,7 +88,7 @@ function patchChildProcess(fakeRoot, remote) {
     opts = opts || {};
 
     const cwd = effectiveCwd(opts);
-    if (!isFakePath(cwd, fakeRoot)) return origSpawnSync(file, args, opts);
+    if (!isFakePath(cwd, fakeRoot) || isLocalOnly(file)) return origSpawnSync(file, args, opts);
 
     return origSpawnSync('ssh', buildSshArgs(file, args, opts), Object.assign({}, opts, { cwd: undefined }));
   };

package/src/local/fs-patch.js

@@ -38,6 +38,15 @@ function makeEisdir(p) {
   );
 }
 
+/**
+ * Returns true if the path looks like a bash executable.
+ * Used on Windows to fake bash presence so pi's shell-detection passes.
+ */
+function isBashPath(p) {
+  const n = String(p).replace(/\\/g, '/').toLowerCase();
+  return n.endsWith('/bash.exe') || n.endsWith('/bash') || n === '/bin/bash';
+}
+
 function rethrowRemote(e, p) {
   if (!e || !e.message) throw e;
   if (e.message.includes('403')) throw makeEnoent(p);
@@ -176,6 +185,11 @@ function patchFs(fakeRoot, port, token) {
 
   fs.existsSync = function patchedExistsSync(p) {
     const s = abs(p);
+    // On Windows, pi checks for bash locally before using the shell tool.
+    // The check never reaches our SSH bridge (it's just an existsSync call).
+    // Fake it so pi believes bash is available; the actual spawn is intercepted
+    // and the Windows exe path is normalised to 'bash' before going over SSH.
+    if (process.platform === 'win32' && isBashPath(s)) return true;
     if (!s || !isFakePath(s, fakeRoot)) return orig.existsSync(p);
     try {
       return httpGet(port, token, '/exists?path=' + encodeURIComponent(rpath(s))).trim() === '1';