pi-better-goal 0.2.0 → 0.2.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-better-goal",
-  "version": "0.2.0",
+  "version": "0.2.2",
   "description": "Pi extension for goal tracking with background-aware continuation.",
   "license": "MIT",
   "type": "module",

package/src/index.ts

@@ -162,6 +162,7 @@ function formatSnapshot(snapshot: ActivitySnapshot): string {
 
 export default function (pi: ExtensionAPI): void {
   const providers = new Map<string, BackgroundActivityProvider>();
+  const providerUnsubscribers = new Map<string, () => void>();
   providers.set("subagents", {
     id: "subagents",
     label: "Subagents",
@@ -172,6 +173,7 @@ export default function (pi: ExtensionAPI): void {
   let foregroundRunning = false;
   let pollTimer: ReturnType<typeof setInterval> | undefined;
   let collecting = false;
+  let collectionPending = false;
   let latestSnapshot: ActivitySnapshot | null = null;
   let backgroundDrainTracker: BackgroundDrainTracker | null = null;
   let lastWakeSignature = "";
@@ -230,6 +232,7 @@ export default function (pi: ExtensionAPI): void {
     continuationQueuedFor = null;
     backgroundDrainTracker = null;
     clearIdleContinuation();
+    syncPollingState();
     // Force a full redraw when the dock height changes (absent ↔ visible clock).
     refreshGoalWidget?.(!wasVisible || !isGoalClockVisible(goal));
   };
@@ -241,6 +244,7 @@ export default function (pi: ExtensionAPI): void {
     continuationQueuedFor = null;
     backgroundDrainTracker = null;
     clearIdleContinuation();
+    syncPollingState();
     refreshGoalWidget?.(wasVisible);
   };
 
@@ -409,12 +413,22 @@ export default function (pi: ExtensionAPI): void {
 
   const collectIfPossible = (): void => {
     const ctx = currentCtx;
-    if (!ctx || collecting) {
+    if (!ctx) {
+      return;
+    }
+    if (collecting) {
+      collectionPending = true;
       return;
     }
     collecting = true;
     void publishSnapshot(ctx).finally(() => {
       collecting = false;
+      if (collectionPending) {
+        collectionPending = false;
+        collectIfPossible();
+      } else {
+        syncPollingState();
+      }
     });
   };
 
@@ -424,7 +438,6 @@ export default function (pi: ExtensionAPI): void {
     }
     pollTimer = setInterval(collectIfPossible, POLL_INTERVAL_MS);
     pollTimer.unref?.();
-    collectIfPossible();
   };
 
   const stopPolling = (): void => {
@@ -435,6 +448,16 @@ export default function (pi: ExtensionAPI): void {
     pollTimer = undefined;
   };
 
+  const syncPollingState = (): void => {
+    const ctx = currentCtx;
+    const goal = ctx ? currentGoalSnapshot(ctx) : null;
+    if (ctx && (isPokeable(goal) || latestSnapshot?.backgroundRunning === true)) {
+      startPolling();
+    } else {
+      stopPolling();
+    }
+  };
+
   const installGoalWidget = (ctx: ExtensionContext): void => {
     if (!ctx.hasUI) {
       return;
@@ -494,8 +517,14 @@ export default function (pi: ExtensionAPI): void {
     if (!candidate || typeof candidate.id !== "string" || typeof candidate.getActivity !== "function") {
       return;
     }
-    providers.set(candidate.id, candidate as BackgroundActivityProvider);
-    collectIfPossible();
+    const accepted = candidate as BackgroundActivityProvider;
+    providerUnsubscribers.get(accepted.id)?.();
+    providerUnsubscribers.delete(accepted.id);
+    providers.set(accepted.id, accepted);
+    if (typeof accepted.onActivityChanged === "function") {
+      providerUnsubscribers.set(accepted.id, accepted.onActivityChanged(collectIfPossible));
+    }
+    if (latestSnapshot) collectIfPossible();
   });
 
   pi.registerCommand("goal", {
@@ -661,7 +690,8 @@ export default function (pi: ExtensionAPI): void {
     foregroundRunning = !ctx.isIdle();
     pi.events.emit(EVENT_READY, { version: EXTENSION_VERSION });
     installGoalWidget(ctx);
-    startPolling();
+    latestSnapshot = await publishSnapshot(ctx);
+    syncPollingState();
   });
 
   pi.on("input", async (event, ctx) => {
@@ -683,7 +713,7 @@ export default function (pi: ExtensionAPI): void {
     }
 
     const backgroundInstruction = snapshot.backgroundRunning
-      ? ` The goal still has delegated background work running (${summarizeActiveBackground(snapshot)}). Foreground idleness alone is not goal completion; do not mark the goal complete until delegated background work reaches a terminal state and its result or failure has been inspected.`
+      ? ` The goal still has delegated background work running (${summarizeActiveBackground(snapshot)}). Foreground idleness alone is not goal completion; keep any structured plan current and do not mark verification, the plan, or the goal complete until every relevant delegated task reaches a terminal state and its result or failure has been inspected and integrated.`
       : "";
     return {
       systemPrompt:
@@ -762,6 +792,8 @@ export default function (pi: ExtensionAPI): void {
     foregroundRunning = false;
     clearIdleContinuation();
     currentCtx = undefined;
+    latestSnapshot = null;
+    collectionPending = false;
     try {
       ctx.ui.setStatus(EXTENSION_NAME, undefined);
       ctx.ui.setWidget(EXTENSION_NAME, undefined);

package/src/subagents.ts

@@ -1,4 +1,4 @@
-import { existsSync, readdirSync, readFileSync } from "node:fs";
+import { existsSync, mkdirSync, readdirSync, readFileSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 
@@ -82,6 +82,46 @@ export function readSubagentMetas(baseDir = defaultSubagentBaseDir()): SubagentR
   return metas.sort((left, right) => right.startedAt - left.startedAt);
 }
 
+export function readParentSubagentMetas(
+  baseDir = defaultSubagentBaseDir(),
+  parentPid = process.pid,
+): SubagentRunMeta[] {
+  const directory = join(baseDir, "by-parent", String(parentPid));
+  ensureParentIndex(baseDir, directory, parentPid);
+  let ids: string[];
+  try {
+    ids = readdirSync(directory).filter((id) => id !== ".initialized");
+  } catch {
+    return [];
+  }
+  return ids
+    .map((id) => readSubagentMeta(baseDir, id))
+    .filter((meta): meta is SubagentRunMeta => meta !== undefined && meta.spawnPid === parentPid)
+    .sort((left, right) => right.startedAt - left.startedAt);
+}
+
+function readSubagentMeta(baseDir: string, id: string): SubagentRunMeta | undefined {
+  try {
+    const meta = JSON.parse(readFileSync(join(baseDir, "runs", id, "meta.json"), "utf8")) as SubagentRunMeta;
+    return typeof meta.id === "string" && typeof meta.status === "string" ? meta : undefined;
+  } catch {
+    return undefined;
+  }
+}
+
+function ensureParentIndex(baseDir: string, directory: string, parentPid: number): void {
+  try {
+    readFileSync(join(directory, ".initialized"));
+    return;
+  } catch {
+    // Existing registries are backfilled once for this parent process.
+  }
+  const owned = readSubagentMetas(baseDir).filter((meta) => meta.spawnPid === parentPid);
+  mkdirSync(directory, { recursive: true });
+  for (const meta of owned) writeFileSync(join(directory, meta.id), "");
+  writeFileSync(join(directory, ".initialized"), "1");
+}
+
 export function subagentStatusToItem(
   meta: SubagentRunMeta,
   status: SubagentEffectiveStatus,
@@ -122,9 +162,7 @@ export function collectSubagentActivity(
 ): BackgroundProviderSnapshot {
   const parentPid = options.parentPid ?? process.pid;
   const processExists = options.processExists ?? defaultProcessExists;
-  const metas = readSubagentMetas(options.baseDir).filter((meta) =>
-    isCurrentParentSubagent(meta, parentPid),
-  );
+  const metas = readParentSubagentMetas(options.baseDir, parentPid);
 
   return {
     providerId: "subagents",

package/src/types.ts

@@ -47,6 +47,7 @@ export interface BackgroundActivityProvider {
   id: string;
   label?: string;
   getActivity(ctx: ExtensionContext): BackgroundProviderSnapshot | Promise<BackgroundProviderSnapshot>;
+  onActivityChanged?(notify: () => void): () => void;
 }
 
 export interface ActivitySnapshot {