pi-better-background-tasks 0.1.14 → 0.1.15

package/README.md

@@ -16,6 +16,7 @@ Use `pi-better-background-tasks` when a command should keep running while the fo
 - Watch commands until success, failure, or timeout.
 - Keep task metadata and logs available across reloads.
 - Show active work in Pi's background-work navigator.
+- Flag running tasks with no observable output or completed poll as stalled.
 
 ## Install
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-better-background-tasks",
-  "version": "0.1.14",
+  "version": "0.1.15",
   "description": "Pi extension for durable background shell tasks, watchers, logs, and status inspection.",
   "license": "MIT",
   "type": "module",

package/src/goal-provider.ts

@@ -2,6 +2,7 @@ import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-a
 import { listMetas } from "./registry.js";
 import type { BackgroundTaskMeta } from "./types.js";
 import { isTerminalStatus } from "./types.js";
+import { backgroundTaskProgressAt, observeBackgroundTaskStall } from "./stall.js";
 
 const GOAL_READY_EVENT = "pi-better-goal:ready";
 const GOAL_REGISTER_PROVIDER_EVENT = "pi-better-goal:register-provider";
@@ -92,11 +93,14 @@ function getGoalActivityOrigin(ctx: ExtensionContext) {
 function backgroundTaskToGoalItem(meta: BackgroundTaskMeta): GoalBackgroundWorkItem {
   const active = meta.status === "running";
   const terminal = isTerminalStatus(meta.status);
-  const attention = terminal && meta.status !== "succeeded";
+  const stall = observeBackgroundTaskStall(meta);
+  const unhealthy = active && stall.state === "stalled";
+  const attention = (terminal && meta.status !== "succeeded") || unhealthy;
   const item: GoalBackgroundWorkItem = {
     id: meta.id,
     status: meta.status,
     active,
+    unhealthy,
     terminal,
     attention,
     startedAt: meta.startedAt,
@@ -108,6 +112,8 @@ function backgroundTaskToGoalItem(meta: BackgroundTaskMeta): GoalBackgroundWorkI
       argv: meta.argv,
       logPath: meta.logPath,
       spawnPid: meta.spawnPid,
+      lastProgressAt: backgroundTaskProgressAt(meta),
+      stall: stall.state,
     },
   };
   if (meta.name !== undefined) item.label = meta.name;

package/src/navigator-provider.ts

@@ -10,8 +10,9 @@ import {
 import { CustomEditor } from "@earendil-works/pi-coding-agent";
 import { Key, matchesKey, truncateToWidth } from "@earendil-works/pi-tui";
 import { readLog } from "./logs.js";
-import { listMetas, readMeta, writeMeta } from "./registry.js";
+import { listMetas, onMetaChanged, readMeta, writeMeta } from "./registry.js";
 import { stopTask } from "./runtime.js";
+import { observeBackgroundTaskStall } from "./stall.js";
 import type { BackgroundTaskCallbackOrigin, BackgroundTaskMeta, BackgroundTaskStatus } from "./types.js";
 
 let unregister: (() => void) | undefined;
@@ -62,6 +63,7 @@ const provider: BackgroundWorkProvider = {
     writeMeta(meta);
     return { action: "dismissed", providerId: "background-tasks", id, status: meta.status };
   },
+  onVisibleChanged: onMetaChanged,
 };
 
 function visibleMetas(now = Date.now()): BackgroundTaskMeta[] {
@@ -113,6 +115,9 @@ function rowFromMeta(meta: BackgroundTaskMeta, now: number): BackgroundWorkRow {
     secondary: secondaryLabel(meta),
     facts: factsForMeta(meta, now),
     sortStartedAt: meta.startedAt,
+    expiresAt: meta.status === "running" || meta.endedAt === undefined
+      ? undefined
+      : meta.endedAt + TERMINAL_NAVIGATOR_RETENTION_MS,
   };
 }
 
@@ -131,6 +136,10 @@ function detailFromMeta(meta: BackgroundTaskMeta | undefined, now: number, optio
   ];
   if (meta.deadlineAt) metadata.push({ label: "deadline", value: formatDuration(meta.deadlineAt - now) });
   if (meta.lastCheckedAt) metadata.push({ label: "checked", value: `${formatDuration(now - meta.lastCheckedAt)} ago` });
+  if (meta.status === "running") {
+    const stall = observeBackgroundTaskStall(meta, now);
+    if (stall.state !== "healthy") metadata.push({ label: "activity", value: stall.state });
+  }
   if (meta.lastExitCode !== undefined) metadata.push({ label: "exit", value: String(meta.lastExitCode) });
   if (meta.error) metadata.push({ label: "error", value: meta.error });
   if (meta.logDiscardedBytes) {
@@ -194,6 +203,11 @@ function secondaryLabel(meta: BackgroundTaskMeta): string | undefined {
 
 function factsForMeta(meta: BackgroundTaskMeta, now: number): string[] {
   const facts: string[] = [];
+  if (meta.status === "running") {
+    const stall = observeBackgroundTaskStall(meta, now);
+    if (stall.state === "stalled") facts.push("stalled");
+    else if (stall.state === "quiet") facts.push("quiet");
+  }
   if (meta.kind === "command_watch" && meta.intervalMs) facts.push(`every ${formatDuration(meta.intervalMs)}`);
   if (meta.deadlineAt && meta.status === "running") facts.push(`${formatDuration(meta.deadlineAt - now)} left`);
   if (meta.result && meta.status !== "running") {

package/src/registry.ts

@@ -6,6 +6,7 @@ import { isTerminalStatus } from "./types.js";
 
 let seq = 0;
 const metaCache = new Map<string, BackgroundTaskMeta>();
+const metaChangedListeners = new Set<() => void>();
 
 export function baseDir(): string {
   return join(tmpdir(), "pi-better-background-tasks");
@@ -40,6 +41,14 @@ export function writeMeta(meta: BackgroundTaskMeta): void {
   ensureTaskDir(meta.id);
   writeFileSync(metaPathFor(meta.id), JSON.stringify(meta, null, 2));
   metaCache.set(meta.id, meta);
+  for (const listener of metaChangedListeners) {
+    try { listener(); } catch { /* best effort */ }
+  }
+}
+
+export function onMetaChanged(listener: () => void): () => void {
+  metaChangedListeners.add(listener);
+  return () => metaChangedListeners.delete(listener);
 }
 
 export function readMeta(id: string): BackgroundTaskMeta | undefined {

package/src/runtime.ts

@@ -1,3 +1,4 @@
+import { statSync } from "node:fs";
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 import { appendLine, appendWatchResult, retainLogTail, resolveMaxLogBytes } from "./logs.js";
 import { evaluateCondition } from "./conditions.js";
@@ -51,6 +52,7 @@ export function spawnTask(
     kind: "process",
     status: "running",
     startedAt: now,
+    lastProgressAt: now,
     deadlineAt: params.timeout_seconds ? now + params.timeout_seconds * 1000 : undefined,
     logPath,
     callback: params.callback,
@@ -103,6 +105,7 @@ export function startWatchTask(
     kind: "command_watch",
     status: "running",
     startedAt: now,
+    lastProgressAt: now,
     deadlineAt: timeoutSeconds ? now + timeoutSeconds * 1000 : undefined,
     intervalMs: Math.max(1, params.interval_seconds ?? 30) * 1000,
     logPath: logPathFor(id),
@@ -212,6 +215,7 @@ async function pollWatch(pi: ExtensionAPI, id: string, getActiveSession?: Active
     if (!latest || latest.status !== "running") return;
     enforceLogRetention(latest);
     latest.lastCheckedAt = Date.now();
+    latest.lastProgressAt = latest.lastCheckedAt;
     latest.lastExitCode = result.exitCode;
     latest.lastSignal = result.signal;
     latest.lastState = extractLastState(result);
@@ -371,6 +375,15 @@ function stopLogRetention(id: string): void {
 }
 
 function enforceLogRetention(meta: BackgroundTaskMeta): void {
+  try {
+    const mtimeMs = Math.trunc(statSync(meta.logPath).mtimeMs);
+    if (mtimeMs > (meta.lastProgressAt ?? meta.startedAt)) {
+      meta.lastProgressAt = mtimeMs;
+      writeMeta(meta);
+    }
+  } catch {
+    // Logs are optional progress evidence; retention still proceeds if absent.
+  }
   const compacted = retainLogTail(meta.logPath, resolveMaxLogBytes(meta.maxLogBytes));
   if (!compacted) return;
   meta.logDiscardedBytes = (meta.logDiscardedBytes ?? 0) + compacted.discardedBytes;

package/src/shared-navigator.ts

@@ -1,5 +1,6 @@
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
 import type { Component } from "@earendil-works/pi-tui";
+import { createRenderScheduler, type RenderScheduler } from "./shared-render-scheduler.ts";
 
 export default function navigatorExtension(): void {
   // Internal shared package. Pi may scan its symlink in the extension directory
@@ -25,6 +26,7 @@ export type BackgroundWorkRow = {
   secondary?: string;
   facts?: string[];
   sortStartedAt: number;
+  expiresAt?: number;
 };
 
 export type BackgroundWorkDetail = {
@@ -79,7 +81,7 @@ type NavigatorState = {
   mainListFocused?: boolean;
   mainListCloseArm?: { id: string; armedAt: number };
   mainListCloseArmTimer?: ReturnType<typeof setTimeout>;
-  mainListTimer?: ReturnType<typeof setInterval>;
+  mainListDeadlineScheduler?: RenderScheduler;
   detailOverlayRows?: number;
   dispose?: () => void;
 };
@@ -91,15 +93,10 @@ const FACTORY_REFRESH = "__piBetterHarnessNavigatorRefresh";
 export const NAVIGATOR_STATUS_KEY = "background-work-nav";
 export const CLOSE_CONFIRM_STATUS_KEY = "background-work-close";
 export const MAIN_LIST_WIDGET_KEY = "background-work-list";
-export const DETAIL_TICK_MS = 1000;
+export const DETAIL_TICK_MS = 10_000;
 export const CLOSE_ARM_MS = 3000;
 export const DEFAULT_LOG_TAIL_ROWS = 10;
 export const LOG_TAIL_ROW_CHOICES = [10, 25] as const;
-// Row rebuild cadence. Each tick asks every provider for rows, which stats and
-// parses run logs, so this is a per-provider I/O cadence and not a paint rate:
-// the widget repaints from render() whenever the TUI asks. 1 Hz matches
-// DETAIL_TICK_MS and the elapsed/spinner resolution the rows can actually show.
-const MAIN_LIST_TICK_MS = 1000;
 const MAIN_LIST_FALLBACK_WIDTH = 100;
 const DETAIL_OVERLAY_HEADER_MARGIN_ROWS = 5;
 const DETAIL_OVERLAY_FOOTER_MARGIN_ROWS = 3;
@@ -173,9 +170,10 @@ export function ensureBackgroundWorkNavigator(ctx: ExtensionContext, deps: HostD
   try { (ctx.ui as any).setWidget?.(MAIN_LIST_WIDGET_KEY, undefined); } catch { /* ignore */ }
   s.mainListWidgetInstalled = false;
   s.mainListRequestRender = undefined;
+  s.mainListDeadlineScheduler?.dispose();
+  s.mainListDeadlineScheduler = createRenderScheduler(() => refreshMainListWidget());
   installNavigatorEditor(ctx.ui as any, deps);
   s.lastHint = undefined;
-  startMainListWidget(ctx);
   refreshBackgroundWorkNavigator(ctx);
   refreshMainListWidget();
 }
@@ -193,6 +191,8 @@ export function disposeBackgroundWorkNavigator(ctx?: ExtensionContext): void {
   }
   s.lastHint = undefined;
   s.lastMainListLines = undefined;
+  s.mainListDeadlineScheduler?.dispose();
+  s.mainListDeadlineScheduler = undefined;
   s.mainListWidgetInstalled = false;
   s.mainListRequestRender = undefined;
   s.detailOverlayRows = undefined;
@@ -226,17 +226,7 @@ function visibleCount(): number {
   }, 0);
 }
 
-function startMainListWidget(ctx: ExtensionContext): void {
-  const s = state();
-  if (s.mainListTimer || !isNavigatorUiAvailable(ctx)) return;
-  s.mainListTimer = setInterval(() => refreshMainListWidget(), MAIN_LIST_TICK_MS);
-  s.mainListTimer.unref?.();
-}
-
 function stopMainListWidget(): void {
-  const s = state();
-  if (s.mainListTimer) clearInterval(s.mainListTimer);
-  s.mainListTimer = undefined;
   clearMainListCloseArm();
 }
 
@@ -254,7 +244,16 @@ function refreshMainListWidget(): void {
   const ctx = s.uiCtx;
   const deps = s.deps;
   if (!ctx || !deps || !isNavigatorUiAvailable(ctx)) return;
-  const rows = listRows();
+  const now = Date.now();
+  const rows = listRows(now);
+  s.mainListDeadlineScheduler?.cancel();
+  const nextExpiry = rows.reduce<number | undefined>((next, row) => {
+    if (row.expiresAt === undefined || row.expiresAt <= now) return next;
+    return next === undefined ? row.expiresAt : Math.min(next, row.expiresAt);
+  }, undefined);
+  if (nextExpiry !== undefined) {
+    s.mainListDeadlineScheduler?.schedule(nextExpiry - now);
+  }
   syncMainListSelection(rows);
   s.lastMainListLines = rows.length ? buildMainListLines(rows, MAIN_LIST_FALLBACK_WIDTH, deps.truncate, themeFg(ctx), {
     selectedId: s.mainListFocused ? s.mainListSelectedId : undefined,
@@ -462,7 +461,7 @@ function statusGlyph(row: InternalRow): string {
 
 function statusIndicator(row: InternalRow, now = Date.now()): { glyph: string; color: string } {
   if (row.statusTone !== "running") return { glyph: statusGlyph(row), color: toneColor(row.statusTone, row.status) };
-  const frame = Math.floor(now / MAIN_LIST_TICK_MS) % RUNNING_DOT_FRAMES.length;
+  const frame = Math.floor(now / DETAIL_TICK_MS) % RUNNING_DOT_FRAMES.length;
   return { glyph: RUNNING_DOT_GLYPH, color: RUNNING_DOT_FRAMES[frame]! };
 }
 
@@ -676,7 +675,6 @@ function createOverlayComponent(
     const idx = overlayState.rows.findIndex((row) => row.navigatorId === detailId);
     if (idx >= 0) overlayState.selected = idx;
   }
-  let detailTimer: ReturnType<typeof setInterval> | undefined;
   let closeArm: { id: string; armedAt: number } | undefined;
   let closeArmTimer: ReturnType<typeof setTimeout> | undefined;
   let closed = false;
@@ -687,6 +685,13 @@ function createOverlayComponent(
     try { tui.requestRender(); } catch { /* ignore */ }
   }
 
+  const detailScheduler = createRenderScheduler(() => {
+    if (!detailId || mode !== "detail" || closed) return;
+    detail = detailFor(detailId, Date.now(), { logTailLines: logTailRows }) ?? detail;
+    requestRender();
+    startDetailTimer();
+  });
+
   function refreshRows(): void {
     const selectedId = overlayState.rows[overlayState.selected]?.navigatorId;
     overlayState.rows = listRows();
@@ -704,18 +709,14 @@ function createOverlayComponent(
   }
 
   function stopDetailTimer(): void {
-    if (detailTimer) clearInterval(detailTimer);
-    detailTimer = undefined;
+    detailScheduler.cancel();
   }
 
   function startDetailTimer(): void {
-    stopDetailTimer();
-    detailTimer = setInterval(() => {
-      if (!detailId || mode !== "detail") return;
-      detail = detailFor(detailId, Date.now(), { logTailLines: logTailRows }) ?? detail;
-      requestRender();
-    }, DETAIL_TICK_MS);
-    detailTimer.unref?.();
+    detailScheduler.cancel();
+    if (detail?.status === "running" || detail?.status === "orphaned") {
+      detailScheduler.schedule(DETAIL_TICK_MS);
+    }
   }
 
   function selectedRow(): InternalRow | undefined {
@@ -759,7 +760,7 @@ function createOverlayComponent(
     if (closed) return;
     closed = true;
     clearCloseArm();
-    stopDetailTimer();
+    detailScheduler.dispose();
     try { done(null); } catch { /* ignore */ }
   }
 
@@ -842,7 +843,7 @@ function createOverlayComponent(
     invalidate() {},
     dispose() {
       clearCloseArm();
-      stopDetailTimer();
+      detailScheduler.dispose();
     },
   };
 }

package/src/shared-render-scheduler.ts

@@ -0,0 +1,47 @@
+// Generated from packages/render-scheduler/index.ts. Do not edit directly.
+export interface RenderScheduler {
+  request(): void;
+  schedule(delayMs: number): void;
+  cancel(): void;
+  dispose(): void;
+  pending(): boolean;
+}
+
+/**
+ * Schedule TUI paints as replaceable one-shot deadlines. Callers reschedule
+ * only while visible state still changes; static and hidden UI stays idle.
+ */
+export function createRenderScheduler(requestRender: () => void): RenderScheduler {
+  let timer: ReturnType<typeof setTimeout> | undefined;
+  let disposed = false;
+
+  const cancel = (): void => {
+    if (timer) clearTimeout(timer);
+    timer = undefined;
+  };
+
+  return {
+    request() {
+      if (disposed) return;
+      cancel();
+      requestRender();
+    },
+    schedule(delayMs: number) {
+      if (disposed) return;
+      cancel();
+      timer = setTimeout(() => {
+        timer = undefined;
+        if (!disposed) requestRender();
+      }, Math.max(0, delayMs));
+      timer.unref?.();
+    },
+    cancel,
+    dispose() {
+      disposed = true;
+      cancel();
+    },
+    pending() {
+      return timer !== undefined;
+    },
+  };
+}

package/src/shared-stall-detector.ts

@@ -0,0 +1,69 @@
+// Generated from packages/stall-detector/index.ts. Do not edit directly.
+export interface StallThresholds {
+  /** Age of observable progress before work becomes quiet. */
+  quietMs: number;
+  /** Age of observable progress before work becomes stalled. */
+  stallMs: number;
+}
+
+export type StallState = "healthy" | "quiet" | "stalled" | "unknown";
+
+export interface StallObservation {
+  state: StallState;
+  /** Most recent meaningful evidence, falling back to the start time. */
+  observedAt?: number;
+  ageMs?: number;
+  thresholds: StallThresholds;
+}
+
+export interface ObserveStallInput {
+  now: number;
+  /** Explicit meaningful progress, never a timer tick or metadata write. */
+  lastProgressAt?: number;
+  /** Fallback anchor for work that has not produced progress yet. */
+  startedAt?: number;
+  /** Known active phases that explain a lack of observable progress. */
+  exempt?: boolean;
+  thresholds?: Partial<StallThresholds>;
+}
+
+export const DEFAULT_STALL_THRESHOLDS: Readonly<StallThresholds> = Object.freeze({
+  quietMs: 60_000,
+  stallMs: 5 * 60_000,
+});
+
+function positiveMs(value: unknown, fallback: number): number {
+  const parsed = Number(value);
+  return Number.isFinite(parsed) && parsed > 0 ? Math.floor(parsed) : fallback;
+}
+
+/** Normalize caller config and ensure quiet never exceeds the stall threshold. */
+export function resolveStallThresholds(partial?: Partial<StallThresholds> | null): StallThresholds {
+  const quietMs = positiveMs(partial?.quietMs, DEFAULT_STALL_THRESHOLDS.quietMs);
+  const stallMs = positiveMs(partial?.stallMs, DEFAULT_STALL_THRESHOLDS.stallMs);
+  return { quietMs: Math.min(quietMs, stallMs), stallMs: Math.max(quietMs, stallMs) };
+}
+
+/**
+ * Classify the age of observable progress. This is deliberately observational:
+ * it does not claim a live process is broken and never performs recovery.
+ */
+export function observeStall(input: ObserveStallInput): StallObservation {
+  const thresholds = resolveStallThresholds(input.thresholds);
+  const observedAt = input.lastProgressAt ?? input.startedAt;
+  if (typeof observedAt !== "number" || !Number.isFinite(observedAt)) {
+    return { state: "unknown", thresholds };
+  }
+
+  const ageMs = Math.max(0, input.now - observedAt);
+  if (input.exempt) {
+    return { state: ageMs >= thresholds.quietMs ? "quiet" : "healthy", observedAt, ageMs, thresholds };
+  }
+  if (ageMs >= thresholds.stallMs) {
+    return { state: "stalled", observedAt, ageMs, thresholds };
+  }
+  if (ageMs >= thresholds.quietMs) {
+    return { state: "quiet", observedAt, ageMs, thresholds };
+  }
+  return { state: "healthy", observedAt, ageMs, thresholds };
+}

package/src/stall.ts

@@ -0,0 +1,42 @@
+import { statSync } from "node:fs";
+
+import { observeStall, type StallObservation, type StallThresholds } from "./shared-stall-detector.js";
+import type { BackgroundTaskMeta } from "./types.js";
+
+function durationEnv(name: string): number | undefined {
+  const raw = process.env[name];
+  if (!raw || raw.trim() === "") return undefined;
+  const value = Number(raw);
+  return Number.isFinite(value) && value > 0 ? Math.floor(value) : undefined;
+}
+
+export function backgroundTaskStallThresholds(): Partial<StallThresholds> {
+  return {
+    quietMs: durationEnv("PI_BETTER_STALL_QUIET_MS"),
+    stallMs: durationEnv("PI_BETTER_STALL_MS"),
+  };
+}
+
+/**
+ * Process logs are the only external progress evidence available for detached
+ * commands. Watchers instead advance after a completed poll command.
+ */
+export function backgroundTaskProgressAt(meta: BackgroundTaskMeta): number | undefined {
+  const recorded = Math.max(meta.lastProgressAt ?? 0, meta.lastCheckedAt ?? 0, meta.startedAt);
+  if (meta.kind !== "process") return recorded;
+  try {
+    return Math.max(recorded, Math.trunc(statSync(meta.logPath).mtimeMs));
+  } catch {
+    return recorded;
+  }
+}
+
+export function observeBackgroundTaskStall(meta: BackgroundTaskMeta, now = Date.now()): StallObservation {
+  return observeStall({
+    now,
+    lastProgressAt: backgroundTaskProgressAt(meta),
+    startedAt: meta.startedAt,
+    exempt: meta.status !== "running",
+    thresholds: backgroundTaskStallThresholds(),
+  });
+}

package/src/types.ts

@@ -46,6 +46,8 @@ export interface BackgroundTaskMeta {
   deadlineAt?: number;
   intervalMs?: number;
   lastCheckedAt?: number;
+  /** Latest command completion or observed process log output. */
+  lastProgressAt?: number;
   lastExitCode?: number | null;
   lastSignal?: NodeJS.Signals | null;
   lastState?: unknown;