pi-ask-user 0.10.0 → 0.11.1

package/README.md

@@ -129,7 +129,7 @@ While an `ask_user` prompt is open:
 | `ctrl+g` (configurable via `commentToggleKey`) | Toggle the optional comment/extra-context row (when `allowComment: true`). |
 | `enter` | Confirm the focused option, submit a freeform response, or submit/skip an optional comment. |
 | `esc` | Clear the search filter, exit freeform/comment mode, or cancel the prompt. |
-| `↑` / `↓` | Navigate options. |
+| `↑` / `↓`, `ctrl+k` / `ctrl+j` | Navigate options. `ctrl+k` / `ctrl+j` (vim-style) work while typing in searchable prompts without disturbing the filter. |
 
 If you prefer never to see the overlay, set `displayMode: "inline"` per call or `PI_ASK_USER_DISPLAY_MODE=inline` globally.
 

package/index.ts

@@ -52,6 +52,36 @@ function StringEnum<const T extends readonly string[]>(
    });
 }
 
+/**
+ * `getMarkdownTheme()` returns a bag of closures that read through a Proxy
+ * over the host's theme singleton. The Proxy only throws on property access,
+ * not when the bag itself is constructed — so a naive
+ * `try { getMarkdownTheme() } catch {}` silently lets a broken bag escape
+ * and crashes mid-render the first time pi-tui's Markdown calls
+ * `mdTheme.bold(...)`.
+ *
+ * That broken-bag scenario shows up whenever this extension's bundled copy
+ * of `@earendil-works/pi-coding-agent` is a different module instance than
+ * the host's — e.g. an older Pi still on the legacy
+ * `@mariozechner/pi-coding-agent` scope (≤ 0.73.1) where npm cannot dedupe
+ * across scopes, so our copy's theme singleton is never initialised
+ * (`globalThis[Symbol.for("@earendil-works/pi-coding-agent:theme")]` is
+ * undefined). See https://github.com/edlsh/pi-ask-user/issues/17.
+ *
+ * Probe `bold("")` to force the Proxy lookup eagerly; on throw, callers
+ * fall back to plain `Text` rendering for context blocks.
+ */
+function safeMarkdownTheme(): MarkdownTheme | undefined {
+   try {
+      const md = getMarkdownTheme();
+      if (!md) return undefined;
+      md.bold("");
+      return md;
+   } catch {
+      return undefined;
+   }
+}
+
 type AskOptionInput = QuestionOption | string;
 
 type AskDisplayMode = "overlay" | "inline";
@@ -320,6 +350,27 @@ const COMMENT_TOGGLE_LABEL = "Add extra context after selection";
 const DEFAULT_OVERLAY_TOGGLE_KEY = "alt+o";
 const DEFAULT_COMMENT_TOGGLE_KEY = "ctrl+g";
 
+// Vim-style aliases for navigating option lists. ctrl+j/k are safe in the
+// searchable single-select because they don't collide with fuzzy-search input.
+const VIM_SELECT_UP_KEY = Key.ctrl("k");
+const VIM_SELECT_DOWN_KEY = Key.ctrl("j");
+
+function matchesSelectUp(data: string, keybindings: KeybindingsManager): boolean {
+   return (
+      keybindings.matches(data, "tui.select.up") ||
+      matchesKey(data, Key.shift("tab")) ||
+      matchesKey(data, VIM_SELECT_UP_KEY)
+   );
+}
+
+function matchesSelectDown(data: string, keybindings: KeybindingsManager): boolean {
+   return (
+      keybindings.matches(data, "tui.select.down") ||
+      matchesKey(data, Key.tab) ||
+      matchesKey(data, VIM_SELECT_DOWN_KEY)
+   );
+}
+
 function buildCustomUIOptions(
    displayMode: AskDisplayMode,
    onHandle?: (handle: OverlayHandle) => void,
@@ -449,13 +500,13 @@ class MultiSelectList implements Component {
          return;
       }
 
-      if (this.keybindings.matches(data, "tui.select.up") || matchesKey(data, Key.shift("tab"))) {
+      if (matchesSelectUp(data, this.keybindings)) {
          this.selectedIndex = this.selectedIndex === 0 ? count - 1 : this.selectedIndex - 1;
          this.invalidate();
          return;
       }
 
-      if (this.keybindings.matches(data, "tui.select.down") || matchesKey(data, Key.tab)) {
+      if (matchesSelectDown(data, this.keybindings)) {
          this.selectedIndex = this.selectedIndex === count - 1 ? 0 : this.selectedIndex + 1;
          this.invalidate();
          return;
@@ -764,10 +815,7 @@ class WrappedSingleSelectList implements Component {
    private buildPreviewLines(width: number, filteredOptions: QuestionOption[], maxLines: number): string[] {
       if (maxLines <= 0) return [];
 
-      let mdTheme: MarkdownTheme | undefined;
-      try {
-         mdTheme = getMarkdownTheme();
-      } catch { }
+      const mdTheme = safeMarkdownTheme();
 
       let md = "";
 
@@ -842,13 +890,13 @@ class WrappedSingleSelectList implements Component {
       const filteredOptions = this.getFilteredOptions();
       const count = this.getItemCount(filteredOptions);
 
-      if ((this.keybindings.matches(data, "tui.select.up") || matchesKey(data, Key.shift("tab"))) && count > 0) {
+      if (matchesSelectUp(data, this.keybindings) && count > 0) {
          this.selectedIndex = this.selectedIndex === 0 ? count - 1 : this.selectedIndex - 1;
          this.invalidate();
          return;
       }
 
-      if ((this.keybindings.matches(data, "tui.select.down") || matchesKey(data, Key.tab)) && count > 0) {
+      if (matchesSelectDown(data, this.keybindings) && count > 0) {
          this.selectedIndex = this.selectedIndex === count - 1 ? 0 : this.selectedIndex + 1;
          this.invalidate();
          return;
@@ -1021,10 +1069,7 @@ class AskComponent extends Container {
 
       if (this.context) {
          this.addChild(new Spacer(1));
-         let mdTheme: MarkdownTheme | undefined;
-         try {
-            mdTheme = getMarkdownTheme();
-         } catch { }
+         const mdTheme = safeMarkdownTheme();
          if (mdTheme) {
             this.contextComponent = new Markdown("", 1, 0, mdTheme);
          } else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-ask-user",
-  "version": "0.10.0",
+  "version": "0.11.1",
   "description": "Interactive ask_user tool for pi-coding-agent with searchable split-pane selection UI, multi-select, and freeform input",
   "type": "module",
   "keywords": [
@@ -44,8 +44,8 @@
     "check": "npm pack --dry-run"
   },
   "peerDependencies": {
-    "@earendil-works/pi-coding-agent": "*",
-    "@earendil-works/pi-tui": "*",
+    "@earendil-works/pi-coding-agent": ">=0.74.0",
+    "@earendil-works/pi-tui": ">=0.74.0",
     "@sinclair/typebox": "*"
   }
 }