pi-archimedes 2.10.2 → 2.10.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-archimedes",
-  "version": "2.10.2",
+  "version": "2.10.4",
   "repository": {
     "type": "git",
     "url": "https://github.com/danielcherubini/pi-archimedes.git"
@@ -16,18 +16,18 @@
   ],
   "main": "./src/index.ts",
   "dependencies": {
-    "@pi-archimedes/core": "2.10.2",
-    "@pi-archimedes/footer": "2.10.2",
-    "@pi-archimedes/diff": "2.10.2",
-    "@pi-archimedes/ask": "2.10.2",
-    "@pi-archimedes/image-paste": "2.10.2",
-    "@pi-archimedes/subagent": "2.10.2",
-    "@pi-archimedes/todo": "2.10.2",
-    "@pi-archimedes/notify": "2.10.2",
-    "@pi-archimedes/session-name": "2.10.2",
-    "@pi-archimedes/sudo": "2.10.2",
-    "@pi-archimedes/ui": "2.10.2",
-    "@pi-archimedes/web": "2.10.2"
+    "@pi-archimedes/core": "2.10.4",
+    "@pi-archimedes/footer": "2.10.4",
+    "@pi-archimedes/diff": "2.10.4",
+    "@pi-archimedes/ask": "2.10.4",
+    "@pi-archimedes/image-paste": "2.10.4",
+    "@pi-archimedes/subagent": "2.10.4",
+    "@pi-archimedes/todo": "2.10.4",
+    "@pi-archimedes/notify": "2.10.4",
+    "@pi-archimedes/session-name": "2.10.4",
+    "@pi-archimedes/sudo": "2.10.4",
+    "@pi-archimedes/ui": "2.10.4",
+    "@pi-archimedes/web": "2.10.4"
   },
   "peerDependencies": {
     "@earendil-works/pi-coding-agent": ">=0.1.0",

package/src/settings.test.ts

@@ -0,0 +1,159 @@
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import { readFileSync } from "node:fs";
+
+// ── Panel wiring guard ──────────────────────────────────────────────────────
+//
+// A SettingItem is only changeable in the /archimedes overlay if it either has
+// `values` (←/→ cycles them) or is registered in PROMPTS (Enter opens a
+// free-text/number field). An item with neither renders as a read-only row:
+// the cursor lands on it, every key does nothing, and the user cannot tell the
+// control is inert. `sessionNameModel` shipped that way — it even has a
+// working `onChange` case waiting for a value it could never receive.
+//
+// The second assertion guards the other half of the same class of bug: an item
+// whose id has no `case` in the onChange switch. Such a row can be changed on
+// screen but the edit is never written to settings.json — the same shape as the
+// dead reasoning row reported on #81, caught before it ships again.
+
+vi.mock("@pi-archimedes/core/settings-io", () => {
+  const store: Record<string, unknown> = {};
+  return {
+    loadConfig: vi.fn(
+      (ns: string, defaults: object) =>
+        ({ ...defaults, ...((store[ns] as object) ?? {}) }),
+    ),
+    saveConfig: vi.fn((ns: string, config: object) => {
+      store[ns] = config;
+    }),
+    removeConfig: vi.fn((ns: string) => {
+      delete store[ns];
+    }),
+    isConfigEnabled: vi.fn(() => true),
+    setConfigEnabled: vi.fn(),
+    __store: store,
+  };
+});
+
+import { buildSettingsItems, openSettings, PROMPTS } from "./settings.js";
+import { loadAllConfig } from "./config.js";
+
+// Capture what openSettings hands the manager so the onChange switch can be
+// driven directly, and what lands in settings.json after onSave.
+const managerCalls: Array<{
+  onChange: (id: string, value: string) => void;
+  onSave: () => void;
+  items: Array<{ id: string; currentValue: string }>;
+}> = [];
+
+vi.mock("./settings-manager.js", async (importOriginal) => ({
+  ...(await importOriginal as object),
+  createSettingsManager: vi.fn((opts: any) => {
+    managerCalls.push({ onChange: opts.onChange, onSave: opts.onSave, items: opts.items });
+    return { render: () => [], handleInput: () => {}, invalidate: () => {}, dispose: () => {} };
+  }),
+}));
+
+const store = (vi.mocked(await import("@pi-archimedes/core/settings-io")) as any).__store;
+
+// The mocked settings-io store is module-level, so every test in this file
+// shares it: without this reset a test that saves a model leaks it into
+// whichever test runs next, making the suite order-dependent.
+beforeEach(() => {
+  for (const key of Object.keys(store)) delete store[key];
+  managerCalls.length = 0;
+});
+
+const SOURCE = readFileSync(new URL("./settings.ts", import.meta.url), "utf8");
+
+describe("/archimedes settings panel wiring", () => {
+  it("every item is editable in the panel (has values or a prompt)", async () => {
+    const items = await buildSettingsItems(loadAllConfig());
+    expect(items.length).toBeGreaterThan(0);
+
+    const inert = items
+      .filter((item) => item.values === undefined && !(item.id in PROMPTS))
+      .map((item) => item.id);
+
+    // e.g. ["sessionNameModel"] — a row that renders but swallows every key.
+    expect(inert).toEqual([]);
+  });
+
+  it("every item persists through onChange", async () => {
+    const items = await buildSettingsItems(loadAllConfig());
+
+    const unhandled = items
+      .filter((item) => !SOURCE.includes(`case "${item.id}":`))
+      .map((item) => item.id);
+
+    expect(unhandled).toEqual([]);
+  });
+
+  it("every prompt has a matching label", () => {
+    for (const [id, descriptor] of Object.entries(PROMPTS)) {
+      expect(descriptor.label, id).not.toBe("");
+      expect(["text", "number"]).toContain(descriptor.kind);
+    }
+  });
+});
+
+describe("sessionNameModel editing", () => {
+  async function openPanel() {
+    managerCalls.length = 0;
+    const custom = vi.fn((factory: any) => factory({}, {}, {}, () => {}));
+    // openSettings awaits buildSettingsItems (diff is lazy-imported) before
+    // it reaches ctx.ui.custom, so this must be awaited, not fired and forgotten.
+    await openSettings({} as any, { ui: { custom } } as any);
+    expect(custom).toHaveBeenCalledTimes(1);
+    const panel = managerCalls.at(-1);
+    if (!panel) throw new Error("openSettings never built a settings manager");
+    return panel;
+  }
+
+  function savedModel() {
+    return (store["archimedes.sessionName"] as any)?.model;
+  }
+
+  it("stores a typed model reference", async () => {
+    const panel = await openPanel();
+    panel.onChange("sessionNameModel", "openai/gpt-4o-mini");
+    panel.onSave();
+    expect(savedModel()).toBe("openai/gpt-4o-mini");
+  });
+
+  it("treats a blank field as 'use the current model' and leaves the key unset", async () => {
+    const panel = await openPanel();
+    panel.onChange("sessionNameModel", "   ");
+    panel.onSave();
+    expect(savedModel()).toBeUndefined();
+    expect(JSON.stringify(store["archimedes.sessionName"])).not.toContain('"model"');
+  });
+
+  it("treats the displayed placeholder the same way", async () => {
+    const panel = await openPanel();
+    panel.onChange("sessionNameModel", "(current model)");
+    panel.onSave();
+    expect(savedModel()).toBeUndefined();
+  });
+
+  it("seeds the prompt with an empty field, not the '(current model)' placeholder", async () => {
+    // Enter seeds from item.currentValue; leaving the placeholder there would
+    // prepend it to whatever the user types (the delayMs pitfall).
+    const panel = await openPanel();
+    const item = panel.items.find((i) => i.id === "sessionNameModel");
+    expect(item?.currentValue).toBe("");
+  });
+
+  it("seeds the prompt with the configured model when one is set", async () => {
+    store["archimedes.sessionName"] = { model: "openai/gpt-4o-mini" };
+    const panel = await openPanel();
+    const item = panel.items.find((i) => i.id === "sessionNameModel");
+    expect(item?.currentValue).toBe("openai/gpt-4o-mini");
+  });
+
+  it("trims whitespace around a reference", async () => {
+    const panel = await openPanel();
+    panel.onChange("sessionNameModel", "  anthropic/claude  ");
+    panel.onSave();
+    expect(savedModel()).toBe("anthropic/claude");
+  });
+});

package/src/settings.ts

@@ -19,7 +19,8 @@ import { createSettingsManager, type PromptDescriptor } from "./settings-manager
 
 // ── Free-input prompt descriptors (keyed by item.id) ───────────────────────
 
-const PROMPTS: Record<string, PromptDescriptor> = {
+// Exported for the panel-wiring test: every item must be reachable through PROMPTS or values.
+export const PROMPTS: Record<string, PromptDescriptor> = {
   labelText: { kind: "text", label: "Label text" },
   editorSpinLabel: { kind: "text", label: "Spinner label" },
   labelColor: { kind: "text", label: "RGB color (e.g. 255,215,0)" },
@@ -29,6 +30,11 @@ const PROMPTS: Record<string, PromptDescriptor> = {
   splitThreshold: { kind: "number", label: "Footer split threshold", min: 80 },
   branchMaxLength: { kind: "number", label: "Branch max length", min: 0 },
   delayMs: { kind: "number", label: "Notify delay (seconds)", min: 1 },
+  // A model reference, so free text: the catalogue is only known at runtime and
+  // resolveModel() tolerates canonical provider/id, bare id, and thinking-suffix
+  // forms. Without this entry the row renders but swallows every key — inert
+  // ever since a2bd4d6 added it alongside an onChange case that could never fire.
+  sessionNameModel: { kind: "text", label: "Model for naming (blank = current model)" },
 };
 
 // ── Settings UI ─────────────────────────────────────────────────────────────
@@ -84,6 +90,14 @@ export async function openSettings(pi: ExtensionAPI, ctx: ExtensionContext): Pro
 
   const items = await buildSettingsItems(allConfig);
 
+  // The row displays "(current model)" when unset, but Enter seeds the prompt
+  // from item.currentValue, so a typed reference would be appended to the
+  // placeholder — the same pitfall buildSettingsItems works around for delayMs.
+  // Show an empty field instead, which is what the row's own description and
+  // PROMPTS label both promise ("blank = current model").
+  const modelItem = items.find((i) => i.id === "sessionNameModel");
+  if (modelItem && modelItem.currentValue === "(current model)") modelItem.currentValue = "";
+
   ctx.ui.custom((_tui, theme, _keybindings, done) => {
     const settingsManager = createSettingsManager({
       items,
@@ -144,7 +158,13 @@ export async function openSettings(pi: ExtensionAPI, ctx: ExtensionContext): Pro
           }
 
           // ── Session name settings ──
-          case "sessionNameModel": sessionNameConfig.model = newValue === "(current model)" ? undefined : newValue; break;
+          // Blank and the displayed placeholder both mean "use the current
+          // model", and are stored as unset rather than "" so the key disappears.
+          case "sessionNameModel": {
+            const ref = newValue.trim();
+            sessionNameConfig.model = !ref || ref === "(current model)" ? undefined : ref;
+            break;
+          }
         }
       },
       onSave: () => {