pi-agent-browser-native 0.9.2 → 0.9.4

package/dist/extensions/agent-browser/lib/results/presentation/output-completion.js

@@ -0,0 +1,77 @@
+import { getScreenshotCapture } from "../../orchestration/browser-run/screenshot-capture.js";
+import { isRecord } from "../../parsing.js";
+import { applyArtifactManifest, attachInlineImage, buildArtifactVerificationSummary, buildManifestEntriesForFileArtifacts, extractFileArtifacts, extractImagePath, isManifestFileArtifact, } from "./artifacts.js";
+import { getPresentationPaths } from "./content.js";
+import { compactLargePresentationOutput } from "./large-output.js";
+export async function extractPresentationArtifacts(options, source) {
+    return extractFileArtifacts({
+        artifactManifest: options.artifactManifest,
+        artifactMaxUpdatedAtMs: options.artifactMaxUpdatedAtMs,
+        artifactMinUpdatedAtMs: options.artifactMinUpdatedAtMs,
+        artifactRequest: options.artifactRequest,
+        commandInfo: source.presentationCommandInfo,
+        cwd: options.cwd,
+        data: source.data,
+        namespace: options.namespace,
+        recordingOutcome: source.recordingCommand ? options.envelope?.success : undefined,
+        recordingPending: options.recordingPending,
+        previousRecordingContactSheetPath: options.previousRecordingContactSheetPath,
+        sessionName: options.sessionName,
+    });
+}
+function getAttachableImage(options, source, artifacts) {
+    const path = getImagePath(options, source, artifacts);
+    if (path === undefined ||
+        path.length === 0 ||
+        (isRecord(source.data) && source.data.changed === false)) {
+        return undefined;
+    }
+    return artifacts.some((artifact) => artifact.absolutePath === path &&
+        ["missing", "stale", "failed"].includes(artifact.status ?? ""))
+        ? undefined
+        : path;
+}
+function getImagePath(options, source, artifacts) {
+    return (options.artifactRequest?.absolutePath ??
+        extractImagePath(options.commandInfo, options.cwd, source.data) ??
+        (source.recordingCommand
+            ? artifacts.find((artifact) => artifact.kind === "image" && artifact.status === "saved")
+                ?.absolutePath
+            : undefined));
+}
+async function attachPresentationImage(draft, options, source, artifacts) {
+    const imagePath = getAttachableImage(options, source, artifacts);
+    const withImage = imagePath === undefined
+        ? draft
+        : await attachInlineImage(draft, imagePath, options.modelVisible);
+    if (options.commandInfo.command === "screenshot" && withImage.imageObservations) {
+        const capture = getScreenshotCapture(source.commandInfo.commandTokens ?? []).kind;
+        withImage.imageObservations = withImage.imageObservations.map((image) => Object.assign({}, image, { capture }));
+    }
+    return withImage;
+}
+export async function completePresentationOutput(draft, options, source, artifacts) {
+    if (artifacts.length > 0 && !draft.artifacts) {
+        draft.artifacts = artifacts;
+    }
+    draft.artifactVerification ??= buildArtifactVerificationSummary(artifacts);
+    const withImage = await attachPresentationImage(draft, options, source, artifacts);
+    const compacted = options.modelVisible === false
+        ? withImage
+        : await compactLargePresentationOutput({
+            artifactManifest: options.artifactManifest,
+            commandInfo: options.commandInfo,
+            data: source.presentationData,
+            persistentArtifactStore: options.persistentArtifactStore,
+            presentation: withImage,
+        });
+    const withManifest = applyArtifactManifest(compacted, compacted.artifactManifest ?? options.artifactManifest, buildManifestEntriesForFileArtifacts(artifacts.filter(isManifestFileArtifact)));
+    const currentSpillPaths = new Set(getPresentationPaths({
+        primaryPath: withManifest.fullOutputPath,
+        secondaryPaths: withManifest.fullOutputPaths,
+    }));
+    withManifest.artifactVerification =
+        buildArtifactVerificationSummary(artifacts, withManifest.artifactManifest, currentSpillPaths) ??
+            withManifest.artifactVerification;
+    return withManifest;
+}

package/dist/extensions/agent-browser/lib/results/presentation/output-spill.js

@@ -0,0 +1,51 @@
+import { writePersistentSessionArtifactFile, writeSecureTempFile, } from "../../temp.js";
+import { buildEvictedSessionArtifactEntries } from "../artifact-manifest.js";
+import { redactModelFacingText, stringifyModelFacing } from "./common.js";
+function serializePayload(data, text) {
+    if (typeof data === "string") {
+        return redactModelFacingText(data);
+    }
+    if (typeof data === "number" || typeof data === "boolean") {
+        return String(data);
+    }
+    return data === undefined ? redactModelFacingText(text) : stringifyModelFacing(data);
+}
+export async function writeLargeOutputSpillFile(options) {
+    const isStructured = typeof options.data !== "string" &&
+        typeof options.data !== "number" &&
+        typeof options.data !== "boolean";
+    const fileOptions = {
+        content: serializePayload(options.data, options.text),
+        prefix: "pi-agent-browser-output",
+        suffix: isStructured ? ".json" : ".txt",
+    };
+    if (options.persistentArtifactStore) {
+        return {
+            ...(await writePersistentSessionArtifactFile({
+                ...fileOptions,
+                store: options.persistentArtifactStore,
+            })),
+            storageScope: "persistent-session",
+        };
+    }
+    return {
+        evictedArtifacts: [],
+        path: await writeSecureTempFile(fileOptions),
+        storageScope: "process-temp",
+    };
+}
+export function buildSpillArtifactEntries(options) {
+    const nowMs = Date.now();
+    return [
+        {
+            command: options.commandInfo.command,
+            createdAtMs: nowMs,
+            kind: "spill",
+            path: options.path,
+            retentionState: options.storageScope === "persistent-session" ? "live" : "ephemeral",
+            storageScope: options.storageScope,
+            subcommand: options.commandInfo.subcommand,
+        },
+        ...buildEvictedSessionArtifactEntries(options.evictedArtifacts, nowMs),
+    ];
+}

package/dist/extensions/agent-browser/lib/results/presentation/registry.js

@@ -1,265 +1,145 @@
 import { isRecord } from "../../parsing.js";
-import { detectConfirmationRequired } from "../confirmation.js";
-import { formatRawSnapshotText, formatSnapshotSummary } from "../snapshot.js";
-import { getPageSummary, omitUpstreamLifecycle, redactModelFacingText, stringifyModelFacing } from "./common.js";
-import { formatDiagnosticSummary, formatDiagnosticText, formatProfilesText, getStreamSummary, getTabSummary } from "./diagnostics.js";
-import { getScreenshotSummary } from "./artifacts.js";
-import { formatSkillsText } from "./skills.js";
+import { getNativeTabContinuationGuidance } from "../../read-confirmation.js";
+import { detectConfirmationRequired, } from "../confirmation.js";
+import { getPageSummary, omitUpstreamLifecycle, redactModelFacingText, stringifyModelFacing, } from "./common.js";
+import { formatDiagnosticSummary, formatDiagnosticText } from "./diagnostics.js";
 import { formatExtractionSummary, formatExtractionText, formatNavigationActionResult, formatNavigationSummary, getNavigationSummary, isNavigationObservableCommand, } from "./navigation.js";
 import { formatSemanticActionPresentationSummary, formatSemanticActionPresentationText, resolvePresentationCommandInfo, } from "./semantic-action.js";
-function formatConfirmationRequiredSummary(confirmation) {
-    return `Confirmation required: ${confirmation.id}`;
-}
-const SIMPLE_ACTION_RESULTS = {
-    check: { field: "checked", label: "Checked" },
-    click: { field: "clicked", label: "Clicked" },
-    fill: { field: "filled", label: "Filled" },
-    focus: { field: "focused", label: "Focused" },
-    hover: { field: "hovered", label: "Hovered" },
-    press: { field: "pressed", label: "Pressed" },
-    select: { field: "selected", label: "Selected" },
-    type: { field: "typed", label: "Typed" },
-    uncheck: { field: "unchecked", label: "Unchecked" },
-};
-function formatSimpleActionResult(command, data) {
-    if (!isRecord(data))
-        return undefined;
-    if (command === "click" && getNavigationSummary(data))
-        return undefined;
-    const definition = SIMPLE_ACTION_RESULTS[command];
-    if (!definition)
-        return undefined;
-    const value = data[definition.field];
-    if (typeof value !== "string" && typeof value !== "number" && typeof value !== "boolean")
-        return undefined;
-    return `${definition.label}: ${redactModelFacingText(String(value))}`;
+import { COMMAND_PRESENTERS } from "./command-presenters.js";
+function formatConfirmationRequiredText(confirmation) {
+    const lines = ["Confirmation required.", `Pending confirmation id: ${confirmation.id}`];
+    if (confirmation.actionText !== undefined && confirmation.actionText.length > 0) {
+        lines.push(`Action: ${confirmation.actionText}`);
+    }
+    lines.push("", "Next steps:", `- Approve: { "args": ["confirm", "${confirmation.id}"] }`, `- Deny: { "args": ["deny", "${confirmation.id}"] }`);
+    return lines.join("\n");
 }
-function formatWaitResult(data) {
-    if (!isRecord(data))
+function formatBatchSummary(data) {
+    if (!Array.isArray(data)) {
         return undefined;
-    if (data.waited === "timeout")
-        return "Fixed wait elapsed; no page condition was verified.";
-    for (const field of ["selector", "text", "url", "state", "waited"]) {
-        const value = data[field];
-        if (typeof value === "string" && value.length > 0)
-            return `Wait completed: ${redactModelFacingText(value)}`;
     }
-    return undefined;
-}
-function formatCloseResult(data) {
-    return isRecord(data) && data.closed === true ? "Browser session closed." : undefined;
+    const count = data.filter((item) => isRecord(item) && item.success !== false).length;
+    return count === data.length
+        ? `Batch: ${count}/${data.length} succeeded`
+        : `Batch failed: ${count}/${data.length} succeeded`;
 }
-const VITALS_METRICS = ["lcp", "fcp", "ttfb", "inp", "cls"];
-function coerceVitalsMetricValue(value) {
-    if (typeof value === "number" && Number.isFinite(value))
-        return value;
-    if (isRecord(value)) {
-        for (const nestedKey of ["value", "duration", "startTime", "score"]) {
-            const nestedValue = value[nestedKey];
-            if (typeof nestedValue === "number" && Number.isFinite(nestedValue))
-                return nestedValue;
+function firstNonemptyResult(formatters) {
+    for (const format of formatters) {
+        const result = format();
+        if (result !== undefined && result.length > 0) {
+            return result;
         }
     }
     return undefined;
 }
-function getVitalsMetric(data, key) {
-    const metrics = isRecord(data.metrics) ? data.metrics : undefined;
-    return coerceVitalsMetricValue(data[key] ?? data[key.toUpperCase()] ?? metrics?.[key] ?? metrics?.[key.toUpperCase()]);
-}
-function formatVitalsMetric(key, value) {
-    return key === "cls" ? `${key.toUpperCase()}: ${value}` : `${key.toUpperCase()}: ${Math.round(value)}ms`;
-}
-function getVitalsMetrics(data) {
-    return VITALS_METRICS.flatMap((key) => {
-        const value = getVitalsMetric(data, key);
-        return value === undefined ? [] : [formatVitalsMetric(key, value)];
-    });
-}
-function getVitalsUnavailableReason(data) {
-    for (const key of ["reason", "message", "error", "status"]) {
-        const value = data[key];
-        if (typeof value === "string" && value.trim().length > 0)
-            return redactModelFacingText(value.trim());
+function formatObservedNavigation(mode, command, data) {
+    const navigation = getNavigationSummary(data);
+    if (!navigation || !isNavigationObservableCommand(command.command, command.subcommand)) {
+        return undefined;
+    }
+    const text = formatNavigationSummary(navigation);
+    if (text === undefined || text.length === 0) {
+        return undefined;
     }
-    return "No Core Web Vitals metric fields were present in the upstream result.";
+    if (mode === "summary") {
+        return `${command.command ?? "navigation"} → ${text.split("\n", 1).at(0) ?? text}`;
+    }
+    const action = formatNavigationActionResult(data);
+    return action !== undefined && action.length > 0
+        ? `${action}\n\nCurrent page:\n${text}`
+        : `Current page:\n${text}`;
 }
-function formatVitalsText(data) {
-    const url = typeof data.url === "string" && data.url.trim().length > 0 ? redactModelFacingText(data.url.trim()) : undefined;
-    const metrics = getVitalsMetrics(data);
-    const lines = [url ? `Vitals for ${url}` : "Vitals result"];
-    if (metrics.length > 0)
-        lines.push(...metrics.map((metric) => `- ${metric}`));
-    else
-        lines.push(`Metrics unavailable: ${getVitalsUnavailableReason(data)}`);
-    return lines.join("\n");
+function formatPageAction(mode, command, data, compiled) {
+    if (compiled) {
+        const format = mode === "summary"
+            ? formatSemanticActionPresentationSummary
+            : formatSemanticActionPresentationText;
+        const text = format(compiled, data);
+        if (text !== undefined && text.length > 0) {
+            return text;
+        }
+    }
+    return formatObservedNavigation(mode, resolvePresentationCommandInfo(command, compiled), data);
 }
-function formatVitalsSummary(data) {
-    const metrics = getVitalsMetrics(data);
-    if (metrics.length > 0)
-        return `Vitals: ${metrics.join(", ")}`;
-    return "Vitals: metrics unavailable";
+function formatPageContentFallback(mode, data) {
+    const page = getPageSummary(data);
+    if (page !== undefined && page.length > 0) {
+        return mode === "summary"
+            ? (page.split("\n", 1).at(0) ?? "agent-browser result")
+            : redactModelFacingText(page);
+    }
+    if (mode === "text") {
+        const { navigationSummary: _navigationSummary, ...content } = omitUpstreamLifecycle(data);
+        if (Object.keys(content).length > 0) {
+            return stringifyModelFacing(content);
+        }
+    }
+    return undefined;
 }
-function formatConfirmationRequiredText(confirmation) {
-    const lines = [
-        "Confirmation required.",
-        `Pending confirmation id: ${confirmation.id}`,
-    ];
-    if (confirmation.actionText)
-        lines.push(`Action: ${confirmation.actionText}`);
-    lines.push("", "Next steps:", `- Approve: { "args": ["confirm", "${confirmation.id}"] }`, `- Deny: { "args": ["deny", "${confirmation.id}"] }`);
-    return lines.join("\n");
+function formatPageFallback(mode, command, data) {
+    const diagnostic = mode === "summary" ? formatDiagnosticSummary : formatDiagnosticText;
+    const extraction = mode === "summary" ? formatExtractionSummary : formatExtractionText;
+    const formatters = mode === "summary" ? [diagnostic, extraction] : [extraction, diagnostic];
+    return (firstNonemptyResult(formatters.map((format) => () => format(command, data))) ??
+        formatPageContentFallback(mode, data));
 }
-const COMMAND_PRESENTERS = {
-    ...Object.fromEntries(Object.keys(SIMPLE_ACTION_RESULTS).map((command) => [command, {
-            summary: (_commandInfo, data) => formatSimpleActionResult(command, data),
-            text: (_commandInfo, data) => formatSimpleActionResult(command, data),
-        }])),
-    close: { summary: (_commandInfo, data) => formatCloseResult(data), text: (_commandInfo, data) => formatCloseResult(data) },
-    exit: { summary: (_commandInfo, data) => formatCloseResult(data), text: (_commandInfo, data) => formatCloseResult(data) },
-    quit: { summary: (_commandInfo, data) => formatCloseResult(data), text: (_commandInfo, data) => formatCloseResult(data) },
-    wait: { summary: (_commandInfo, data) => formatWaitResult(data), text: (_commandInfo, data) => formatWaitResult(data) },
-    profiles: {
-        summary: (_commandInfo, data) => Array.isArray(data) ? `Chrome profiles: ${data.length}` : undefined,
-        text: (_commandInfo, data) => Array.isArray(data) ? formatProfilesText(data, "Chrome profiles") : undefined,
-    },
-    read: {
-        summary: (_commandInfo, data) => isRecord(data) && typeof (data.finalUrl ?? data.url) === "string" ? `Read: ${data.finalUrl ?? data.url}` : undefined,
-        text: (_commandInfo, data) => isRecord(data) && typeof data.content === "string" ? redactModelFacingText(data.content) : undefined,
-    },
-    screenshot: {
-        summary: (_commandInfo, data) => isRecord(data) && data.changed === false ? getScreenshotSummary(data) : isRecord(data) && typeof data.path === "string" ? `Screenshot saved: ${data.path}` : undefined,
-        text: (_commandInfo, data) => isRecord(data) ? getScreenshotSummary(data) : undefined,
-    },
-    skills: {
-        summary: (commandInfo, data) => {
-            if (Array.isArray(data) && commandInfo.subcommand === "list")
-                return `agent-browser skills: ${data.length}`;
-            if (commandInfo.subcommand === "get")
-                return "agent-browser skill loaded";
-            if (commandInfo.subcommand === "path")
-                return "agent-browser skill path";
-            return undefined;
-        },
-        text: formatSkillsText,
-    },
-    snapshot: {
-        summary: (_commandInfo, data) => isRecord(data) ? formatSnapshotSummary(data) : undefined,
-        text: (_commandInfo, data) => isRecord(data) ? formatRawSnapshotText(data) : undefined,
-    },
-    stream: {
-        summary: (commandInfo, data) => {
-            if (!isRecord(data) || commandInfo.subcommand !== "status")
-                return undefined;
-            const port = typeof data.port === "number" ? ` on port ${data.port}` : "";
-            return `Stream ${data.enabled === true ? "enabled" : "disabled"}${port}`;
-        },
-        text: (commandInfo, data) => isRecord(data) && commandInfo.subcommand === "status" ? getStreamSummary(data) : undefined,
-    },
-    tab: {
-        summary: (_commandInfo, data) => isRecord(data) && Array.isArray(data.tabs)
-            ? `Tabs: ${data.tabs.length}`
-            : isRecord(data) && data.closed === true ? "Tab closed" : undefined,
-        text: (_commandInfo, data) => isRecord(data) && data.closed === true
-            ? `Tab closed${typeof data.tabId === "string" ? `: ${redactModelFacingText(data.tabId)}` : "."}`
-            : isRecord(data) ? getTabSummary(data) : undefined,
-    },
-    vitals: {
-        summary: (_commandInfo, data) => isRecord(data) ? formatVitalsSummary(data) : undefined,
-        text: (_commandInfo, data) => isRecord(data) ? formatVitalsText(data) : undefined,
-    },
-    "web-vitals": {
-        summary: (_commandInfo, data) => isRecord(data) ? formatVitalsSummary(data) : undefined,
-        text: (_commandInfo, data) => isRecord(data) ? formatVitalsText(data) : undefined,
-    },
-};
-function formatBatchSummary(data) {
-    if (!Array.isArray(data))
-        return undefined;
-    const successCount = data.filter((item) => isRecord(item) && item.success !== false).length;
-    return successCount === data.length
-        ? `Batch: ${successCount}/${data.length} succeeded`
-        : `Batch failed: ${successCount}/${data.length} succeeded`;
+function formatNativeCommand(mode, command, data) {
+    const presenter = command.command !== undefined ? COMMAND_PRESENTERS[command.command] : undefined;
+    const format = mode === "summary" ? presenter?.summary : presenter?.text;
+    return format?.(command, data);
 }
-export function formatPresentationSummary(commandInfo, data, compiledSemanticAction) {
-    const confirmationRequired = detectConfirmationRequired(data);
-    if (confirmationRequired)
-        return formatConfirmationRequiredSummary(confirmationRequired);
-    const presentationCommandInfo = resolvePresentationCommandInfo(commandInfo, compiledSemanticAction);
-    if (commandInfo.command === "batch") {
-        const batchSummary = formatBatchSummary(data);
-        if (batchSummary)
-            return batchSummary;
+export function formatPresentationSummary(command, data, compiled) {
+    const confirmation = detectConfirmationRequired(data);
+    if (confirmation) {
+        return `Confirmation required: ${confirmation.id}`;
+    }
+    const text = firstNonemptyResult([
+        () => (command.command === "batch" ? formatBatchSummary(data) : undefined),
+        () => (isRecord(data) ? formatPageAction("summary", command, data, compiled) : undefined),
+        () => formatNativeCommand("summary", command, data),
+    ]);
+    if (text !== undefined) {
+        return text;
     }
     if (isRecord(data)) {
-        if (compiledSemanticAction) {
-            const semanticSummary = formatSemanticActionPresentationSummary(compiledSemanticAction, data);
-            if (semanticSummary)
-                return semanticSummary;
-        }
-        const navigationSummary = getNavigationSummary(data);
-        if (navigationSummary && isNavigationObservableCommand(presentationCommandInfo.command, presentationCommandInfo.subcommand)) {
-            const navigationText = formatNavigationSummary(navigationSummary);
-            if (navigationText) {
-                return `${presentationCommandInfo.command ?? "navigation"} → ${navigationText.split("\n", 1)[0] ?? navigationText}`;
-            }
+        const fallback = formatPageFallback("summary", command, data);
+        if (fallback !== undefined) {
+            return fallback;
         }
     }
-    const presenterSummary = commandInfo.command ? COMMAND_PRESENTERS[commandInfo.command]?.summary?.(commandInfo, data) : undefined;
-    if (presenterSummary)
-        return presenterSummary;
-    if (isRecord(data)) {
-        const diagnosticSummary = formatDiagnosticSummary(commandInfo, data);
-        if (diagnosticSummary)
-            return diagnosticSummary;
-        const extractionSummary = formatExtractionSummary(commandInfo, data);
-        if (extractionSummary)
-            return extractionSummary;
-        const pageSummary = getPageSummary(data);
-        if (pageSummary)
-            return pageSummary.split("\n", 1)[0] ?? "agent-browser result";
+    if (typeof data === "string" && data.length > 0) {
+        return data.split("\n", 1).at(0) ?? data;
     }
-    if (typeof data === "string" && data.length > 0)
-        return data.split("\n", 1)[0] ?? data;
-    return `${presentationCommandInfo.command ?? commandInfo.command ?? "agent-browser"} completed`;
+    return `${resolvePresentationCommandInfo(command, compiled).command ?? command.command ?? "agent-browser"} completed`;
 }
-export function formatPresentationContentText(commandInfo, data, compiledSemanticAction) {
-    const confirmationRequired = detectConfirmationRequired(data);
-    if (confirmationRequired)
-        return formatConfirmationRequiredText(confirmationRequired);
-    const presenterText = commandInfo.command ? COMMAND_PRESENTERS[commandInfo.command]?.text?.(commandInfo, data) : undefined;
-    if (presenterText)
-        return presenterText;
-    if (typeof data === "string")
+function formatPageResultText(command, data, compiled) {
+    const action = formatPageAction("text", command, data, compiled);
+    const text = action !== undefined && action.length > 0 ? action : formatPageFallback("text", command, data);
+    return (text ??
+        `${resolvePresentationCommandInfo(command, compiled).command ?? command.command ?? "agent-browser"} completed`);
+}
+function formatContentValue(data) {
+    if (typeof data === "string") {
         return redactModelFacingText(data);
-    if (typeof data === "number" || typeof data === "boolean")
+    }
+    if (typeof data === "number" || typeof data === "boolean") {
         return String(data);
-    if (!isRecord(data))
-        return stringifyModelFacing(data);
-    if (compiledSemanticAction) {
-        const semanticText = formatSemanticActionPresentationText(compiledSemanticAction, data);
-        if (semanticText)
-            return semanticText;
     }
-    const presentationCommandInfo = resolvePresentationCommandInfo(commandInfo, compiledSemanticAction);
-    const navigationSummary = getNavigationSummary(data);
-    if (navigationSummary && isNavigationObservableCommand(presentationCommandInfo.command, presentationCommandInfo.subcommand)) {
-        const navigationText = formatNavigationSummary(navigationSummary);
-        if (navigationText) {
-            const actionText = formatNavigationActionResult(data);
-            return actionText ? `${actionText}\n\nCurrent page:\n${navigationText}` : `Current page:\n${navigationText}`;
-        }
+    return stringifyModelFacing(data);
+}
+export function formatPresentationContentText(command, data, compiled) {
+    const confirmation = detectConfirmationRequired(data);
+    if (confirmation) {
+        return [
+            formatConfirmationRequiredText(confirmation),
+            getNativeTabContinuationGuidance(command.commandTokens ?? [], data),
+        ]
+            .filter(Boolean)
+            .join("\n\n");
+    }
+    const native = formatNativeCommand("text", command, data);
+    if (native !== undefined && native.length > 0) {
+        return native;
     }
-    const extractionText = formatExtractionText(commandInfo, data);
-    if (extractionText)
-        return extractionText;
-    const diagnosticText = formatDiagnosticText(commandInfo, data);
-    if (diagnosticText)
-        return diagnosticText;
-    const pageSummary = getPageSummary(data);
-    if (pageSummary)
-        return redactModelFacingText(pageSummary);
-    const { navigationSummary: _navigationSummary, ...pageData } = omitUpstreamLifecycle(data);
-    if (Object.keys(pageData).length > 0)
-        return stringifyModelFacing(pageData);
-    return `${presentationCommandInfo.command ?? commandInfo.command ?? "agent-browser"} completed`;
+    return isRecord(data) ? formatPageResultText(command, data, compiled) : formatContentValue(data);
 }

package/dist/extensions/agent-browser/lib/results/presentation/semantic-action.js

@@ -4,20 +4,25 @@ import { formatNavigationSummary, getNavigationSummary, isNavigationObservableCo
 import { getPageSummary, redactModelFacingText } from "./common.js";
 const SEMANTIC_NAVIGATION_PROBE_ACTIONS = new Set(["check", "click"]);
 const SEMANTIC_PRESENTATION_ACTIONS = new Set(["check", "click", "fill", "select"]);
+function formatSemanticSelectTarget(compiled) {
+    const selector = compiled.selector ?? "selector";
+    const values = compiled.values !== undefined && compiled.values.length > 0 ? compiled.values.join(", ") : "";
+    return values.length > 0 ? `${selector} → ${values}` : selector;
+}
 function formatSemanticActionTarget(compiled) {
     if (compiled.action === "select") {
-        const selector = compiled.selector ?? "selector";
-        const values = compiled.values?.length ? compiled.values.join(", ") : "";
-        return values ? `${selector} → ${values}` : selector;
+        return formatSemanticSelectTarget(compiled);
     }
     const commandIndex = getCompiledSemanticActionCommandIndex(compiled);
-    const locator = compiled.locator ?? compiled.args[commandIndex + 1] ?? "locator";
-    const locatorValue = compiled.args[commandIndex + 2];
+    const locator = compiled.locator ?? compiled.args.at(commandIndex + 1) ?? "locator";
+    const locatorValue = compiled.args.at(commandIndex + 2);
     const nameIndex = compiled.args.indexOf("--name");
-    const name = nameIndex >= 0 ? compiled.args[nameIndex + 1] : undefined;
+    const name = nameIndex >= 0 ? compiled.args.at(nameIndex + 1) : undefined;
     const quotedValue = JSON.stringify(locatorValue ?? "");
     const target = `${locator} ${quotedValue}`;
-    return name ? `${target} (name ${JSON.stringify(name)})` : target;
+    return name !== undefined && name.length > 0
+        ? `${target} (name ${JSON.stringify(name)})`
+        : target;
 }
 function formatSemanticActionCompactLine(compiled) {
     const target = formatSemanticActionTarget(compiled);
@@ -30,61 +35,70 @@ function formatSemanticActionCompactLine(compiled) {
             return `Checked: ${target}`;
         case "select":
             return `Selected: ${target}`;
-        default:
-            return `${compiled.action}: ${target}`;
     }
 }
 function resolveSemanticPresentationCommand(compiled) {
-    if (!compiled || !SEMANTIC_PRESENTATION_ACTIONS.has(compiled.action))
+    if (!compiled || !SEMANTIC_PRESENTATION_ACTIONS.has(compiled.action)) {
         return undefined;
-    if (compiled.action === "select")
+    }
+    if (compiled.action === "select") {
         return "select";
-    if (isCompiledSemanticActionFindCommand(compiled))
+    }
+    if (isCompiledSemanticActionFindCommand(compiled)) {
         return compiled.action;
+    }
     return undefined;
 }
 export function resolvePresentationCommandInfo(commandInfo, compiledSemanticAction) {
     const presentationCommand = resolveSemanticPresentationCommand(compiledSemanticAction);
-    if (!presentationCommand)
+    if (presentationCommand === undefined) {
         return commandInfo;
+    }
     return { ...commandInfo, command: presentationCommand };
 }
 export function shouldCaptureSemanticActionNavigationSummary(compiled, data) {
-    if (!compiled || !SEMANTIC_NAVIGATION_PROBE_ACTIONS.has(compiled.action))
+    if (!compiled || !SEMANTIC_NAVIGATION_PROBE_ACTIONS.has(compiled.action)) {
         return false;
-    if (!isCompiledSemanticActionFindCommand(compiled))
+    }
+    if (!isCompiledSemanticActionFindCommand(compiled)) {
         return false;
+    }
     return !isRecord(data) || (typeof data.title !== "string" && typeof data.url !== "string");
 }
 export function formatSemanticActionPresentationText(compiled, data) {
     const presentationCommand = resolveSemanticPresentationCommand(compiled);
-    if (!presentationCommand)
+    if (presentationCommand === undefined) {
         return undefined;
+    }
     const actionLine = formatSemanticActionCompactLine(compiled);
     const navigationSummary = getNavigationSummary(data);
     if (navigationSummary && isNavigationObservableCommand(presentationCommand)) {
         const navigationText = formatNavigationSummary(navigationSummary);
-        if (navigationText)
+        if (navigationText !== undefined && navigationText.length > 0) {
             return `${actionLine}\n\nCurrent page:\n${navigationText}`;
+        }
     }
     const pageSummary = getPageSummary(data);
-    if (pageSummary)
+    if (pageSummary !== undefined && pageSummary.length > 0) {
         return `${actionLine}\n\nCurrent page:\n${redactModelFacingText(pageSummary)}`;
+    }
     return actionLine;
 }
 export function formatSemanticActionPresentationSummary(compiled, data) {
     const presentationCommand = resolveSemanticPresentationCommand(compiled);
-    if (!presentationCommand)
+    if (presentationCommand === undefined) {
         return undefined;
+    }
     const navigationSummary = getNavigationSummary(data);
     if (navigationSummary && isNavigationObservableCommand(presentationCommand)) {
         const navigationText = formatNavigationSummary(navigationSummary);
-        if (navigationText) {
+        if (navigationText !== undefined && navigationText.length > 0) {
             return `${presentationCommand} → ${navigationText.split("\n", 1)[0] ?? navigationText}`;
         }
     }
     const pageSummary = getPageSummary(data);
-    if (pageSummary)
+    if (pageSummary !== undefined && pageSummary.length > 0) {
         return `${presentationCommand} → ${pageSummary.split("\n", 1)[0] ?? pageSummary}`;
+    }
     return `${presentationCommand} → ${formatSemanticActionTarget(compiled)}`;
 }