pi-agent-browser-native 0.2.61 → 0.2.63

package/dist/extensions/agent-browser/lib/orchestration/browser-run/prepare.js

@@ -10,11 +10,12 @@ import { trySnapshotFilter } from "./prepare/snapshot-filter.js";
 import { getWaitAwareProcessTimeoutMs } from "./prepare/wait-timeouts.js";
 import { getPersistentSessionArtifactStore } from "./session-artifacts.js";
 import { buildAgentBrowserResultCategoryDetails } from "../../results.js";
+import { applyNamespaceToNextActions } from "../../results/next-actions.js";
 import { buildSessionAwareStaleRefNextActions, buildSessionTabRecoveryNextActions } from "../../results/recovery-next-actions.js";
 import { resolveVisibleRefActionFromSnapshot } from "../../results/selector-recovery.js";
 import { extractRefSnapshotFromData } from "../../session-page-state.js";
 import { buildExecutionPlan, createFreshSessionName, extractCommandTokens, redactInvocationArgs, } from "../../runtime.js";
-import { applyOpenResultTabCorrection, buildManagedSessionOutcome, buildPinnedBatchPlan, buildSessionDetailFields, buildStaleRefPreflight, collectSessionTabSelection, getGuardedRefUsage, getTraceOwnerGuardMessage, runSessionCommandData, shouldPinSessionTabForCommand, } from "./session-state.js";
+import { applyOpenResultTabCorrection, buildManagedSessionOutcome, buildPinnedBatchPlan, buildSessionDetailFields, buildStaleRefPreflight, getSessionContextKey, collectSessionTabSelection, getGuardedRefUsage, getTraceOwnerGuardMessage, runSessionCommandData, shouldPinSessionTabForCommand, } from "./session-state.js";
 import { parseBatchStdinJsonArray } from "../batch-stdin.js";
 import { buildElectronHostFailureResult, getElectronLaunchFailureCategory, redactRecoveryHint } from "./final-result.js";
 import { prepareClickDispatchProbe } from "./click-dispatch.js";
@@ -242,7 +243,7 @@ async function collectSamePageRefFreshnessPreflight(options) {
     const currentTargetUrl = options.currentTarget?.url;
     if (currentTargetUrl === "about:blank" || (previousUrl && currentTargetUrl && previousUrl !== currentTargetUrl))
         return undefined;
-    const snapshotData = await runSessionCommandData({ args: ["snapshot", "-i"], cwd: options.cwd, sessionName: options.sessionName, signal: options.signal });
+    const snapshotData = await runSessionCommandData({ args: ["snapshot", "-i"], cwd: options.cwd, namespace: options.namespace, sessionName: options.sessionName, signal: options.signal });
     const currentSnapshot = extractRefSnapshotFromData(snapshotData);
     if (!currentSnapshot)
         return undefined;
@@ -280,7 +281,7 @@ export function validateStdinCommandContract(options) {
 export async function resolveSemanticActionVisibleRefArgs(options) {
     if (!options.compiled || !options.sessionName || options.compiled.locator !== "role" || !["check", "click", "fill"].includes(options.compiled.action))
         return undefined;
-    const snapshotData = await runSessionCommandData({ args: ["snapshot", "-i"], cwd: options.cwd, sessionName: options.sessionName, signal: options.signal });
+    const snapshotData = await runSessionCommandData({ args: ["snapshot", "-i"], cwd: options.cwd, namespace: options.namespace, sessionName: options.sessionName, signal: options.signal });
     const resolution = resolveVisibleRefActionFromSnapshot({ allowFill: true, compiledAction: options.compiled, snapshotData });
     if (!resolution)
         return undefined;
@@ -328,6 +329,7 @@ export async function prepareBrowserRun(options) {
         freshSessionName,
         managedSessionActive: state.managedSessionActive,
         managedSessionName: state.managedSessionName,
+        managedSessionNamespace: state.managedSessionNamespace,
         sessionMode,
     });
     let semanticActionVisibleRefResolution;
@@ -335,6 +337,7 @@ export async function prepareBrowserRun(options) {
         semanticActionVisibleRefResolution = await resolveSemanticActionVisibleRefArgs({
             compiled: compiledSemanticAction,
             cwd,
+            namespace: executionPlan.namespace,
             sessionName: executionPlan.sessionName,
             signal,
         });
@@ -343,6 +346,7 @@ export async function prepareBrowserRun(options) {
                 freshSessionName,
                 managedSessionActive: state.managedSessionActive,
                 managedSessionName: state.managedSessionName,
+                managedSessionNamespace: state.managedSessionNamespace,
                 sessionMode,
             });
         }
@@ -382,9 +386,10 @@ export async function prepareBrowserRun(options) {
         commandTokens,
         stdin: runtimeToolStdin,
     });
+    const sessionStateKey = getSessionContextKey(executionPlan.sessionName, executionPlan.namespace);
     const traceOwnerGuardMessage = getTraceOwnerGuardMessage({
         command: executionPlan.commandInfo.command,
-        sessionName: executionPlan.sessionName,
+        sessionName: sessionStateKey,
         subcommand: executionPlan.commandInfo.subcommand,
         traceOwners,
     });
@@ -399,7 +404,7 @@ export async function prepareBrowserRun(options) {
                     sessionMode,
                     ...buildAgentBrowserResultCategoryDetails({ args: redactedEffectiveArgs, command: executionPlan.commandInfo.command, errorText: traceOwnerGuardMessage, succeeded: false, validationError: traceOwnerGuardMessage }),
                     validationError: traceOwnerGuardMessage,
-                    ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession),
+                    ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession, executionPlan.namespace),
                 },
                 isError: true,
             } };
@@ -420,12 +425,12 @@ export async function prepareBrowserRun(options) {
                     sessionMode,
                     ...buildAgentBrowserResultCategoryDetails({ args: redactedEffectiveArgs, command: executionPlan.commandInfo.command, errorText: stdinValidationError, succeeded: false, validationError: stdinValidationError }),
                     validationError: stdinValidationError,
-                    ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession),
+                    ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession, executionPlan.namespace),
                 },
                 isError: true,
             } };
     }
-    const priorSessionPageState = sessionPageState.get(executionPlan.sessionName);
+    const priorSessionPageState = sessionPageState.get(sessionStateKey);
     const priorSessionTabTarget = priorSessionPageState.tabTarget;
     const sessionTabPinningReason = priorSessionPageState.pinningReason;
     const priorRefSnapshotState = priorSessionPageState.refSnapshot;
@@ -447,7 +452,7 @@ export async function prepareBrowserRun(options) {
                     sessionMode,
                     ...buildAgentBrowserResultCategoryDetails({ args: redactedEffectiveArgs, command: executionPlan.commandInfo.command, errorText: requestedArtifactCloseViolation.message, failureCategory: "policy-blocked", succeeded: false, validationError: requestedArtifactCloseViolation.message }),
                     validationError: requestedArtifactCloseViolation.message,
-                    ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession),
+                    ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession, executionPlan.namespace),
                 },
                 isError: true,
             } };
@@ -467,13 +472,13 @@ export async function prepareBrowserRun(options) {
                     command: executionPlan.commandInfo.command,
                     compatibilityWorkaround,
                     effectiveArgs: redactedEffectiveArgs,
-                    nextActions: buildSessionAwareStaleRefNextActions(executionPlan.sessionName),
+                    nextActions: applyNamespaceToNextActions(buildSessionAwareStaleRefNextActions(executionPlan.sessionName), executionPlan.namespace),
                     refIds: staleRefPreflight.refIds,
                     refSnapshot: staleRefPreflight.snapshot,
                     refSnapshotInvalidation: staleRefPreflight.snapshotInvalidation,
                     sessionMode,
                     ...buildAgentBrowserResultCategoryDetails({ args: redactedEffectiveArgs, command: executionPlan.commandInfo.command, errorText: staleRefPreflight.message, failureCategory: "stale-ref", succeeded: false }),
-                    ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession),
+                    ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession, executionPlan.namespace),
                 },
                 isError: true,
             } };
@@ -483,12 +488,13 @@ export async function prepareBrowserRun(options) {
         cwd,
         currentTarget: priorSessionTabTarget,
         previousSnapshot: resolvedSemanticActionRefSnapshot ? undefined : priorRefSnapshotState,
+        namespace: executionPlan.namespace,
         sessionName: executionPlan.sessionName,
         signal,
     });
     if (samePageRefFreshnessPreflight) {
-        if (samePageRefFreshnessPreflight.snapshot && executionPlan.sessionName) {
-            sessionPageState.applyRefSnapshot({ fallbackTarget: priorSessionTabTarget, sessionName: executionPlan.sessionName, snapshot: samePageRefFreshnessPreflight.snapshot, update: options.sessionPageStateUpdate });
+        if (samePageRefFreshnessPreflight.snapshot && sessionStateKey) {
+            sessionPageState.applyRefSnapshot({ fallbackTarget: priorSessionTabTarget, sessionName: sessionStateKey, snapshot: samePageRefFreshnessPreflight.snapshot, update: options.sessionPageStateUpdate });
         }
         return { kind: "early-result", statePatch, result: {
                 content: [{ type: "text", text: samePageRefFreshnessPreflight.message }],
@@ -497,12 +503,12 @@ export async function prepareBrowserRun(options) {
                     command: executionPlan.commandInfo.command,
                     compatibilityWorkaround,
                     effectiveArgs: redactedEffectiveArgs,
-                    nextActions: buildSessionAwareStaleRefNextActions(executionPlan.sessionName),
+                    nextActions: applyNamespaceToNextActions(buildSessionAwareStaleRefNextActions(executionPlan.sessionName), executionPlan.namespace),
                     refIds: samePageRefFreshnessPreflight.refIds,
                     refSnapshot: samePageRefFreshnessPreflight.snapshot,
                     sessionMode,
                     ...buildAgentBrowserResultCategoryDetails({ args: redactedEffectiveArgs, command: executionPlan.commandInfo.command, errorText: samePageRefFreshnessPreflight.message, failureCategory: "stale-ref", succeeded: false }),
-                    ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession),
+                    ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession, executionPlan.namespace),
                 },
                 isError: true,
             } };
@@ -510,6 +516,7 @@ export async function prepareBrowserRun(options) {
     if (compiledQaPreset?.checks.attached) {
         const qaAttachedPrecondition = await validateQaAttachedPrecondition({
             cwd,
+            namespace: executionPlan.namespace,
             sessionName: executionPlan.sessionName,
             signal,
         });
@@ -521,11 +528,11 @@ export async function prepareBrowserRun(options) {
                         compiledQaPreset: redactedCompiledQaPreset,
                         compatibilityWorkaround,
                         effectiveArgs: redactedEffectiveArgs,
-                        nextActions: qaAttachedPrecondition.nextActions,
+                        nextActions: applyNamespaceToNextActions(qaAttachedPrecondition.nextActions, executionPlan.namespace),
                         sessionMode,
                         ...buildAgentBrowserResultCategoryDetails({ args: redactedEffectiveArgs, command: executionPlan.commandInfo.command, errorText: qaAttachedPrecondition.error, succeeded: false, validationError: qaAttachedPrecondition.error }),
                         validationError: qaAttachedPrecondition.error,
-                        ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession),
+                        ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession, executionPlan.namespace),
                     },
                     isError: true,
                 } };
@@ -541,8 +548,10 @@ export async function prepareBrowserRun(options) {
         persistentArtifactStore,
         previousRefSnapshot: priorRefSnapshotState,
         redactedArgs,
+        namespace: executionPlan.namespace,
         sessionMode,
         sessionName: executionPlan.sessionName,
+        sessionStateKey,
         sessionPageState,
         sessionPageStateUpdate: options.sessionPageStateUpdate,
         signal,
@@ -557,6 +566,7 @@ export async function prepareBrowserRun(options) {
         effectiveArgs: redactedEffectiveArgs,
         redactedArgs,
         sessionMode,
+        namespace: executionPlan.namespace,
         sessionName: executionPlan.sessionName,
         signal,
         usedImplicitSession: executionPlan.usedImplicitSession,
@@ -570,6 +580,7 @@ export async function prepareBrowserRun(options) {
         effectiveArgs: redactedEffectiveArgs,
         redactedArgs,
         sessionMode,
+        namespace: executionPlan.namespace,
         sessionName: executionPlan.sessionName,
         signal,
         usedImplicitSession: executionPlan.usedImplicitSession,
@@ -583,6 +594,7 @@ export async function prepareBrowserRun(options) {
         effectiveArgs: redactedEffectiveArgs,
         redactedArgs,
         sessionMode,
+        namespace: executionPlan.namespace,
         sessionName: executionPlan.sessionName,
         signal,
         usedImplicitSession: executionPlan.usedImplicitSession,
@@ -597,6 +609,7 @@ export async function prepareBrowserRun(options) {
         effectiveArgs: redactedEffectiveArgs,
         redactedArgs,
         sessionMode,
+        namespace: executionPlan.namespace,
         sessionName: executionPlan.sessionName,
         signal,
         usedImplicitSession: executionPlan.usedImplicitSession,
@@ -618,6 +631,7 @@ export async function prepareBrowserRun(options) {
         })) {
         const plannedSessionTabSelection = await collectSessionTabSelection({
             cwd,
+            namespace: executionPlan.namespace,
             sessionName: executionPlan.sessionName,
             signal,
             target: priorSessionTabTarget,
@@ -627,6 +641,7 @@ export async function prepareBrowserRun(options) {
                 const appliedSessionTabSelection = await applyOpenResultTabCorrection({
                     correction: plannedSessionTabSelection,
                     cwd,
+                    namespace: executionPlan.namespace,
                     sessionName: executionPlan.sessionName,
                     signal,
                 });
@@ -642,15 +657,15 @@ export async function prepareBrowserRun(options) {
                                 sessionMode,
                                 sessionTabCorrection: plannedSessionTabSelection,
                                 ...buildAgentBrowserResultCategoryDetails({ args: redactedEffectiveArgs, command: executionPlan.commandInfo.command, errorText: error, failureCategory: "tab-drift", succeeded: false, tabDrift: true, validationError: error }),
-                                nextActions: buildSessionTabRecoveryNextActions({
+                                nextActions: applyNamespaceToNextActions(buildSessionTabRecoveryNextActions({
                                     kind: "tab-drift",
                                     resultCategory: "failure",
                                     sessionName: executionPlan.sessionName,
                                     tabCorrection: plannedSessionTabSelection,
                                     target: priorSessionTabTarget,
-                                }),
+                                }), executionPlan.namespace),
                                 validationError: error,
-                                ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession),
+                                ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession, executionPlan.namespace),
                             },
                             isError: true,
                         } };
@@ -675,22 +690,22 @@ export async function prepareBrowserRun(options) {
                                 sessionMode,
                                 sessionTabCorrection: plannedSessionTabSelection,
                                 ...buildAgentBrowserResultCategoryDetails({ args: redactedEffectiveArgs, command: executionPlan.commandInfo.command, errorText: pinnedBatchPlan.error, failureCategory: "tab-drift", succeeded: false, tabDrift: true, validationError: pinnedBatchPlan.error }),
-                                nextActions: buildSessionTabRecoveryNextActions({
+                                nextActions: applyNamespaceToNextActions(buildSessionTabRecoveryNextActions({
                                     kind: "tab-drift",
                                     resultCategory: "failure",
                                     sessionName: executionPlan.sessionName,
                                     tabCorrection: plannedSessionTabSelection,
                                     target: priorSessionTabTarget,
-                                }),
+                                }), executionPlan.namespace),
                                 validationError: pinnedBatchPlan.error,
-                                ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession),
+                                ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession, executionPlan.namespace),
                             },
                             isError: true,
                         } };
                 }
                 if (pinnedBatchPlan) {
                     sessionTabCorrection = plannedSessionTabSelection;
-                    processArgs = ["--json", "--session", executionPlan.sessionName, "batch"];
+                    processArgs = ["--json", ...(executionPlan.namespace ? ["--namespace", executionPlan.namespace] : []), "--session", executionPlan.sessionName, "batch"];
                     processStdin = JSON.stringify(pinnedBatchPlan.steps);
                     includePinnedNavigationSummary = pinnedBatchPlan.includeNavigationSummary;
                     pinnedBatchUnwrapMode = pinnedBatchPlan.unwrapMode;
@@ -699,13 +714,14 @@ export async function prepareBrowserRun(options) {
         }
     }
     const clickDispatchProbe = pinnedBatchUnwrapMode === undefined && compiledElectron === undefined
-        ? await prepareClickDispatchProbe({ commandTokens, cwd, refSnapshot: promptRefSnapshot, sessionName: executionPlan.sessionName, signal })
+        ? await prepareClickDispatchProbe({ commandTokens, cwd, namespace: executionPlan.namespace, refSnapshot: promptRefSnapshot, sessionName: executionPlan.sessionName, signal })
         : undefined;
     const processTimeoutMs = options.params.timeoutMs ?? getDialogAwareProcessTimeoutMs(commandTokens, promptRefSnapshot, processStdin) ?? getWaitAwareProcessTimeoutMs(commandTokens, processStdin);
     const redactedProcessArgs = redactInvocationArgs(processArgs);
-    const shouldProbeScrollNoop = executionPlan.commandInfo.command === "scroll" && executionPlan.startupScopedFlags.length === 0;
+    const scrollAmount = Number(commandTokens.find((token) => /^\d+(?:\.\d+)?$/.test(token)));
+    const shouldProbeScrollNoop = executionPlan.commandInfo.command === "scroll" && executionPlan.startupScopedFlags.length === 0 && (state.managedSessionActive || sessionMode === "fresh") && (!Number.isFinite(scrollAmount) || scrollAmount >= 500);
     const scrollPositionBefore = shouldProbeScrollNoop
-        ? await collectScrollPositionSnapshot({ cwd, sessionName: executionPlan.sessionName, signal })
+        ? await collectScrollPositionSnapshot({ cwd, namespace: executionPlan.namespace, sessionName: executionPlan.sessionName, signal })
         : undefined;
     onUpdate?.({
         content: [{ type: "text", text: `Running agent-browser ${buildInvocationPreview(redactedProcessArgs)}` }],
@@ -714,7 +730,7 @@ export async function prepareBrowserRun(options) {
             effectiveArgs: redactedProcessArgs,
             sessionMode,
             sessionTabCorrection,
-            ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession),
+            ...buildSessionDetailFields(executionPlan.sessionName, executionPlan.usedImplicitSession, executionPlan.namespace),
         },
     });
     return { kind: "ready", prepared: {