pi-agent-browser-native 0.2.48 → 0.2.49

package/extensions/agent-browser/lib/results/contracts.ts

@@ -1,241 +0,0 @@
-/**
- * Purpose: Define stable result-rendering data contracts shared across focused result modules.
- * Responsibilities: Keep upstream envelope, presentation, artifact, category, and network shapes in one type-only surface.
- * Scope: Types only; runtime classifiers, manifests, network rules, and text helpers live in neighboring modules.
- * Usage: Imported with `import type` by result modules and re-exported by the public results facade.
- * Invariants/Assumptions: This file has no runtime policy so adding fields cannot hide behavior in a catch-all module.
- */
-
-import type { AgentBrowserNextAction } from "./next-actions.js";
-
-export type { AgentBrowserNextAction } from "./next-actions.js";
-
-export interface AgentBrowserEnvelope {
-	data?: unknown;
-	error?: unknown;
-	success: boolean;
-}
-
-export interface AgentBrowserBatchResult {
-	command?: string[];
-	error?: unknown;
-	result?: unknown;
-	success?: boolean;
-}
-
-export type AgentBrowserResultCategory = "failure" | "success";
-
-export type AgentBrowserSuccessCategory = "artifact-saved" | "artifact-unverified" | "completed" | "inspection";
-
-export type AgentBrowserFailureCategory =
-	| "aborted"
-	| "artifact-missing"
-	| "cleanup-failed"
-	| "confirmation-required"
-	| "download-not-verified"
-	| "missing-binary"
-	| "parse-failure"
-	| "policy-blocked"
-	| "qa-failure"
-	| "selector-not-found"
-	| "selector-unsupported"
-	| "stale-ref"
-	| "tab-drift"
-	| "timeout"
-	| "upstream-error"
-	| "validation-error";
-
-export interface AgentBrowserResultCategoryDetails {
-	failureCategory?: AgentBrowserFailureCategory;
-	resultCategory: AgentBrowserResultCategory;
-	successCategory?: AgentBrowserSuccessCategory;
-}
-
-export interface AgentBrowserPageChangeSummary {
-	artifactCount?: number;
-	changeType: "artifact" | "confirmation" | "mutation" | "navigation";
-	command?: string;
-	nextActionIds?: string[];
-	savedFilePath?: string;
-	summary: string;
-	title?: string;
-	url?: string;
-}
-
-export type FileArtifactKind = "download" | "file" | "har" | "image" | "pdf" | "profile" | "trace" | "video";
-
-export type FileArtifactStatus = "missing" | "pending" | "repaired-from-temp" | "saved" | "upstream-temp-only";
-
-export interface FileArtifactMetadata {
-	absolutePath: string;
-	artifactType?: FileArtifactKind;
-	command?: string;
-	cwd?: string;
-	exists?: boolean;
-	extension?: string;
-	kind: FileArtifactKind;
-	mediaType?: string;
-	path: string;
-	recordingState?: "openRecording";
-	requestedPath?: string;
-	session?: string;
-	sizeBytes?: number;
-	status?: FileArtifactStatus;
-	subcommand?: string;
-	tempPath?: string;
-	willExistOnStop?: boolean;
-}
-
-export type ArtifactVerificationState = "missing" | "pending" | "unverified" | "verified";
-
-export interface ArtifactVerificationEntry {
-	absolutePath?: string;
-	exists?: boolean;
-	kind: FileArtifactKind | "spill";
-	limitation?: string;
-	mediaType?: string;
-	path: string;
-	requestedPath?: string;
-	recordingState?: "openRecording";
-	retentionState?: ArtifactRetentionState;
-	sizeBytes?: number;
-	state: ArtifactVerificationState;
-	status?: FileArtifactStatus;
-	storageScope?: ArtifactStorageScope;
-	willExistOnStop?: boolean;
-}
-
-export interface ArtifactVerificationSummary {
-	artifacts: ArtifactVerificationEntry[];
-	missingCount: number;
-	pendingCount: number;
-	unverifiedCount: number;
-	verified: boolean;
-	verifiedCount: number;
-}
-
-export interface SavedFilePresentationDetails {
-	command: "download" | "pdf" | "wait";
-	kind: "download" | "pdf";
-	metadata?: Record<string, unknown>;
-	path: string;
-	subcommand?: string;
-}
-
-export type ArtifactRetentionState = "evicted" | "ephemeral" | "live" | "missing";
-
-export type ArtifactStorageScope = "explicit-path" | "persistent-session" | "process-temp";
-
-export interface SessionArtifactManifestEntry {
-	absolutePath?: string;
-	command?: string;
-	createdAtMs: number;
-	cwd?: string;
-	evictedAtMs?: number;
-	exists?: boolean;
-	extension?: string;
-	kind: FileArtifactKind | "spill";
-	mediaType?: string;
-	path: string;
-	requestedPath?: string;
-	retentionState: ArtifactRetentionState;
-	session?: string;
-	sizeBytes?: number;
-	storageScope: ArtifactStorageScope;
-	subcommand?: string;
-}
-
-export interface SessionArtifactManifest {
-	entries: SessionArtifactManifestEntry[];
-	evictedCount: number;
-	liveCount: number;
-	maxEntries: number;
-	updatedAtMs: number;
-	version: 1;
-}
-
-export interface BatchStepPresentationDetails {
-	artifactVerification?: ArtifactVerificationSummary;
-	artifacts?: FileArtifactMetadata[];
-	command?: string[];
-	commandText: string;
-	data?: unknown;
-	failureCategory?: AgentBrowserFailureCategory;
-	fullOutputPath?: string;
-	fullOutputPaths?: string[];
-	imagePath?: string;
-	imagePaths?: string[];
-	index: number;
-	networkRouteDiagnostics?: NetworkRouteDiagnostic[];
-	nextActions?: AgentBrowserNextAction[];
-	pageChangeSummary?: AgentBrowserPageChangeSummary;
-	resultCategory: AgentBrowserResultCategory;
-	savedFile?: SavedFilePresentationDetails;
-	savedFilePath?: string;
-	success: boolean;
-	successCategory?: AgentBrowserSuccessCategory;
-	summary: string;
-	text: string;
-}
-
-export interface BatchFailurePresentationDetails {
-	failedStep: BatchStepPresentationDetails;
-	failureCount: number;
-	successCount: number;
-	totalCount: number;
-}
-
-export interface ToolPresentation {
-	artifactManifest?: SessionArtifactManifest;
-	artifactRetentionSummary?: string;
-	artifactVerification?: ArtifactVerificationSummary;
-	artifacts?: FileArtifactMetadata[];
-	batchFailure?: BatchFailurePresentationDetails;
-	batchSteps?: BatchStepPresentationDetails[];
-	content: Array<{ text: string; type: "text" } | { data: string; mimeType: string; type: "image" }>;
-	data?: unknown;
-	failureCategory?: AgentBrowserFailureCategory;
-	fullOutputPath?: string;
-	fullOutputPaths?: string[];
-	imagePath?: string;
-	imagePaths?: string[];
-	networkRouteDiagnostics?: NetworkRouteDiagnostic[];
-	nextActions?: AgentBrowserNextAction[];
-	pageChangeSummary?: AgentBrowserPageChangeSummary;
-	resultCategory?: AgentBrowserResultCategory;
-	savedFile?: SavedFilePresentationDetails;
-	savedFilePath?: string;
-	successCategory?: AgentBrowserSuccessCategory;
-	summary: string;
-}
-
-export type NetworkFailureImpact = "actionable" | "benign";
-
-export interface NetworkFailureClassification {
-	impact: NetworkFailureImpact;
-	reason: string;
-	resourceType?: string;
-	status?: number;
-	url?: string;
-}
-
-export interface NetworkFailureSummary {
-	actionableCount: number;
-	benignCount: number;
-	failures: NetworkFailureClassification[];
-	totalCount: number;
-}
-
-export interface NetworkRouteRecord {
-	mode: "abort" | "body" | "handler" | "unknown";
-	pattern: string;
-}
-
-export interface NetworkRouteDiagnostic {
-	mode: NetworkRouteRecord["mode"];
-	reason: "pending-routed-request" | "cors-likely-routed-request" | "unfulfilled-routed-request";
-	requestId?: string;
-	requestUrl?: string;
-	routePattern: string;
-	summary: string;
-}

package/extensions/agent-browser/lib/results/editable-ref-evidence.ts

@@ -1,72 +0,0 @@
-/**
- * Purpose: Detect whether upstream ref metadata or snapshot text proves an element is editable.
- * Responsibilities: Parse structured ref flags and snapshot-line contenteditable/editable markers into a conservative boolean/unknown signal.
- * Scope: Editable evidence only; callers decide how to rank controls or build recovery actions from the signal.
- * Usage: Imported by snapshot compaction and selector/fill recovery diagnostics.
- * Invariants/Assumptions: Explicit false evidence wins over positive hints; unknown remains undefined.
- */
-
-const EDITABLE_REF_EVIDENCE_KEYS = ["editable", "contentEditable", "contenteditable", "isContentEditable"] as const;
-const EDITABLE_FALSE_TEXT_PATTERN = /\b(?:contenteditable|editable)\s*=\s*["']?(?:false|0)["']?/i;
-const EDITABLE_ASSIGNMENT_TEXT_PATTERN = /\b(contenteditable|editable)\s*=\s*("[^"]*"|'[^']*'|[^\s,\]]+)/gi;
-const EDITABLE_BARE_TEXT_PATTERN = /\b(?:contenteditable|editable)\b(?!\s*=)/i;
-
-function parseEditableEvidenceValue(value: unknown): boolean | undefined {
-	if (typeof value === "boolean") return value;
-	if (typeof value === "number") {
-		if (value === 1) return true;
-		if (value === 0) return false;
-		return undefined;
-	}
-	if (typeof value !== "string") return undefined;
-	const normalized = value.trim().replace(/^["']|["']$/g, "").toLowerCase();
-	if (["false", "0", "no"].includes(normalized)) return false;
-	if (["", "true", "1", "yes", "plaintext-only"].includes(normalized)) return true;
-	return undefined;
-}
-
-function stripLeadingSnapshotAccessibleName(text: string): string {
-	return text.replace(/^(\s*[-*]\s+\S+\s+)(?:"[^"]*"|'[^']*')/, "$1");
-}
-
-function parseEditableEvidenceText(text: string | undefined): boolean | undefined {
-	if (!text) return undefined;
-	const markerText = stripLeadingSnapshotAccessibleName(text);
-	if (EDITABLE_FALSE_TEXT_PATTERN.test(markerText)) return false;
-	let hasPositiveAssignment = false;
-	for (const match of markerText.matchAll(EDITABLE_ASSIGNMENT_TEXT_PATTERN)) {
-		const key = match[1]?.toLowerCase();
-		const evidence = parseEditableEvidenceValue(match[2]);
-		if (evidence === false) return false;
-		if (evidence === true && (key === "contenteditable" || key === "editable")) {
-			hasPositiveAssignment = true;
-		}
-	}
-	if (hasPositiveAssignment) return true;
-	return EDITABLE_BARE_TEXT_PATTERN.test(markerText) ? true : undefined;
-}
-
-export function getEditableRefEvidence(options: {
-	ref?: Record<string, unknown>;
-	text?: string;
-}): boolean | undefined {
-	let hasPositiveEvidence = false;
-	if (options.ref) {
-		for (const key of EDITABLE_REF_EVIDENCE_KEYS) {
-			const evidence = parseEditableEvidenceValue(options.ref[key]);
-			if (evidence === false) return false;
-			if (evidence === true) hasPositiveEvidence = true;
-		}
-	}
-	const textEvidence = parseEditableEvidenceText(options.text);
-	if (textEvidence === false) return false;
-	if (textEvidence === true) hasPositiveEvidence = true;
-	return hasPositiveEvidence ? true : undefined;
-}
-
-export function hasPositiveEditableRefEvidence(options: {
-	ref?: Record<string, unknown>;
-	text?: string;
-}): boolean {
-	return getEditableRefEvidence(options) === true;
-}

package/extensions/agent-browser/lib/results/envelope.ts

@@ -1,195 +0,0 @@
-/**
- * Purpose: Parse upstream agent-browser output and turn failure envelopes into actionable error text.
- * Responsibilities: Read inline or spilled stdout, parse observed JSON envelope shapes, normalize batch arrays, and extract the most useful error text from nested upstream failures.
- * Scope: Envelope parsing and error derivation only; content rendering and snapshot compaction live in separate modules.
- * Usage: Imported by the public `lib/results.ts` facade and by tests through that facade.
- * Invariants/Assumptions: Upstream `agent-browser --json` responses follow the observed `{ success, data, error }` envelope shape or the array shape returned by `batch --json`.
- */
-
-import { readFile } from "node:fs/promises";
-
-import { isRecord } from "../parsing.js";
-import { detectConfirmationRequired } from "./confirmation.js";
-import type { AgentBrowserBatchResult, AgentBrowserEnvelope } from "./contracts.js";
-import { stringifyUnknown } from "./text.js";
-
-function hasStructuredBatchStepFailure(data: unknown): data is AgentBrowserBatchResult[] {
-	return Array.isArray(data) && data.some((item) => isRecord(item) && item.success === false);
-}
-
-async function readEnvelopeSource(options: { stdout: string; stdoutPath?: string }): Promise<string> {
-	if (!options.stdoutPath) {
-		return options.stdout;
-	}
-
-	try {
-		return await readFile(options.stdoutPath, "utf8");
-	} catch (error) {
-		const message = error instanceof Error ? error.message : String(error);
-		throw new Error(`agent-browser output spill file could not be read: ${message}`);
-	}
-}
-
-function extractEnvelopeErrorText(error: unknown): string | undefined {
-	if (typeof error === "string") {
-		return error.trim() || undefined;
-	}
-	if (typeof error === "number" || typeof error === "boolean") {
-		return String(error);
-	}
-	if (Array.isArray(error)) {
-		const parts = error.map((item) => extractEnvelopeErrorText(item) ?? stringifyUnknown(item)).filter((item) => item.length > 0);
-		return parts.length > 0 ? parts.join("\n") : undefined;
-	}
-	if (!isRecord(error)) {
-		return error == null ? undefined : stringifyUnknown(error);
-	}
-
-	for (const key of ["message", "error", "details", "cause", "stderr"] as const) {
-		const value = extractEnvelopeErrorText(error[key]);
-		if (value) return value;
-	}
-
-	const fallback = stringifyUnknown(error).trim();
-	return fallback.length > 0 && fallback !== "{}" ? fallback : undefined;
-}
-
-export async function parseAgentBrowserEnvelope(options: string | { stdout: string; stdoutPath?: string }): Promise<{
-	envelope?: AgentBrowserEnvelope;
-	parseError?: string;
-}> {
-	let stdout: string;
-	try {
-		stdout = typeof options === "string" ? options : await readEnvelopeSource(options);
-	} catch (error) {
-		return { parseError: error instanceof Error ? error.message : String(error) };
-	}
-
-	const trimmed = stdout.trim();
-	if (trimmed.length === 0) {
-		return { parseError: "agent-browser returned no JSON output." };
-	}
-
-	try {
-		const parsed = JSON.parse(trimmed) as AgentBrowserEnvelope | AgentBrowserBatchResult[];
-		if (Array.isArray(parsed)) {
-			return { envelope: { success: parsed.every((item) => !isRecord(item) || item.success !== false), data: parsed } };
-		}
-		if (!isRecord(parsed)) {
-			return { parseError: "agent-browser returned JSON, but it was not an object envelope." };
-		}
-		if (!("success" in parsed)) {
-			return { parseError: "agent-browser returned an invalid JSON envelope: missing boolean success field." };
-		}
-		if (typeof parsed.success !== "boolean") {
-			return { parseError: "agent-browser returned an invalid JSON envelope: success field must be boolean." };
-		}
-		if (!Object.hasOwn(parsed, "data")) {
-			const { success, error, ...topLevelData } = parsed;
-			if (Object.keys(topLevelData).length > 0) {
-				return { envelope: { error, success, data: topLevelData } as AgentBrowserEnvelope };
-			}
-		}
-		return { envelope: parsed as AgentBrowserEnvelope };
-	} catch (error) {
-		const message = error instanceof Error ? error.message : String(error);
-		return { parseError: `agent-browser returned invalid JSON: ${message}` };
-	}
-}
-
-function buildInvocationLabel(options: { command?: string; effectiveArgs?: string[] }): string {
-	if (options.effectiveArgs && options.effectiveArgs.length > 0) {
-		return `agent-browser ${options.effectiveArgs.join(" ")}`;
-	}
-	if (options.command && options.command.trim().length > 0) {
-		return `agent-browser ${options.command.trim()}`;
-	}
-	return "agent-browser";
-}
-
-function appendWrapperRecoveryHint(message: string, wrapperRecoveryHint?: string): string {
-	const hint = wrapperRecoveryHint?.trim();
-	return hint ? `${message}\n${hint}` : message;
-}
-
-function buildFailureFallback(options: { command?: string; effectiveArgs?: string[]; exitCode: number; wrapperRecoveryHint?: string }): string {
-	const invocation = buildInvocationLabel(options);
-	const exitSuffix = options.exitCode !== 0 ? ` (exit code ${options.exitCode})` : "";
-	return appendWrapperRecoveryHint(`${invocation} reported failure${exitSuffix}.`, options.wrapperRecoveryHint);
-}
-
-function buildExitCodeFallback(options: { command?: string; effectiveArgs?: string[]; exitCode: number; wrapperRecoveryHint?: string }): string {
-	const invocation = buildInvocationLabel(options);
-	return appendWrapperRecoveryHint(`${invocation} exited with code ${options.exitCode}.`, options.wrapperRecoveryHint);
-}
-
-function buildWatchdogTimeoutMessage(options: { timeoutMs?: number }): string {
-	const timeoutText = options.timeoutMs === undefined ? "the wrapper watchdog" : `the ${options.timeoutMs}ms wrapper watchdog`;
-	const ipcTiming = options.timeoutMs !== undefined && options.timeoutMs <= 30_000
-		? "before the upstream CLI entered its 30s IPC retry path"
-		: "after waiting beyond the upstream CLI's 30s IPC retry window";
-	return [
-		`agent-browser exceeded ${timeoutText} and was stopped ${ipcTiming}.`,
-		"Prefer a condition wait or split long work into shorter calls; for legitimately long opens or captures, pass agent_browser timeoutMs with a bounded higher value and inspect details.timeoutPartialProgress before retrying.",
-	].join(" ");
-}
-
-function isUpstreamIpcReadTimeoutMessage(message: string): boolean {
-	return /Failed to read: Resource temporarily unavailable(?: \(os error \d+\))?.*daemon may be busy or unresponsive/i.test(message);
-}
-
-function buildUpstreamIpcReadTimeoutMessage(): string {
-	return [
-		"agent-browser hit the upstream CLI 30s IPC read timeout while waiting for the daemon response.",
-		"The daemon may still be alive; do not blindly retry a non-idempotent command. Prefer a shorter command, split long waits, or retry with sessionMode: \"fresh\" after checking tab list.",
-	].join(" ");
-}
-
-function maybeAppendStaleRefHint(message: string, args?: string[]): string {
-	const usedRef = args?.some((arg) => /^@e\d+\b/.test(arg)) ?? false;
-	if (!usedRef || !/could not locate element|element not found|no element/i.test(message)) {
-		return message;
-	}
-	return [
-		message,
-		"This @ref may be stale after navigation, scrolling, or a DOM update. Run `agent_browser` with `{ \"args\": [\"snapshot\", \"-i\"] }` again and retry with a current ref, or use a stable `find` locator.",
-	].join("\n");
-}
-
-export function getAgentBrowserErrorText(options: {
-	aborted: boolean;
-	command?: string;
-	effectiveArgs?: string[];
-	envelope?: AgentBrowserEnvelope;
-	exitCode: number;
-	parseError?: string;
-	plainTextInspection: boolean;
-	spawnError?: Error;
-	staleRefArgs?: string[];
-	stderr: string;
-	timedOut?: boolean;
-	timeoutMs?: number;
-	wrapperRecoveryHint?: string;
-}): string | undefined {
-	const { aborted, envelope, exitCode, parseError, plainTextInspection, spawnError, stderr, timedOut } = options;
-	if (plainTextInspection) return undefined;
-	if (timedOut) return buildWatchdogTimeoutMessage(options);
-	if (aborted) return "agent-browser was aborted.";
-	if (spawnError) return spawnError.message;
-	if (parseError) return parseError;
-	if (envelope?.success === false) {
-		if ((hasStructuredBatchStepFailure(envelope.data) || detectConfirmationRequired(envelope.data)) && envelope.error === undefined) {
-			return undefined;
-		}
-		const envelopeErrorText = extractEnvelopeErrorText(envelope.error);
-		if (envelopeErrorText && isUpstreamIpcReadTimeoutMessage(envelopeErrorText)) {
-			return buildUpstreamIpcReadTimeoutMessage();
-		}
-		const fallback = envelopeErrorText ?? (stderr.trim() || buildFailureFallback(options));
-		return maybeAppendStaleRefHint(fallback, options.staleRefArgs ?? options.effectiveArgs);
-	}
-	if (exitCode !== 0) {
-		return stderr.trim() || buildExitCodeFallback(options);
-	}
-	return undefined;
-}

package/extensions/agent-browser/lib/results/network-routes.ts

@@ -1,83 +0,0 @@
-import { isRecord } from "../parsing.js";
-import { redactSensitiveText } from "../runtime.js";
-import type { NetworkRouteDiagnostic, NetworkRouteRecord } from "./contracts.js";
-import { getStringRecordField, isApiLikeNetworkRequest } from "./network.js";
-
-function getArrayField(data: Record<string, unknown>, key: string): unknown[] | undefined {
-	const value = data[key];
-	return Array.isArray(value) ? value : undefined;
-}
-
-function networkRoutePatternMatchesUrl(pattern: string, url: string): boolean {
-	if (pattern === url) return true;
-	if (pattern.includes("*")) {
-		const escaped = pattern.replace(/[.+?^${}()|[\]\\]/g, "\\$&").replace(/\*/g, ".*");
-		return new RegExp(`^${escaped}$`).test(url);
-	}
-	return pattern.length >= 4 && url.includes(pattern);
-}
-
-function getSafeRequestId(item: Record<string, unknown>): string | undefined {
-	const requestId = getStringRecordField(item, "requestId") ?? getStringRecordField(item, "id");
-	if (!requestId || redactSensitiveText(requestId) !== requestId) return undefined;
-	return requestId;
-}
-
-function getRouteDiagnosticReason(item: Record<string, unknown>, route: NetworkRouteRecord): NetworkRouteDiagnostic["reason"] | undefined {
-	const statusMissing = typeof item.status !== "number";
-	const error = getStringRecordField(item, "error") ?? getStringRecordField(item, "failureText") ?? getStringRecordField(item, "errorText");
-	if (error && /(?:cors|cross-origin|preflight|access-control-allow-origin)/i.test(error)) return "cors-likely-routed-request";
-	if (statusMissing && isApiLikeNetworkRequest(item)) return "pending-routed-request";
-	if (route.mode !== "abort" && ((typeof item.status === "number" && item.status >= 400) || item.failed === true || typeof error === "string")) return "unfulfilled-routed-request";
-	return undefined;
-}
-
-export function getNetworkRouteMode(args: string[]): NetworkRouteRecord["mode"] {
-	if (args.includes("--abort")) return "abort";
-	if (args.includes("--body")) return "body";
-	return "handler";
-}
-
-export function applyNetworkRouteRecords(routes: NetworkRouteRecord[] | undefined, commandTokens: string[] | undefined, succeeded: boolean): NetworkRouteRecord[] | undefined {
-	if (!succeeded || commandTokens?.[0] !== "network") return routes;
-	const subcommand = commandTokens[1];
-	if (subcommand !== "route" && subcommand !== "unroute") return routes;
-	const existing = routes ?? [];
-	const pattern = commandTokens[2];
-	if (subcommand === "route" && pattern) return [...existing.filter((route) => route.pattern !== pattern), { mode: getNetworkRouteMode(commandTokens), pattern }];
-	if (!pattern) return undefined;
-	const next = existing.filter((route) => route.pattern !== pattern);
-	return next.length > 0 ? next : undefined;
-}
-
-export function buildNetworkRouteDiagnostics(data: unknown, routes: NetworkRouteRecord[] | undefined): NetworkRouteDiagnostic[] | undefined {
-	if (!routes || routes.length === 0 || !isRecord(data)) return undefined;
-	const requests = getArrayField(data, "requests");
-	if (!requests) return undefined;
-	const diagnostics: NetworkRouteDiagnostic[] = [];
-	for (const item of requests) {
-		if (!isRecord(item)) continue;
-		const url = getStringRecordField(item, "url");
-		if (!url) continue;
-		const route = routes.find((candidate) => networkRoutePatternMatchesUrl(candidate.pattern, url));
-		if (!route) continue;
-		const reason = getRouteDiagnosticReason(item, route);
-		if (!reason) continue;
-		const requestId = getSafeRequestId(item);
-		const requestUrl = redactSensitiveText(url);
-		const routePattern = redactSensitiveText(route.pattern);
-		diagnostics.push({
-			mode: route.mode,
-			reason,
-			...(requestId ? { requestId } : {}),
-			requestUrl,
-			routePattern,
-			summary: reason === "cors-likely-routed-request"
-				? `Routed request ${requestId ?? requestUrl} looks CORS/preflight-related for route ${routePattern}.`
-				: reason === "unfulfilled-routed-request"
-					? `Routed request ${requestId ?? requestUrl} failed instead of returning the configured route ${routePattern}.`
-					: `Routed request ${requestId ?? requestUrl} is still pending/no-status for route ${routePattern}.`,
-		});
-	}
-	return diagnostics.length > 0 ? diagnostics.slice(0, 5) : undefined;
-}

package/extensions/agent-browser/lib/results/network.ts

@@ -1,78 +0,0 @@
-/**
- * Purpose: Classify failed network requests into actionable vs benign diagnostics.
- * Responsibilities: Recognize failed request rows, de-prioritize browser icon misses, and summarize failure counts.
- * Scope: Network diagnostic classification only.
- * Usage: QA preset analysis and presentation network summaries.
- * Invariants/Assumptions: Browser favicon/apple-touch icon misses are warnings; API/document/script failures are actionable.
- */
-
-import { isRecord } from "../parsing.js";
-import type { NetworkFailureClassification, NetworkFailureSummary } from "./contracts.js";
-
-export function getStringRecordField(value: Record<string, unknown>, key: string): string | undefined {
-	const field = value[key];
-	return typeof field === "string" && field.trim().length > 0 ? field.trim() : undefined;
-}
-
-export function getNetworkRequestUrlPath(url: string | undefined): string | undefined {
-	if (!url) return undefined;
-	try {
-		return new URL(url).pathname;
-	} catch {
-		const withoutQuery = url.split(/[?#]/, 1)[0];
-		return withoutQuery.length > 0 ? withoutQuery : undefined;
-	}
-}
-
-function isFailedNetworkRequest(request: Record<string, unknown>): boolean {
-	return (typeof request.status === "number" && request.status >= 400) || request.failed === true || typeof request.error === "string";
-}
-
-export function isNetworkArtifactNoiseRequest(request: Record<string, unknown>): boolean {
-	const url = getStringRecordField(request, "url") ?? "";
-	const resourceType = (getStringRecordField(request, "resourceType") ?? getStringRecordField(request, "mimeType") ?? "").toLowerCase();
-	return /^data:image\//i.test(url) || (url.startsWith("data:") && resourceType.includes("image"));
-}
-
-function isBenignAssetFailure(request: Record<string, unknown>, url: string | undefined, resourceType: string | undefined): boolean {
-	const path = getNetworkRequestUrlPath(url);
-	if (!path) return false;
-	const normalizedResourceType = resourceType?.toLowerCase();
-	return /(?:^|\/)(?:favicon(?:[-.\w]*)?\.(?:ico|png|svg)|apple-touch-icon(?:[-.\w]*)?\.png)$/i.test(path)
-		&& (request.status === 404 || request.failed === true || typeof request.error === "string")
-		&& (!normalizedResourceType || ["image", "img", "other"].includes(normalizedResourceType) || normalizedResourceType.startsWith("image/"));
-}
-
-export function isApiLikeNetworkRequest(request: Record<string, unknown>): boolean {
-	const method = (getStringRecordField(request, "method") ?? "GET").toUpperCase();
-	const resourceType = (getStringRecordField(request, "resourceType") ?? "").toLowerCase();
-	const mimeType = (getStringRecordField(request, "mimeType") ?? "").toLowerCase();
-	const path = getNetworkRequestUrlPath(getStringRecordField(request, "url")) ?? "";
-	return resourceType === "fetch" || resourceType === "xhr" || mimeType.includes("json") || /\/(?:api|graphql|rpc)(?:\/|$)/i.test(path) || !["GET", "HEAD"].includes(method);
-}
-
-export function classifyNetworkRequestFailure(request: Record<string, unknown>): NetworkFailureClassification | undefined {
-	if (!isFailedNetworkRequest(request)) return undefined;
-	const url = getStringRecordField(request, "url");
-	const resourceType = getStringRecordField(request, "resourceType") ?? getStringRecordField(request, "mimeType");
-	const status = typeof request.status === "number" ? request.status : undefined;
-	if (isBenignAssetFailure(request, url, resourceType)) {
-		return { impact: "benign", reason: "low-impact browser icon asset", resourceType, status, url };
-	}
-	return { impact: "actionable", reason: "document, script, API, or non-benign request failure", resourceType, status, url };
-}
-
-export function summarizeNetworkFailures(requests: unknown[]): NetworkFailureSummary {
-	const failures = requests.flatMap((request) => {
-		if (!isRecord(request) || isNetworkArtifactNoiseRequest(request)) return [];
-		const classification = classifyNetworkRequestFailure(request);
-		return classification ? [classification] : [];
-	});
-	const benignCount = failures.filter((failure) => failure.impact === "benign").length;
-	return {
-		actionableCount: failures.length - benignCount,
-		benignCount,
-		failures,
-		totalCount: failures.length,
-	};
-}