pi-agent-browser-native 0.2.47 → 0.2.49

package/extensions/agent-browser/lib/input-modes/params.ts

@@ -1,205 +0,0 @@
-/**
- * Purpose: Define the Pi tool input schema for the native agent_browser wrapper.
- * Responsibilities: Keep TypeBox schema construction separate from runtime execution and input-mode compilers.
- * Scope: Schema-only; behavioral validation lives in the mode compilers.
- */
-
-import { JsonSchema, type JsonSchemaBuilder } from "../json-schema.js";
-import { StringEnum as localStringEnum, type StringEnumBuilder } from "../string-enum-schema.js";
-
-import {
-	ELECTRON_DISCOVERY_DEFAULT_MAX_RESULTS,
-	ELECTRON_DISCOVERY_MAX_RESULTS,
-} from "../electron/discovery.js";
-import {
-	AGENT_BROWSER_ELECTRON_HANDOFFS,
-	AGENT_BROWSER_ELECTRON_TARGET_TYPES,
-	AGENT_BROWSER_JOB_STEP_ACTIONS,
-	AGENT_BROWSER_JOB_TYPE_DELAYED_TEXT_MAX_CHARACTERS,
-	AGENT_BROWSER_QA_LOAD_STATES,
-	AGENT_BROWSER_SEMANTIC_ACTIONS,
-	AGENT_BROWSER_SEMANTIC_LOCATORS,
-	DEFAULT_SESSION_MODE,
-	SOURCE_LOOKUP_MAX_WORKSPACE_FILES,
-} from "./types.js";
-
-export function createAgentBrowserParamsSchema(
-	Type: JsonSchemaBuilder = JsonSchema,
-	StringEnum: StringEnumBuilder = localStringEnum,
-) {
-	return Type.Object({
-
-	args: Type.Optional(
-		Type.Array(Type.String({ description: "Exact agent-browser CLI arguments, excluding the binary name. Do not pass --json; the wrapper injects it. First-call recipe: open → snapshot -i → click/fill @eN → snapshot -i." }), {
-			description: "Exact agent-browser CLI arguments, excluding the binary name and any shell operators. Required unless semanticAction, job, qa, sourceLookup, networkSourceLookup, or electron is provided. Do not include --json (wrapper injects it). Typical first calls: open, snapshot -i, click/fill current @refs, then snapshot -i again after navigation or DOM changes.",
-			minItems: 1,
-		}),
-	),
-	semanticAction: Type.Optional(
-		Type.Object({
-			action: StringEnum(AGENT_BROWSER_SEMANTIC_ACTIONS, {
-				description: "Intent action to compile to an existing agent-browser find command, direct selector/ref command, or upstream select when action=select.",
-			}),
-			locator: Type.Optional(StringEnum(AGENT_BROWSER_SEMANTIC_LOCATORS, {
-				description: "Upstream find locator family to use for check/click/fill actions.",
-			})),
-			value: Type.Optional(Type.String({ description: "Locator value for find actions, or a single option value for select actions. For locator=role, role may be supplied instead." })),
-			values: Type.Optional(Type.Array(Type.String({ description: "Option value for select actions." }), { description: "One or more option values for select actions.", minItems: 1 })),
-			selector: Type.Optional(Type.String({ description: "Selector or @ref for direct click/check/fill actions, or for select actions compiled to select <selector> <value...>." })),
-			text: Type.Optional(Type.String({ description: "Text/value argument for fill actions." })),
-			role: Type.Optional(Type.String({ description: "Role locator value for locator=role. May be used instead of value; when both are set they must match." })),
-			name: Type.Optional(Type.String({ description: "Accessible name filter for locator=role; compiles to --name <name>." })),
-			session: Type.Optional(Type.String({ description: "Optional upstream session name; prepends --session <name> before the compiled command." })),
-		}, { additionalProperties: false }),
-	),
-	qa: Type.Optional(
-		Type.Union([
-			Type.Object({
-				attached: Type.Literal(true, { description: "Run the QA preset against the currently attached session instead of opening qa.url." }),
-				expectedText: Type.Optional(Type.Union([Type.String(), Type.Array(Type.String())], { description: "Text that must appear on the page." })),
-				expectedSelector: Type.Optional(Type.String({ description: "Selector or @ref that must appear on the page." })),
-				screenshotPath: Type.Optional(Type.String({ description: "Optional evidence screenshot path captured at the end of the QA preset." })),
-				checkConsole: Type.Optional(Type.Boolean({ description: "Whether to inspect console messages and fail on console errors. Defaults to false for qa.attached because upstream buffers may predate the check." })),
-				checkErrors: Type.Optional(Type.Boolean({ description: "Whether to inspect page errors and fail when errors are present. Defaults to false for qa.attached because upstream buffers may predate the check." })),
-				checkNetwork: Type.Optional(Type.Boolean({ description: "Whether to inspect network requests and fail on actionable request failures; benign icon misses warn. Defaults to false for qa.attached because upstream buffers may predate the check." })),
-				loadState: Type.Optional(StringEnum(AGENT_BROWSER_QA_LOAD_STATES, { description: "Page readiness state for the QA preset before assertions and diagnostics. Defaults to domcontentloaded; use networkidle only for pages without long-lived background requests." })),
-			}, { additionalProperties: false }),
-			Type.Object({
-				url: Type.String({ description: "URL to open for a lightweight QA preset." }),
-				attached: Type.Optional(Type.Literal(false, { description: "When omitted or false, qa.url is required and opened before checks." })),
-				expectedText: Type.Optional(Type.Union([Type.String(), Type.Array(Type.String())], { description: "Text that must appear on the page." })),
-				expectedSelector: Type.Optional(Type.String({ description: "Selector or @ref that must appear on the page." })),
-				screenshotPath: Type.Optional(Type.String({ description: "Optional evidence screenshot path captured at the end of the QA preset." })),
-				checkConsole: Type.Optional(Type.Boolean({ description: "Whether to fail on console error messages. Defaults to true." })),
-				checkErrors: Type.Optional(Type.Boolean({ description: "Whether to fail on page errors. Defaults to true." })),
-				checkNetwork: Type.Optional(Type.Boolean({ description: "Whether to inspect network requests and fail on actionable request failures; benign icon misses warn. Defaults to true." })),
-				loadState: Type.Optional(StringEnum(AGENT_BROWSER_QA_LOAD_STATES, { description: "Page readiness state for the QA preset before assertions and diagnostics. Defaults to domcontentloaded; use networkidle only for pages without long-lived background requests." })),
-			}, { additionalProperties: false }),
-		], { description: "Lightweight QA preset. Use qa.url to open a URL, or qa.attached=true to check the current attached session without opening a URL." }),
-	),
-	sourceLookup: Type.Optional(
-		Type.Object({
-			selector: Type.Optional(Type.String({ description: "Visible selector or @ref whose DOM metadata should be inspected for source hints." })),
-			reactFiberId: Type.Optional(Type.String({ description: "React fiber id to inspect with upstream react inspect. Requires a session opened with --enable react-devtools." })),
-			componentName: Type.Optional(Type.String({ description: "Component name to correlate with react tree output and bounded local workspace search." })),
-			includeDomHints: Type.Optional(Type.Boolean({ description: "Whether selector lookups should inspect DOM HTML attributes for source-like metadata. Defaults to true." })),
-			maxWorkspaceFiles: Type.Optional(Type.Number({ description: "Maximum local source files to scan when componentName is provided. Defaults to 2000 and cannot exceed 5000.", minimum: 1, maximum: SOURCE_LOOKUP_MAX_WORKSPACE_FILES })),
-		}, { additionalProperties: false, description: "EXPERIMENTAL: local UI-to-source candidates only (confidence/evidence, not guaranteed mappings). Compiles to batch; mutually exclusive with other input modes." }),
-	),
-	networkSourceLookup: Type.Optional(
-		Type.Object({
-			filter: Type.Optional(Type.String({ description: "Optional upstream network requests filter pattern." })),
-			requestId: Type.Optional(Type.String({ description: "Optional network request id to inspect with network request <id>." })),
-			session: Type.Optional(Type.String({ description: "Optional upstream session name; prepends --session <name> before the generated batch." })),
-			url: Type.Optional(Type.String({ description: "Optional failed request URL or URL fragment to correlate with local source." })),
-			maxWorkspaceFiles: Type.Optional(Type.Number({ description: "Maximum local source files to scan for URL literals. Defaults to 2000 and cannot exceed 5000.", minimum: 1, maximum: SOURCE_LOOKUP_MAX_WORKSPACE_FILES })),
-		}, { additionalProperties: false, description: "EXPERIMENTAL: failed-request-to-source candidates only (initiator metadata and bounded workspace URL literals; not definitive blame). Compiles to batch; mutually exclusive with other input modes." }),
-	),
-	electron: Type.Optional(
-		Type.Union([
-			Type.Object({
-				action: StringEnum(["list"] as const, { description: "List discovered Electron apps." }),
-				query: Type.Optional(Type.String({ description: "Optional case-insensitive substring filter for electron.list across app name, bundle id, desktop id, and paths.", minLength: 1 })),
-				maxResults: Type.Optional(Type.Integer({ description: `Maximum electron.list apps to return. Defaults to ${ELECTRON_DISCOVERY_DEFAULT_MAX_RESULTS}; values above ${ELECTRON_DISCOVERY_MAX_RESULTS} are clamped.`, minimum: 1 })),
-			}, { additionalProperties: false }),
-			Type.Object({
-				action: StringEnum(["launch"] as const, { description: "Launch an Electron app with an isolated wrapper-owned profile." }),
-				appPath: Type.String({ description: "Electron launch target: macOS .app bundle path. Exactly one launch target is required for electron.launch.", minLength: 1 }),
-				appArgs: Type.Optional(Type.Array(Type.String({ description: "Argument passed to the Electron application.", minLength: 1 }), { description: "Optional Electron app argv. Wrapper-owned lifecycle/debug flags are rejected." })),
-				handoff: Type.Optional(StringEnum(AGENT_BROWSER_ELECTRON_HANDOFFS, { description: "Post-launch handoff depth. Defaults to snapshot." })),
-				targetType: Type.Optional(StringEnum(AGENT_BROWSER_ELECTRON_TARGET_TYPES, { description: "Preferred CDP target type. Defaults to page." })),
-				timeoutMs: Type.Optional(Type.Integer({ description: "Bounded launch timeout in milliseconds.", minimum: 1 })),
-				allow: Type.Optional(Type.Array(Type.String({ description: "App identifier allowed by the caller for electron.launch.", minLength: 1 }), { description: "Optional caller-owned allow list for electron.launch policy checks." })),
-				deny: Type.Optional(Type.Array(Type.String({ description: "App identifier denied by the caller for electron.launch.", minLength: 1 }), { description: "Optional caller-owned deny list for electron.launch policy checks; deny wins over allow." })),
-			}, { additionalProperties: false }),
-			Type.Object({
-				action: StringEnum(["launch"] as const, { description: "Launch an Electron app with an isolated wrapper-owned profile." }),
-				appName: Type.String({ description: "Electron launch target: app display name discovered by electron.list. Exactly one launch target is required for electron.launch.", minLength: 1 }),
-				appArgs: Type.Optional(Type.Array(Type.String({ description: "Argument passed to the Electron application.", minLength: 1 }), { description: "Optional Electron app argv. Wrapper-owned lifecycle/debug flags are rejected." })),
-				handoff: Type.Optional(StringEnum(AGENT_BROWSER_ELECTRON_HANDOFFS, { description: "Post-launch handoff depth. Defaults to snapshot." })),
-				targetType: Type.Optional(StringEnum(AGENT_BROWSER_ELECTRON_TARGET_TYPES, { description: "Preferred CDP target type. Defaults to page." })),
-				timeoutMs: Type.Optional(Type.Integer({ description: "Bounded launch timeout in milliseconds.", minimum: 1 })),
-				allow: Type.Optional(Type.Array(Type.String({ description: "App identifier allowed by the caller for electron.launch.", minLength: 1 }), { description: "Optional caller-owned allow list for electron.launch policy checks." })),
-				deny: Type.Optional(Type.Array(Type.String({ description: "App identifier denied by the caller for electron.launch.", minLength: 1 }), { description: "Optional caller-owned deny list for electron.launch policy checks; deny wins over allow." })),
-			}, { additionalProperties: false }),
-			Type.Object({
-				action: StringEnum(["launch"] as const, { description: "Launch an Electron app with an isolated wrapper-owned profile." }),
-				bundleId: Type.String({ description: "Electron launch target: macOS bundle identifier discovered by electron.list. Exactly one launch target is required for electron.launch.", minLength: 1 }),
-				appArgs: Type.Optional(Type.Array(Type.String({ description: "Argument passed to the Electron application.", minLength: 1 }), { description: "Optional Electron app argv. Wrapper-owned lifecycle/debug flags are rejected." })),
-				handoff: Type.Optional(StringEnum(AGENT_BROWSER_ELECTRON_HANDOFFS, { description: "Post-launch handoff depth. Defaults to snapshot." })),
-				targetType: Type.Optional(StringEnum(AGENT_BROWSER_ELECTRON_TARGET_TYPES, { description: "Preferred CDP target type. Defaults to page." })),
-				timeoutMs: Type.Optional(Type.Integer({ description: "Bounded launch timeout in milliseconds.", minimum: 1 })),
-				allow: Type.Optional(Type.Array(Type.String({ description: "App identifier allowed by the caller for electron.launch.", minLength: 1 }), { description: "Optional caller-owned allow list for electron.launch policy checks." })),
-				deny: Type.Optional(Type.Array(Type.String({ description: "App identifier denied by the caller for electron.launch.", minLength: 1 }), { description: "Optional caller-owned deny list for electron.launch policy checks; deny wins over allow." })),
-			}, { additionalProperties: false }),
-			Type.Object({
-				action: StringEnum(["launch"] as const, { description: "Launch an Electron app with an isolated wrapper-owned profile." }),
-				executablePath: Type.String({ description: "Electron launch target: executable path. Discovery is not required when this is provided. Exactly one launch target is required for electron.launch.", minLength: 1 }),
-				appArgs: Type.Optional(Type.Array(Type.String({ description: "Argument passed to the Electron application.", minLength: 1 }), { description: "Optional Electron app argv. Wrapper-owned lifecycle/debug flags are rejected." })),
-				handoff: Type.Optional(StringEnum(AGENT_BROWSER_ELECTRON_HANDOFFS, { description: "Post-launch handoff depth. Defaults to snapshot." })),
-				targetType: Type.Optional(StringEnum(AGENT_BROWSER_ELECTRON_TARGET_TYPES, { description: "Preferred CDP target type. Defaults to page." })),
-				timeoutMs: Type.Optional(Type.Integer({ description: "Bounded launch timeout in milliseconds.", minimum: 1 })),
-				allow: Type.Optional(Type.Array(Type.String({ description: "App identifier allowed by the caller for electron.launch.", minLength: 1 }), { description: "Optional caller-owned allow list for electron.launch policy checks." })),
-				deny: Type.Optional(Type.Array(Type.String({ description: "App identifier denied by the caller for electron.launch.", minLength: 1 }), { description: "Optional caller-owned deny list for electron.launch policy checks; deny wins over allow." })),
-			}, { additionalProperties: false }),
-			Type.Object({
-				action: StringEnum(["status", "cleanup"] as const, { description: "Inspect or cleanup one wrapper-tracked Electron launch by launchId." }),
-				launchId: Type.String({ description: "Wrapper launch id for electron.status and electron.cleanup.", minLength: 1 }),
-				timeoutMs: Type.Optional(Type.Integer({ description: "Bounded status/cleanup timeout in milliseconds.", minimum: 1 })),
-			}, { additionalProperties: false }),
-			Type.Object({
-				action: StringEnum(["status", "cleanup"] as const, { description: "Inspect or cleanup all wrapper-tracked Electron launches." }),
-				all: Type.Literal(true, { description: "Apply electron.status or electron.cleanup to all wrapper-owned launches." }),
-				timeoutMs: Type.Optional(Type.Integer({ description: "Bounded status/cleanup timeout in milliseconds.", minimum: 1 })),
-			}, { additionalProperties: false }),
-			Type.Object({
-				action: StringEnum(["status", "cleanup"] as const, { description: "Inspect or cleanup the only active wrapper-tracked Electron launch." }),
-				timeoutMs: Type.Optional(Type.Integer({ description: "Bounded status/cleanup timeout in milliseconds.", minimum: 1 })),
-			}, { additionalProperties: false }),
-			Type.Object({
-				action: StringEnum(["probe"] as const, { description: "Probe the current attached Electron managed session; launchId is accepted for launch-scoped follow-up actions." }),
-				launchId: Type.Optional(Type.String({ description: "Wrapper launch id for electron.probe follow-up targeting.", minLength: 1 })),
-				timeoutMs: Type.Optional(Type.Integer({ description: "Bounded probe timeout in milliseconds.", minimum: 1 })),
-			}, { additionalProperties: false }),
-		], { description: "Electron wrapper action. Fields are action-specific and unsupported fields are rejected." }),
-	),
-	job: Type.Optional(
-		Type.Object({
-			failFast: Type.Optional(Type.Boolean({ description: "Stop the compiled batch on the first failed job step. Defaults to true so later mutating steps do not run after setup/assertion failures." })),
-			steps: Type.Array(
-				Type.Object({
-					action: StringEnum(AGENT_BROWSER_JOB_STEP_ACTIONS, {
-						description: "Constrained one-call job step compiled to existing upstream batch commands.",
-					}),
-					url: Type.Optional(Type.String({ description: "URL for open steps, or URL pattern for assertUrl steps." })),
-					loadState: Type.Optional(StringEnum(AGENT_BROWSER_QA_LOAD_STATES, { description: "Optional readiness wait to insert immediately after an open step; use domcontentloaded/load/networkidle when the next job step needs page hydration evidence before clicking or reading." })),
-					selector: Type.Optional(Type.String({ description: "Selector or @ref for click/fill/type/select-like steps; omit when using semantic locator fields on click/fill steps." })),
-					locator: Type.Optional(StringEnum(AGENT_BROWSER_SEMANTIC_LOCATORS, { description: "Semantic locator for click/fill steps when selector is omitted." })),
-					role: Type.Optional(Type.String({ description: "Role locator value for click/fill steps when locator is role." })),
-					name: Type.Optional(Type.String({ description: "Accessible name filter for role locator click/fill steps." })),
-					text: Type.Optional(Type.String({ description: "Text for fill steps or visible text for assertText steps." })),
-					value: Type.Optional(Type.String({ description: "Single option value for select steps, or locator value for semantic click/fill steps." })),
-					values: Type.Optional(Type.Array(Type.String({ description: "Option value for select steps." }), { description: "One or more option values for select steps.", minItems: 1 })),
-					path: Type.Optional(Type.String({ description: "Artifact/download path for waitForDownload or screenshot steps." })),
-					delayMs: Type.Optional(Type.Integer({ description: `Optional per-character delay for type steps; when set, the job compiles to focus/keyboard type/wait steps instead of instant fill-like typing, capped at ${AGENT_BROWSER_JOB_TYPE_DELAYED_TEXT_MAX_CHARACTERS} characters.`, minimum: 1 })),
-					press: Type.Optional(Type.String({ description: "Optional key to press after a type step, for example Enter." })),
-					milliseconds: Type.Optional(Type.Number({ description: "Milliseconds for wait steps." })),
-				}, { additionalProperties: false }),
-				{ minItems: 1 },
-			),
-		}, { additionalProperties: false }),
-	),
-	stdin: Type.Optional(Type.String({ description: "Optional raw stdin content; only supported for batch, eval --stdin, auth save --password-stdin, and is generated internally by job, qa, sourceLookup, or networkSourceLookup mode. Do not use with electron mode." })),
-	outputPath: Type.Optional(Type.String({ description: "Optional workspace-relative or absolute file path that receives the model-facing command data/result after the browser command completes. Useful for eval/get/snapshot captures that should become durable local artifacts.", minLength: 1 })),
-	timeoutMs: Type.Optional(Type.Integer({ description: "Optional per-call wrapper subprocess watchdog in milliseconds for browser CLI args/job/qa/source lookup calls. Use for long opens or large output captures; fixed wait steps still must stay below the upstream IPC wait budget. Electron actions use electron.timeoutMs instead.", minimum: 1 })),
-	sessionMode: Type.Optional(
-		StringEnum(["auto", "fresh"] as const, {
-			description:
-				"Session handling mode. `auto` reuses the extension-managed pi-scoped session when possible. `fresh` switches that managed session to a fresh upstream launch so launch-scoped flags like --profile, --executable-path, --session-name, --cdp, --state, --auto-connect, --init-script, --enable, -p/--provider, or iOS --device apply and later auto calls follow the new browser.",
-			default: DEFAULT_SESSION_MODE,
-		}),
-	),
-	}, { additionalProperties: false });
-}
-
-export const AGENT_BROWSER_PARAMS = createAgentBrowserParamsSchema();

package/extensions/agent-browser/lib/input-modes/semantic-action.ts

@@ -1,127 +0,0 @@
-/**
- * Purpose: Compile semanticAction shorthand inputs into upstream agent-browser commands.
- * Responsibilities: Validate shorthand locator/action fields and expose compiled-command helpers.
- * Scope: semanticAction mode only.
- */
-
-import { isRecord } from "../parsing.js";
-import { getSelectValues } from "./shared.js";
-import {
-	AGENT_BROWSER_SEMANTIC_ACTIONS,
-	AGENT_BROWSER_SEMANTIC_LOCATORS,
-	type AgentBrowserSemanticActionName,
-	type AgentBrowserSemanticLocator,
-	type CompiledAgentBrowserSemanticAction,
-} from "./types.js";
-
-export function getCompiledSemanticActionCommandIndex(compiled: CompiledAgentBrowserSemanticAction): number {
-	return compiled.args[0] === "--session" ? 2 : 0;
-}
-
-export function getCompiledSemanticActionSessionPrefix(compiled: CompiledAgentBrowserSemanticAction): string[] {
-	const commandIndex = getCompiledSemanticActionCommandIndex(compiled);
-	return commandIndex > 0 ? compiled.args.slice(0, commandIndex) : [];
-}
-
-export function isCompiledSemanticActionFindCommand(compiled: CompiledAgentBrowserSemanticAction | undefined): boolean {
-	if (!compiled) return false;
-	return compiled.args[getCompiledSemanticActionCommandIndex(compiled)] === "find";
-}
-
-export function compileAgentBrowserSemanticAction(input: unknown): { compiled?: CompiledAgentBrowserSemanticAction; error?: string } {
-	if (!isRecord(input)) {
-		return { error: "semanticAction must be an object." };
-	}
-	const action = input.action;
-	const locator = input.locator;
-	const value = input.value;
-	const values = input.values;
-	const selector = input.selector;
-	const text = input.text;
-	const role = input.role;
-	const name = input.name;
-	const session = input.session;
-	if (typeof action !== "string" || !AGENT_BROWSER_SEMANTIC_ACTIONS.includes(action as AgentBrowserSemanticActionName)) {
-		return { error: `semanticAction.action must be one of: ${AGENT_BROWSER_SEMANTIC_ACTIONS.join(", ")}.` };
-	}
-	if (session !== undefined && (typeof session !== "string" || session.trim().length === 0)) {
-		return { error: "semanticAction.session must be a non-empty string when provided." };
-	}
-	if (action === "select") {
-		if (locator !== undefined || role !== undefined || name !== undefined) {
-			return { error: "semanticAction.locator, role, and name are not supported for select; use selector plus value or values." };
-		}
-		if (text !== undefined) {
-			return { error: "semanticAction.text is not supported for select; use value or values for option values." };
-		}
-		if (typeof selector !== "string" || selector.trim().length === 0) {
-			return { error: "semanticAction.selector is required for select." };
-		}
-		const selectedValues = getSelectValues(input, "semanticAction");
-		if (selectedValues.error) return { error: selectedValues.error };
-		const args = typeof session === "string" ? ["--session", session, "select", selector, ...(selectedValues.values as string[])] : ["select", selector, ...(selectedValues.values as string[])];
-		return { compiled: { action: "select", selector, values: selectedValues.values, args } };
-	}
-	if (values !== undefined) {
-		return { error: "semanticAction.values is only supported for select actions." };
-	}
-	if (selector !== undefined) {
-		if (typeof selector !== "string" || selector.trim().length === 0) {
-			return { error: "semanticAction.selector must be a non-empty string when provided." };
-		}
-		if (locator !== undefined || value !== undefined || role !== undefined || name !== undefined) {
-			return { error: "semanticAction.selector cannot be combined with locator, value, role, or name; use selector for a direct click/check/fill target or locator fields for find-based actions." };
-		}
-		if (text !== undefined && typeof text !== "string") {
-			return { error: "semanticAction.text must be a string when provided." };
-		}
-		if (action === "fill" && (typeof text !== "string" || text.length === 0)) {
-			return { error: `semanticAction.text is required for ${action}.` };
-		}
-		if (action !== "fill" && text !== undefined) {
-			return { error: "semanticAction.text is only supported for fill actions." };
-		}
-		const directArgs = typeof session === "string" ? ["--session", session, action, selector] : [action, selector];
-		if (action === "fill") directArgs.push(text as string);
-		return { compiled: { action: action as AgentBrowserSemanticActionName, selector, args: directArgs } };
-	}
-	if (typeof locator !== "string" || !AGENT_BROWSER_SEMANTIC_LOCATORS.includes(locator as AgentBrowserSemanticLocator)) {
-		return { error: `semanticAction.locator must be one of: ${AGENT_BROWSER_SEMANTIC_LOCATORS.join(", ")}.` };
-	}
-	if (value !== undefined && (typeof value !== "string" || value.trim().length === 0)) {
-		return { error: "semanticAction.value must be a non-empty string when provided." };
-	}
-	if (role !== undefined && (typeof role !== "string" || role.trim().length === 0)) {
-		return { error: "semanticAction.role must be a non-empty string when provided." };
-	}
-	const locatorValue = locator === "role" && typeof role === "string" ? role : value;
-	if (typeof locatorValue !== "string" || locatorValue.trim().length === 0) {
-		return { error: locator === "role" ? "semanticAction.value or semanticAction.role must be a non-empty string for locator=role." : "semanticAction.value must be a non-empty string." };
-	}
-	if (text !== undefined && typeof text !== "string") {
-		return { error: "semanticAction.text must be a string when provided." };
-	}
-	if (action === "fill" && (typeof text !== "string" || text.length === 0)) {
-		return { error: `semanticAction.text is required for ${action}.` };
-	}
-	if (action !== "fill" && text !== undefined) {
-		return { error: "semanticAction.text is only supported for fill actions." };
-	}
-	if (role !== undefined && locator !== "role") {
-		return { error: "semanticAction.role is only supported for locator=role." };
-	}
-	if (role !== undefined && value !== undefined && role !== value) {
-		return { error: "semanticAction.role must match value when both are provided for locator=role." };
-	}
-	if (name !== undefined && (locator !== "role" || typeof name !== "string" || name.length === 0)) {
-		return { error: "semanticAction.name is only supported as a non-empty string for locator=role." };
-	}
-	const args = typeof session === "string" ? ["--session", session, "find", locator, locatorValue, action] : ["find", locator, locatorValue, action];
-	if (action === "fill") {
-		args.push(text as string);
-	}
-	if (locator === "role" && typeof name === "string") {
-		args.push("--name", name);
-	}
-	return { compiled: { action: action as AgentBrowserSemanticActionName, locator: locator as AgentBrowserSemanticLocator, args } };
-}

package/extensions/agent-browser/lib/input-modes/shared.ts

@@ -1,46 +0,0 @@
-/**
- * Purpose: Hold tiny shared parsing helpers for structured agent_browser input modes.
- * Responsibilities: Normalize common select values, batch result rows, and workspace scan limits.
- * Scope: Generic input-mode helpers only; mode-specific policy stays in the owning module.
- */
-
-import { isRecord } from "../parsing.js";
-import { SOURCE_LOOKUP_DEFAULT_MAX_WORKSPACE_FILES, SOURCE_LOOKUP_MAX_WORKSPACE_FILES } from "./types.js";
-
-export function getSelectValues(input: Record<string, unknown>, context: string): { values?: string[]; error?: string } {
-	const rawValue = input.value;
-	const rawValues = input.values;
-	if (rawValue !== undefined && rawValues !== undefined) {
-		return { error: `${context}.value and ${context}.values cannot both be provided for select.` };
-	}
-	if (rawValues !== undefined) {
-		if (!Array.isArray(rawValues) || rawValues.length === 0 || rawValues.some((value) => typeof value !== "string" || value.trim().length === 0)) {
-			return { error: `${context}.values must be a non-empty array of non-empty strings for select.` };
-		}
-		return { values: rawValues };
-	}
-	if (typeof rawValue === "string" && rawValue.trim().length > 0) {
-		return { values: [rawValue] };
-	}
-	return { error: `${context}.value or ${context}.values is required for select.` };
-}
-
-export function getBatchResultItems(data: unknown): Array<Record<string, unknown>> {
-	return Array.isArray(data) ? data.filter(isRecord) : [];
-}
-
-export function getCommandNameFromBatchItem(item: Record<string, unknown>): string | undefined {
-	const command = item.command;
-	return Array.isArray(command) && typeof command[0] === "string" ? command[0] : undefined;
-}
-
-export function validateLookupMaxWorkspaceFiles(value: unknown, fieldName: string): { value?: number; error?: string } {
-	if (value === undefined) return { value: SOURCE_LOOKUP_DEFAULT_MAX_WORKSPACE_FILES };
-	if (typeof value !== "number" || !Number.isInteger(value) || value <= 0) {
-		return { error: `${fieldName} must be a positive integer when provided.` };
-	}
-	if (value > SOURCE_LOOKUP_MAX_WORKSPACE_FILES) {
-		return { error: `${fieldName} must be ${SOURCE_LOOKUP_MAX_WORKSPACE_FILES} or less.` };
-	}
-	return { value };
-}

package/extensions/agent-browser/lib/input-modes/types.ts

@@ -1,225 +0,0 @@
-/**
- * Purpose: Define structured agent_browser input-mode constants and TypeScript contracts.
- * Responsibilities: Share schema enums and compiled input-mode result types across input-mode modules.
- * Scope: Types and constants only; validation and compilation live in sibling modules.
- */
-
-export const DEFAULT_SESSION_MODE = "auto" as const;
-
-export const AGENT_BROWSER_SEMANTIC_ACTIONS = ["check", "click", "fill", "select"] as const;
-
-export const AGENT_BROWSER_SEMANTIC_LOCATORS = ["alt", "label", "placeholder", "role", "testid", "text", "title"] as const;
-
-export const AGENT_BROWSER_JOB_TYPE_DELAYED_TEXT_MAX_CHARACTERS = 200;
-export const AGENT_BROWSER_JOB_STEP_ACTIONS = ["open", "click", "fill", "type", "select", "wait", "assertText", "assertUrl", "waitForDownload", "screenshot", "snapshot"] as const;
-
-export const AGENT_BROWSER_QA_LOAD_STATES = ["domcontentloaded", "load", "networkidle"] as const;
-
-export const AGENT_BROWSER_ELECTRON_ACTIONS = ["list", "launch", "status", "cleanup", "probe"] as const;
-
-export const AGENT_BROWSER_ELECTRON_HANDOFFS = ["connect", "tabs", "snapshot"] as const;
-
-export const AGENT_BROWSER_ELECTRON_TARGET_TYPES = ["page", "webview", "any"] as const;
-
-export const AGENT_BROWSER_ELECTRON_LIST_FIELDS = new Set(["action", "query", "maxResults"]);
-
-export const AGENT_BROWSER_ELECTRON_PROBE_FIELDS = new Set(["action", "launchId", "timeoutMs"]);
-
-export const AGENT_BROWSER_ELECTRON_RESERVED_APP_ARGS = ["--user-data-dir", "--remote-debugging-port", "--remote-debugging-address", "--remote-debugging-pipe"] as const;
-
-export const SOURCE_LOOKUP_WORKSPACE_EXTENSIONS = new Set([".ts", ".tsx", ".js", ".jsx"]);
-
-export const SOURCE_LOOKUP_IGNORED_DIRECTORIES = new Set([".git", "node_modules", "dist", "build", "coverage", ".next", "out", "tmp", "temp"]);
-
-export const SOURCE_LOOKUP_DEFAULT_MAX_WORKSPACE_FILES = 2_000;
-
-export const SOURCE_LOOKUP_MAX_WORKSPACE_FILES = 5_000;
-
-export type AgentBrowserSemanticActionName = (typeof AGENT_BROWSER_SEMANTIC_ACTIONS)[number];
-
-export type AgentBrowserSemanticLocator = (typeof AGENT_BROWSER_SEMANTIC_LOCATORS)[number];
-
-export type AgentBrowserJobStepAction = (typeof AGENT_BROWSER_JOB_STEP_ACTIONS)[number];
-
-export type AgentBrowserQaLoadState = (typeof AGENT_BROWSER_QA_LOAD_STATES)[number];
-
-export type AgentBrowserElectronAction = (typeof AGENT_BROWSER_ELECTRON_ACTIONS)[number];
-
-export type AgentBrowserSourceLookupStatus = "candidates-found" | "no-candidates" | "unsupported";
-
-export type AgentBrowserNetworkSourceLookupStatus = "failed-requests-found" | "no-failed-requests" | "no-candidates";
-
-export type CompiledAgentBrowserElectron =
-	| {
-		action: "list";
-		maxResults?: number;
-		query?: string;
-	}
-	| {
-		action: "launch";
-		allow?: string[];
-		appArgs?: string[];
-		deny?: string[];
-		appName?: string;
-		appPath?: string;
-		bundleId?: string;
-		executablePath?: string;
-		handoff: "connect" | "snapshot" | "tabs";
-		targetType: "any" | "page" | "webview";
-		timeoutMs?: number;
-	}
-	| {
-		action: "cleanup" | "status";
-		all?: boolean;
-		launchId?: string;
-		timeoutMs?: number;
-	}
-	| {
-		action: "probe";
-		launchId?: string;
-		timeoutMs?: number;
-	};
-
-export interface AgentBrowserSemanticActionInput {
-	action: AgentBrowserSemanticActionName;
-	locator?: AgentBrowserSemanticLocator;
-	value?: string;
-	values?: string[];
-	selector?: string;
-	text?: string;
-	role?: string;
-	name?: string;
-	session?: string;
-}
-
-export interface CompiledAgentBrowserSemanticAction {
-	action: AgentBrowserSemanticActionName;
-	locator?: AgentBrowserSemanticLocator;
-	selector?: string;
-	values?: string[];
-	args: string[];
-}
-
-export interface CompiledAgentBrowserJobStep {
-	action: AgentBrowserJobStepAction;
-	args: string[];
-	generatedFrom?: string;
-}
-
-export interface CompiledAgentBrowserJob {
-	args: string[];
-	failFast: boolean;
-	stdin: string;
-	steps: CompiledAgentBrowserJobStep[];
-}
-
-export interface CompiledAgentBrowserQaPreset extends CompiledAgentBrowserJob {
-	checks: {
-		checkConsole: boolean;
-		checkErrors: boolean;
-		checkNetwork: boolean;
-		diagnosticsResetAtStart: boolean;
-		loadState: AgentBrowserQaLoadState;
-		expectedText: string[];
-		expectedSelector?: string;
-		screenshotPath?: string;
-		attached: boolean;
-		url?: string;
-	};
-}
-
-export interface CompiledAgentBrowserSourceLookupStep {
-	action: "dom" | "react";
-	args: string[];
-}
-
-export interface CompiledAgentBrowserSourceLookup {
-	args: string[];
-	stdin: string;
-	steps: CompiledAgentBrowserSourceLookupStep[];
-	query: {
-		componentName?: string;
-		includeDomHints: boolean;
-		maxWorkspaceFiles: number;
-		reactFiberId?: string;
-		selector?: string;
-	};
-}
-
-export interface AgentBrowserSourceLookupCandidate {
-	column?: number;
-	componentName?: string;
-	confidence: "high" | "medium" | "low";
-	evidence: string[];
-	file?: string;
-	line?: number;
-	source: "react-inspect" | "dom-attribute" | "workspace-search";
-}
-
-export interface AgentBrowserSourceLookupElectronContext {
-	appName?: string;
-	appPath?: string;
-	executablePath?: string;
-	launchId?: string;
-	sessionName?: string;
-	url?: string;
-}
-
-export interface AgentBrowserSourceLookupAnalysis {
-	candidates: AgentBrowserSourceLookupCandidate[];
-	electronContext?: AgentBrowserSourceLookupElectronContext;
-	limitations: string[];
-	status: AgentBrowserSourceLookupStatus;
-	summary: string;
-	workspaceRoot?: string;
-}
-
-export interface AgentBrowserSourceLookupAnalysisContext {
-	electronContext?: AgentBrowserSourceLookupElectronContext;
-	workspaceRoot: string;
-}
-
-export interface CompiledAgentBrowserNetworkSourceLookup {
-	args: string[];
-	stdin: string;
-	steps: Array<{ action: "network"; args: string[] }>;
-	query: {
-		filter?: string;
-		maxWorkspaceFiles: number;
-		requestId?: string;
-		session?: string;
-		url?: string;
-	};
-}
-
-export interface AgentBrowserNetworkSourceLookupRequest {
-	error?: string;
-	method?: string;
-	requestId?: string;
-	status?: number;
-	url?: string;
-}
-
-export interface AgentBrowserNetworkSourceLookupCandidate {
-	confidence: "high" | "medium" | "low";
-	evidence: string[];
-	file?: string;
-	line?: number;
-	requestUrl?: string;
-	source: "initiator" | "workspace-search";
-}
-
-export interface AgentBrowserNetworkSourceLookupAnalysis {
-	candidates: AgentBrowserNetworkSourceLookupCandidate[];
-	failedRequests: AgentBrowserNetworkSourceLookupRequest[];
-	limitations: string[];
-	status: AgentBrowserNetworkSourceLookupStatus;
-	summary: string;
-}
-
-export interface AgentBrowserQaPresetAnalysis {
-	failedChecks: string[];
-	passed: boolean;
-	summary: string;
-	warnings: string[];
-}

package/extensions/agent-browser/lib/input-modes.ts

@@ -1,45 +0,0 @@
-/**
- * Purpose: Re-export focused input-mode schema, compiler, and analysis modules for the agent_browser wrapper.
- * Responsibilities: Preserve the extension entrypoint's import surface while keeping input-mode code split by concern.
- * Scope: Barrel only; add behavior to focused files under ./input-modes/.
- */
-
-export { AGENT_BROWSER_PARAMS } from "./input-modes/params.js";
-export {
-	analyzeQaPresetResults,
-	analyzeQaPresetTimeout,
-	buildQaCompactPassText,
-	compileAgentBrowserJob,
-	compileAgentBrowserQaPreset,
-	extractQaPageContext,
-	isHttpOrHttpsUrl,
-} from "./input-modes/job.js";
-export {
-	analyzeNetworkSourceLookupResults,
-	analyzeSourceLookupResults,
-	compileAgentBrowserNetworkSourceLookup,
-	compileAgentBrowserSourceLookup,
-	redactNetworkSourceLookupAnalysis,
-	redactNetworkSourceLookupArgs,
-	redactNetworkSourceLookupSurface,
-	redactNetworkSourceLookupUrl,
-} from "./input-modes/lookups.js";
-export { compileAgentBrowserElectron } from "./input-modes/electron.js";
-export {
-	compileAgentBrowserSemanticAction,
-	getCompiledSemanticActionCommandIndex,
-	getCompiledSemanticActionSessionPrefix,
-	isCompiledSemanticActionFindCommand,
-} from "./input-modes/semantic-action.js";
-export type {
-	AgentBrowserNetworkSourceLookupAnalysis,
-	AgentBrowserQaPresetAnalysis,
-	AgentBrowserSourceLookupAnalysis,
-	AgentBrowserSourceLookupElectronContext,
-	CompiledAgentBrowserElectron,
-	CompiledAgentBrowserJob,
-	CompiledAgentBrowserNetworkSourceLookup,
-	CompiledAgentBrowserQaPreset,
-	CompiledAgentBrowserSemanticAction,
-	CompiledAgentBrowserSourceLookup,
-} from "./input-modes/types.js";