pi-agent-browser-native 0.2.1 → 0.2.3

package/extensions/agent-browser/lib/results/presentation.ts

@@ -10,6 +10,7 @@ import { readFile, stat } from "node:fs/promises";
 import { resolve } from "node:path";
 
 import { parseCommandInfo, type CommandInfo } from "../runtime.js";
+import { type PersistentSessionArtifactStore } from "../temp.js";
 import { buildSnapshotPresentation, formatRawSnapshotText, formatSnapshotSummary } from "./snapshot.js";
 import {
 	type AgentBrowserBatchResult,
@@ -106,6 +107,63 @@ function getScreenshotSummary(data: Record<string, unknown>): string | undefined
 	return typeof data.path === "string" ? `Saved image: ${data.path}` : undefined;
 }
 
+function getScalarExtractionResult(data: Record<string, unknown>): string | undefined {
+	const { result } = data;
+	if (typeof result === "string") {
+		return result.trim().length > 0 ? result : undefined;
+	}
+	if (typeof result === "number" || typeof result === "boolean") {
+		return String(result);
+	}
+	return undefined;
+}
+
+function getExtractionOrigin(data: Record<string, unknown>): string | undefined {
+	if (typeof data.origin === "string" && data.origin.trim().length > 0) {
+		return data.origin.trim();
+	}
+	if (typeof data.url === "string" && data.url.trim().length > 0) {
+		return data.url.trim();
+	}
+	return undefined;
+}
+
+function formatGetSummaryLabel(subcommand: string | undefined): string {
+	if (!subcommand) {
+		return "Get result";
+	}
+	if (subcommand.toLowerCase() === "url") {
+		return "URL";
+	}
+	return `${subcommand.slice(0, 1).toUpperCase()}${subcommand.slice(1)}`;
+}
+
+function formatExtractionSummary(commandInfo: CommandInfo, data: Record<string, unknown>): string | undefined {
+	const scalarResult = getScalarExtractionResult(data);
+	if (!scalarResult) {
+		return undefined;
+	}
+	if (commandInfo.command === "get") {
+		return `${formatGetSummaryLabel(commandInfo.subcommand)}: ${scalarResult.split("\n", 1)[0] ?? scalarResult}`;
+	}
+	if (commandInfo.command === "eval") {
+		return `Eval result: ${scalarResult.split("\n", 1)[0] ?? scalarResult}`;
+	}
+	return undefined;
+}
+
+function formatExtractionText(commandInfo: CommandInfo, data: Record<string, unknown>): string | undefined {
+	if (commandInfo.command !== "get" && commandInfo.command !== "eval") {
+		return undefined;
+	}
+	const scalarResult = getScalarExtractionResult(data);
+	if (!scalarResult) {
+		return undefined;
+	}
+	const origin = getExtractionOrigin(data);
+	return origin && origin !== scalarResult ? `${scalarResult}\n\nOrigin: ${origin}` : scalarResult;
+}
+
 function isNavigationObservableCommand(command: string | undefined): boolean {
 	return command !== undefined && NAVIGATION_SUMMARY_COMMANDS.has(command);
 }
@@ -207,8 +265,9 @@ async function buildBatchStepPresentation(options: {
 	cwd: string;
 	index: number;
 	item: AgentBrowserBatchResult;
+	persistentArtifactStore?: PersistentSessionArtifactStore;
 }): Promise<{ details: BatchStepPresentationDetails; presentation: ToolPresentation }> {
-	const { cwd, index, item } = options;
+	const { cwd, index, item, persistentArtifactStore } = options;
 	const command = isStringArray(item.command) ? item.command : undefined;
 	const commandText = formatBatchStepCommand(command, index);
 
@@ -236,6 +295,7 @@ async function buildBatchStepPresentation(options: {
 		commandInfo: parseCommandInfo(command ?? []),
 		cwd,
 		envelope: { data: item.result, success: true },
+		persistentArtifactStore,
 	});
 	const fullOutputPaths = getPresentationPaths({
 		primaryPath: presentation.fullOutputPath,
@@ -268,12 +328,28 @@ async function buildBatchStepPresentation(options: {
 async function buildBatchPresentation(options: {
 	cwd: string;
 	data: AgentBrowserBatchResult[];
+	persistentArtifactStore?: PersistentSessionArtifactStore;
 	summary: string;
 }): Promise<ToolPresentation> {
-	const { cwd, data, summary } = options;
+	const { cwd, data, persistentArtifactStore, summary } = options;
 	const steps: Array<{ details: BatchStepPresentationDetails; presentation: ToolPresentation }> = [];
+	const protectedPersistentPaths: string[] = [];
 	for (const [index, item] of data.entries()) {
-		steps.push(await buildBatchStepPresentation({ cwd, index, item }));
+		const step = await buildBatchStepPresentation({
+			cwd,
+			index,
+			item,
+			persistentArtifactStore: persistentArtifactStore
+				? { ...persistentArtifactStore, protectedPaths: protectedPersistentPaths }
+				: undefined,
+		});
+		steps.push(step);
+		protectedPersistentPaths.push(
+			...getPresentationPaths({
+				primaryPath: step.presentation.fullOutputPath,
+				secondaryPaths: step.presentation.fullOutputPaths,
+			}),
+		);
 	}
 
 	const batchFailure = getBatchFailureDetails(steps);
@@ -354,6 +430,10 @@ function formatSummary(commandInfo: CommandInfo, data: unknown): string {
 		if (commandInfo.command === "screenshot" && typeof data.path === "string") {
 			return `Screenshot saved: ${data.path}`;
 		}
+		const extractionSummary = formatExtractionSummary(commandInfo, data);
+		if (extractionSummary) {
+			return extractionSummary;
+		}
 		const pageSummary = getPageSummary(data);
 		if (pageSummary) {
 			return pageSummary.split("\n", 1)[0] ?? "agent-browser result";
@@ -404,6 +484,11 @@ function formatContentText(commandInfo: CommandInfo, data: unknown): string {
 		if (screenshotSummary) return screenshotSummary;
 	}
 
+	const extractionText = formatExtractionText(commandInfo, data);
+	if (extractionText) {
+		return extractionText;
+	}
+
 	const pageSummary = getPageSummary(data);
 	if (pageSummary) {
 		return pageSummary;
@@ -459,8 +544,9 @@ export async function buildToolPresentation(options: {
 	cwd: string;
 	envelope?: AgentBrowserEnvelope;
 	errorText?: string;
+	persistentArtifactStore?: PersistentSessionArtifactStore;
 }): Promise<ToolPresentation> {
-	const { commandInfo, cwd, envelope, errorText } = options;
+	const { commandInfo, cwd, envelope, errorText, persistentArtifactStore } = options;
 	if (errorText) {
 		return {
 			content: [{ type: "text", text: errorText }],
@@ -472,9 +558,9 @@ export async function buildToolPresentation(options: {
 	const summary = formatSummary(commandInfo, data);
 	const presentation =
 		commandInfo.command === "batch" && Array.isArray(data)
-			? await buildBatchPresentation({ cwd, data: data as AgentBrowserBatchResult[], summary })
+			? await buildBatchPresentation({ cwd, data: data as AgentBrowserBatchResult[], persistentArtifactStore, summary })
 			: commandInfo.command === "snapshot" && isRecord(data)
-				? await buildSnapshotPresentation(data)
+				? await buildSnapshotPresentation(data, persistentArtifactStore)
 				: {
 						content: [{ type: "text" as const, text: formatContentText(commandInfo, data) }],
 						data,

package/extensions/agent-browser/lib/results/snapshot.ts

@@ -6,7 +6,7 @@
  * Invariants/Assumptions: Snapshot compaction should stay helpful even if upstream snapshot text formatting shifts, so structured parsing is best-effort and always has a resilient raw-outline fallback.
  */
 
-import { writeSecureTempFile } from "../temp.js";
+import { type PersistentSessionArtifactStore, writePersistentSessionArtifactFile, writeSecureTempFile } from "../temp.js";
 import { type ToolPresentation, compareRefIds, countLines, isRecord, normalizeWhitespace, truncateText } from "./shared.js";
 
 const SNAPSHOT_INLINE_MAX_CHARS = 6_000;
@@ -463,12 +463,18 @@ function canUseStructuredSnapshotPreview(snapshotLines: SnapshotLine[], refEntri
 	);
 }
 
-async function writeSnapshotSpillFile(data: Record<string, unknown>): Promise<string> {
-	return await writeSecureTempFile({
+async function writeSnapshotSpillFile(
+	data: Record<string, unknown>,
+	persistentArtifactStore: PersistentSessionArtifactStore | undefined,
+): Promise<string> {
+	const options = {
 		content: JSON.stringify(data, null, 2),
 		prefix: SNAPSHOT_SPILL_FILE_PREFIX,
 		suffix: ".json",
-	});
+	};
+	return persistentArtifactStore
+		? await writePersistentSessionArtifactFile({ ...options, store: persistentArtifactStore })
+		: await writeSecureTempFile(options);
 }
 
 export function formatSnapshotSummary(data: Record<string, unknown>): string {
@@ -487,7 +493,10 @@ export function formatRawSnapshotText(data: Record<string, unknown>): string {
 	return `Origin: ${origin}\nRefs: ${refs}\n\n${snapshot}`;
 }
 
-export async function buildSnapshotPresentation(data: Record<string, unknown>): Promise<ToolPresentation> {
+export async function buildSnapshotPresentation(
+	data: Record<string, unknown>,
+	persistentArtifactStore: PersistentSessionArtifactStore | undefined = undefined,
+): Promise<ToolPresentation> {
 	const summary = formatSnapshotSummary(data);
 	const rawText = formatRawSnapshotText(data);
 	if (!shouldCompactSnapshot(rawText, data)) {
@@ -501,7 +510,7 @@ export async function buildSnapshotPresentation(data: Record<string, unknown>):
 	let fullOutputPath: string | undefined;
 	let spillErrorText: string | undefined;
 	try {
-		fullOutputPath = await writeSnapshotSpillFile(data);
+		fullOutputPath = await writeSnapshotSpillFile(data, persistentArtifactStore);
 	} catch (error) {
 		spillErrorText = error instanceof Error ? error.message : String(error);
 	}