pi-advisor-flow 0.9.0 → 0.9.2-dev.1

package/CHANGELOG.md

@@ -4,6 +4,23 @@ All notable changes to this project are documented here.
 
 The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0/).
 
+## 0.9.1 - 2026-09-30
+
+### Fixed
+
+- Overrode transitive `brace-expansion` 5.0.12 and `undici` 8.11.2 to clear four high-severity audit advisories (stack-exhaustion DoS, WebSocket subprotocol DoS, TLS validation bypass).
+
+- Fixed manual Advisor consultations crashing non-interactive (`--print`) sessions on Pi 0.99: UI status updates and scout lifecycle reads now no-op safely once the session context is retired instead of throwing, `/advisor-manual` completes within the command handler in print mode, and streaming tool-result repaint timers stop once their renderer is gone.
+
+### Changed
+
+- Added Pi 0.99.x support (peer range `^0.87.1 || ^0.99.1`); Pi 0.99's context-lifecycle enforcement is now honored. Manual consultation results no longer trigger a follow-up turn in print mode.
+- Updated the dev toolchain: oxlint 1.86.0, @oxlint/plugins 1.86.0, oxfmt 0.71.0, ultracite 7.12.2, knip 6.39.0.
+
+### Added
+
+- Regression tests covering stale-context resilience of the guarded UI helpers.
+
 ## 0.9.0 - 2026-09-28
 
 ### Added

package/README.md

@@ -41,7 +41,7 @@ Regular consultations never block execution. Automatic loop gates are different:
 
 ## Install
 
-Requires Pi 0.84.1 or later. Pi 0.85.0 is not supported (broken upstream release); use Pi 0.85.1 or later instead.
+Requires Pi 0.87.1+ (0.87.x) or 0.99.1+ (0.99.x).
 
 ```bash
 pi install npm:pi-advisor-flow

package/dist/index.js

@@ -3884,6 +3884,30 @@ var runAdvisorGate = async (ctx, question, trigger = "repeated-tool-call", signa
 // src/tools/scout-status.ts
 import { Text as Text2 } from "@earendil-works/pi-tui";
 
+// src/ui-guard.ts
+var isStaleContext = (error) => error instanceof Error && /stale/iu.test(error.message);
+var uiAvailable = (ctx) => {
+  try {
+    return ctx.hasUI;
+  } catch (error) {
+    if (isStaleContext(error)) {
+      return false;
+    }
+    throw error;
+  }
+};
+var uiAction = (ctx, action) => {
+  try {
+    if (ctx.hasUI) {
+      action(ctx.ui);
+    }
+  } catch (error) {
+    if (!isStaleContext(error)) {
+      throw error;
+    }
+  }
+};
+
 // src/tools/render-common.ts
 import { getMarkdownTheme } from "@earendil-works/pi-coding-agent";
 import {
@@ -4071,14 +4095,14 @@ class ScoutStatusManager {
     }
   }
   update(ctx, token, event) {
-    if (this.#retired.has(token) || !ctx.hasUI) {
+    if (this.#retired.has(token) || !uiAvailable(ctx)) {
       return;
     }
     this.#known.add(token);
     if (event.type === "call" || event.type === "chunk") {
       this.#active.add(token);
       if (this.showStatus) {
-        ctx.ui.setStatus("advisor-scout", "Scout curating…");
+        uiAction(ctx, (ui) => ui.setStatus("advisor-scout", "Scout curating…"));
       }
       return;
     }
@@ -4088,10 +4112,10 @@ class ScoutStatusManager {
     this.#active.delete(token);
     this.#known.delete(token);
     this.#retired.add(token);
-    if (!(ctx.hasUI && this.showStatus)) {
+    if (!(uiAvailable(ctx) && this.showStatus)) {
       return;
     }
-    ctx.ui.setStatus("advisor-scout", this.#active.size > 0 ? "Scout curating…" : undefined);
+    uiAction(ctx, (ui) => ui.setStatus("advisor-scout", this.#active.size > 0 ? "Scout curating…" : undefined));
   }
   clear(ctx) {
     for (const token of this.#known) {
@@ -4099,8 +4123,8 @@ class ScoutStatusManager {
     }
     this.#known.clear();
     this.#active.clear();
-    if (ctx.hasUI && this.showStatus) {
-      ctx.ui.setStatus("advisor-scout", undefined);
+    if (this.showStatus) {
+      uiAction(ctx, (ui) => ui.setStatus("advisor-scout", undefined));
     }
   }
 }
@@ -4638,9 +4662,7 @@ var advisorSessionState = new AdvisorSessionState;
 
 // src/commands/runtime.ts
 var notify = (ctx, message, level) => {
-  if (ctx.hasUI) {
-    ctx.ui.notify(message, level);
-  }
+  uiAction(ctx, (ui) => ui.notify(message, level));
 };
 var reportManualBudgetExhausted = (ctx) => {
   const message = "Advisor call budget exhausted for this session.";
@@ -4648,9 +4670,7 @@ var reportManualBudgetExhausted = (ctx) => {
   notifyHerdrAdvisorFailure("Advisor budget exhausted", message);
 };
 var requestManualRender = (ctx) => {
-  if (ctx.hasUI) {
-    ctx.ui.setStatus("advisor-manual", undefined);
-  }
+  uiAction(ctx, (ui) => ui.setStatus("advisor-manual", undefined));
 };
 
 class CommandRuntime {
@@ -4706,9 +4726,7 @@ class CommandRuntime {
     }
   }
   updateAdvisorUsageStatus(ctx) {
-    if (ctx.hasUI) {
-      ctx.ui.setStatus("advisor-usage", getAdvisorSettings().showUsageFooter ? this.advisorSessionState.usageStatus() : undefined);
-    }
+    uiAction(ctx, (ui) => ui.setStatus("advisor-usage", getAdvisorSettings().showUsageFooter ? this.advisorSessionState.usageStatus() : undefined));
   }
 }
 var createCommandRuntime = (pi, dependencies = {}) => new CommandRuntime(pi, dependencies);
@@ -5849,9 +5867,10 @@ var screeningSkipText = (outcome) => outcome.kind === "repeat" && outcome.reatta
 
 // src/commands/manual-consultation.ts
 var startManualConsultation = async (runtime, ctx, question, controller, scoutStatusToken, progress, gitContext) => {
+  const isPrintMode = ctx.mode === "print";
   progress.phase = "preparing";
   runtime.requestManualRender(ctx);
-  if (ctx.hasUI) {
+  if (uiAvailable(ctx)) {
     const timer = setInterval(() => {
       if (controller.signal.aborted || runtime.manualConsultations.get(controller) !== scoutStatusToken) {
         clearInterval(timer);
@@ -5916,7 +5935,7 @@ ${markdown}`,
       display: true
     }, {
       deliverAs: "steer",
-      triggerTurn: true
+      triggerTurn: !isPrintMode
     });
   } catch (error) {
     if (controller.signal.aborted) {
@@ -5941,7 +5960,7 @@ ${markdown}`,
         text: `**Advisor consultation failed:** ${message}`
       },
       display: true
-    }, { deliverAs: "steer", triggerTurn: true });
+    }, { deliverAs: "steer", triggerTurn: !isPrintMode });
     notify(ctx, `Advisor consultation failed: ${message}`, "error");
     notifyHerdrAdvisorFailure("Advisor consultation failed", message);
   } finally {
@@ -6035,7 +6054,15 @@ var registerManualCommand = (runtime) => {
       runtime.scoutStatus.register(scoutStatusToken);
       runtime.manualConsultations.set(controller, scoutStatusToken);
       runtime.pi.appendEntry?.("advisor-manual-call", { progressId, question });
-      startManualConsultation(runtime, ctx, question, controller, scoutStatusToken, progress, gitContext);
+      if (ctx.mode === "print") {
+        await startManualConsultation(runtime, ctx, question, controller, scoutStatusToken, progress, gitContext);
+        return;
+      }
+      (async () => {
+        try {
+          await startManualConsultation(runtime, ctx, question, controller, scoutStatusToken, progress, gitContext);
+        } catch {}
+      })();
     }
   });
 };
@@ -7769,7 +7796,14 @@ var renderPartialAdvisorResult = (box, result, expanded, theme, context) => {
   const scoutActive = scout?.status === "calling" || scout?.status === "streaming";
   syncRenderPhase(context, scoutActive ? "scout" : "advisor");
   if (!context.state.timerId) {
-    context.state.timerId = setInterval(() => context.invalidate(), 80);
+    context.state.timerId = setInterval(() => {
+      try {
+        context.invalidate();
+      } catch {
+        clearInterval(context.state.timerId);
+        context.state.timerId = undefined;
+      }
+    }, 80);
   }
   if (scout) {
     renderScoutDetails(box, scout, expanded, theme);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-advisor-flow",
-  "version": "0.9.0",
+  "version": "0.9.2-dev.1",
   "description": "Advanced Executor/Advisor flow for Pi, fully configurable and extendable.",
   "keywords": [
     "advisor",
@@ -51,26 +51,26 @@
     "format:check": "oxfmt --check"
   },
   "devDependencies": {
-    "@earendil-works/pi-ai": "0.87.1",
-    "@earendil-works/pi-coding-agent": "0.87.1",
-    "@earendil-works/pi-tui": "0.87.1",
-    "@oxlint/plugins": "1.85.0",
+    "@earendil-works/pi-ai": "0.99.1",
+    "@earendil-works/pi-coding-agent": "0.99.1",
+    "@earendil-works/pi-tui": "0.99.1",
+    "@oxlint/plugins": "1.86.0",
     "@types/node": "^26.6.3",
     "@typesafe-ai/sdk": "^0.6.0",
     "bun-types": "1.4.2",
     "husky": "^9.1.7",
-    "knip": "^6.38.0",
+    "knip": "6.39.0",
     "lint-staged": "^17.6.0",
-    "oxfmt": "0.70.0",
-    "oxlint": "1.85.0",
+    "oxfmt": "0.71.0",
+    "oxlint": "1.86.0",
     "typebox": "^1.3.34",
     "typescript": "^7.0.2",
-    "ultracite": "7.12.0"
+    "ultracite": "7.12.2"
   },
   "peerDependencies": {
-    "@earendil-works/pi-ai": "^0.87.1",
-    "@earendil-works/pi-coding-agent": "^0.87.1",
-    "@earendil-works/pi-tui": "^0.87.1",
+    "@earendil-works/pi-ai": "^0.87.1 || ^0.99.1",
+    "@earendil-works/pi-coding-agent": "^0.87.1 || ^0.99.1",
+    "@earendil-works/pi-tui": "^0.87.1 || ^0.99.1",
     "typebox": "^1.1.38"
   },
   "peerDependenciesMeta": {
@@ -92,10 +92,10 @@
     "safe-buffer": "npm:@socketregistry/safe-buffer@1.0.9"
   },
   "overrides": {
-    "brace-expansion": "5.0.9",
+    "brace-expansion": "5.0.12",
     "is-unicode-supported": "npm:@socketregistry/is-unicode-supported@1.0.5",
     "safe-buffer": "npm:@socketregistry/safe-buffer@1.0.9",
-    "undici": "8.9.0"
+    "undici": "8.11.2"
   },
   "lint-staged": {
     "*.{ts,tsx}": [

package/src/commands/manual-command.ts

@@ -112,18 +112,38 @@ export const registerManualCommand = (runtime: CommandRuntime) => {
       runtime.scoutStatus.register(scoutStatusToken);
       runtime.manualConsultations.set(controller, scoutStatusToken);
       runtime.pi.appendEntry?.("advisor-manual-call", { progressId, question });
+      // Print mode tears the session down when the handler returns, so the
+      // consultation must complete inside the handler to keep its ctx valid.
+      if (ctx.mode === "print") {
+        await startManualConsultation(
+          runtime,
+          ctx,
+          question,
+          controller,
+          scoutStatusToken,
+          progress,
+          gitContext
+        );
+        return;
+      }
       // Intentional fire-and-forget: the consultation streams after the command
-      // handler returns. void satisfies noFloatingPromises; noVoid is ignored here
-      // because this Biome version offers no ignoreVoidAsExpression option.
-      void startManualConsultation(
-        runtime,
-        ctx,
-        question,
-        controller,
-        scoutStatusToken,
-        progress,
-        gitContext
-      );
+      // handler returns. A rejected consultation must not escape as an
+      // unhandled rejection; its error paths already notify and record.
+      void (async () => {
+        try {
+          await startManualConsultation(
+            runtime,
+            ctx,
+            question,
+            controller,
+            scoutStatusToken,
+            progress,
+            gitContext
+          );
+        } catch {
+          // Consultation error paths already notify and record; nothing to add.
+        }
+      })();
     },
   });
 };

package/src/commands/manual-consultation.ts

@@ -7,6 +7,7 @@ import { notifyHerdrAdvisorFailure } from "../herdr.ts";
 import { normalizeScreeningQuestion } from "../tools/jev-filter.ts";
 import { appendScoutLifecycleEntry } from "../tools/scout-status.ts";
 import type { ScoutToolDetails } from "../tools/types.ts";
+import { uiAvailable } from "../ui-guard.ts";
 import { advisorUsageCost, snapshotAdvisorUsage } from "../usage.ts";
 import type { AdvisorUsageSnapshot } from "../usage.ts";
 import { notify } from "./runtime.ts";
@@ -28,9 +29,10 @@ export const startManualConsultation = async (
   progress: ManualAdvisorProgressState,
   gitContext?: GitContextLevel
 ) => {
+  const isPrintMode = ctx.mode === "print";
   progress.phase = "preparing";
   runtime.requestManualRender(ctx);
-  if (ctx.hasUI) {
+  if (uiAvailable(ctx)) {
     const timer = setInterval(() => {
       if (
         controller.signal.aborted ||
@@ -118,8 +120,10 @@ export const startManualConsultation = async (
       {
         // Steer lets the current turn finish its active work; the Executor sees
         // the result before its next model call rather than being interrupted.
+        // Print mode has no follow-up turn; triggering one trips pi's turn_end
+        // entry resolution during teardown.
         deliverAs: "steer",
-        triggerTurn: true,
+        triggerTurn: !isPrintMode,
       }
     );
   } catch (error) {
@@ -147,7 +151,7 @@ export const startManualConsultation = async (
         },
         display: true,
       },
-      { deliverAs: "steer", triggerTurn: true }
+      { deliverAs: "steer", triggerTurn: !isPrintMode }
     );
     notify(ctx, `Advisor consultation failed: ${message}`, "error");
     notifyHerdrAdvisorFailure("Advisor consultation failed", message);

package/src/commands/runtime.ts

@@ -13,6 +13,7 @@ import {
 } from "../tools/model-access.ts";
 import { ScoutStatusManager } from "../tools/scout-status.ts";
 import { advisorSessionState as defaultAdvisorSessionState } from "../tools/session.ts";
+import { uiAction } from "../ui-guard.ts";
 import type {
   CommandDependencies,
   CommandRuntime as CommandRuntimeContract,
@@ -25,9 +26,7 @@ export const notify = (
   message: string,
   level: "error" | "info" | "warning"
 ) => {
-  if (ctx.hasUI) {
-    ctx.ui.notify(message, level);
-  }
+  uiAction(ctx, (ui) => ui.notify(message, level));
 };
 
 const reportManualBudgetExhausted = (ctx: ExtensionContext) => {
@@ -37,9 +36,7 @@ const reportManualBudgetExhausted = (ctx: ExtensionContext) => {
 };
 
 const requestManualRender = (ctx: ExtensionContext) => {
-  if (ctx.hasUI) {
-    ctx.ui.setStatus("advisor-manual", undefined);
-  }
+  uiAction(ctx, (ui) => ui.setStatus("advisor-manual", undefined));
 };
 
 class CommandRuntime implements CommandRuntimeContract {
@@ -130,14 +127,14 @@ class CommandRuntime implements CommandRuntimeContract {
   }
 
   updateAdvisorUsageStatus(ctx: ExtensionContext) {
-    if (ctx.hasUI) {
-      ctx.ui.setStatus(
+    uiAction(ctx, (ui) =>
+      ui.setStatus(
         "advisor-usage",
         getAdvisorSettings().showUsageFooter
           ? this.advisorSessionState.usageStatus()
           : undefined
-      );
-    }
+      )
+    );
   }
 }
 

package/src/tools/render-advisor-result.ts

@@ -100,7 +100,15 @@ const renderPartialAdvisorResult = (
     scout?.status === "calling" || scout?.status === "streaming";
   syncRenderPhase(context, scoutActive ? "scout" : "advisor");
   if (!context.state.timerId) {
-    context.state.timerId = setInterval(() => context.invalidate(), 80);
+    context.state.timerId = setInterval(() => {
+      try {
+        context.invalidate();
+      } catch {
+        // Renderer context is gone; stop repainting and drop the timer.
+        clearInterval(context.state.timerId);
+        context.state.timerId = undefined;
+      }
+    }, 80);
   }
   if (scout) {
     renderScoutDetails(box, scout, expanded, theme);

package/src/tools/scout-status.ts

@@ -8,6 +8,7 @@ import type { Box } from "@earendil-works/pi-tui";
 
 import { executorRef, getAdvisorSettings } from "../config/state.ts";
 import type { ScoutLifecycleEvent } from "../scout.ts";
+import { uiAction, uiAvailable } from "../ui-guard.ts";
 import { formatAdvisorUsage, snapshotAdvisorUsage } from "../usage.ts";
 import { renderThinkingMarkdown, SPINNER_FRAMES } from "./render-common.ts";
 import type { ScoutToolDetails } from "./types.ts";
@@ -91,14 +92,14 @@ export class ScoutStatusManager {
   }
 
   update(ctx: ExtensionContext, token: symbol, event: ScoutLifecycleEvent) {
-    if (this.#retired.has(token) || !ctx.hasUI) {
+    if (this.#retired.has(token) || !uiAvailable(ctx)) {
       return;
     }
     this.#known.add(token);
     if (event.type === "call" || event.type === "chunk") {
       this.#active.add(token);
       if (this.showStatus) {
-        ctx.ui.setStatus("advisor-scout", "Scout curating…");
+        uiAction(ctx, (ui) => ui.setStatus("advisor-scout", "Scout curating…"));
       }
       return;
     }
@@ -109,12 +110,14 @@ export class ScoutStatusManager {
     this.#active.delete(token);
     this.#known.delete(token);
     this.#retired.add(token);
-    if (!(ctx.hasUI && this.showStatus)) {
+    if (!(uiAvailable(ctx) && this.showStatus)) {
       return;
     }
-    ctx.ui.setStatus(
-      "advisor-scout",
-      this.#active.size > 0 ? "Scout curating…" : undefined
+    uiAction(ctx, (ui) =>
+      ui.setStatus(
+        "advisor-scout",
+        this.#active.size > 0 ? "Scout curating…" : undefined
+      )
     );
   }
 
@@ -124,8 +127,8 @@ export class ScoutStatusManager {
     }
     this.#known.clear();
     this.#active.clear();
-    if (ctx.hasUI && this.showStatus) {
-      ctx.ui.setStatus("advisor-scout", undefined);
+    if (this.showStatus) {
+      uiAction(ctx, (ui) => ui.setStatus("advisor-scout", undefined));
     }
   }
 }

package/src/ui-guard.ts

@@ -0,0 +1,31 @@
+import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
+
+// Pi 0.99 asserts ctx liveness on UI access; post-session reads must no-op.
+const isStaleContext = (error: unknown): error is Error =>
+  error instanceof Error && /stale/iu.test(error.message);
+
+export const uiAvailable = (ctx: ExtensionContext): boolean => {
+  try {
+    return ctx.hasUI;
+  } catch (error) {
+    if (isStaleContext(error)) {
+      return false;
+    }
+    throw error;
+  }
+};
+
+export const uiAction = (
+  ctx: ExtensionContext,
+  action: (ui: ExtensionContext["ui"]) => void
+): void => {
+  try {
+    if (ctx.hasUI) {
+      action(ctx.ui);
+    }
+  } catch (error) {
+    if (!isStaleContext(error)) {
+      throw error;
+    }
+  }
+};