pi-advisor-flow 0.6.0 → 0.8.0

package/src/ui/settings-items.ts

@@ -1,6 +1,21 @@
 import type { Theme } from "@earendil-works/pi-coding-agent";
-import type { SettingItem } from "@earendil-works/pi-tui";
+import { getKeybindings } from "@earendil-works/pi-tui";
+import type { KeybindingsManager, SettingItem } from "@earendil-works/pi-tui";
+
+import {
+  DEFAULT_JEV_DIGEST_MAX_CHARS,
+  DEFAULT_JEV_FILTER_NOUL_MARGIN,
+  DEFAULT_JEV_FILTER_OVERRIDE_WINDOW,
+  DEFAULT_JEV_FILTER_SKIP_CONFIDENCE,
+  DEFAULT_JEV_MODEL,
+  DEFAULT_JEV_PRICE_PER_MTOK,
+  DEFAULT_JEV_TIMEOUT_MS,
+  DEFAULT_JEV_TRANSPORT,
+  DEFAULT_JEV_TURN_GATE_NOUL_THRESHOLD,
+} from "../config/types.ts";
 import { isValidAdvisorToolPolicies } from "../config/validation.ts";
+import { JevSetupSubmenu } from "./jev-setup-submenu.ts";
+import { SearchableModelMultiSelector } from "./model-multi-selector.ts";
 import {
   contextDescription,
   currentContextLabel,
@@ -20,6 +35,7 @@ import type {
 
 export interface SettingsItemsOptions {
   effortLevels: string[];
+  modelWhitelist: SettingItem;
   presets: ContextPreset[];
   settings: AdvisorSettings;
   theme: Theme;
@@ -40,8 +56,187 @@ const toggle = (
   values: TOGGLE_VALUES,
 });
 
+const jevItems = (
+  settings: AdvisorSettings,
+  theme: Theme,
+  tui: RenderRequester
+): SettingItem[] => [
+  {
+    currentValue: settingValue(settings.jevFilterEnabled, false),
+    description:
+      "Screen low-stakes ask_advisor consultations with Jev; guided setup verifies credentials.",
+    id: "jevFilter",
+    label: "Jev consultation filter",
+    submenu: (currentValue, done) =>
+      new JevSetupSubmenu({ currentValue, done, theme, tui }),
+  },
+  {
+    currentValue: String(
+      settings.jevFilterSkipConfidence ?? DEFAULT_JEV_FILTER_SKIP_CONFIDENCE
+    ),
+    description:
+      "Required probability on negligible stakes before a consultation is skipped.",
+    id: "jevFilterSkipConfidence",
+    label: "Jev skip confidence",
+    values: numericValues(
+      settings.jevFilterSkipConfidence ?? DEFAULT_JEV_FILTER_SKIP_CONFIDENCE,
+      [0.6, 0.7, 0.75, 0.8, 0.85, 0.9, 0.95]
+    ),
+  },
+  {
+    currentValue: String(
+      settings.jevFilterNoulMargin ?? DEFAULT_JEV_FILTER_NOUL_MARGIN
+    ),
+    description:
+      "Extra margin over a coin flip required on self-answerability before skipping.",
+    id: "jevFilterNoulMargin",
+    label: "Jev Noul margin",
+    values: numericValues(
+      settings.jevFilterNoulMargin ?? DEFAULT_JEV_FILTER_NOUL_MARGIN,
+      [0.1, 0.2, 0.25, 0.3, 0.35, 0.4, 0.45]
+    ),
+  },
+  {
+    currentValue: `${settings.jevFilterOverrideWindow ?? DEFAULT_JEV_FILTER_OVERRIDE_WINDOW} turns`,
+    description:
+      "Turns after a skip during which the same question passes automatically.",
+    id: "jevFilterOverrideWindow",
+    label: "Jev override window",
+    values: numericValues(
+      settings.jevFilterOverrideWindow ?? DEFAULT_JEV_FILTER_OVERRIDE_WINDOW,
+      [0, 3, 5, 10, 20, 50]
+    ).map((value) => `${value} turns`),
+  },
+  {
+    currentValue: settings.jevModel ?? DEFAULT_JEV_MODEL,
+    description: "TypeSafe Jev model used for screening and turn-gate checks.",
+    id: "jevModel",
+    label: "Jev model",
+    submenu: (_currentValue, done) =>
+      new TextSettingSubmenu({
+        description:
+          "Enter a TypeSafe model name (for example jev-latest or jev-1.13.0).",
+        initial: settings.jevModel ?? DEFAULT_JEV_MODEL,
+        onCancel: done,
+        onSubmit: (value) => ({ value: value.trim() || DEFAULT_JEV_MODEL }),
+        theme,
+        title: "Jev model",
+        tui,
+      }),
+  },
+  {
+    currentValue: String(settings.jevTimeoutMs ?? DEFAULT_JEV_TIMEOUT_MS),
+    description: "Total wall-time budget for one Jev call, including retries.",
+    id: "jevTimeoutMs",
+    label: "Jev timeout ms",
+    values: numericValues(
+      settings.jevTimeoutMs ?? DEFAULT_JEV_TIMEOUT_MS,
+      [1000, 2000, 5000, 8000, 15_000, 30_000]
+    ),
+  },
+  {
+    currentValue: String(
+      settings.jevDigestMaxChars ?? DEFAULT_JEV_DIGEST_MAX_CHARS
+    ),
+    description: "Conversation characters sent to Jev as screening evidence.",
+    id: "jevDigestMaxChars",
+    label: "Jev digest chars",
+    values: numericValues(
+      settings.jevDigestMaxChars ?? DEFAULT_JEV_DIGEST_MAX_CHARS,
+      [0, 1000, 2000, 4000, 8000, 15_000]
+    ),
+  },
+  {
+    currentValue: String(
+      settings.jevPricePerMtok ?? DEFAULT_JEV_PRICE_PER_MTOK
+    ),
+    description:
+      "Assumed TypeSafe price per million input tokens for cost lines.",
+    id: "jevPricePerMtok",
+    label: "Jev price/Mtok",
+    values: numericValues(
+      settings.jevPricePerMtok ?? DEFAULT_JEV_PRICE_PER_MTOK,
+      [0.01, 0.02, 0.042, 0.05, 0.1]
+    ),
+  },
+  {
+    currentValue:
+      settings.jevTurnGateEveryTurns === 0 ||
+      settings.jevTurnGateEveryTurns === undefined
+        ? "Off"
+        : `every ${settings.jevTurnGateEveryTurns} turns`,
+    description:
+      "Proactively consult the Advisor every N turns without a consultation (0 = off).",
+    id: "jevTurnGateEveryTurns",
+    label: "Jev turn gate",
+    values: [
+      "Off",
+      "every 3 turns",
+      "every 5 turns",
+      "every 10 turns",
+      "every 20 turns",
+    ],
+  },
+  {
+    currentValue: String(
+      settings.jevTurnGateNoulThreshold ?? DEFAULT_JEV_TURN_GATE_NOUL_THRESHOLD
+    ),
+    description:
+      "Jev confidence required before the turn gate interrupts with advice.",
+    id: "jevTurnGateNoulThreshold",
+    label: "Jev turn-gate threshold",
+    values: numericValues(
+      settings.jevTurnGateNoulThreshold ?? DEFAULT_JEV_TURN_GATE_NOUL_THRESHOLD,
+      [0.6, 0.7, 0.8, 0.85, 0.9, 0.95]
+    ),
+  },
+  {
+    currentValue: settings.jevTransport ?? DEFAULT_JEV_TRANSPORT,
+    description:
+      "How Jev calls travel: auto reuses an OpenRouter login when no TypeSafe key is set.",
+    id: "jevTransport",
+    label: "Jev transport",
+    values: withCurrentValue(settings.jevTransport ?? DEFAULT_JEV_TRANSPORT, [
+      "auto",
+      "typesafe",
+      "openrouter",
+    ]),
+  },
+];
+
+export const advisorModelWhitelistItem = (
+  settings: AdvisorSettings,
+  modelRefs: string[] | undefined,
+  keybindings: KeybindingsManager | undefined,
+  theme: Theme,
+  tui: RenderRequester
+): SettingItem => ({
+  currentValue: settings.modelWhitelist?.length
+    ? settings.modelWhitelist.join(", ")
+    : "Any model",
+  description:
+    "Only the exact provider/model references listed here may call the Advisor; an empty list allows every model.",
+  id: "modelWhitelist",
+  label: "Advisor model whitelist",
+  submenu: (_currentValue, done) =>
+    new SearchableModelMultiSelector({
+      allOptions: [
+        ...new Set([...(modelRefs ?? []), ...(settings.modelWhitelist ?? [])]),
+      ],
+      currentOptions: settings.modelWhitelist ?? [],
+      keybindings: keybindings ?? getKeybindings(),
+      multiSelect: true,
+      onCancel: done,
+      onSelect: (values) => done(values.join(",")),
+      theme,
+      title: "Advisor model whitelist",
+      tui,
+    }),
+});
+
 export const createSettingsItems = ({
   effortLevels,
+  modelWhitelist,
   presets,
   settings,
   theme,
@@ -73,6 +268,7 @@ export const createSettingsItems = ({
     },
   ];
   if (settings.simpleMode) {
+    items.push(modelWhitelist);
     return items;
   }
 
@@ -84,6 +280,7 @@ export const createSettingsItems = ({
       label: "Advisor reasoning",
       values: withCurrentValue(currentEffort(settings.effort), effortLevels),
     },
+    modelWhitelist,
     toggle(
       "scoutEnabled",
       "Experimental Advisor Scout",
@@ -317,7 +514,8 @@ export const createSettingsItems = ({
       "Allow anonymized Advisor outcomes to be logged globally.",
       settings.outcomeLogging,
       false
-    )
+    ),
+    ...jevItems(settings, theme, tui)
   );
   return items;
 };

package/src/ui/settings-list-adapter.ts

@@ -1,11 +1,10 @@
-import {
-  type Component,
-  type Focusable,
-  type Input,
-  Key,
-  matchesKey,
-  type SettingItem,
-  type SettingsList,
+import { Key, matchesKey } from "@earendil-works/pi-tui";
+import type {
+  Component,
+  Focusable,
+  Input,
+  SettingItem,
+  SettingsList,
 } from "@earendil-works/pi-tui";
 
 interface SettingsListPrivateFields {
@@ -15,6 +14,8 @@ interface SettingsListPrivateFields {
   submenuComponent?: Component | null;
 }
 
+type SettingsListWithPrivateFields = SettingsList & SettingsListPrivateFields;
+
 /**
  * Contains the narrow compatibility access needed for pi-tui's SettingsList.
  * No other UI module should depend on its private fields.
@@ -45,6 +46,7 @@ export class SettingsListAdapter {
 
   setFocused(value: boolean): void {
     const fields = this.privateFields();
+    // SAFETY: a SettingsList submenu component is registered only when focusable.
     const submenu = fields.submenuComponent as Focusable | undefined;
     if (submenu) {
       submenu.focused = value;
@@ -53,7 +55,7 @@ export class SettingsListAdapter {
 
   setSelectedId(items: SettingItem[], selectedId: string): void {
     const selectedIndex = items.findIndex((item) => item.id === selectedId);
-    if (selectedIndex >= 0) {
+    if (selectedIndex !== -1) {
       this.privateFields().selectedIndex = selectedIndex;
     }
   }
@@ -63,9 +65,9 @@ export class SettingsListAdapter {
     onChange: (id: string, value: string) => void
   ): boolean {
     let direction = 0;
-    if (matchesKey(keyData, Key.left) || keyData === "\u001b[D") {
+    if (matchesKey(keyData, Key.left) || keyData === "\u001B[D") {
       direction = -1;
-    } else if (matchesKey(keyData, Key.right) || keyData === "\u001b[C") {
+    } else if (matchesKey(keyData, Key.right) || keyData === "\u001B[C") {
       direction = 1;
     }
     if (direction === 0) {
@@ -98,6 +100,7 @@ export class SettingsListAdapter {
   }
 
   private privateFields(): SettingsListPrivateFields {
-    return this.list as unknown as SettingsListPrivateFields;
+    // SAFETY: compatibility-only read of SettingsList's private layout fields.
+    return this.list as SettingsListWithPrivateFields;
   }
 }

package/src/ui/settings-mutations.ts

@@ -1,80 +1,202 @@
-import type { AdvisorSettings, ContextPreset, SettingValue } from "./types.ts";
+import { DEFAULT_JEV_MODEL } from "../config/types.ts";
+import type { AdvisorSettings, ContextPreset } from "./types.ts";
 
-const BOOLEAN_SETTING_IDS = new Set([
-  "scoutEnabled",
-  "showUsageDetails",
-  "showUsageFooter",
-  "planGate",
-  "failureGate",
-  "completionGate",
-  "collapseResponses",
-  "blockOnBlocked",
+const BOOLEAN_SETTING_FIELDS = [
   "autoLoopGate",
-  "sessionSummary",
+  "blockOnBlocked",
+  "collapseResponses",
+  "completionGate",
+  "failureGate",
   "herdrIntegration",
+  "outcomeLogging",
+  "planGate",
   "redactSecrets",
+  "scoutEnabled",
+  "sessionSummary",
+  "showUsageDetails",
+  "showUsageFooter",
   "trackedFileContent",
   "untrackedContent",
-  "outcomeLogging",
-]);
+] as const;
 
-export const mutateAdvisorSettings = (
+const BOOLEAN_SETTING_IDS = new Set<string>(BOOLEAN_SETTING_FIELDS);
+
+type BooleanSettingField = (typeof BOOLEAN_SETTING_FIELDS)[number];
+
+const parseModelWhitelist = (value: string) => [
+  ...new Set(
+    value
+      .split(",")
+      .map((model) => model.trim())
+      .filter(Boolean)
+  ),
+];
+
+const applyCoreMutation = (
   settings: AdvisorSettings,
   id: string,
   value: string,
   presets: ContextPreset[]
-): void => {
+): boolean => {
   switch (id) {
-    case "context":
+    case "context": {
       settings.contextMaxChars =
         presets.find((preset) => preset.label === value)?.value ??
         settings.contextMaxChars;
-      break;
-    case "simpleMode":
+      return true;
+    }
+    case "simpleMode": {
       settings.simpleMode = value === "On";
-      break;
-    case "alwaysOn":
+      return true;
+    }
+    case "alwaysOn": {
       settings.alwaysOn = value === "On";
-      break;
-    case "effort":
+      return true;
+    }
+    case "effort": {
       settings.effort = value;
-      break;
-    case "customRule":
+      return true;
+    }
+    case "customRule": {
       settings.customRule = value.trim() || undefined;
-      break;
-    case "toolPolicies":
+      return true;
+    }
+    case "toolPolicies": {
+      // SAFETY: the value originates from the settings submenu's previously validated JSON editor.
       settings.toolPolicies = JSON.parse(
         value
       ) as AdvisorSettings["toolPolicies"];
-      break;
-    case "loopThreshold":
+      return true;
+    }
+    case "loopThreshold": {
       settings.loopThreshold = Number(
         value.replace("After ", "").replace(" repeats", "")
       );
-      break;
-    case "maxCallsPerSession":
+      return true;
+    }
+    case "maxCallsPerSession": {
       settings.maxCallsPerSession = value === "∞" ? undefined : Number(value);
-      break;
-    case "failureMode":
+      return true;
+    }
+    case "modelWhitelist": {
+      settings.modelWhitelist = parseModelWhitelist(value);
+      return true;
+    }
+    case "failureMode": {
+      // SAFETY: value comes from the fixed failureMode options of the settings list.
       settings.failureMode = value as AdvisorSettings["failureMode"];
-      break;
-    case "gitContext":
+      return true;
+    }
+    case "gitContext": {
+      // SAFETY: value comes from the fixed GitContextLevel options of the settings list.
       settings.gitContext = value as AdvisorSettings["gitContext"];
-      break;
-    case "toolResultMaxLines":
+      return true;
+    }
+    default: {
+      return false;
+    }
+  }
+};
+
+const applyNumericMutation = (
+  settings: AdvisorSettings,
+  id: string,
+  value: string
+): boolean => {
+  switch (id) {
+    case "toolResultMaxLines": {
       settings.toolResultMaxLines = Number(value);
-      break;
-    case "toolResultMaxBytes":
+      return true;
+    }
+    case "toolResultMaxBytes": {
       settings.toolResultMaxBytes = Number(value);
-      break;
-    case "gitContextMaxChars":
+      return true;
+    }
+    case "gitContextMaxChars": {
       settings.gitContextMaxChars = Number(value);
-      break;
-    default:
-      if (BOOLEAN_SETTING_IDS.has(id)) {
-        (settings as unknown as Record<string, SettingValue | boolean>)[id] =
-          value === "On";
-      }
-      break;
+      return true;
+    }
+    default: {
+      return false;
+    }
+  }
+};
+
+const applyJevMutation = (
+  settings: AdvisorSettings,
+  id: string,
+  value: string
+): boolean => {
+  switch (id) {
+    case "jevFilter": {
+      settings.jevFilterEnabled = value === "On";
+      return true;
+    }
+    case "jevFilterSkipConfidence": {
+      settings.jevFilterSkipConfidence = Number(value);
+      return true;
+    }
+    case "jevFilterNoulMargin": {
+      settings.jevFilterNoulMargin = Number(value);
+      return true;
+    }
+    case "jevFilterOverrideWindow": {
+      settings.jevFilterOverrideWindow = Number(value.replace(" turns", ""));
+      return true;
+    }
+    case "jevTurnGateEveryTurns": {
+      settings.jevTurnGateEveryTurns =
+        value === "Off" ? 0 : Number(value.replaceAll(/[^0-9]/gu, ""));
+      return true;
+    }
+    case "jevTurnGateNoulThreshold": {
+      settings.jevTurnGateNoulThreshold = Number(value);
+      return true;
+    }
+    case "jevModel": {
+      settings.jevModel = value.trim() || DEFAULT_JEV_MODEL;
+      return true;
+    }
+    case "jevTimeoutMs": {
+      settings.jevTimeoutMs = Number(value);
+      return true;
+    }
+    case "jevDigestMaxChars": {
+      settings.jevDigestMaxChars = Number(value);
+      return true;
+    }
+    case "jevPricePerMtok": {
+      settings.jevPricePerMtok = Number(value);
+      return true;
+    }
+    case "jevTransport": {
+      // SAFETY: value comes from the fixed jevTransport options of the settings list.
+      settings.jevTransport = value as AdvisorSettings["jevTransport"];
+      return true;
+    }
+    default: {
+      return false;
+    }
+  }
+};
+
+export const mutateAdvisorSettings = (
+  settings: AdvisorSettings,
+  id: string,
+  value: string,
+  presets: ContextPreset[]
+): void => {
+  if (applyCoreMutation(settings, id, value, presets)) {
+    return;
+  }
+  if (applyNumericMutation(settings, id, value)) {
+    return;
+  }
+  if (applyJevMutation(settings, id, value)) {
+    return;
+  }
+  if (BOOLEAN_SETTING_IDS.has(id)) {
+    // SAFETY: BOOLEAN_SETTING_IDS only contains AdvisorSettings boolean fields.
+    settings[id as BooleanSettingField] = value === "On";
   }
 };

package/src/ui/settings-selector.ts

@@ -1,15 +1,15 @@
 import { getSettingsListTheme } from "@earendil-works/pi-coding-agent";
-import {
-  type Component,
-  type Focusable,
-  SettingsList,
-  truncateToWidth,
-} from "@earendil-works/pi-tui";
+import { SettingsList, truncateToWidth } from "@earendil-works/pi-tui";
+import type { Component, Focusable } from "@earendil-works/pi-tui";
+
 import {
   rainbowGradient,
   SIMPLE_MODE_GRADIENT_INTERVAL_MS,
 } from "./settings-formatting.ts";
-import { createSettingsItems } from "./settings-items.ts";
+import {
+  advisorModelWhitelistItem,
+  createSettingsItems,
+} from "./settings-items.ts";
 import { SettingsListAdapter } from "./settings-list-adapter.ts";
 import { mutateAdvisorSettings } from "./settings-mutations.ts";
 import type {
@@ -51,7 +51,7 @@ export class AdvisorSettingsSelector implements Component, Focusable {
             label: String(configuredContext),
             value: configuredContext,
           },
-        ].sort((a, b) => a.value - b.value);
+        ].toSorted((a, b) => a.value - b.value);
     if (this.settings.simpleMode) {
       this.startSimpleModeGradient();
     }
@@ -96,8 +96,16 @@ export class AdvisorSettingsSelector implements Component, Focusable {
       }
       return defaultLabel(text, selected);
     };
+    const modelWhitelist = advisorModelWhitelistItem(
+      this.settings,
+      this.options.modelRefs,
+      this.options.keybindings,
+      this.options.theme,
+      this.options.tui
+    );
     const items = createSettingsItems({
       effortLevels: this.options.effortLevels,
+      modelWhitelist,
       presets: this.presets,
       settings: this.settings,
       theme: this.options.theme,
@@ -147,12 +155,13 @@ export class AdvisorSettingsSelector implements Component, Focusable {
     (this.options.onChange ?? this.options.onSave)?.({
       ...this.settings,
       showUsageDetails: this.settings.showUsageDetails ?? true,
-      toolPolicies: { ...(this.settings.toolPolicies ?? {}) },
+      toolPolicies: { ...this.settings.toolPolicies },
     });
     if (
       id === "context" ||
       id === "simpleMode" ||
       id === "customRule" ||
+      id === "modelWhitelist" ||
       id === "toolPolicies"
     ) {
       this.settingsList = this.createSettingsList(id);

package/src/ui/text-setting-submenu.ts

@@ -1,9 +1,6 @@
-import {
-  type Component,
-  type Focusable,
-  Input,
-  truncateToWidth,
-} from "@earendil-works/pi-tui";
+import { Input, truncateToWidth } from "@earendil-works/pi-tui";
+import type { Component, Focusable } from "@earendil-works/pi-tui";
+
 import type { TextSettingSubmenuOptions } from "./types.ts";
 
 /** Small inline editor used by SettingsList for the two free-form settings. */

package/src/ui/types.ts

@@ -1,5 +1,6 @@
 import type { Theme } from "@earendil-works/pi-coding-agent";
 import type { KeybindingsManager, TUI } from "@earendil-works/pi-tui";
+
 import type { GateFailureMode } from "../config/types.ts";
 import type { GitContextLevel } from "../git.ts";
 
@@ -11,6 +12,7 @@ export interface SearchableModelSelectorOptions {
   allOptions: string[];
   currentOption?: string;
   keybindings: KeybindingsManager;
+  multiSelect?: false;
   onCancel: () => void;
   onSelect: (value: string) => void;
   theme: Theme;
@@ -18,6 +20,15 @@ export interface SearchableModelSelectorOptions {
   tui: RenderRequester;
 }
 
+export interface SearchableModelMultiSelectorOptions extends Omit<
+  SearchableModelSelectorOptions,
+  "currentOption" | "multiSelect" | "onSelect"
+> {
+  currentOptions: string[];
+  multiSelect: true;
+  onSelect: (values: string[]) => void;
+}
+
 export interface ManualAdvisorRequest {
   /** The repository disclosure level selected for this consultation. */
   gitContext: GitContextLevel;
@@ -69,8 +80,20 @@ export interface AdvisorSettings {
   gitContext?: GitContextLevel;
   gitContextMaxChars?: number;
   herdrIntegration?: boolean;
+  jevDigestMaxChars?: number;
+  jevFilterEnabled?: boolean;
+  jevFilterNoulMargin?: number;
+  jevFilterOverrideWindow?: number;
+  jevFilterSkipConfidence?: number;
+  jevModel?: string;
+  jevPricePerMtok?: number;
+  jevTimeoutMs?: number;
+  jevTransport?: "auto" | "typesafe" | "openrouter";
+  jevTurnGateEveryTurns?: number;
+  jevTurnGateNoulThreshold?: number;
   loopThreshold?: number;
   maxCallsPerSession?: number;
+  modelWhitelist?: string[];
   outcomeLogging?: boolean;
   planGate: boolean;
   redactSecrets?: boolean;
@@ -89,6 +112,8 @@ export interface AdvisorSettings {
 export interface AdvisorSettingsSelectorOptions {
   effortLevels: string[];
   initial: AdvisorSettings;
+  keybindings?: KeybindingsManager;
+  modelRefs?: string[];
   onCancel: () => void;
   onChange?: (settings: AdvisorSettings) => void;
   /** @deprecated Use onChange; retained for extensions embedding this component. */

package/src/ui.ts

@@ -1,4 +1,3 @@
-// biome-ignore lint/performance/noBarrelFile: this facade intentionally preserves the public UI module contract.
 export { ManualAdvisorDialog } from "./ui/manual-dialog.ts";
 export { SearchableModelSelector } from "./ui/model-selector.ts";
 export { AdvisorSettingsSelector } from "./ui/settings-selector.ts";