pi-advisor-flow 0.5.6 → 0.6.0

package/extensions/index.ts

@@ -1,16 +1,16 @@
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
-import { registerCommands } from "../src/commands/registration.js";
-import { setHerdrBlockedEmitter } from "../src/herdr.js";
-import { AdvisorSessionState } from "../src/session-state.js";
+import { registerCommands } from "../src/commands/registration.ts";
+import { setHerdrBlockedEmitter } from "../src/herdr.ts";
+import { AdvisorSessionState } from "../src/session-state.ts";
 import {
   consultAdvisor as consultAdvisorImplementation,
   runAdvisorGate as runAdvisorGateImplementation,
-} from "../src/tools/consultation.js";
-import { parseAutomaticDecision as parseAutomaticDecisionImplementation } from "../src/tools/gate-protocol.js";
-import { registerAdvisorTool } from "../src/tools/registration.js";
-import { ScoutStatusManager } from "../src/tools/scout-status.js";
+} from "../src/tools/consultation.ts";
+import { parseAutomaticDecision as parseAutomaticDecisionImplementation } from "../src/tools/gate-protocol.ts";
+import { registerAdvisorTool } from "../src/tools/registration.ts";
+import { ScoutStatusManager } from "../src/tools/scout-status.ts";
 
-export type { AdvisorConfig, GateFailureMode } from "../src/config/types.js";
+export type { AdvisorConfig, GateFailureMode } from "../src/config/types.ts";
 export type {
   AdvisorConsultationResult,
   AdvisorGateFailure,
@@ -19,7 +19,7 @@ export type {
   ConsultationTrigger,
   GateDecision,
   GateTrigger,
-} from "../src/tools/types.js";
+} from "../src/tools/types.ts";
 export const consultAdvisor = (
   ...args: Parameters<typeof consultAdvisorImplementation>
 ) => consultAdvisorImplementation(...args);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-advisor-flow",
-  "version": "0.5.6",
+  "version": "0.6.0",
   "description": "Advanced Executor/Advisor flow for Pi, fully configurable and extendable.",
   "keywords": [
     "pi-package",
@@ -36,6 +36,7 @@
     "build": "bun build ./extensions/index.ts --outfile dist/index.js --target node --format esm --external @earendil-works/pi-ai --external @earendil-works/pi-coding-agent --external @earendil-works/pi-tui --external typebox",
     "check:boundaries": "node scripts/check-module-boundaries.mjs",
     "format": "bunx ultracite fix --linter-enabled=false",
+    "knip": "knip",
     "lint": "bunx ultracite check",
     "lint:fix": "bunx ultracite fix",
     "prepack": "bun run build >/dev/null",
@@ -68,6 +69,7 @@
     "@types/node": "^26.4.1",
     "bun-types": "1.4.1",
     "husky": "^9.1.7",
+    "knip": "^6.35.1",
     "lint-staged": "^17.4.1",
     "typebox": "^1.3.25",
     "typescript": "^7.0.2",

package/src/{untracked.ts → attachments.ts}

@@ -2,18 +2,15 @@ import { execFileSync } from "node:child_process";
 import { constants } from "node:fs";
 import { lstat, open, realpath } from "node:fs/promises";
 import { isAbsolute, relative, resolve } from "node:path";
-import { redactAndCapText } from "./conversation.js";
+import { redactAndCapText } from "./redaction.ts";
 
 export const ADVISOR_FILE_MAX_BYTES = 8 * 1024;
-export const ADVISOR_FILES_TOTAL_MAX_BYTES = 24 * 1024;
-export const UNTRACKED_FILE_MAX_BYTES = ADVISOR_FILE_MAX_BYTES;
-export const UNTRACKED_TOTAL_MAX_BYTES = ADVISOR_FILES_TOTAL_MAX_BYTES;
+const ADVISOR_FILES_TOTAL_MAX_BYTES = 24 * 1024;
 export interface UntrackedAttachment {
   bytes: number;
   path: string;
   text: string;
 }
-export type TrackedAttachment = UntrackedAttachment;
 
 const PATH_SEGMENTS = /[\\/]/;
 

package/src/commands/activation-preparation.ts

@@ -9,16 +9,16 @@ import {
   setAdvisorRef,
   setExecutorEffortRef,
   setExecutorRef,
-} from "../config/state.js";
-import { loadConfig } from "../config/storage.js";
+} from "../config/state.ts";
+import { loadConfig } from "../config/storage.ts";
 import {
   getAvailableModelRefs,
   getExplicitModelError,
   planActivationModels,
-} from "./model-options.js";
-import { selectAdvisorModels } from "./model-picker.js";
-import { notify } from "./runtime.js";
-import type { CommandRuntime } from "./types.js";
+} from "./model-options.ts";
+import { selectAdvisorModels } from "./model-picker.ts";
+import { notify } from "./runtime.ts";
+import type { CommandRuntime } from "./types.ts";
 
 export interface PreparedActivationModels {
   pendingExecutor?: string;

package/src/commands/activation.ts

@@ -1,5 +1,5 @@
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
-import { parseArgs } from "../config/args.js";
+import { parseArgs } from "../config/args.ts";
 import {
   advisorEffortRef,
   advisorRef,
@@ -11,20 +11,20 @@ import {
   setContextMaxCharsRef,
   setExecutorEffortRef,
   setExecutorRef,
-} from "../config/state.js";
-import { saveConfig } from "../config/storage.js";
+} from "../config/state.ts";
+import { saveConfig } from "../config/storage.ts";
 import {
   loadCommandConfig,
   prepareActivationModels,
-} from "./activation-preparation.js";
+} from "./activation-preparation.ts";
 import {
   ADVISOR_ACTIVATION_EXPLANATION,
   findConfiguredModel,
   hasAdvisorOverride,
   hasExecutorOverride,
-} from "./model-options.js";
-import { notify } from "./runtime.js";
-import type { CommandRuntime, ThinkingLevel } from "./types.js";
+} from "./model-options.ts";
+import { notify } from "./runtime.ts";
+import type { CommandRuntime, ThinkingLevel } from "./types.ts";
 
 const resolveActivationModels = async (
   runtime: CommandRuntime,

package/src/commands/lifecycle.ts

@@ -4,11 +4,11 @@ import {
   executorRef,
   getPersistedModelRefs,
   setExecutorRef,
-} from "../config/state.js";
-import { loadConfig, saveConfig } from "../config/storage.js";
-import { herdrAdvisorActivity } from "../herdr.js";
-import { notify } from "./runtime.js";
-import type { CommandRuntime } from "./types.js";
+} from "../config/state.ts";
+import { loadConfig, saveConfig } from "../config/storage.ts";
+import { herdrAdvisorActivity } from "../herdr.ts";
+import { notify } from "./runtime.ts";
+import type { CommandRuntime } from "./types.ts";
 
 export type ActivateAdvisor = (
   args: string,

package/src/commands/manual-command.ts

@@ -2,14 +2,14 @@ import {
   getAdvisorMaxCallsPerSession,
   getAdvisorSettings,
   isSimpleMode,
-} from "../config/state.js";
-import type { GitContextLevel } from "../git.js";
-import { resolveAdvisorRequest } from "../tools/render-common.js";
-import { ManualAdvisorDialog } from "../ui/manual-dialog.js";
-import type { ManualAdvisorRequest } from "../ui/types.js";
-import { loadCommandConfig } from "./activation-preparation.js";
-import { startManualConsultation } from "./manual-consultation.js";
-import type { CommandRuntime, ManualAdvisorProgressState } from "./types.js";
+} from "../config/state.ts";
+import type { GitContextLevel } from "../git.ts";
+import { resolveAdvisorRequest } from "../tools/render-common.ts";
+import { ManualAdvisorDialog } from "../ui/manual-dialog.ts";
+import type { ManualAdvisorRequest } from "../ui/types.ts";
+import { loadCommandConfig } from "./activation-preparation.ts";
+import { startManualConsultation } from "./manual-consultation.ts";
+import type { CommandRuntime, ManualAdvisorProgressState } from "./types.ts";
 
 export const registerManualCommand = (runtime: CommandRuntime) => {
   runtime.pi.registerCommand("advisor-manual", {
@@ -93,7 +93,11 @@ export const registerManualCommand = (runtime: CommandRuntime) => {
       runtime.scoutStatus.register(scoutStatusToken);
       runtime.manualConsultations.set(controller, scoutStatusToken);
       runtime.pi.appendEntry?.("advisor-manual-call", { progressId, question });
-      startManualConsultation(
+      // Intentional fire-and-forget: the consultation streams after the command
+      // handler returns. void satisfies noFloatingPromises; noVoid is ignored here
+      // because this Biome version offers no ignoreVoidAsExpression option.
+      // biome-ignore lint/complexity/noVoid: marks an intentional fire-and-forget promise
+      void startManualConsultation(
         runtime,
         ctx,
         question,

package/src/commands/manual-consultation.ts

@@ -1,12 +1,12 @@
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
-import { advisorRef } from "../config/state.js";
-import type { GitContextLevel } from "../git.js";
-import { herdrAdvisorActivity, notifyHerdrAdvisorFailure } from "../herdr.js";
-import { appendScoutLifecycleEntry } from "../tools/scout-status.js";
-import type { ScoutToolDetails } from "../tools/types.js";
-import { advisorUsageCost, snapshotAdvisorUsage } from "../usage.js";
-import { notify } from "./runtime.js";
-import type { CommandRuntime, ManualAdvisorProgressState } from "./types.js";
+import { advisorRef } from "../config/state.ts";
+import type { GitContextLevel } from "../git.ts";
+import { herdrAdvisorActivity, notifyHerdrAdvisorFailure } from "../herdr.ts";
+import { appendScoutLifecycleEntry } from "../tools/scout-status.ts";
+import type { ScoutToolDetails } from "../tools/types.ts";
+import { advisorUsageCost, snapshotAdvisorUsage } from "../usage.ts";
+import { notify } from "./runtime.ts";
+import type { CommandRuntime, ManualAdvisorProgressState } from "./types.ts";
 
 export const startManualConsultation = (
   runtime: CommandRuntime,

package/src/commands/manual-progress.ts

@@ -5,9 +5,9 @@ import {
   renderAdvisorCallBox,
   renderThinkingMarkdown,
   SPINNER_FRAMES,
-} from "../tools/render-common.js";
-import { renderScoutDetails } from "../tools/scout-status.js";
-import type { ManualAdvisorProgressState } from "./types.js";
+} from "../tools/render-common.ts";
+import { renderScoutDetails } from "../tools/scout-status.ts";
+import type { ManualAdvisorProgressState } from "./types.ts";
 
 export class ManualAdvisorProgressComponent implements Component {
   private readonly question: string | undefined;

package/src/commands/model-commands.ts

@@ -8,12 +8,12 @@ import {
   setAdvisorRef,
   setExecutorEffortRef,
   setExecutorRef,
-} from "../config/state.js";
-import { saveConfig } from "../config/storage.js";
-import { activateAdvisor } from "./activation.js";
-import { loadCommandConfig } from "./activation-preparation.js";
-import { selectAdvisorModels } from "./model-picker.js";
-import type { CommandRuntime } from "./types.js";
+} from "../config/state.ts";
+import { saveConfig } from "../config/storage.ts";
+import { activateAdvisor } from "./activation.ts";
+import { loadCommandConfig } from "./activation-preparation.ts";
+import { selectAdvisorModels } from "./model-picker.ts";
+import type { CommandRuntime } from "./types.ts";
 
 export const registerModelCommands = (runtime: CommandRuntime) => {
   runtime.pi.registerCommand("advisor", {

package/src/commands/model-options.ts

@@ -1,9 +1,9 @@
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
-import { type getPersistedModelRefs, splitRef } from "../config/state.js";
-import type { ContextPreset } from "../ui/types.js";
+import { type getPersistedModelRefs, splitRef } from "../config/state.ts";
+import type { ContextPreset } from "../ui/types.ts";
 
 export const DEFAULT_EFFORT_LEVEL = "Default (Model Default)";
-export const SELECTED_PREFIX = "✓ ";
+const SELECTED_PREFIX = "✓ ";
 export const EFFORT_LEVELS = [
   DEFAULT_EFFORT_LEVEL,
   "off",
@@ -105,7 +105,7 @@ export const getAvailableModelRefs = (
     .map((model) => `${model.provider}/${model.id}`);
 };
 
-export const isSelectableModel = (
+const isSelectableModel = (
   ctx: ExtensionContext,
   ref: string | undefined,
   availableRefs: Set<string> | undefined

package/src/commands/model-picker.ts

@@ -1,10 +1,10 @@
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
-import { SearchableModelSelector } from "../ui/model-selector.js";
+import { SearchableModelSelector } from "../ui/model-selector.ts";
 import {
   effortChoices,
   getAvailableModelRefs,
   selectedEffort,
-} from "./model-options.js";
+} from "./model-options.ts";
 
 export interface AdvisorModelSelection {
   advisor: string;

package/src/commands/registration.ts

@@ -2,14 +2,14 @@ import type {
   ExtensionAPI,
   ExtensionContext,
 } from "@earendil-works/pi-coding-agent";
-import { activateAdvisor } from "./activation.js";
-import { registerCommandLifecycle } from "./lifecycle.js";
-import { registerManualCommand } from "./manual-command.js";
-import { registerModelCommands } from "./model-commands.js";
-import { registerCommandRenderers } from "./renderers.js";
-import { createCommandRuntime } from "./runtime.js";
-import { registerSettingsCommands } from "./settings-commands.js";
-import type { CommandDependencies } from "./types.js";
+import { activateAdvisor } from "./activation.ts";
+import { registerCommandLifecycle } from "./lifecycle.ts";
+import { registerManualCommand } from "./manual-command.ts";
+import { registerModelCommands } from "./model-commands.ts";
+import { registerCommandRenderers } from "./renderers.ts";
+import { createCommandRuntime } from "./runtime.ts";
+import { registerSettingsCommands } from "./settings-commands.ts";
+import type { CommandDependencies } from "./types.ts";
 
 export const registerCommands = (
   pi: ExtensionAPI,

package/src/commands/renderers.ts

@@ -1,15 +1,15 @@
 import { getMarkdownTheme } from "@earendil-works/pi-coding-agent";
 import { Box, Markdown, Text } from "@earendil-works/pi-tui";
-import { getAdvisorSettings } from "../config/state.js";
+import { getAdvisorSettings } from "../config/state.ts";
 import {
   adviceForDisplay,
   hasSoundVerdict,
   renderAdvisorCallBox,
   renderAdvisorResponseHeader,
-} from "../tools/render-common.js";
-import { formatAdvisorUsage } from "../usage.js";
-import { ManualAdvisorProgressComponent } from "./manual-progress.js";
-import type { CommandRuntime } from "./types.js";
+} from "../tools/render-common.ts";
+import { formatAdvisorUsage } from "../usage.ts";
+import { ManualAdvisorProgressComponent } from "./manual-progress.ts";
+import type { CommandRuntime } from "./types.ts";
 
 export const registerCommandRenderers = (runtime: CommandRuntime) => {
   runtime.pi.registerEntryRenderer?.(

package/src/commands/runtime.ts

@@ -2,18 +2,18 @@ import type {
   ExtensionAPI,
   ExtensionContext,
 } from "@earendil-works/pi-coding-agent";
-import { getAdvisorSettings } from "../config/state.js";
-import { notifyHerdrAdvisorFailure } from "../herdr.js";
-import type { AdvisorSessionState } from "../session-state.js";
-import { consultAdvisor } from "../tools/consultation.js";
-import { ScoutStatusManager } from "../tools/scout-status.js";
-import { advisorSessionState as defaultAdvisorSessionState } from "../tools/session.js";
+import { getAdvisorSettings } from "../config/state.ts";
+import { notifyHerdrAdvisorFailure } from "../herdr.ts";
+import type { AdvisorSessionState } from "../session-state.ts";
+import { consultAdvisor } from "../tools/consultation.ts";
+import { ScoutStatusManager } from "../tools/scout-status.ts";
+import { advisorSessionState as defaultAdvisorSessionState } from "../tools/session.ts";
 import type {
   CommandDependencies,
   CommandRuntime as CommandRuntimeContract,
   ManualAdvisorProgressState,
   ManualConsult,
-} from "./types.js";
+} from "./types.ts";
 
 export const notify = (
   ctx: ExtensionContext,
@@ -25,7 +25,7 @@ export const notify = (
   }
 };
 
-export class CommandRuntime implements CommandRuntimeContract {
+class CommandRuntime implements CommandRuntimeContract {
   readonly advisorSessionState: AdvisorSessionState;
   readonly manualConsultations = new Map<AbortController, symbol>();
   readonly manualProgress = new Map<string, ManualAdvisorProgressState>();

package/src/commands/settings-commands.ts

@@ -3,14 +3,14 @@ import {
   getAdvisorSettings,
   getPersistedModelRefs,
   setAlwaysOnRef,
-} from "../config/state.js";
-import { saveConfig } from "../config/storage.js";
-import { AdvisorSettingsSelector } from "../ui/settings-selector.js";
-import { loadCommandConfig } from "./activation-preparation.js";
-import { CONTEXT_PRESETS, EFFORT_LEVELS } from "./model-options.js";
-import { notify } from "./runtime.js";
-import { saveAdvisorSettings } from "./settings-persistence.js";
-import type { CommandRuntime } from "./types.js";
+} from "../config/state.ts";
+import { saveConfig } from "../config/storage.ts";
+import { AdvisorSettingsSelector } from "../ui/settings-selector.ts";
+import { loadCommandConfig } from "./activation-preparation.ts";
+import { CONTEXT_PRESETS, EFFORT_LEVELS } from "./model-options.ts";
+import { notify } from "./runtime.ts";
+import { saveAdvisorSettings } from "./settings-persistence.ts";
+import type { CommandRuntime } from "./types.ts";
 
 export const registerSettingsCommands = (runtime: CommandRuntime) => {
   runtime.pi.registerCommand("advisor-settings", {

package/src/commands/settings-persistence.ts

@@ -29,12 +29,12 @@ import {
   setShowUsageDetailsRef,
   setShowUsageFooterRef,
   setSimpleModeRef,
-} from "../config/state.js";
-import { saveConfig, saveGlobalOutcomeLogging } from "../config/storage.js";
-import type { AdvisorSettings } from "../ui/types.js";
+} from "../config/state.ts";
+import { saveConfig, saveGlobalOutcomeLogging } from "../config/storage.ts";
+import type { AdvisorSettings } from "../ui/types.ts";
 
 // biome-ignore lint/complexity/noExcessiveCognitiveComplexity: one settings form maps every persisted control.
-export const applyAdvisorSettings = (settings: AdvisorSettings) => {
+const applyAdvisorSettings = (settings: AdvisorSettings) => {
   setAdvisorEffortRef(
     settings.effort === "Default (Model Default)" ? undefined : settings.effort
   );

package/src/commands/types.ts

@@ -1,13 +1,12 @@
 import type {
   ExtensionAPI,
   ExtensionContext,
-  Theme,
 } from "@earendil-works/pi-coding-agent";
-import type { GitContextLevel } from "../git.js";
-import type { ScoutLifecycleEvent } from "../scout.js";
-import type { AdvisorSessionState } from "../session-state.js";
-import type { ScoutStatusManager } from "../tools/scout-status.js";
-import type { ScoutToolDetails } from "../tools/types.js";
+import type { GitContextLevel } from "../git.ts";
+import type { ScoutLifecycleEvent } from "../scout.ts";
+import type { AdvisorSessionState } from "../session-state.ts";
+import type { ScoutStatusManager } from "../tools/scout-status.ts";
+import type { ScoutToolDetails } from "../tools/types.ts";
 
 export type ManualConsult = (
   ctx: ExtensionContext,
@@ -69,10 +68,3 @@ export interface CommandRuntime {
   suppressModelSelectionSync: boolean;
   updateAdvisorUsageStatus: (ctx: ExtensionContext) => void;
 }
-
-export interface ManualAdvisorProgressView {
-  expanded: boolean;
-  question: string | undefined;
-  state: ManualAdvisorProgressState;
-  theme: Theme;
-}

package/src/commands.ts

@@ -1,9 +1,9 @@
 // biome-ignore lint/performance/noBarrelFile: this facade intentionally preserves the public command module contract.
-export { registerCommands } from "./commands/registration.js";
+export { registerCommands } from "./commands/registration.ts";
 export type {
   CommandDependencies,
   ManualAdvisorProgressPhase,
   ManualAdvisorProgressState,
   ManualConsult,
   ThinkingLevel,
-} from "./commands/types.js";
+} from "./commands/types.ts";

package/src/config/args.ts

@@ -5,9 +5,9 @@ import {
   setAdvisorRef,
   setContextMaxCharsRef,
   setExecutorRef,
-} from "./state.js";
-import { MAX_CONTEXT_MAX_CHARS } from "./types.js";
-import { isValidContextMaxChars } from "./validation.js";
+} from "./state.ts";
+import { MAX_CONTEXT_MAX_CHARS } from "./types.ts";
+import { isValidContextMaxChars } from "./validation.ts";
 
 const ARGUMENT_WHITESPACE = /\s+/;
 

package/src/config/defaults.ts

@@ -31,14 +31,14 @@ import {
   setShowUsageDetailsRef,
   setShowUsageFooterRef,
   setSimpleModeRef,
-} from "./state.js";
-import type { AdvisorConfig } from "./types.js";
+} from "./state.ts";
+import type { AdvisorConfig } from "./types.ts";
 import {
   DEFAULT_ADVISOR_GIT_CONTEXT_MAX_CHARS,
   DEFAULT_ADVISOR_TOOL_RESULT_MAX_BYTES,
   DEFAULT_ADVISOR_TOOL_RESULT_MAX_LINES,
   DEFAULT_CONTEXT_MAX_CHARS,
-} from "./types.js";
+} from "./types.ts";
 
 export const resetDefaults = () => {
   setExecutorRef("");