pi-advisor-flow 0.5.2 → 0.5.4

package/CHANGELOG.md

@@ -4,6 +4,19 @@ All notable changes to this project are documented here.
 
 The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 0.5.4 - 2026-09-08
+
+### Fixed
+
+- Pinned the Socket security dependency overrides for `is-unicode-supported` and `safe-buffer` to exact published versions instead of floating `^1` ranges, keeping the resolved dependency tree unchanged while avoiding floating ranges in the published manifest.
+
+## 0.5.3 - 2026-09-08
+
+### Fixed
+
+- Kept a malformed `advisor.json` from blocking every tool call while the Advisor flow is active: the `tool_call` handler now skips Advisor gating, notifies once per distinct configuration error, and resumes gating once the configuration is valid again.
+- Preserved the one-shot tracked-file handoff across rejected follow-up calls: disabled `advisorTrackedFileContent` consent or an exhausted Advisor call budget now fails the `ask_advisor` call up front without consuming the handoff from the prior Advisor response.
+
 ## 0.5.2 - 2026-09-05
 
 ### Changed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-advisor-flow",
-  "version": "0.5.2",
+  "version": "0.5.4",
   "description": "Advanced Executor/Advisor flow for Pi, fully configurable and extendable.",
   "keywords": [
     "pi-package",
@@ -47,13 +47,13 @@
     "*.{json,jsonc,ts}": "bun run lint:fix --"
   },
   "resolutions": {
-    "is-unicode-supported": "npm:@socketregistry/is-unicode-supported@^1",
-    "safe-buffer": "npm:@socketregistry/safe-buffer@^1"
+    "is-unicode-supported": "npm:@socketregistry/is-unicode-supported@1.0.5",
+    "safe-buffer": "npm:@socketregistry/safe-buffer@1.0.9"
   },
   "overrides": {
     "brace-expansion": "5.0.9",
-    "is-unicode-supported": "npm:@socketregistry/is-unicode-supported@^1",
-    "safe-buffer": "npm:@socketregistry/safe-buffer@^1",
+    "is-unicode-supported": "npm:@socketregistry/is-unicode-supported@1.0.5",
+    "safe-buffer": "npm:@socketregistry/safe-buffer@1.0.9",
     "undici": "8.9.0"
   },
   "devDependencies": {

package/src/tools/register-ask-advisor.ts

@@ -3,6 +3,7 @@ import { Type } from "typebox";
 import {
   advisorRef,
   getAdvisorMaxCallsPerSession,
+  getAdvisorSettings,
   isSimpleMode,
 } from "../config/state.js";
 import { herdrAdvisorActivity, notifyHerdrAdvisorFailure } from "../herdr.js";
@@ -28,6 +29,30 @@ import type {
   ToolRegistrationContext,
 } from "./types.js";
 
+/**
+ * Validates a tracked-file follow-up and consumes the one-shot handoff only
+ * when the call is worth it: consent must be enabled and the session budget
+ * was checked by the caller. A rejected call never burns the claim.
+ */
+const claimTrackedHandoff = (
+  session: ToolRegistrationContext["session"],
+  includeTrackedFiles: string[] | undefined
+) => {
+  if (!includeTrackedFiles?.length) {
+    return;
+  }
+  if (!getAdvisorSettings().trackedFileContent) {
+    throw new Error(
+      "Tracked file attachments are disabled: enable the global advisorTrackedFileContent setting (Tracked file content in /advisor-settings) and retry."
+    );
+  }
+  if (!session.claimTrackedFiles(includeTrackedFiles)) {
+    throw new Error(
+      "Tracked file handoff requires a prior Advisor response that explicitly names every requested path and is consumed once."
+    );
+  }
+};
+
 export const registerAskAdvisorTool = ({
   consult: requestAdvisor,
   pi,
@@ -39,18 +64,15 @@ export const registerAskAdvisorTool = ({
       "Consult the on-demand Advisor model for strategic guidance. Call with an empty object for a contextual review; attach an optional draft for concrete plan or completion review. If the Advisor explicitly names a missing file, you may make a sequential follow-up call with includeTrackedFiles when enabled and relevant.",
     async execute(_id, params, signal, onUpdate, ctx) {
       reservedCalls.delete(_id);
+      // The budget check precedes the handoff claim so a rejected call never
+      // consumes the one-shot tracked-file handoff.
       if (
-        params.includeTrackedFiles?.length &&
-        !session.claimTrackedFiles(params.includeTrackedFiles)
+        !(isSimpleMode() || session.canConsult(getAdvisorMaxCallsPerSession()))
       ) {
-        throw new Error(
-          "Tracked file handoff requires a prior Advisor response that explicitly names every requested path and is consumed once."
-        );
+        throw new Error("Advisor call budget exhausted for this session.");
       }
+      claimTrackedHandoff(session, params.includeTrackedFiles);
       if (!isSimpleMode()) {
-        if (!session.canConsult(getAdvisorMaxCallsPerSession())) {
-          throw new Error("Advisor call budget exhausted for this session.");
-        }
         session.consumeCall();
       }
       herdrAdvisorActivity.start();

package/src/tools/register-lifecycle.ts

@@ -17,6 +17,32 @@ export const registerToolLifecycle = ({
   scoutStatus,
   session,
 }: ToolRegistrationContext): void => {
+  // A throwing tool_call handler makes pi block that tool call (fail-safe), so
+  // a malformed advisor.json must not escape this handler: gating is skipped
+  // for that call and the failure is surfaced once per distinct outage. Config
+  // errors stay an Advisor concern instead of escalating into a session-wide
+  // outage.
+  let lastConfigErrorNotified: string | undefined;
+  const loadConfigOrSkipGating = (ctx: Parameters<typeof loadConfig>[0]) => {
+    try {
+      loadConfig(ctx);
+      lastConfigErrorNotified = undefined;
+      return true;
+    } catch (error) {
+      const message = error instanceof Error ? error.message : String(error);
+      if (message !== lastConfigErrorNotified) {
+        lastConfigErrorNotified = message;
+        if (ctx.hasUI) {
+          ctx.ui.notify(
+            `Advisor gating skipped; configuration is invalid. ${message} Fix advisor.json.`,
+            "error"
+          );
+        }
+      }
+      return false;
+    }
+  };
+
   pi.on("session_start", (_event, ctx) => {
     session.resetTask();
     reservedCalls.clear();
@@ -57,7 +83,11 @@ export const registerToolLifecycle = ({
     if (!pi.getActiveTools().includes("ask_advisor")) {
       return;
     }
-    loadConfig(ctx);
+    if (!loadConfigOrSkipGating(ctx)) {
+      // The ask_advisor execute path surfaces its own configuration errors as
+      // tool errors; every other tool must proceed without Advisor gating.
+      return;
+    }
     const reservation = reserveAdvisorCall(event, ctx, session, reservedCalls);
     if (event.toolName === "ask_advisor") {
       return reservation;