pi-advisor-flow 0.3.6 → 0.5.0

package/CHANGELOG.md

@@ -4,6 +4,44 @@ All notable changes to this project are documented here.
 
 The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 0.5.0
+
+### Changed
+
+- Updated the development toolchain and Pi compatibility packages, including TypeScript 7, Node.js 26 type definitions, Pi 0.84.4 packages, and Bun 1.3.14 validation.
+
+### Added
+
+- Added a centered TUI overlay for `/advisor-manual` with an editable prefilled focus message, optional general review, a Git context selector bounded by the configured disclosure ceiling, and live Scout/Advisor progress without duplicate footer status text; non-TUI invocations remain immediate.
+- Reworked `/advisor-settings` into a compact Pi-style searchable settings list with fuzzy search, arrow-key value adjustment, and immediate persistence for every valid change.
+- Restored the animated Simple mode indicator and added a context-depth meter spanning recent history to the complete branch at `ALL`.
+- Added enabled-by-default per-response usage detail display plus an independent, opt-in `showUsageFooter` setting for cumulative Advisor footer usage; both are presentation-only and do not change usage accounting.
+
+### Performance
+
+- Coalesced Advisor streaming UI updates to roughly 10–12 refreshes per second while flushing the latest partial state immediately on completion or error.
+
+### Fixed
+
+- Fixed `/advisor-settings` context-meter alignment and numeric controls so custom max-call limits advance to the next numeric option.
+- Made blocked automatic-gate decisions honor the configured session, tool, or warning behavior.
+- Allowed failed local Advisor outcome writes to be retried without consuming the advice.
+
+## 0.4.0
+
+### Added
+
+- Exposed provider-reported Advisor and Scout token/cache/cost details per result, tracked cumulative direct Advisor usage in the session footer and optional summary, and attached normalized `ask_advisor` usage to Pi's built-in cost totals without double-counting manual consultations or automatic gates.
+
+### Removed
+
+- Removed the repository-only Benchmark suite and its benchmark-specific telemetry instrumentation.
+
+### Fixed
+
+- Kept Scout's serialized manifest limit separate from the Advisor conversation budget so required context does not fall back solely because of manifest metadata overhead.
+- Made unlimited Advisor call budgets live at every enforcement boundary, preventing stale finite limits from triggering false Herdr budget notifications after switching to unlimited.
+
 ## 0.3.6
 
 ### Fixed

package/README.md

@@ -21,8 +21,10 @@ The idea is simple: keep implementation on a fast model and borrow frontier reas
 - **Configurable review gates** before plans, after repeated failures, and before declaring completion.
 - **Automatic loop detection** for repeated tool calls, with explicit proceed, revise, or blocked decisions.
 - **Separate model and reasoning controls** for the Executor and Advisor.
+- **Advisor usage accounting** with per-response token/cost details and optional cumulative direct usage in the Pi footer and session summary. Per-response usage and cost details are shown by default and can be hidden independently from the footer in `/advisor-settings`.
 - **Privacy controls** for conversation history, repository context, explicit tracked/untracked file handoff, tool results, secret redaction, and outcome logging.
 - **Optional persistent activation, Simple mode, session summaries, and Herdr integration.**
+- **Compact searchable `/advisor-settings` controls** that match Pi's settings list and save changes immediately.
 - **EXPERIMENTAL Advisor Scout** that uses the configured Executor model to curate conversation evidence before every Advisor call.
 
 ## Install
@@ -46,7 +48,7 @@ Restart or reload Pi after installation.
 
 1. Run `/advisor` to enable the flow and register `ask_advisor`.
 2. Run `/advisor-models` to choose the Executor and Advisor models. Current model and thinking-level selections appear first and ticked, so pressing Enter keeps them.
-3. Run `/advisor-settings` to configure review gates, context, privacy, and limits.
+3. Run `/advisor-settings` to configure review gates, context, privacy, and limits. Type to fuzzy-search settings; changes save immediately.
 
 ![Advisor Settings](https://raw.githubusercontent.com/philipbrembeck/pi-advisor/refs/heads/main/assets/settings.png)
 
@@ -55,7 +57,7 @@ Unknown fields in `advisor.json` are preserved for forward compatibility and rep
 You can also enable the flow and select both models at once:
 
 ```text
-/advisor executor=anthropic/claude-sonnet-5 advisor=openai/gpt-5.6-sol
+/advisor executor=openai-codex/gpt-5.6-luna advisor=openai-codex/gpt-5.6-sol
 ```
 
 ## How it works
@@ -68,15 +70,17 @@ You can also enable the flow and select both models at once:
 
 A normal consultation never blocks execution. The optional automatic loop gate is different: it evaluates repeated tool calls and applies the configured failure policy when the Advisor says to revise, reports a block, is unavailable, or returns an invalid decision.
 
+Advisor responses show provider-reported input, output, cache, and cost details when available. Successful `ask_advisor` tool results also carry normalized usage into Pi's built-in `Tools/summaries` and `/cost` totals. Manual consultations and automatic gates remain in the separate session-local direct Advisor accounting because they are custom messages, so they are not double-counted in Pi's Executor totals. Missing or partial provider usage is shown as unavailable rather than fabricated as zero usage. `/advisor-settings` independently controls per-response usage details and the cumulative Advisor footer without disabling this accounting; the footer is off by default.
+
 Successful calls return an opaque `adviceId`. If global outcome logging is enabled, the Executor can call `record_advisor_outcome` once to record whether the advice was adopted and whether final validation passed.
 
 ### Experimental Advisor Scout
 
 Experimental Advisor Scout is off by default. Enable `Experimental Advisor Scout` in the advanced `/advisor-settings` screen or set `"advisorScoutEnabled": true` in the global `advisor.json`.
 
-Scout runs before `ask_advisor`, `/advisor-manual`, and automatic Advisor gates. It uses the configured Executor model and Executor reasoning effort in a separate model call. This adds cost and latency, but can reduce cost in the Advisor call. The compact result shows the model, selection counts, and elapsed time; `Ctrl+O` shows bounded selected labels and the synthesis.
+Scout runs before `ask_advisor`, `/advisor-manual`, and automatic Advisor gates. It uses the configured Executor model and Executor reasoning effort in a separate model call. This adds cost and latency, but can reduce cost in the Advisor call. The compact result shows the model, selection counts, elapsed time, and usage/cost details; `Ctrl+O` shows bounded selected labels and the synthesis. Usage and cost details can be hidden in `/advisor-settings`.
 
-Scout receives a bounded manifest of conversation and tool-history groups after the normal tool disclosure, result-cap, and redaction policies are applied. The manifest and reconstructed Scout conversation share the Advisor's remaining context budget after repository context; a zero remaining budget produces no history groups. For a pending `ask_advisor` call, Scout receives only the allowlisted question and Git-context preference, never the draft or explicit attachment paths. Scout does not receive the deterministic Git context, draft, project preferences, or explicit tracked and untracked attachments. Those regions are appended later through their existing consent and cap rules.
+Scout receives a bounded manifest of conversation and tool-history groups after the normal tool disclosure, result-cap, and redaction policies are applied. The Scout manifest has its own fixed transport limit, while the reconstructed conversation remains bounded by the Advisor's remaining context budget after repository context; manifest metadata no longer consumes that Advisor conversation budget. A zero remaining budget produces no history groups. For a pending `ask_advisor` call, Scout receives only the allowlisted question and Git-context preference, never the draft or explicit attachment paths. Scout does not receive the deterministic Git context, draft, project preferences, or explicit tracked and untracked attachments. Those regions are appended later through their existing consent and cap rules.
 
 This experiment adapts the context-boundary idea from Zhang et al., ["FastContext: Training Efficient Repository Explorer for Coding Agents"](https://arxiv.org/html/2606.14066v1). It is not a reproduction of FastContext. pi-advisor Scout curates conversation history only.
 
@@ -85,11 +89,13 @@ This experiment adapts the context-boundary idea from Zhang et al., ["FastContex
 | Command | Purpose |
 | --- | --- |
 | `/advisor` | Enable the flow and optionally override the Executor, Advisor, or context limit. |
-| `/advisor-manual [focus]` | Start a parallel consultation without interrupting the current Executor turn; shows progress in the footer. |
+| `/advisor-manual [focus]` | Open a TUI form for a parallel consultation, or consult immediately in non-TUI modes; shows progress in the footer. |
 | `/advisor-models` | Choose both models and their reasoning effort; current models are preselected. |
 | `/advisor-settings` | Configure behavior, context, gates, privacy, and output limits. |
 | `/advisor-off` | Disable the flow and turn off persistent activation. |
 
+In the interactive TUI, `/advisor-manual [focus]` opens a centered overlay. The optional focus text is prefilled and editable; Enter submits, Shift+Enter inserts a newline, Tab/Shift+Tab moves focus, and Escape cancels. The form lets you choose the permitted Git context level, with choices above the configured ceiling hidden. `None` withholds Git data only; it does not remove configured conversation history. After submission, the call, Scout, and Advisor streaming progress appear immediately in the transcript. Canceling has no consultation side effects. RPC, print, and JSON invocations retain their immediate argument-driven behavior.
+
 The Executor calls `ask_advisor({})` for a general review. It can pass a targeted `question` or a concise `draft` describing proposed work, validation, and remaining risks. If the Advisor explicitly says it cannot review a specifically named file, the Executor may make a sequential follow-up call with `includeTrackedFiles` when global consent is enabled and the file is relevant. Draft claims give the Advisor review context; they are not verification evidence.
 
 ## What gets sent to the Advisor

package/extensions/index.ts

@@ -2,7 +2,6 @@ import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 import { registerCommands } from "../src/commands.js";
 import { setHerdrBlockedEmitter } from "../src/herdr.js";
 import { AdvisorSessionState } from "../src/session-state.js";
-import { createBenchmarkTelemetry } from "../src/telemetry.js";
 import {
   consultAdvisor as consultAdvisorImplementation,
   parseAutomaticDecision as parseAutomaticDecisionImplementation,
@@ -37,20 +36,11 @@ export default function (pi: ExtensionAPI) {
   setHerdrBlockedEmitter((active, label) =>
     pi.events.emit("herdr:blocked", { active, label })
   );
-  const benchmarkTelemetry = createBenchmarkTelemetry(pi.events);
-  if (benchmarkTelemetry) {
-    // Diagnostics only: never rewrite provider payloads or affect production sessions.
-    pi.on("before_provider_request", (event) => {
-      benchmarkTelemetry.providerRequest(event.payload);
-    });
-  }
   registerAdvisorTool(pi, sessionState, {
     statusManager: scoutStatus,
-    telemetry: benchmarkTelemetry,
   });
   registerCommands(pi, {
     sessionState,
     statusManager: scoutStatus,
-    telemetry: benchmarkTelemetry,
   });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-advisor-flow",
-  "version": "0.3.6",
+  "version": "0.5.0",
   "description": "Advanced Executor/Advisor flow for Pi, fully configurable and extendable.",
   "keywords": [
     "pi-package",
@@ -28,8 +28,6 @@
     "README.md"
   ],
   "scripts": {
-    "benchmark": "bun benchmarks/src/cli.ts",
-    "benchmark:report": "bun benchmarks/src/cli.ts report",
     "format": "bunx ultracite fix --linter-enabled=false",
     "lint": "bunx ultracite check",
     "lint:fix": "bunx ultracite fix",
@@ -46,17 +44,17 @@
     "undici": "8.9.0"
   },
   "devDependencies": {
-    "@biomejs/biome": "2.5.8",
-    "@earendil-works/pi-ai": "^0.84.2",
-    "@earendil-works/pi-coding-agent": "^0.84.2",
-    "@earendil-works/pi-tui": "^0.84.2",
-    "@types/node": "^20.11.0",
-    "bun-types": "^1.0.0",
+    "@biomejs/biome": "2.5.11",
+    "@earendil-works/pi-ai": "^0.84.4",
+    "@earendil-works/pi-coding-agent": "^0.84.4",
+    "@earendil-works/pi-tui": "^0.84.4",
+    "@types/node": "^26.4.0",
+    "bun-types": "1.3.14",
     "husky": "^9.1.7",
-    "lint-staged": "^17.3.0",
-    "typebox": "^1.3.14",
-    "typescript": "^5.3.3",
-    "ultracite": "7.10.4"
+    "lint-staged": "^17.4.1",
+    "typebox": "^1.3.21",
+    "typescript": "^7.0.2",
+    "ultracite": "7.10.7"
   },
   "peerDependencies": {
     "@earendil-works/pi-ai": "^0.84.1",