pi-advisor-flow 0.2.4 → 0.2.6

package/README.md

@@ -1,19 +1,18 @@
 # pi-advisor
 
 <div align="center">
-  <img src="https://raw.githubusercontent.com/philipbrembeck/pi-advisor/refs/heads/main/assets/screenshot.png" alt="Pi Advisor consultation in the terminal" width="760">
 
-A configurable second-opinion workflow for <a href="https://github.com/earendil-works/pi">Pi</a> coding agents.
+![Pi Advisor consultation in the terminal](https://raw.githubusercontent.com/philipbrembeck/pi-advisor/refs/heads/main/assets/screenshot.png)
 
-</div>
+A configurable second-opinion workflow for <a href="https://github.com/earendil-works/pi">Pi</a> coding agents, inspired by the ["Steering Black-Box LLMs with Advisor Models" paper](https://arxiv.org/abs/2510.02453) and Claude's [Advisor](https://code.claude.com/docs/en/advisor) feature.
 
-Keep the work to the executor model, while the advisor steers it.
+</div>
 
-This extension introduces a strategic "Executor/Advisor" workflow, inspired by Claudes [Advisor](https://code.claude.com/docs/en/advisor).
+This extension introduces a strategic "Executor/Advisor" workflow.
 
 `pi-advisor-flow` keeps one model focused on execution and makes a second, smarter model available for consequential decisions, stalled work, and final reviews. The Executor still owns the work. The Advisor provides a concise review, answers questions and can provide help; it does not take over planning or run tools.
 
-[Read more about Advisors here](https://philipbrembeck.com/writings/2026/07/only-as-much-intelligence-as-you-need).
+The concept is simple, keep implementation on a fast model, borrow frontier reasoning only when decisions actually matter. [Read more about Advisors here](https://philipbrembeck.com/writings/2026/07/only-as-much-intelligence-as-you-need).
 
 ## Install
 
@@ -58,7 +57,9 @@ Enable with models in one command when preferred:
 
 ### `ask_advisor`
 
-The Executor calls `ask_advisor({})` for a general review of the current task and reconstructed conversation. It can pass a `question` for a targeted review.
+The Executor calls `ask_advisor({})` for a general review of the current task and reconstructed conversation. It can pass a `question` for a targeted review, or a concise `draft` for plan and completion reviews. A draft should name proposed work, validation, and remaining risks; it is an unverified claim, not evidence.
+
+Successful calls return an opaque `adviceId`. When global outcome logging is enabled, the Executor may voluntarily call `record_advisor_outcome` once with that ID, an adoption value, and a final validation status.
 
 Use the Advisor after the Executor has investigated and formed a candidate direction. It is intended to challenge assumptions, expose risks, and confirm the next verification step—not to replace the Executor's work.
 
@@ -126,6 +127,8 @@ All fields are optional. This example shows the available settings and their nor
   "gateFailureMode": "block-session",
 
   "advisorSessionSummary": false,
+  "advisorGitContext": "summary",
+  "advisorGitContextMaxChars": 20000,
   "simpleMode": false,
   "alwaysOn": false,
   "advisorHerdrIntegration": true,
@@ -133,6 +136,8 @@ All fields are optional. This example shows the available settings and their nor
   "advisorToolResultMaxBytes": 51200,
 
   "advisorRedactSecrets": false,
+  "advisorUntrackedContent": false,
+  "advisorOutcomeLogging": false,
   "advisorToolPolicies": {
     "bash": "summary",
     "deploy": "exclude"
@@ -146,6 +151,27 @@ All fields are optional. This example shows the available settings and their nor
 - `alwaysOn` defaults to `false`. When enabled, Pi restores the configured Executor and activates `ask_advisor` for new, resumed, forked, and reloaded sessions. While the Advisor flow is active, an explicit `/model` selection becomes the persisted Executor for the next activation; a model restored with a session does not change the saved Executor. `/advisor-off` turns `alwaysOn` off so the flow stays disabled in later sessions.
 - In Simple mode, settings keeps the Context window/history slider alongside Simple mode and Always on; advanced values remain saved and take effect when Simple mode is disabled.
 
+### Repository context
+
+- `advisorGitContext` defaults to `summary`. It controls how much of the working tree reaches the Advisor:
+  - `off` sends no repository information.
+  - `summary` sends changed file names, change status, and line counts. It never sends file contents.
+  - `full` additionally sends the patch.
+- Changes are measured against the last commit and cover staged and unstaged work. Untracked files are always listed by name only; their contents are never sent by `gitContext: full`.
+- `advisorUntrackedContent` defaults to false. When enabled, `includeUntracked` can attach only exact named, repository-relative, untracked regular files. Files are redacted and capped before egress; sibling files remain withheld.
+- `advisorGitContextMaxChars` defaults to `20000`. Repository context may claim its own cap or half of `contextMaxChars`, whichever is smaller, so it cannot crowd out the conversation.
+- The Executor may pass `gitContext` to `ask_advisor` as `none`, `summary`, or `full`. `advisorGitContext` is the ceiling: a larger request is narrowed to the configured level and the Advisor is told that a fuller view was withheld, so it does not claim verification it could not perform.
+- `summary` deliberately excludes diff hunk headers. Git derives those from surrounding file content, so a hunk header can reproduce a line the change never touched, including a credential.
+- Redaction runs before the region is capped, and repository content is labelled as untrusted data in the request. Paths and patch text are escaped so a crafted path cannot close the region early and have the remainder read as instructions.
+- File names themselves can be sensitive. `summary` withholds file contents, not file names; use `off` when names must not leave the machine.
+- Collection shares a single overall time budget across its git commands and degrades to a stated failure rather than implying a clean tree.
+
+### Project preferences and outcomes
+
+In a trusted project only, `.pi/advisor-preferences.md` may provide a short local brief. It is never written by pi-advisor, is treated as lower-priority untrusted text, and is redacted/capped before egress. Symlinks, unreadable files, and paths outside the project are ignored.
+
+`advisorOutcomeLogging` defaults to false and is global-only: a project config cannot enable it. When enabled, `~/.pi/agent/advisor-outcomes.jsonl` stores bounded rotating JSONL records with only a version, timestamp, salted truncated advice digest, trigger, adoption, and validation status. It stores no prompt, advice, paths, tool output, repository data, session ID, or advice ID.
+
 ### Context and limits
 
 - `contextMaxChars` defaults to `15000`. It preserves complete semantic entries and adds an omission marker rather than splitting a message.

package/package.json

@@ -1,4 +1,12 @@
 {
+  "name": "pi-advisor-flow",
+  "version": "0.2.6",
+  "author": "Philip Brembeck",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/philipbrembeck/pi-advisor.git"
+  },
+  "main": "extensions/index.ts",
   "devDependencies": {
     "@biomejs/biome": "2.5.3",
     "@earendil-works/pi-ai": "^0.80.7",
@@ -12,37 +20,19 @@
     "typescript": "^5.3.3",
     "ultracite": "7.9.4"
   },
-  "name": "pi-advisor-flow",
   "peerDependencies": {
     "@earendil-works/pi-ai": "^0.80.7",
     "@earendil-works/pi-coding-agent": "^0.80.7",
     "@earendil-works/pi-tui": "^0.80.7",
     "typebox": "^1.1.38"
   },
-  "scripts": {
-    "test": "bun test",
-    "typecheck": "tsc --noEmit",
-    "format": "bunx ultracite fix --linter-enabled=false",
-    "lint": "bunx ultracite check",
-    "lint:fix": "bunx ultracite fix",
-    "package:check": "npm pack --dry-run --json >/dev/null",
-    "prepare": "husky"
-  },
-  "lint-staged": {
-    "*.{json,jsonc,ts}": "bun run lint:fix --"
-  },
-  "type": "module",
-  "version": "0.2.4",
-  "license": "MIT",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/philipbrembeck/pi-advisor.git"
-  },
-  "homepage": "https://github.com/philipbrembeck/pi-advisor",
-  "author": "Philip Brembeck",
   "description": "Advanced Executor/Advisor flow for Pi, fully configurable and extendable.",
-  "main": "extensions/index.ts",
-  "types": "extensions/index.ts",
+  "files": [
+    "extensions",
+    "src",
+    "README.md"
+  ],
+  "homepage": "https://github.com/philipbrembeck/pi-advisor",
   "keywords": [
     "pi-package",
     "pi-extension",
@@ -51,15 +41,28 @@
     "pi-advisor",
     "herdr"
   ],
-  "files": [
-    "extensions",
-    "src",
-    "README.md"
-  ],
+  "license": "MIT",
+  "lint-staged": {
+    "*.{json,jsonc,ts}": "bun run lint:fix --"
+  },
+  "overrides": {
+    "brace-expansion": "5.0.8"
+  },
   "pi": {
     "extensions": [
       "./extensions/index.ts"
     ],
     "image": "https://raw.githubusercontent.com/philipbrembeck/pi-advisor/refs/heads/main/assets/hero.png"
-  }
+  },
+  "scripts": {
+    "test": "bun test",
+    "typecheck": "tsc --noEmit",
+    "format": "bunx ultracite fix --linter-enabled=false",
+    "lint": "bunx ultracite check",
+    "lint:fix": "bunx ultracite fix",
+    "package:check": "npm pack --dry-run --json >/dev/null",
+    "prepare": "husky"
+  },
+  "type": "module",
+  "types": "extensions/index.ts"
 }

package/src/commands.ts

@@ -16,6 +16,7 @@ import {
   loadConfig,
   parseArgs,
   saveConfig,
+  saveGlobalOutcomeLogging,
   setAdvisorAutoLoopGateRef,
   setAdvisorBlockOnBlockedRef,
   setAdvisorCollapseResponsesRef,
@@ -24,9 +25,12 @@ import {
   setAdvisorEffortRef,
   setAdvisorFailureGateRef,
   setAdvisorFailureModeRef,
+  setAdvisorGitContextMaxCharsRef,
+  setAdvisorGitContextRef,
   setAdvisorHerdrIntegrationRef,
   setAdvisorLoopThresholdRef,
   setAdvisorMaxCallsPerSessionRef,
+  setAdvisorOutcomeLoggingRef,
   setAdvisorPlanGateRef,
   setAdvisorRedactSecretsRef,
   setAdvisorRef,
@@ -34,6 +38,7 @@ import {
   setAdvisorToolPoliciesRef,
   setAdvisorToolResultMaxBytesRef,
   setAdvisorToolResultMaxLinesRef,
+  setAdvisorUntrackedContentRef,
   setAlwaysOnRef,
   setContextMaxCharsRef,
   setExecutorEffortRef,
@@ -108,7 +113,12 @@ type ManualConsult = (
   ctx: ExtensionContext,
   question?: string,
   signal?: AbortSignal
-) => Promise<{ markdown: string; thinkingText: string }>;
+) => Promise<{
+  markdown: string;
+  thinkingText: string;
+  draftBytes?: number;
+  preferenceBytes?: number;
+}>;
 type ThinkingLevel = Parameters<ExtensionAPI["setThinkingLevel"]>[0];
 
 const notify = (
@@ -248,7 +258,11 @@ export const registerCommands = (
       pi.setThinkingLevel(executorEffortRef as ThinkingLevel);
     }
     if (!flowEnabled()) {
-      pi.setActiveTools([...pi.getActiveTools(), "ask_advisor"]);
+      pi.setActiveTools([
+        ...pi.getActiveTools(),
+        "ask_advisor",
+        "record_advisor_outcome",
+      ]);
     }
     if (announce) {
       notify(
@@ -459,6 +473,7 @@ export const registerCommands = (
 
   pi.registerCommand("advisor-settings", {
     description: "Configure Advisor context and reasoning effort",
+    // biome-ignore lint/complexity/noExcessiveCognitiveComplexity: one settings form maps every persisted control.
     handler: async (_args, ctx) => {
       loadConfig(ctx);
       if (!ctx.hasUI) {
@@ -505,9 +520,19 @@ export const registerCommands = (
       setAdvisorToolResultMaxLinesRef(settings.toolResultMaxLines ?? 2000);
       setAdvisorToolResultMaxBytesRef(settings.toolResultMaxBytes ?? 50 * 1024);
       setAdvisorRedactSecretsRef(settings.redactSecrets ?? false);
+      setAdvisorGitContextRef(settings.gitContext ?? "summary");
+      setAdvisorGitContextMaxCharsRef(settings.gitContextMaxChars ?? 20_000);
       setAdvisorToolPoliciesRef(settings.toolPolicies ?? {});
+      setAdvisorUntrackedContentRef(settings.untrackedContent ?? false);
+      setAdvisorOutcomeLoggingRef(settings.outcomeLogging ?? false);
       const path = saveConfig(ctx);
-      ctx.ui.notify(`Saved Advisor settings to ${path}`, "info");
+      const globalPath = saveGlobalOutcomeLogging(
+        settings.outcomeLogging ?? false
+      );
+      ctx.ui.notify(
+        `Saved Advisor settings to ${path}; outcome logging globally to ${globalPath}`,
+        "info"
+      );
     },
   });
 
@@ -515,7 +540,12 @@ export const registerCommands = (
     description: "Disable on-demand Advisor calls; keep the current model",
     handler: (_args, ctx) => {
       pi.setActiveTools(
-        pi.getActiveTools().filter((name) => name !== "ask_advisor")
+        pi
+          .getActiveTools()
+          .filter(
+            (name) =>
+              name !== "ask_advisor" && name !== "record_advisor_outcome"
+          )
       );
       // Leaving alwaysOn set would silently reactivate the flow next session.
       const wasAlwaysOn = alwaysOnRef;

package/src/config.ts

@@ -7,6 +7,11 @@ import {
   type ExtensionContext,
   getAgentDir,
 } from "@earendil-works/pi-coding-agent";
+import {
+  GIT_CONTEXT_LEVELS,
+  type GitContextLevel,
+  isValidGitContextLevel,
+} from "./git.js";
 
 export const FALLBACK_EXECUTOR = "aikeys/claude-sonnet-5";
 export const FALLBACK_ADVISOR = "aikeys/claude-fable-5";
@@ -14,6 +19,7 @@ export const DEFAULT_CONTEXT_MAX_CHARS = 15_000;
 export const MAX_CONTEXT_MAX_CHARS = Number.MAX_SAFE_INTEGER;
 export const DEFAULT_ADVISOR_TOOL_RESULT_MAX_LINES = DEFAULT_MAX_LINES;
 export const DEFAULT_ADVISOR_TOOL_RESULT_MAX_BYTES = DEFAULT_MAX_BYTES;
+export const DEFAULT_ADVISOR_GIT_CONTEXT_MAX_CHARS = 20_000;
 export type AdvisorToolPolicy = "full" | "summary" | "exclude";
 export type AdvisorToolPolicies = Record<string, AdvisorToolPolicy>;
 export const ADVISOR_TOOL_POLICIES: AdvisorToolPolicy[] = [
@@ -53,7 +59,11 @@ export let advisorHerdrIntegrationRef = true;
 export let advisorToolResultMaxLinesRef = DEFAULT_ADVISOR_TOOL_RESULT_MAX_LINES;
 export let advisorToolResultMaxBytesRef = DEFAULT_ADVISOR_TOOL_RESULT_MAX_BYTES;
 export let advisorRedactSecretsRef = false;
+export let advisorGitContextRef: GitContextLevel = "summary";
+export let advisorGitContextMaxCharsRef = DEFAULT_ADVISOR_GIT_CONTEXT_MAX_CHARS;
 export let advisorToolPoliciesRef: AdvisorToolPolicies = {};
+export let advisorOutcomeLoggingRef = false;
+export let advisorUntrackedContentRef = false;
 
 export const setExecutorRef = (ref: string) => {
   executorRef = ref;
@@ -141,9 +151,21 @@ export const setAdvisorToolResultMaxBytesRef = (value: number) => {
 export const setAdvisorRedactSecretsRef = (enabled: boolean) => {
   advisorRedactSecretsRef = enabled;
 };
+export const setAdvisorGitContextRef = (level: GitContextLevel) => {
+  advisorGitContextRef = level;
+};
+export const setAdvisorGitContextMaxCharsRef = (value: number) => {
+  advisorGitContextMaxCharsRef = value;
+};
 export const setAdvisorToolPoliciesRef = (policies: AdvisorToolPolicies) => {
   advisorToolPoliciesRef = { ...policies };
 };
+export const setAdvisorOutcomeLoggingRef = (enabled: boolean) => {
+  advisorOutcomeLoggingRef = enabled;
+};
+export const setAdvisorUntrackedContentRef = (enabled: boolean) => {
+  advisorUntrackedContentRef = enabled;
+};
 
 /**
  * Returns the current live settings state. Use this at UI boundaries instead of
@@ -160,9 +182,12 @@ export const getAdvisorSettings = () => ({
   effort: advisorEffortRef,
   failureGate: advisorFailureGateRef,
   failureMode: advisorFailureModeRef,
+  gitContext: advisorGitContextRef,
+  gitContextMaxChars: advisorGitContextMaxCharsRef,
   herdrIntegration: advisorHerdrIntegrationRef,
   loopThreshold: advisorLoopThresholdRef,
   maxCallsPerSession: advisorMaxCallsPerSessionRef,
+  outcomeLogging: advisorOutcomeLoggingRef,
   planGate: advisorPlanGateRef,
   redactSecrets: advisorRedactSecretsRef,
   sessionSummary: advisorSessionSummaryRef,
@@ -170,6 +195,7 @@ export const getAdvisorSettings = () => ({
   toolPolicies: { ...advisorToolPoliciesRef },
   toolResultMaxBytes: advisorToolResultMaxBytesRef,
   toolResultMaxLines: advisorToolResultMaxLinesRef,
+  untrackedContent: advisorUntrackedContentRef,
 });
 
 export const splitRef = (ref: string): [string, string] => {
@@ -193,15 +219,19 @@ export interface AdvisorConfig {
   advisorCustomInvocation?: string;
   advisorEffort?: string;
   advisorFailureGate?: boolean;
+  advisorGitContext?: GitContextLevel;
+  advisorGitContextMaxChars?: number;
   advisorHerdrIntegration?: boolean;
   advisorLoopThreshold?: number;
   advisorMaxCallsPerSession?: number;
+  advisorOutcomeLogging?: boolean;
   advisorPlanGate?: boolean;
   advisorRedactSecrets?: boolean;
   advisorSessionSummary?: boolean;
   advisorToolPolicies?: AdvisorToolPolicies;
   advisorToolResultMaxBytes?: number;
   advisorToolResultMaxLines?: number;
+  advisorUntrackedContent?: boolean;
   alwaysOn?: boolean;
   contextMaxChars?: number;
   executor?: string;
@@ -219,6 +249,8 @@ const CONFIG_KEYS = new Set<keyof AdvisorConfig>([
   "advisorCustomInvocation",
   "advisorEffort",
   "advisorFailureGate",
+  "advisorGitContext",
+  "advisorGitContextMaxChars",
   "advisorHerdrIntegration",
   "advisorLoopThreshold",
   "advisorMaxCallsPerSession",
@@ -229,6 +261,8 @@ const CONFIG_KEYS = new Set<keyof AdvisorConfig>([
   "advisorToolResultMaxBytes",
   "advisorToolResultMaxLines",
   "advisorRedactSecrets",
+  "advisorUntrackedContent",
+  "advisorOutcomeLogging",
   "advisorToolPolicies",
   "contextMaxChars",
   "executor",
@@ -247,6 +281,8 @@ const BOOLEAN_CONFIG_KEYS = [
   "alwaysOn",
   "advisorHerdrIntegration",
   "advisorRedactSecrets",
+  "advisorUntrackedContent",
+  "advisorOutcomeLogging",
 ] as const;
 const STRING_CONFIG_KEYS = [
   "executor",
@@ -347,6 +383,11 @@ const validateNumericValues = (config: ConfigRecord, path: string) => {
       isValidToolResultMaxBytes,
       "a non-negative safe integer",
     ],
+    [
+      "advisorGitContextMaxChars",
+      isValidToolResultMaxBytes,
+      "a non-negative safe integer",
+    ],
   ];
   for (const [key, isValid, description] of numericRules) {
     if (config[key] !== undefined && !isValid(config[key])) {
@@ -385,6 +426,16 @@ export const validateConfig = (
   ) {
     invalidConfigValue(path, "gateFailureMode", GATE_FAILURE_MODES.join(", "));
   }
+  if (
+    config.advisorGitContext !== undefined &&
+    !isValidGitContextLevel(config.advisorGitContext)
+  ) {
+    invalidConfigValue(
+      path,
+      "advisorGitContext",
+      GIT_CONTEXT_LEVELS.join(", ")
+    );
+  }
   return true;
 };
 
@@ -411,7 +462,11 @@ const resetDefaults = () => {
   advisorToolResultMaxLinesRef = DEFAULT_ADVISOR_TOOL_RESULT_MAX_LINES;
   advisorToolResultMaxBytesRef = DEFAULT_ADVISOR_TOOL_RESULT_MAX_BYTES;
   advisorRedactSecretsRef = false;
+  advisorGitContextRef = "summary";
+  advisorGitContextMaxCharsRef = DEFAULT_ADVISOR_GIT_CONTEXT_MAX_CHARS;
   advisorToolPoliciesRef = {};
+  advisorOutcomeLoggingRef = false;
+  advisorUntrackedContentRef = false;
 };
 
 const applyOptionalConfig = <Key extends keyof AdvisorConfig>(
@@ -501,7 +556,18 @@ const applyConfig = (config: AdvisorConfig) => {
     "advisorRedactSecrets",
     setAdvisorRedactSecretsRef
   );
+  applyOptionalConfig(config, "advisorGitContext", setAdvisorGitContextRef);
+  applyOptionalConfig(
+    config,
+    "advisorGitContextMaxChars",
+    setAdvisorGitContextMaxCharsRef
+  );
   applyOptionalConfig(config, "advisorToolPolicies", setAdvisorToolPoliciesRef);
+  applyOptionalConfig(
+    config,
+    "advisorUntrackedContent",
+    setAdvisorUntrackedContentRef
+  );
 };
 
 const readConfig = (path: string): AdvisorConfig => {
@@ -553,17 +619,25 @@ const readConfigCached = (path: string): AdvisorConfig => {
 
 export const loadConfig = (ctx: ExtensionContext) => {
   resetDefaults();
-  const path = configPaths(ctx).find(
+  const paths = configPaths(ctx);
+  const path = paths.find(
     (candidate): candidate is string =>
       candidate !== null && existsSync(candidate)
   );
-  if (!path) {
-    return null;
+  if (path) {
+    applyConfig(readConfigCached(path));
   }
-  applyConfig(readConfigCached(path));
-  return path;
+  // Persistent outcome consent is global-only: project configuration cannot enable it.
+  const global = join(getAgentDir(), "advisor.json");
+  const globalConfig = existsSync(global)
+    ? readConfigCached(global)
+    : undefined;
+  // Never apply this field through project-first configuration selection.
+  advisorOutcomeLoggingRef = globalConfig?.advisorOutcomeLogging === true;
+  return path ?? null;
 };
 
+/** Saves the ordinary project-preferred configuration without outcome consent. */
 export const saveConfig = (ctx: ExtensionContext) => {
   const project = join(ctx.cwd, CONFIG_DIR_NAME, "advisor.json");
   const path =
@@ -600,12 +674,15 @@ export const saveConfig = (ctx: ExtensionContext) => {
     ...(advisorMaxCallsPerSessionRef === undefined
       ? {}
       : { advisorMaxCallsPerSession: advisorMaxCallsPerSessionRef }),
+    advisorGitContext: advisorGitContextRef,
+    advisorGitContextMaxChars: advisorGitContextMaxCharsRef,
     advisorHerdrIntegration: advisorHerdrIntegrationRef,
     advisorRedactSecrets: advisorRedactSecretsRef,
     advisorSessionSummary: advisorSessionSummaryRef,
     advisorToolPolicies: advisorToolPoliciesRef,
     advisorToolResultMaxBytes: advisorToolResultMaxBytesRef,
     advisorToolResultMaxLines: advisorToolResultMaxLinesRef,
+    advisorUntrackedContent: advisorUntrackedContentRef,
     alwaysOn: alwaysOnRef,
     gateFailureMode: advisorFailureModeRef,
     simpleMode: simpleModeRef,
@@ -615,6 +692,26 @@ export const saveConfig = (ctx: ExtensionContext) => {
   return path;
 };
 
+/** Outcome logging is deliberately written only to the global Pi configuration. */
+export const saveGlobalOutcomeLogging = (enabled: boolean) => {
+  const path = join(getAgentDir(), "advisor.json");
+  let existing: Record<string, unknown> = {};
+  try {
+    const parsed = JSON.parse(readFileSync(path, "utf8"));
+    if (parsed && typeof parsed === "object" && !Array.isArray(parsed)) {
+      existing = parsed as Record<string, unknown>;
+    }
+  } catch {
+    /* create it */
+  }
+  writeFileSync(
+    path,
+    `${JSON.stringify({ ...existing, advisorOutcomeLogging: enabled }, null, 2)}\n`
+  );
+  resetConfigCache();
+  return path;
+};
+
 export const parseArgs = (args: string): string | undefined => {
   let nextExecutor = executorRef;
   let nextAdvisor = advisorRef;

package/src/conversation.ts

@@ -59,6 +59,23 @@ export const redactSecrets = (value: string): string => {
   return redacted;
 };
 
+/** Redacts before a byte-safe cap so no secret fragment survives truncation. */
+export const redactAndCapText = (
+  value: string,
+  maxBytes: number,
+  redact = true
+): string => {
+  const source = redact ? redactSecrets(value) : value;
+  let result = "";
+  for (const character of source) {
+    if (byteLength(result + character) > maxBytes) {
+      break;
+    }
+    result += character;
+  }
+  return result;
+};
+
 export interface ToolResultTruncation {
   content: string;
   omittedLines: number;