pi-advisor-flow 0.2.3 → 0.2.6

package/src/preferences.ts

@@ -0,0 +1,50 @@
+import { lstat, open, realpath } from "node:fs/promises";
+import { join, relative } from "node:path";
+import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { redactAndCapText } from "./conversation.js";
+
+export const PREFERENCES_MAX_BYTES = 8 * 1024;
+export interface TextAttachment {
+  bytes: number;
+  text: string;
+}
+
+const inside = (root: string, candidate: string) => {
+  const path = relative(root, candidate);
+  return path === "" || !(path.startsWith("..") || path.includes("../"));
+};
+
+/** Reads trusted project preferences without following a file or root escape. */
+export const readProjectPreferences = async (
+  ctx: ExtensionContext,
+  maxBytes = PREFERENCES_MAX_BYTES,
+  redact = true
+): Promise<TextAttachment | undefined> => {
+  if (!ctx.isProjectTrusted()) {
+    return;
+  }
+  try {
+    const root = await realpath(ctx.cwd);
+    const candidate = join(ctx.cwd, ".pi", "advisor-preferences.md");
+    const stats = await lstat(candidate);
+    if (stats.isSymbolicLink() || !stats.isFile()) {
+      return;
+    }
+    const resolved = await realpath(candidate);
+    if (!inside(root, resolved)) {
+      return;
+    }
+    const file = await open(resolved, "r");
+    try {
+      const buffer = Buffer.alloc(maxBytes + 1);
+      const { bytesRead } = await file.read(buffer, 0, buffer.length, 0);
+      const source = buffer.subarray(0, bytesRead).toString("utf8");
+      const capped = redactAndCapText(source, maxBytes, redact);
+      return { bytes: Buffer.byteLength(capped, "utf8"), text: capped };
+    } finally {
+      await file.close();
+    }
+  } catch {
+    // Missing, unreadable, or unsafe preferences are intentionally withheld.
+  }
+};

package/src/session-state.ts

@@ -112,6 +112,13 @@ export class AdvisorSessionState {
   #invocations: AdvisorInvocationRecord[] = [];
   #loopInterventions = 0;
   #consumedCalls = 0;
+  readonly #issuedAdvice = new Map<
+    string,
+    { advice: string; trigger: ConsultationTrigger }
+  >();
+  readonly #reportedAdvice = new Set<string>();
+  #draftConsultations = 0;
+  #outcomes = 0;
 
   resetTask() {
     this.#previousSignature = undefined;
@@ -120,6 +127,10 @@ export class AdvisorSessionState {
     this.#invocations = [];
     this.#loopInterventions = 0;
     this.#consumedCalls = 0;
+    this.#issuedAdvice.clear();
+    this.#reportedAdvice.clear();
+    this.#draftConsultations = 0;
+    this.#outcomes = 0;
   }
 
   clearBlocked() {
@@ -172,6 +183,29 @@ export class AdvisorSessionState {
   recordInvocation(record: AdvisorInvocationRecord) {
     this.#invocations.push(record);
   }
+  issueAdvice(
+    id: string,
+    advice: string,
+    trigger: ConsultationTrigger,
+    draft = false
+  ) {
+    this.#issuedAdvice.set(id, { advice, trigger });
+    if (draft) {
+      this.#draftConsultations += 1;
+    }
+  }
+  claimAdvice(id: string) {
+    if (this.#reportedAdvice.has(id)) {
+      return;
+    }
+    const advice = this.#issuedAdvice.get(id);
+    if (!advice) {
+      return;
+    }
+    this.#reportedAdvice.add(id);
+    this.#outcomes += 1;
+    return advice;
+  }
 
   summary(limit: number | undefined) {
     if (this.#invocations.length === 0 && this.#loopInterventions === 0) {
@@ -215,7 +249,8 @@ export class AdvisorSessionState {
       `Triggers: ${["manual", "executor-requested", "repeated-tool-call", "completion-review", "custom-rule"].filter((trigger) => countTrigger(trigger as AdvisorTrigger) > 0).join(", ") || "none"}`,
       `Models: ${models}`,
       `Budget: ${budget}`,
-      `Markdown advice: ${markdown.length} responses`,
+      `Markdown advice: ${markdown.length} responses (${this.#draftConsultations} with drafts)`,
+      `Outcome reports: ${this.#outcomes}`,
       `Gate decisions: ${decisions}`,
       `Loop matching: normalized tool signatures; ${this.#loopInterventions} gate intervention${this.#loopInterventions === 1 ? "" : "s"}`,
       `Execution effects: ${effects("tool-blocked")} tool blocked, ${effects("session-blocked")} sessions blocked, ${effects("continued")} continued`,