pi-acp 0.0.28 → 0.0.30

package/dist/index.js

@@ -529,16 +529,16 @@ function expandSlashCommand(text, fileCommands) {
 // src/acp/translate/pi-tools.ts
 function toolResultToText(result) {
   if (!result) return "";
-  const content = result.content;
-  if (Array.isArray(content)) {
-    const texts = content.map((c) => c?.type === "text" && typeof c.text === "string" ? c.text : "").filter(Boolean);
-    if (texts.length) return texts.join("");
-  }
   const details = result?.details;
   const diff = details?.diff;
   if (typeof diff === "string" && diff.trim()) {
     return diff;
   }
+  const content = result.content;
+  if (Array.isArray(content)) {
+    const texts = content.map((c) => c?.type === "text" && typeof c.text === "string" ? c.text : "").filter(Boolean);
+    if (texts.length) return texts.join("");
+  }
   const stdout = (typeof details?.stdout === "string" ? details.stdout : void 0) ?? (typeof result?.stdout === "string" ? result.stdout : void 0) ?? (typeof details?.output === "string" ? details.output : void 0) ?? (typeof result?.output === "string" ? result.output : void 0);
   const stderr = (typeof details?.stderr === "string" ? details.stderr : void 0) ?? (typeof result?.stderr === "string" ? result.stderr : void 0);
   const exitCode = (typeof details?.exitCode === "number" ? details.exitCode : void 0) ?? (typeof result?.exitCode === "number" ? result.exitCode : void 0) ?? (typeof details?.code === "number" ? details.code : void 0) ?? (typeof result?.code === "number" ? result.code : void 0);
@@ -576,8 +576,58 @@ function findUniqueLineNumber(text, needle) {
   }
   return line;
 }
+function getToolPath(args) {
+  const record = args;
+  if (typeof record?.path === "string") return record.path;
+  if (typeof record?.file_path === "string") return record.file_path;
+  return void 0;
+}
+function getParsedEdits(args) {
+  const record = args;
+  const parsed = [];
+  if (typeof record?.oldText === "string" && typeof record?.newText === "string") {
+    parsed.push({ oldText: record.oldText, newText: record.newText });
+  }
+  let edits = record?.edits;
+  if (typeof edits === "string") {
+    try {
+      edits = JSON.parse(edits);
+    } catch {
+      edits = void 0;
+    }
+  }
+  if (Array.isArray(edits)) {
+    for (const edit of edits) {
+      const item = edit;
+      if (typeof item?.oldText === "string" && typeof item?.newText === "string") {
+        parsed.push({ oldText: item.oldText, newText: item.newText });
+      }
+    }
+  }
+  return parsed;
+}
+function getEditOldTexts(args) {
+  const record = args;
+  const oldTexts = getParsedEdits(args).map((edit) => edit.oldText);
+  if (typeof record?.oldText === "string" && !oldTexts.includes(record.oldText)) oldTexts.push(record.oldText);
+  let edits = record?.edits;
+  if (typeof edits === "string") {
+    try {
+      edits = JSON.parse(edits);
+    } catch {
+      edits = void 0;
+    }
+  }
+  if (Array.isArray(edits)) {
+    for (const edit of edits) {
+      const oldText = edit?.oldText;
+      if (typeof oldText === "string" && !oldTexts.includes(oldText)) oldTexts.push(oldText);
+    }
+  }
+  return oldTexts;
+}
 function toToolCallLocations(args, cwd, line) {
-  const path = typeof args?.path === "string" ? args.path : void 0;
+  const path = getToolPath(args);
   if (!path) return void 0;
   const resolvedPath = isAbsolute(path) ? path : resolvePath(cwd, path);
   return [{ path: resolvedPath, ...typeof line === "number" ? { line } : {} }];
@@ -677,8 +727,7 @@ var PiAcpSession = class {
   cwd;
   mcpServers;
   startupInfo = null;
-  startupInfoSentOutOfTurn = false;
-  startupInfoSentInPrompt = false;
+  startupInfoSent = false;
   proc;
   conn;
   fileCommands;
@@ -695,10 +744,11 @@ var PiAcpSession = class {
   // pi can emit multiple `turn_end` events for a single user prompt (e.g. after tool_use).
   // The overall agent loop completes when `agent_end` is emitted.
   inAgentLoop = false;
-  // For ACP diff support: capture file contents before edits, then emit ToolCallContent {type:"diff"}.
-  // This is due to pi sending diff as a string as opposed to ACP expected diff format.
-  // Compatible format may need to be implemented in pi in the future.
-  editSnapshots = /* @__PURE__ */ new Map();
+  // For ACP diff support: capture file contents before edit/write mutations,
+  // then emit ToolCallContent {type:"diff"}. Compatible structured edit/write
+  // events may need to be implemented in pi in the future.
+  fileSnapshots = /* @__PURE__ */ new Map();
+  fileMutationToolCallIds = /* @__PURE__ */ new Set();
   // Ensure `session/update` notifications are sent in order and can be awaited
   // before completing a `session/prompt` request.
   lastEmit = Promise.resolve();
@@ -713,8 +763,7 @@ var PiAcpSession = class {
   }
   setStartupInfo(text) {
     this.startupInfo = text;
-    this.startupInfoSentOutOfTurn = false;
-    this.startupInfoSentInPrompt = false;
+    this.startupInfoSent = false;
   }
   /**
    * Best-effort attempt to send startup info outside of a prompt turn.
@@ -722,23 +771,14 @@ var PiAcpSession = class {
    * callers can invoke this shortly after session/new returns.
    */
   sendStartupInfoIfPending() {
-    if (this.startupInfoSentOutOfTurn || !this.startupInfo) return;
-    this.startupInfoSentOutOfTurn = true;
-    this.emit({
-      sessionUpdate: "agent_message_chunk",
-      content: { type: "text", text: this.startupInfo }
-    });
-  }
-  sendStartupInfoOnFirstPromptIfPending() {
-    if (this.startupInfoSentInPrompt || !this.startupInfo) return;
-    this.startupInfoSentInPrompt = true;
+    if (this.startupInfoSent || !this.startupInfo) return;
+    this.startupInfoSent = true;
     this.emit({
       sessionUpdate: "agent_message_chunk",
       content: { type: "text", text: this.startupInfo }
     });
   }
   async prompt(message, images = []) {
-    this.sendStartupInfoOnFirstPromptIfPending();
     const expandedMessage = expandSlashCommand(message, this.fileCommands);
     const turnPromise = new Promise((resolve4, reject) => {
       const queued = { message: expandedMessage, images, resolve: resolve4, reject };
@@ -889,16 +929,25 @@ var PiAcpSession = class {
         const toolName = String(ev.toolName ?? "tool");
         const args = ev.args;
         let line;
-        if (toolName === "edit") {
-          const p = typeof args?.path === "string" ? args.path : void 0;
+        const isFileMutation = toolName === "edit" || toolName === "write";
+        let snapshotOldText;
+        if (isFileMutation) {
+          this.fileMutationToolCallIds.add(toolCallId);
+          const p = getToolPath(args);
           if (p) {
             try {
               const abs = isAbsolute(p) ? p : resolvePath(this.cwd, p);
-              const oldText = readFileSync3(abs, "utf8");
-              this.editSnapshots.set(toolCallId, { path: p, oldText });
-              const needle = typeof args?.oldText === "string" ? args.oldText : "";
-              line = findUniqueLineNumber(oldText, needle);
+              snapshotOldText = readFileSync3(abs, "utf8");
+              this.fileSnapshots.set(toolCallId, { path: p, oldText: snapshotOldText });
+              if (toolName === "edit") {
+                for (const needle of getEditOldTexts(args)) {
+                  line = findUniqueLineNumber(snapshotOldText, needle);
+                  if (typeof line === "number") break;
+                }
+              }
             } catch {
+              snapshotOldText = null;
+              this.fileSnapshots.set(toolCallId, { path: p, oldText: null });
             }
           }
         }
@@ -930,13 +979,13 @@ var PiAcpSession = class {
         const toolCallId = String(ev.toolCallId ?? "");
         if (!toolCallId) break;
         const partial = ev.partialResult;
-        const text = toolResultToText(partial);
+        const text = this.fileMutationToolCallIds.has(toolCallId) ? "" : toolResultToText(partial);
         this.emit({
           sessionUpdate: "tool_call_update",
           toolCallId,
           status: "in_progress",
           content: text ? [{ type: "content", content: { type: "text", text } }] : void 0,
-          rawOutput: partial
+          ...this.fileMutationToolCallIds.has(toolCallId) ? {} : { rawOutput: partial }
         });
         break;
       }
@@ -946,27 +995,28 @@ var PiAcpSession = class {
         const result = ev.result;
         const isError = Boolean(ev.isError);
         const text = toolResultToText(result);
-        const snapshot = this.editSnapshots.get(toolCallId);
+        const snapshot = this.fileSnapshots.get(toolCallId);
         let content;
+        let hasStructuredDiff = false;
         if (!isError && snapshot) {
           try {
             const abs = isAbsolute(snapshot.path) ? snapshot.path : resolvePath(this.cwd, snapshot.path);
             const newText = readFileSync3(abs, "utf8");
-            if (newText !== snapshot.oldText) {
+            if (snapshot.oldText === null || newText !== snapshot.oldText) {
+              hasStructuredDiff = true;
               content = [
                 {
                   type: "diff",
                   path: snapshot.path,
                   oldText: snapshot.oldText,
                   newText
-                },
-                ...text ? [{ type: "content", content: { type: "text", text } }] : []
+                }
               ];
             }
           } catch {
           }
         }
-        if (!content && text) {
+        if (!content && !hasStructuredDiff && text) {
           content = [{ type: "content", content: { type: "text", text } }];
         }
         this.emit({
@@ -974,10 +1024,11 @@ var PiAcpSession = class {
           toolCallId,
           status: isError ? "failed" : "completed",
           content,
-          rawOutput: result
+          ...hasStructuredDiff ? {} : { rawOutput: result }
         });
         this.currentToolCalls.delete(toolCallId);
-        this.editSnapshots.delete(toolCallId);
+        this.fileSnapshots.delete(toolCallId);
+        this.fileMutationToolCallIds.delete(toolCallId);
         break;
       }
       case "extension_ui_request": {
@@ -1441,10 +1492,9 @@ function listPiSessions() {
   });
   return items;
 }
-function findPiSessionFile(sessionId) {
+function findPiSession(sessionId) {
   const all = listPiSessions();
-  const found = all.find((s) => s.sessionId === sessionId);
-  return found?.sessionFile ?? null;
+  return all.find((s) => s.sessionId === sessionId) ?? null;
 }
 
 // src/acp/translate/pi-messages.ts
@@ -1600,6 +1650,8 @@ import { existsSync as existsSync4, readFileSync as readFileSync6, realpathSync,
 import { join as join5, dirname as dirname2, basename } from "path";
 import { spawnSync } from "child_process";
 import { fileURLToPath } from "url";
+var MODEL_CONFIG_ID = "model";
+var THOUGHT_LEVEL_CONFIG_ID = "thought_level";
 function builtinAvailableCommands() {
   return [
     {
@@ -1656,6 +1708,7 @@ var PiAcpAgent = class {
   conn;
   sessions = new SessionManager();
   store = new SessionStore();
+  restoringSessions = /* @__PURE__ */ new Map();
   dispose() {
     this.sessions.disposeAll();
   }
@@ -1676,6 +1729,66 @@ var PiAcpAgent = class {
     }
     this.store.delete(sessionId);
   }
+  findStoredSession(sessionId) {
+    const stored = this.store.get(sessionId);
+    if (stored?.cwd && stored?.sessionFile) {
+      return { cwd: stored.cwd, sessionFile: stored.sessionFile };
+    }
+    const piSession = findPiSession(sessionId);
+    if (!piSession) return null;
+    this.store.upsert({
+      sessionId,
+      cwd: piSession.cwd,
+      sessionFile: piSession.sessionFile
+    });
+    return {
+      cwd: piSession.cwd,
+      sessionFile: piSession.sessionFile
+    };
+  }
+  async restoreSession(sessionId, opts) {
+    const existing = this.sessions.maybeGet(sessionId);
+    if (existing) return existing;
+    const inFlight = this.restoringSessions.get(sessionId);
+    if (inFlight) return inFlight;
+    const restorePromise = (async () => {
+      const stored = this.findStoredSession(sessionId);
+      if (!stored) {
+        throw RequestError3.invalidParams(`Unknown sessionId: ${sessionId}`);
+      }
+      const cwd = opts?.cwd ?? stored.cwd;
+      let proc;
+      try {
+        proc = await PiRpcProcess.spawn({
+          cwd,
+          sessionPath: stored.sessionFile,
+          piCommand: process.env.PI_ACP_PI_COMMAND
+        });
+      } catch (e) {
+        if (e?.name === "PiRpcSpawnError") {
+          throw RequestError3.internalError({ code: e?.code }, String(e?.message ?? e));
+        }
+        throw e;
+      }
+      const fileCommands = loadSlashCommands(cwd);
+      const session = this.sessions.getOrCreate(sessionId, {
+        cwd,
+        mcpServers: opts?.mcpServers ?? [],
+        conn: this.conn,
+        proc,
+        fileCommands
+      });
+      this.lastSessionCwd = cwd;
+      this.store.upsert({ sessionId, cwd, sessionFile: stored.sessionFile });
+      return session;
+    })();
+    this.restoringSessions.set(sessionId, restorePromise);
+    try {
+      return await restorePromise;
+    } finally {
+      this.restoringSessions.delete(sessionId);
+    }
+  }
   async initialize(params) {
     const supportedVersion = 1;
     const requested = params.protocolVersion;
@@ -1763,8 +1876,10 @@ var PiAcpAgent = class {
         "Configure an API key or log in with an OAuth provider."
       );
     }
-    const models = await getModelState(session.proc, { state, availableModels });
-    const thinking = await getThinkingState(session.proc, { state });
+    const { configOptions, models, modes } = await getSessionConfiguration(session.proc, {
+      state,
+      availableModels
+    });
     const quietStartup = getQuietStartup(params.cwd);
     const updateNotice = buildUpdateNotice();
     const preludeText = quietStartup ? updateNotice ? updateNotice + "\n" : "" : buildStartupInfo({
@@ -1777,8 +1892,9 @@ var PiAcpAgent = class {
     this.sessions.closeAllExcept?.(session.sessionId);
     const response = {
       sessionId: session.sessionId,
+      configOptions,
       models,
-      modes: thinking,
+      modes,
       _meta: {
         piAcp: {
           startupInfo: preludeText || null
@@ -1819,7 +1935,7 @@ var PiAcpAgent = class {
     return;
   }
   async prompt(params) {
-    const session = this.sessions.get(params.sessionId);
+    const session = await this.restoreSession(params.sessionId);
     const { message, images } = promptToPiMessage(params.prompt);
     if (images.length === 0 && message.trimStart().startsWith("/")) {
       const trimmed = message.trim();
@@ -2192,7 +2308,8 @@ ${JSON.stringify(stats, null, 2)}`;
     return { stopReason };
   }
   async cancel(params) {
-    const session = this.sessions.get(params.sessionId);
+    const session = this.sessions.maybeGet(params.sessionId);
+    if (!session) return;
     await session.cancel();
   }
   async unstable_listSessions(params) {
@@ -2218,38 +2335,22 @@ ${JSON.stringify(stats, null, 2)}`;
     }
     this.sessions.close(params.sessionId);
     this.lastSessionCwd = params.cwd;
-    const stored = this.store.get(params.sessionId);
-    const sessionFile = stored?.sessionFile ?? findPiSessionFile(params.sessionId);
-    if (!sessionFile) {
+    const stored = this.findStoredSession(params.sessionId);
+    if (!stored) {
       throw RequestError3.invalidParams(`Unknown sessionId: ${params.sessionId}`);
     }
-    let proc;
-    try {
-      proc = await PiRpcProcess.spawn({
-        cwd: params.cwd,
-        sessionPath: sessionFile,
-        piCommand: process.env.PI_ACP_PI_COMMAND
-      });
-    } catch (e) {
-      if (e?.name === "PiRpcSpawnError") {
-        throw RequestError3.internalError({ code: e?.code }, String(e?.message ?? e));
-      }
-      throw e;
-    }
-    const fileCommands = loadSlashCommands(params.cwd);
     const enableSkillCommands = getEnableSkillCommands(params.cwd);
-    const session = this.sessions.getOrCreate(params.sessionId, {
+    const session = await this.restoreSession(params.sessionId, {
       cwd: params.cwd,
-      mcpServers: params.mcpServers,
-      conn: this.conn,
-      proc,
-      fileCommands
+      mcpServers: params.mcpServers
     });
+    const proc = session.proc;
+    const fileCommands = loadSlashCommands(params.cwd);
     this.sessions.closeAllExcept?.(session.sessionId);
     this.store.upsert({
       sessionId: params.sessionId,
       cwd: params.cwd,
-      sessionFile
+      sessionFile: stored.sessionFile
     });
     const data = await proc.getMessages();
     const messages = Array.isArray(data?.messages) ? data.messages : [];
@@ -2308,11 +2409,11 @@ ${JSON.stringify(stats, null, 2)}`;
         });
       }
     }
-    const models = await getModelState(proc);
-    const thinking = await getThinkingState(proc);
+    const { configOptions, models, modes } = await getSessionConfiguration(proc);
     const response = {
+      configOptions,
       models,
-      modes: thinking,
+      modes,
       _meta: {
         piAcp: {
           startupInfo: null
@@ -2349,32 +2450,12 @@ ${JSON.stringify(stats, null, 2)}`;
     return response;
   }
   async unstable_setSessionModel(params) {
-    const session = this.sessions.get(params.sessionId);
-    let provider = null;
-    let modelId = null;
-    if (params.modelId.includes("/")) {
-      const [p, ...rest] = params.modelId.split("/");
-      provider = p;
-      modelId = rest.join("/");
-    } else {
-      modelId = params.modelId;
-    }
-    if (!provider) {
-      const data = await session.proc.getAvailableModels();
-      const models = Array.isArray(data?.models) ? data.models : [];
-      const found = models.find((m) => String(m?.id) === modelId);
-      if (found) {
-        provider = String(found.provider);
-        modelId = String(found.id);
-      }
-    }
-    if (!provider || !modelId) {
-      throw RequestError3.invalidParams(`Unknown modelId: ${params.modelId}`);
-    }
-    await session.proc.setModel(provider, modelId);
+    const session = await this.restoreSession(params.sessionId);
+    await setSessionModel(session.proc, params.modelId);
+    await emitConfigOptionsUpdate(this.conn, session.sessionId, session.proc);
   }
   async setSessionMode(params) {
-    const session = this.sessions.get(params.sessionId);
+    const session = await this.restoreSession(params.sessionId);
     const mode = String(params.modeId);
     if (!isThinkingLevel(mode)) {
       throw RequestError3.invalidParams(`Unknown modeId: ${mode}`);
@@ -2387,8 +2468,35 @@ ${JSON.stringify(stats, null, 2)}`;
         currentModeId: mode
       }
     });
+    await emitConfigOptionsUpdate(this.conn, session.sessionId, session.proc);
     return {};
   }
+  async setSessionConfigOption(params) {
+    const session = await this.restoreSession(params.sessionId);
+    const configId = String(params.configId);
+    if (typeof params.value !== "string") {
+      throw RequestError3.invalidParams(`Expected string value for config option: ${configId}`);
+    }
+    if (configId === MODEL_CONFIG_ID) {
+      await setSessionModel(session.proc, params.value);
+    } else if (configId === THOUGHT_LEVEL_CONFIG_ID) {
+      if (!isThinkingLevel(params.value)) {
+        throw RequestError3.invalidParams(`Unknown thinking level: ${params.value}`);
+      }
+      await session.proc.setThinkingLevel(params.value);
+      void this.conn.sessionUpdate({
+        sessionId: session.sessionId,
+        update: {
+          sessionUpdate: "current_mode_update",
+          currentModeId: params.value
+        }
+      });
+    } else {
+      throw RequestError3.invalidParams(`Unknown config option: ${configId}`);
+    }
+    const configOptions = await emitConfigOptionsUpdate(this.conn, session.sessionId, session.proc);
+    return { configOptions };
+  }
 };
 function isThinkingLevel(x) {
   return x === "off" || x === "minimal" || x === "low" || x === "medium" || x === "high" || x === "xhigh";
@@ -2414,6 +2522,47 @@ async function getThinkingState(proc, pre) {
     }))
   };
 }
+async function getSessionConfiguration(proc, pre) {
+  const [models, modes] = await Promise.all([getModelState(proc, pre), getThinkingState(proc, { state: pre?.state })]);
+  return {
+    configOptions: buildConfigOptions({ models, modes }),
+    models,
+    modes
+  };
+}
+function buildConfigOptions(state) {
+  const configOptions = [
+    {
+      type: "select",
+      id: THOUGHT_LEVEL_CONFIG_ID,
+      category: "thought_level",
+      name: "Thinking",
+      description: "Set the reasoning effort for this session",
+      currentValue: state.modes.currentModeId,
+      options: state.modes.availableModes.map((mode) => ({
+        value: mode.id,
+        name: mode.name,
+        description: mode.description ?? null
+      }))
+    }
+  ];
+  if (state.models?.availableModels.length) {
+    configOptions.unshift({
+      type: "select",
+      id: MODEL_CONFIG_ID,
+      category: "model",
+      name: "Model",
+      description: "Select the model for this session",
+      currentValue: state.models.currentModelId,
+      options: state.models.availableModels.map((model) => ({
+        value: model.modelId,
+        name: model.name,
+        description: model.description ?? null
+      }))
+    });
+  }
+  return configOptions;
+}
 async function getModelState(proc, pre) {
   let availableModels = [];
   const data = pre?.availableModels ?? await (async () => {
@@ -2453,9 +2602,44 @@ async function getModelState(proc, pre) {
   if (!currentModelId) currentModelId = availableModels[0]?.modelId ?? "default";
   return {
     availableModels,
-    currentModelId
+    currentModelId: currentModelId ?? availableModels[0]?.modelId ?? "default"
   };
 }
+async function emitConfigOptionsUpdate(conn, sessionId, proc) {
+  const { configOptions } = await getSessionConfiguration(proc);
+  await conn.sessionUpdate({
+    sessionId,
+    update: {
+      sessionUpdate: "config_option_update",
+      configOptions
+    }
+  });
+  return configOptions;
+}
+async function setSessionModel(proc, requestedModelId) {
+  let provider = null;
+  let modelId = null;
+  if (requestedModelId.includes("/")) {
+    const [candidateProvider, ...rest] = requestedModelId.split("/");
+    provider = candidateProvider;
+    modelId = rest.join("/");
+  } else {
+    modelId = requestedModelId;
+  }
+  if (!provider) {
+    const data = await proc.getAvailableModels();
+    const models = Array.isArray(data?.models) ? data.models : [];
+    const found = models.find((m) => String(m?.id) === modelId);
+    if (found) {
+      provider = String(found.provider);
+      modelId = String(found.id);
+    }
+  }
+  if (!provider || !modelId) {
+    throw RequestError3.invalidParams(`Unknown modelId: ${requestedModelId}`);
+  }
+  await proc.setModel(provider, modelId);
+}
 function isSemver(v) {
   return /^\d+\.\d+\.\d+(?:[-+].+)?$/.test(v);
 }