phone-lens 0.3.6 → 0.3.7

package/lib/index.js

@@ -1,4 +1,4 @@
-import { join } from "node:path";
+import { basename, join, resolve, sep } from "node:path";
 import { Service } from "@deepseek-ai/cordis";
 import z from "@deepseek-ai/schemastery";
 import { createUserMessage } from "@deepseek-ai/dsh-llm";
@@ -371,6 +371,60 @@ var DeviceStore = class {
 	}
 };
 
+//#endregion
+//#region src/store/settings.ts
+const SAVE_MODES = [
+	"composer",
+	"folder",
+	"both"
+];
+/**
+* User-facing capture settings, persisted as JSON under the plugin data dir.
+* Stored host-side on purpose: the folder save happens on this machine, and
+* every loopback view (overlay, /view.html) must see the same mode.
+*/
+var AppSettingsStore = class {
+	data;
+	constructor(file, defaultSaveDir) {
+		this.file = file;
+		this.defaultSaveDir = defaultSaveDir;
+		this.data = {
+			saveMode: "composer",
+			saveDir: ""
+		};
+		this.load();
+	}
+	load() {
+		if (!existsSync(this.file)) return;
+		try {
+			const raw = JSON.parse(readFileSync(this.file, "utf8"));
+			if (SAVE_MODES.includes(raw.saveMode)) this.data.saveMode = raw.saveMode;
+			if (typeof raw.saveDir === "string") this.data.saveDir = raw.saveDir;
+		} catch {}
+	}
+	get() {
+		return { ...this.data };
+	}
+	/** Effective absolute folder (resolved default when unset). */
+	effectiveSaveDir() {
+		return this.data.saveDir.trim() || this.defaultSaveDir;
+	}
+	set(patch) {
+		if (patch.saveMode && SAVE_MODES.includes(patch.saveMode)) this.data.saveMode = patch.saveMode;
+		if (typeof patch.saveDir === "string") this.data.saveDir = patch.saveDir.replace(/^["']|["']$/g, "").trim();
+		this.persist();
+		return this.get();
+	}
+	persist() {
+		try {
+			mkdirSync(join(this.file, ".."), { recursive: true });
+			const tmp = `${this.file}.tmp`;
+			writeFileSync(tmp, JSON.stringify(this.data, null, 2), "utf8");
+			renameSync(tmp, this.file);
+		} catch {}
+	}
+};
+
 //#endregion
 //#region src/types.ts
 const ERROR_CODES = {
@@ -768,6 +822,8 @@ function queryOf(req) {
 
 //#endregion
 //#region src/server/http.ts
+/** Process-lifetime marker: surfaces service rebuilds via /status. */
+const SERVER_BOOT_AT = Date.now();
 /** Boot the receiver: HTTP routes + two websocket endpoints. */
 async function startLensServer(deps) {
 	const { config, pairing, devices, hub, targets, sink, log } = deps;
@@ -834,18 +890,19 @@ async function startLensServer(deps) {
 		done(404, "Not Found");
 	});
 	const heartbeat = setInterval(() => hub.pingAll(), 2e4);
-	await new Promise((resolve, reject) => {
+	await new Promise((resolve$1, reject) => {
 		server.once("error", reject);
-		server.listen(config.server.port, config.server.host, () => resolve());
+		server.listen(config.server.port, config.server.host, () => resolve$1());
 	});
 	log("info", `phone-lens listening on ${config.server.host}:${config.server.port} (paired devices: ${devices.count()})`);
 	return {
 		port: config.server.port,
 		dispose: async () => {
 			clearInterval(heartbeat);
+			hub.dispose();
 			hub.detachAll();
 			for (const client of wss.clients) client.terminate();
-			await new Promise((resolve) => server.close(() => resolve()));
+			await new Promise((resolve$1) => server.close(() => resolve$1()));
 		}
 	};
 }
@@ -863,10 +920,10 @@ async function handle(deps, req, res, ctx) {
 	}
 	if (method === "GET" && path === "/info") return sendJson(res, 200, {
 		name: "PhoneLens 直连取景",
-		version: "0.3.5",
+		version: "0.3.7",
 		requiresPairing: true
 	}, cors);
-	if (!loop && (path === "/" || path === "/view.html" || path === "/qr.json" || path === "/qr.png" || path === "/app-qr.json")) return sendError(res, 403, ERROR_CODES.LOOPBACK_ONLY, "preview surface is loopback-only");
+	if (!loop && (path === "/" || path === "/view.html" || path === "/qr.json" || path === "/qr.png" || path === "/app-qr.json" || path === "/app-settings")) return sendError(res, 403, ERROR_CODES.LOOPBACK_ONLY, "preview surface is loopback-only");
 	if (method === "GET" && (path === "/" || path === "/view.html")) {
 		res.writeHead(200, {
 			"content-type": "text/html; charset=utf-8",
@@ -961,7 +1018,8 @@ async function handle(deps, req, res, ctx) {
 		const captureId = q.get("captureId");
 		const note = q.get("note") ?? (captureId ? hub.noteFor(captureId) : void 0);
 		if (captureId) hub.consumeCapture(captureId);
-		const name = (q.get("name") ?? `shot_${new Date().toISOString().replace(/[:.]/g, "-")}.${mediaType === "image/png" ? "png" : "jpg"}`).slice(0, 120);
+		const rawName = (q.get("name") ?? `shot_${new Date().toISOString().replace(/[:.]/g, "-")}.${mediaType === "image/png" ? "png" : "jpg"}`).slice(0, 120);
+		const name = sanitizeFileName(rawName);
 		let admitted;
 		try {
 			admitted = await admitImage({
@@ -975,18 +1033,43 @@ async function handle(deps, req, res, ctx) {
 		}
 		log("info", `stored ${name} (${buf.byteLength}B) → ${admitted.storage}:${admitted.ref.attachmentId}`);
 		if (admitted.storage === "file") await pruneUploads(deps.fallbackDir, config.limits.maxStoredUploads).catch((error) => log("warn", `upload pruning failed: ${String(error)}`));
-		const pendingPath = join(deps.pendingDir, `${admitted.ref.attachmentId}.jpg`);
-		try {
-			mkdirSync(deps.pendingDir, { recursive: true });
-			writeFileSync(pendingPath, buf);
-			log("info", `staged for composer: ${pendingPath}`);
-		} catch (error) {
-			log("warn", `staging failed: ${String(error)}`);
+		const st = deps.appSettings.get();
+		const wantFolder = st.saveMode !== "composer";
+		const wantComposer = st.saveMode !== "folder";
+		let savedDir = null;
+		if (wantFolder) {
+			const dir = deps.appSettings.effectiveSaveDir();
+			try {
+				mkdirSync(dir, { recursive: true });
+				const fileName = nextAvailableName(dir, name);
+				const target = resolveUnder(dir, fileName);
+				if (!target) throw new Error("resolved path escapes the save directory");
+				writeFileSync(target, buf);
+				savedDir = dir;
+				log("info", `folder-mode saved: ${target}`);
+			} catch (error) {
+				log("warn", `folder save failed (${String(error)}) — falling back to composer staging`);
+			}
 		}
-		hub.broadcastToViews({
-			type: "pending_image",
-			attachmentId: admitted.ref.attachmentId,
-			name
+		if (wantComposer || !savedDir) {
+			const pendingPath = resolveUnder(deps.pendingDir, pendingFileName(admitted.ref.attachmentId));
+			try {
+				if (!pendingPath) throw new Error("resolved path escapes the pending directory");
+				mkdirSync(deps.pendingDir, { recursive: true });
+				writeFileSync(pendingPath, buf);
+				log("info", `staged for composer: ${pendingPath}`);
+			} catch (error) {
+				log("warn", `staging failed: ${String(error)}`);
+			}
+			hub.broadcastToViews({
+				type: "pending_image",
+				attachmentId: admitted.ref.attachmentId,
+				name
+			});
+		} else hub.broadcastToViews({
+			type: "upload_saved",
+			name,
+			dir: savedDir
 		});
 		return sendJson(res, 200, {
 			ok: true,
@@ -996,12 +1079,13 @@ async function handle(deps, req, res, ctx) {
 			bytes: admitted.ref.bytes,
 			storage: admitted.storage,
 			delivered: null,
-			deliverReason: "staged-in-composer"
+			deliverReason: savedDir ? wantComposer ? "saved-and-staged" : "saved-to-folder" : "staged-in-composer"
 		});
 	}
 	if (method === "GET" && path.startsWith("/pending/") && loop) {
 		const id = path.slice(9).split("/")[0] ?? "";
-		const file = join(deps.pendingDir, `${id}.jpg`);
+		const file = resolveUnder(deps.pendingDir, pendingFileName(id));
+		if (!file) return sendError(res, 404, ERROR_CODES.BAD_REQUEST, "pending image not found");
 		try {
 			const data = await readFile(file);
 			res.writeHead(200, {
@@ -1018,6 +1102,7 @@ async function handle(deps, req, res, ctx) {
 	if (method === "GET" && path === "/status") {
 		const cameraDeviceId = ctx.getCurrentCamera();
 		return sendJson(res, 200, {
+			bootAt: SERVER_BOOT_AT,
 			devices: devices.list().map((d) => ({
 				id: d.deviceId,
 				name: d.name,
@@ -1039,6 +1124,28 @@ async function handle(deps, req, res, ctx) {
 		targets: targets.list(),
 		default: targets.resolve()?.sessionId ?? null
 	}, cors);
+	if (method === "GET" && path === "/app-settings") {
+		const st = deps.appSettings.get();
+		return sendJson(res, 200, {
+			saveMode: st.saveMode,
+			saveDir: st.saveDir,
+			effectiveSaveDir: deps.appSettings.effectiveSaveDir()
+		}, cors);
+	}
+	if (method === "POST" && path === "/app-settings") {
+		const body = await readJsonBody(req, 4096);
+		if (!body) return sendError(res, 400, ERROR_CODES.BAD_REQUEST, "invalid JSON body");
+		const patch = {};
+		if (typeof body.saveMode === "string" && SAVE_MODES.includes(body.saveMode)) patch.saveMode = body.saveMode;
+		if (typeof body.saveDir === "string") patch.saveDir = body.saveDir;
+		const st = deps.appSettings.set(patch);
+		log("info", `app settings updated: mode=${st.saveMode} dir=${st.saveDir ? JSON.stringify(st.saveDir) : "(default)"}`);
+		return sendJson(res, 200, {
+			saveMode: st.saveMode,
+			saveDir: st.saveDir,
+			effectiveSaveDir: deps.appSettings.effectiveSaveDir()
+		}, cors);
+	}
 	if (method === "POST" && path === "/capture" && loop) {
 		const captureId = randomUUID();
 		const ok = hub.requestCapture(captureId, queryOf(req).get("note") ?? void 0);
@@ -1047,6 +1154,37 @@ async function handle(deps, req, res, ctx) {
 	}
 	return sendError(res, 404, ERROR_CODES.BAD_REQUEST, `no route ${method} ${path}`);
 }
+/** Strip path separators / reserved characters so a phone-supplied upload
+*  name can never escape the target directory or hide as a dotfile. */
+function sanitizeFileName(input) {
+	const base = basename(input).replace(/[<>:"|?*\u0000-\u001F]/g, "_").replace(/^[\s.]+/, "").trim();
+	return base || "shot.jpg";
+}
+/** Pick `name`, then `name (2).ext`, `name (3).ext`, … — folder saves never overwrite. */
+function nextAvailableName(dir, name) {
+	if (!existsSync(join(dir, name))) return name;
+	const dot = name.lastIndexOf(".");
+	const stem = dot > 0 ? name.slice(0, dot) : name;
+	const ext = dot > 0 ? name.slice(dot) : "";
+	for (let n = 2;; n++) {
+		const candidate = `${stem} (${n})${ext}`;
+		if (!existsSync(join(dir, candidate))) return candidate;
+	}
+}
+/** Pending-staging filename for an attachment id. Ids may be URN-ish
+*  ("file:<digest>" without the dsh attachment service) and Windows forbids
+*  ":" in filenames — flatten to a portable name, write and read alike. */
+function pendingFileName(attachmentId) {
+	return `${attachmentId.replace(/[^A-Za-z0-9._-]/g, "_")}.jpg`;
+}
+/** Resolve `name` under `baseDir` and refuse anything that escapes it
+*  (defense in depth on top of sanitizeFileName — e.g. a crafted name that
+*  survives sanitization but still resolves outside the base). */
+function resolveUnder(baseDir, name) {
+	const base = resolve(baseDir);
+	const target = resolve(base, name);
+	return target === base || target.startsWith(base + sep) ? target : null;
+}
 function sendJson(res, status, body, extraHeaders) {
 	res.writeHead(status, {
 		"content-type": "application/json; charset=utf-8",
@@ -1072,7 +1210,7 @@ async function readJsonBody(req, limit) {
 	}
 }
 function readRawBody(req, maxBytes) {
-	return new Promise((resolve, reject) => {
+	return new Promise((resolve$1, reject) => {
 		const chunks = [];
 		let size = 0;
 		let truncated = false;
@@ -1082,7 +1220,7 @@ function readRawBody(req, maxBytes) {
 				truncated = true;
 				chunks.length = 0;
 				req.destroy();
-				resolve({
+				resolve$1({
 					buf: Buffer.alloc(0),
 					truncated
 				});
@@ -1090,7 +1228,7 @@ function readRawBody(req, maxBytes) {
 			}
 			chunks.push(chunk);
 		});
-		req.on("end", () => resolve({
+		req.on("end", () => resolve$1({
 			buf: Buffer.concat(chunks),
 			truncated
 		}));
@@ -1122,6 +1260,22 @@ async function pruneUploads(dir, max) {
 //#region src/server/hub.ts
 /**
 
+* How long the ACTIVE device's stream may go silent before views are told the
+
+* preview was turned off. The phone app never announces "preview off" — it
+
+* just stops pushing frames (the WS stays up) — so the host derives the state:
+
+* a live, open camera uplink with no frames for this long means the user
+
+* switched preview off on the phone. Device disconnects are signalled
+
+* separately via the `devices` list.
+
+*/
+const PREVIEW_STALL_MS = 3e3;
+/**
+
 * The viewfinder hub: MULTIPLE camera uplinks (one per phone, keyed by
 
 * deviceId), N loopback view downlinks. The "active" device is auto-selected
@@ -1142,13 +1296,23 @@ var ViewHub = class {
 	/** captureId → { note, requestedAt } until the matching upload lands or timeout. */
 	pendingCaptures = new Map();
 	captureTimeoutMs = 6e4;
+	/** Whether the active device is confirmed to be streaming (hello/frame seen). */
+	previewOn = false;
+	stallTimer = null;
 	constructor(config, log) {
 		this.config = config;
 		this.log = log;
+		this.stallTimer = setInterval(() => this.checkPreviewStall(), 1e3);
+	}
+	/** Stop the stall watchdog (server dispose). */
+	dispose() {
+		if (this.stallTimer) clearInterval(this.stallTimer);
+		this.stallTimer = null;
 	}
 	attachCamera(deviceId, ws, name) {
 		const prev = this.cameras.get(deviceId);
 		if (prev) {
+			this.log("warn", `camera re-attach: kicking previous ws for ${deviceId.slice(0, 8)}`);
 			try {
 				prev.ws.close(1e3, "new-instance");
 			} catch {}
@@ -1169,7 +1333,8 @@ var ViewHub = class {
 		if (this.activeDeviceId === deviceId) this.sendControl(deviceId, { type: "resume_preview" });
 		else this.sendControl(deviceId, { type: "pause_preview" });
 		this.log("info", `camera uplink: ${name} (${deviceId.slice(0, 8)})`);
-		ws.on("close", () => {
+		ws.on("close", (code, reason) => {
+			this.log("warn", `camera ws closed: code=${code} reason=${reason.toString("utf8") || "-"} (${name} ${deviceId.slice(0, 8)})`);
 			if (this.cameras.get(deviceId)?.ws === ws) this.detachCamera(deviceId);
 		});
 		ws.on("message", (data, isBinary) => {
@@ -1183,6 +1348,7 @@ var ViewHub = class {
 	}
 	detachCamera(deviceId) {
 		const cam = this.cameras.get(deviceId);
+		this.log("warn", `detachCamera(${deviceId.slice(0, 8)}) had-camera=${!!cam}`);
 		if (cam) this.cameras.delete(deviceId);
 		if (this.activeDeviceId === deviceId) {
 			const next = [...this.cameras.keys()].at(-1) ?? null;
@@ -1215,14 +1381,18 @@ var ViewHub = class {
 					fps: msg.fps,
 					...msg.rotation !== void 0 ? { rotation: msg.rotation } : {}
 				};
-				if (this.activeDeviceId === deviceId) this.broadcastToViews({
-					type: "frame_meta",
-					width: msg.width,
-					height: msg.height,
-					...msg.rotation !== void 0 ? { rotation: msg.rotation } : {}
-				});
+				if (this.activeDeviceId === deviceId) {
+					this.markPreviewActive();
+					this.broadcastToViews({
+						type: "frame_meta",
+						width: msg.width,
+						height: msg.height,
+						...msg.rotation !== void 0 ? { rotation: msg.rotation } : {}
+					});
+				}
 				break;
 			case "bye":
+				this.log("warn", `camera sent bye: ${deviceId.slice(0, 8)}`);
 				this.detachCamera(deviceId);
 				break;
 			case "claim_active":
@@ -1258,12 +1428,50 @@ var ViewHub = class {
 			cam.frameCount = 0;
 		}
 		if (this.activeDeviceId === deviceId) {
+			this.markPreviewActive();
 			for (const view of this.views) if (view.readyState === view.OPEN) view.send(frame, { binary: true });
 		}
 	}
+	/** Flip the view-side preview state to on (once) when stream activity returns. */
+	markPreviewActive() {
+		if (this.previewOn) return;
+		this.previewOn = true;
+		this.broadcastToViews({
+			type: "preview_state",
+			on: true
+		});
+	}
+	/**
+	
+	* Watchdog: an open, ACTIVE camera uplink that has gone silent means the
+	
+	* user turned preview off on the phone (the app keeps the WS while only
+	
+	* stopping its frame pump). Tell views so they can clear the stale frame.
+	
+	* Disconnected devices are NOT handled here — the `devices` broadcast owns
+	
+	* the offline state on the view side.
+	
+	*/
+	checkPreviewStall() {
+		if (!this.previewOn) return;
+		const active = this.activeCam();
+		if (!active || active.ws.readyState !== active.ws.OPEN) return;
+		if (Date.now() - active.lastFrameAt <= PREVIEW_STALL_MS) return;
+		this.previewOn = false;
+		this.broadcastToViews({
+			type: "preview_state",
+			on: false
+		});
+		this.log("info", `active preview stalled >${PREVIEW_STALL_MS}ms — notified views (preview off)`);
+	}
 	attachView(ws, hooks = {}) {
 		this.views.add(ws);
-		ws.on("close", () => this.views.delete(ws));
+		ws.on("close", (code, reason) => {
+			this.log("warn", `view ws closed: code=${code} reason=${reason.toString("utf8") || "-"} (views left: ${this.views.size - 1})`);
+			this.views.delete(ws);
+		});
 		ws.on("message", (data, isBinary) => {
 			if (isBinary) return;
 			const msg = parseViewClient(data.toString());
@@ -1291,7 +1499,11 @@ var ViewHub = class {
 			paired: true
 		}));
 		this.broadcastDevicesTo(ws);
-		if (active?.lastFrame && ws.readyState === ws.OPEN) ws.send(active.lastFrame, { binary: true });
+		ws.send(JSON.stringify({
+			type: "preview_state",
+			on: this.previewOn
+		}));
+		if (this.previewOn && active?.lastFrame && ws.readyState === ws.OPEN) ws.send(active.lastFrame, { binary: true });
 	}
 	viewCount() {
 		return this.views.size;
@@ -1320,7 +1532,7 @@ var ViewHub = class {
 	}
 	pushActiveFrameToViews() {
 		const active = this.activeCam();
-		if (active?.lastFrame) {
+		if (this.previewOn && active?.lastFrame) {
 			for (const view of this.views) if (view.readyState === view.OPEN) view.send(active.lastFrame, { binary: true });
 		}
 		if (active) this.broadcastToViews({
@@ -1450,6 +1662,7 @@ var PhoneLens = class extends Service {
 		};
 		const pairing = new PairingStore(config.pairing.codeTtlMs);
 		const devices = new DeviceStore(dataDir);
+		const appSettings = new AppSettingsStore(join(dataDir, "settings.json"), join(dataDir, "saved"));
 		const hub = new ViewHub(config, (level, msg) => log(level, msg));
 		const targets = new TargetTracker(config);
 		const sink = new HostDeliverySink(config, (level, msg) => log(level, msg));
@@ -1473,6 +1686,7 @@ var PhoneLens = class extends Service {
 			attachments,
 			fallbackDir: join(dataDir, "uploads"),
 			pendingDir: join(dataDir, "pending"),
+			appSettings,
 			log
 		}).then(async (h) => {
 			handle$1 = h;