phoenix_live_view 1.1.26 → 1.1.28

package/assets/js/phoenix_live_view/dom_patch.js

@@ -407,7 +407,10 @@ export default class DOMPatch {
             portalCallbacks.push(() => this.teleport(toEl, morph));
             // for the magicId optimization we need to ensure that the template contents
             // are properly updated as they are used when restoring a cloned tree
-            fromEl.innerHTML = toEl.innerHTML;
+            // Note: we can't write fromEl.innerHTML = toEl.innerHTML because in Chrome
+            // the HTML parser would drop nested forms, even when it should not.
+            // https://issues.chromium.org/issues/490290430
+            fromEl.content.replaceChildren(toEl.content.cloneNode(true));
             return false;
           }
 

package/assets/js/phoenix_live_view/view.js

@@ -193,6 +193,11 @@ export default class View {
     // bind the view to the element
     DOM.putPrivate(this.el, "view", this);
     this.id = this.el.id;
+    // destroyViewByEl requires the root set, so we need to set it early
+    // otherwise it could happen that we try to apply a join result for a
+    // view whose DOM node was already removed
+    // See https://github.com/phoenixframework/phoenix_live_view/issues/4177.
+    this.el.setAttribute(PHX_ROOT_ID, this.root.id);
     this.ref = 0;
     this.lastAckRef = null;
     this.childJoins = 0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "phoenix_live_view",
-  "version": "1.1.26",
+  "version": "1.1.28",
   "description": "The Phoenix LiveView JavaScript client.",
   "license": "MIT",
   "type": "module",

package/priv/static/phoenix_live_view.cjs.js

@@ -2516,7 +2516,7 @@ var DOMPatch = class {
           dom_default.copyPrivates(toEl, fromEl);
           if (dom_default.isPortalTemplate(toEl)) {
             portalCallbacks.push(() => this.teleport(toEl, morph));
-            fromEl.innerHTML = toEl.innerHTML;
+            fromEl.content.replaceChildren(toEl.content.cloneNode(true));
             return false;
           }
           if (isFocusedFormEl && fromEl.type !== "hidden" && !focusedSelectChanged) {
@@ -4189,6 +4189,7 @@ var View = class _View {
     }
     dom_default.putPrivate(this.el, "view", this);
     this.id = this.el.id;
+    this.el.setAttribute(PHX_ROOT_ID, this.root.id);
     this.ref = 0;
     this.lastAckRef = null;
     this.childJoins = 0;
@@ -5934,7 +5935,7 @@ var LiveSocket = class {
   }
   // public
   version() {
-    return "1.1.26";
+    return "1.1.28";
   }
   isProfileEnabled() {
     return this.sessionStorage.getItem(PHX_LV_PROFILE) === "true";