phoenix_live_view 0.18.8 → 0.18.10

package/assets/js/phoenix_live_view/live_socket.js

@@ -634,8 +634,8 @@ export default class LiveSocket {
       }
       let phxEvent = target && target.getAttribute(click)
       if(!phxEvent){
-        let href = e.target.href
-        if(!capture && href !== undefined && !DOM.wantsNewTab(e) && DOM.isNewPageHref(href, window.location)){
+        let href = e.target instanceof HTMLAnchorElement ? e.target.getAttribute("href") : null
+        if(!capture && href !== null && !DOM.wantsNewTab(e) && DOM.isNewPageHref(href, window.location)){
           this.unload()
         }
         return
@@ -801,17 +801,23 @@ export default class LiveSocket {
       if(!externalFormSubmitted && phxChange && !phxSubmit){
         externalFormSubmitted = true
         e.preventDefault()
-        this.unload()
         this.withinOwners(e.target, view => {
           view.disableForm(e.target)
-          window.requestAnimationFrame(() => e.target.submit()) // safari needs next tick
+          // safari needs next tick
+          window.requestAnimationFrame(() => {
+            if(!DOM.wantsNewTab(e)){ this.unload() }
+            e.target.submit()
+          })
         })
       }
     }, true)
 
     this.on("submit", e => {
       let phxEvent = e.target.getAttribute(this.binding("submit"))
-      if(!phxEvent){ return this.unload() }
+      if(!phxEvent){
+        if(!DOM.wantsNewTab(e)){ this.unload() }
+        return
+      }
       e.preventDefault()
       e.target.disabled = true
       this.withinOwners(e.target, view => {

package/assets/package.json

@@ -1,6 +1,6 @@
 {
   "name": "phoenix_live_view",
-  "version": "0.18.8",
+  "version": "0.18.10",
   "description": "The Phoenix LiveView JavaScript client.",
   "license": "MIT",
   "repository": {},

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "phoenix_live_view",
-  "version": "0.18.8",
+  "version": "0.18.10",
   "description": "The Phoenix LiveView JavaScript client.",
   "license": "MIT",
   "module": "./priv/static/phoenix_live_view.esm.js",

package/priv/static/phoenix_live_view.cjs.js

@@ -3848,8 +3848,8 @@ var LiveSocket = class {
       }
       let phxEvent = target && target.getAttribute(click);
       if (!phxEvent) {
-        let href = e.target.href;
-        if (!capture && href !== void 0 && !dom_default.wantsNewTab(e) && dom_default.isNewPageHref(href, window.location)) {
+        let href = e.target instanceof HTMLAnchorElement ? e.target.getAttribute("href") : null;
+        if (!capture && href !== null && !dom_default.wantsNewTab(e) && dom_default.isNewPageHref(href, window.location)) {
           this.unload();
         }
         return;
@@ -4014,17 +4014,24 @@ var LiveSocket = class {
       if (!externalFormSubmitted && phxChange && !phxSubmit) {
         externalFormSubmitted = true;
         e.preventDefault();
-        this.unload();
         this.withinOwners(e.target, (view) => {
           view.disableForm(e.target);
-          window.requestAnimationFrame(() => e.target.submit());
+          window.requestAnimationFrame(() => {
+            if (!dom_default.wantsNewTab(e)) {
+              this.unload();
+            }
+            e.target.submit();
+          });
         });
       }
     }, true);
     this.on("submit", (e) => {
       let phxEvent = e.target.getAttribute(this.binding("submit"));
       if (!phxEvent) {
-        return this.unload();
+        if (!dom_default.wantsNewTab(e)) {
+          this.unload();
+        }
+        return;
       }
       e.preventDefault();
       e.target.disabled = true;