phoenix_live_view 0.17.1 → 0.17.2

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.17.2 (2021-10-22)
+
+### Bug fixes
+  - Fix HTML engine bug causing attribute expressions to be incorrectly evaluated in certain cases
+  - Fix show/hide/toggle custom display not being restored.
+  - Fix default `to` target for `JS.show|hide|dispatch`
+  - Fix form input targetting
+
 ## 0.17.1 (2021-10-21)
 
 ### Bug fixes
@@ -76,6 +84,7 @@ Some functionality that was previously deprecated has been removed:
 
 ### Enhancements
   - Allow slots in function components: they are marked as `<:slot_name>` and can be rendered with `<%= render_slot @slot_name %>`
+  - Add JS command for executing JavaScript utility operations on the client with an extended push API
   - Optimize string attributes:
     - If the attribute is a string interpolation, such as `<div class={"foo bar #{@baz}"}>`, only the interpolation part is marked as dynamic
     - If the attribute can be empty, such as "class" and "style", keep the attribute name as static

package/assets/js/phoenix_live_view/js.js

@@ -19,13 +19,18 @@ let JS = {
   // commands
 
   exec_dispatch(eventType, phxEvent, view, sourceEl, {to, event, detail}){
-    DOM.all(document, to, el => DOM.dispatchEvent(el, event, detail))
+    if(to){
+      DOM.all(document, to, el => DOM.dispatchEvent(el, event, detail))
+    } else {
+      DOM.dispatchEvent(sourceEl, event, detail)
+    }
   },
 
   exec_push(eventType, phxEvent, view, sourceEl, args){
     let {event, data, target, page_loading, loading, value} = args
     let pushOpts = {page_loading: !!page_loading, loading: loading, value: value}
-    let phxTarget = target || sourceEl.getAttribute(view.binding("target")) || sourceEl
+    let targetSrc = eventType === "change" ? sourceEl.form : sourceEl
+    let phxTarget = target || targetSrc.getAttribute(view.binding("target")) || targetSrc
     view.withinTargets(phxTarget, (targetView, targetCtx) => {
       if(eventType === "change"){
         let {newCid, _target, callback} = args
@@ -75,7 +80,7 @@ let JS = {
     if(to){
       DOM.all(document, to, el => this.show(eventType, view, el, display, transition, time))
     } else {
-      this.show(eventType, view, el, transition, time)
+      this.show(eventType, view, sourceEl, transition, time)
     }
   },
 
@@ -83,7 +88,7 @@ let JS = {
     if(to){
       DOM.all(document, to, el => this.hide(eventType, view, el, display, transition, time))
     } else {
-      this.hide(eventType, view, el, dispaly, transition, time)
+      this.hide(eventType, view, sourceEl, display, transition, time)
     }
   },
 
@@ -118,7 +123,7 @@ let JS = {
       } else {
         if(eventType === "remove"){ return }
         this.addOrRemoveClasses(el, in_classes, out_classes)
-        DOM.putSticky(el, "toggle", currentEl => currentEl.style.display = "block")
+        DOM.putSticky(el, "toggle", currentEl => currentEl.style.display = (display || "block"))
         view.transition(time, () => {
           this.addOrRemoveClasses(el, [], in_classes)
         })
@@ -161,4 +166,4 @@ let JS = {
   }
 }
 
-export default JS
+export default JS

package/assets/js/phoenix_live_view/live_socket.js

@@ -792,4 +792,4 @@ class TransitionSet {
     this.pendingOps.forEach(op => op())
     this.pendingOps = []
   }
-}
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "phoenix_live_view",
-  "version": "0.17.1",
+  "version": "0.17.2",
   "description": "The Phoenix LiveView JavaScript client.",
   "license": "MIT",
   "module": "./priv/static/phoenix_live_view.esm.js",