phoenix-ui-components 4.1.0 → 4.2.1

package/dist/fesm2022/phoenix-ui-components.mjs

@@ -800,14 +800,20 @@ class NotificationToastComponent {
 class DownloadAnimationDialogComponent {
     data;
     progress = 0;
+    progressSub;
     constructor(data) {
         this.data = data;
     }
     ngOnInit() {
-        this.data.progress$.subscribe((val) => {
+        this.progressSub = this.data.progress$.subscribe((val) => {
             this.progress = val;
         });
     }
+    ngOnDestroy() {
+        // `progress$` is a BehaviorSubject that is never completed, so the
+        // subscription outlives the dialog unless it is dropped here.
+        this.progressSub?.unsubscribe();
+    }
     static ɵfac = function DownloadAnimationDialogComponent_Factory(__ngFactoryType__) { return new (__ngFactoryType__ || DownloadAnimationDialogComponent)(i0.ɵɵdirectiveInject(MAT_DIALOG_DATA)); };
     static ɵcmp = /*@__PURE__*/ i0.ɵɵdefineComponent({ type: DownloadAnimationDialogComponent, selectors: [["app-download-animation-dialog"]], standalone: false, decls: 12, vars: 5, consts: [[1, "loader-wrapper", "d-flex", "flex-column", "justify-content-center", "align-items-center", "w-100", "h-100", "p-5", "text-center"], ["src", "assets/images/logo-small.svg", "alt", "Loader"], [1, "mt-5", "text-light"], [1, "text-muted"], [1, "loading-bar-container"], ["mode", "determinate", 3, "value"], [1, "progress-text", "text-light", "mt-2"]], template: function DownloadAnimationDialogComponent_Template(rf, ctx) { if (rf & 1) {
             i0.ɵɵelementStart(0, "div", 0);
@@ -1042,13 +1048,21 @@ class AnimateCameraComponent {
                 dialogRef.close();
             });
         };
-        if (preset) {
-            this.animatePreset(preset, onEnd);
-        }
-        else {
-            this.animateCamera(onEnd);
+        // `animateCamera` refuses to start while another animation is running. If
+        // it does not start, nothing will ever call `onEnd`, so the interval would
+        // run forever behind a dialog the user cannot dismiss.
+        const started = preset
+            ? this.animatePreset(preset, onEnd)
+            : this.animateCamera(onEnd);
+        if (!started) {
+            clearInterval(interval);
+            recorder.stopRecording(() => dialogRef.close());
         }
     }
+    /**
+     * Animate through the given preset.
+     * @returns Whether the animation was started.
+     */
     animatePreset(preset, onEnd) {
         this.setDetectorOpacity(0.2);
         this.eventDisplay.animatePreset(this.animationPresets[preset], () => {
@@ -1056,16 +1070,24 @@ class AnimateCameraComponent {
             if (onEnd)
                 onEnd();
         });
+        return true;
     }
+    /**
+     * Animate the camera through the event.
+     * @returns Whether the animation was started. It is refused while another
+     * animation is already running.
+     */
     animateCamera(onEnd) {
-        if (!this.isAnimating) {
-            this.isAnimating = true;
-            this.eventDisplay.animateThroughEvent([11976, 7262, 11927], 3000, () => {
-                this.isAnimating = false;
-                if (onEnd)
-                    onEnd();
-            });
+        if (this.isAnimating) {
+            return false;
         }
+        this.isAnimating = true;
+        this.eventDisplay.animateThroughEvent([11976, 7262, 11927], 3000, () => {
+            this.isAnimating = false;
+            if (onEnd)
+                onEnd();
+        });
+        return true;
     }
     setDetectorOpacity(opacity) {
         const sceneManager = this.eventDisplay.getThreeManager().getSceneManager();
@@ -2553,7 +2575,15 @@ class IOOptionsDialogComponent {
     }
     async handleROOTInput(files) {
         const rootObjectName = prompt('Enter object name in ROOT file');
-        await this.eventDisplay.loadRootGeometry(URL.createObjectURL(files[0]), rootObjectName, files[0].name.split('.')[0]);
+        // The object URL pins the whole file in memory, so release it once the
+        // geometry has been read - ROOT files are routinely hundreds of MB.
+        const objectUrl = URL.createObjectURL(files[0]);
+        try {
+            await this.eventDisplay.loadRootGeometry(objectUrl, rootObjectName, files[0].name.split('.')[0]);
+        }
+        finally {
+            URL.revokeObjectURL(objectUrl);
+        }
         this.onClose();
     }
     async handleRootJSONInput(files) {
@@ -2561,7 +2591,13 @@ class IOOptionsDialogComponent {
             return;
         }
         const name = files[0].name.split('.')[0];
-        await this.eventDisplay.loadRootJSONGeometry(URL.createObjectURL(files[0]), name);
+        const objectUrl = URL.createObjectURL(files[0]);
+        try {
+            await this.eventDisplay.loadRootJSONGeometry(objectUrl, name);
+        }
+        finally {
+            URL.revokeObjectURL(objectUrl);
+        }
         this.onClose();
     }
     async handlePHYSLITEInput(files) {
@@ -3373,21 +3409,49 @@ class CartesianGridConfigComponent {
     shiftCartesianGridByPointer() {
         this.shiftGrid = true;
         this.eventDisplay.getUIManager().shiftCartesianGridByPointer();
+        // Drop any subscriptions from a previous shift before starting a new one.
+        this.clearShiftSubscriptions();
         this.originChangedSub = this.eventDisplay
             .getThreeManager()
             .originChanged.subscribe((intersect) => {
             this.translateGrid(intersect);
         });
+        // `stopShifting` may emit synchronously during `subscribe`, in which case
+        // the handler runs before `stopShiftingSub` has been assigned. Track that
+        // with a flag so the teardown still happens (and never dereferences null).
+        let stoppedDuringSubscribe = false;
         this.stopShiftingSub = this.eventDisplay
             .getThreeManager()
             .stopShifting.subscribe((stop) => {
-            if (stop) {
-                this.originChangedSub.unsubscribe();
-                this.stopShiftingSub.unsubscribe();
+            if (!stop) {
+                return;
+            }
+            if (this.stopShiftingSub) {
+                this.clearShiftSubscriptions();
+            }
+            else {
+                stoppedDuringSubscribe = true;
             }
         });
+        if (stoppedDuringSubscribe) {
+            this.clearShiftSubscriptions();
+        }
         this.onClose();
     }
+    /**
+     * Unsubscribe from the grid-shifting subscriptions, if any are active.
+     */
+    clearShiftSubscriptions() {
+        this.originChangedSub?.unsubscribe();
+        this.originChangedSub = null;
+        this.stopShiftingSub?.unsubscribe();
+        this.stopShiftingSub = null;
+    }
+    ngOnDestroy() {
+        // The dialog closes as soon as pointer shifting starts, so without this the
+        // subscriptions outlive the component and leak on every reopen.
+        this.clearShiftSubscriptions();
+    }
     shiftCartesianGridByValues(position) {
         this.translateGrid(position);
         this.eventDisplay.getThreeManager().originChangedEmit(position);
@@ -3664,7 +3728,9 @@ class ViewOptionsComponent {
         this.eventDisplay.getUIManager().show3DDistance(change.checked);
     }
     ngOnDestroy() {
-        this.sub.unsubscribe();
+        // The component can be destroyed before ngOnInit has created the
+        // subscription, so guard rather than dereferencing it unconditionally.
+        this.sub?.unsubscribe();
     }
     static ɵfac = function ViewOptionsComponent_Factory(__ngFactoryType__) { return new (__ngFactoryType__ || ViewOptionsComponent)(i0.ɵɵdirectiveInject(EventDisplayService), i0.ɵɵdirectiveInject(i1$1.MatDialog)); };
     static ɵcmp = /*@__PURE__*/ i0.ɵɵdefineComponent({ type: ViewOptionsComponent, selectors: [["app-view-options"]], viewQuery: function ViewOptionsComponent_Query(rf, ctx) { if (rf & 1) {