phimpal-tv 0.2.1 → 0.2.2

package/README.md

@@ -113,6 +113,13 @@ swallow all input — that looked like a frozen cursor with a dead Return key. S
 - page scans are memoised (a TV CPU was re-computing the same styles hundreds of times per
   key), held keys are coalesced, and carousels are recognised structurally so paging also
   works on Tizen ≤ 6.5, whose Chromium ignores `overflow-x: clip`.
+- (0.2.2) a **black box**: the last 40 steps (key, mode, focus, scope, paging…) are written to
+  `localStorage['tv-trace']` as they happen. If a session ends in the middle of a key, the
+  **next launch** shows the last 12 steps in the same red box for 25 s — so after a freeze,
+  relaunch the module and photograph that box.
+- (0.2.2) a navigation scope (dialog/menu) now has to be on screen **and** contain something
+  focusable; an element merely carrying `role="dialog"` cannot trap the keys any more, and a
+  scope that refuses to close is ignored afterwards.
 
 ## Known limits
 

package/mod.js

@@ -1,4 +1,4 @@
-// PhimPal TV v0.2.1 — generated by build.js from phimpal-tv.user.js, do not edit.
+// PhimPal TV v0.2.2 — generated by build.js from phimpal-tv.user.js, do not edit.
 // TizenBrew site-modification module for https://phimpal.com/
 (function registerRemoteKeys() {
   try {
@@ -67,6 +67,28 @@
     } catch (x) { /* ignore */ }
   }
   const safe = (where, fn) => function () { try { return fn.apply(this, arguments); } catch (e) { report(where, e); } };
+
+  // Black box: the last steps are written to localStorage as they happen. If the previous
+  // session died mid-key (frozen page, app killed), the next launch shows that tail on screen.
+  const TRACE_KEY = 'tv-trace', TRACE_MAX = 40;
+  let traceBuf = [];
+  function trace(msg) {
+    traceBuf.push((Date.now() % 100000) + ' ' + msg);
+    if (traceBuf.length > TRACE_MAX) traceBuf.shift();
+    try { localStorage.setItem(TRACE_KEY, traceBuf.join('\n')); } catch (e) { /* ignore */ }
+  }
+  function showPreviousTrace() {
+    let prev = null; try { prev = localStorage.getItem(TRACE_KEY); } catch (e) { /* ignore */ }
+    if (!prev || !/\bkey \d+ start\b(?![\s\S]*\bkey end\b)/.test(prev)) return; // previous session ended cleanly
+    const tail = prev.split('\n').slice(-12).join('\n');
+    try {
+      let b = $('#tv-error');
+      if (!b) { b = document.createElement('pre'); b.id = 'tv-error'; document.body.appendChild(b); }
+      b.textContent = 'phimpal-tv — previous session ended mid-key:\n' + tail;
+      b.style.opacity = '1';
+      clearTimeout(errTimer); errTimer = setTimeout(() => { b.style.opacity = '0'; }, 25000);
+    } catch (e) { /* ignore */ }
+  }
   const rectOf = (el) => el.getBoundingClientRect();
   const isWatch = () => /^\/watch\//.test(location.pathname);
   const isHome = () => location.pathname === '/';
@@ -187,14 +209,23 @@
   }
   const hoverMenuOpen = () => !!S.hoverTrigger && !!currentScope(); // aria-expanded goes stale, the rendered menu doesn't
 
-  // dialogs / menus that should capture navigation
+  // dialogs / menus that should capture navigation.
+  // A scope must be on screen AND contain something to focus: an element that merely
+  // carries role="dialog" (a toast, an off-screen drawer, a banner) would otherwise trap
+  // every key — arrows find nothing inside it and Back cannot close it. Scopes that refuse
+  // to close are blacklisted for the rest of the page.
   const subPanel = () => $('.vjs-subtitle-panel.is-open');
+  const deadScopes = new WeakSet();
   function currentScope() {
     const list = $$('.vjs-modal-dialog:not(.vjs-hidden), [role="dialog"], [role="alertdialog"], [role="menu"], [data-scope="menu"][data-part="content"], [data-scope="popover"][data-part="content"], [data-scope="dialog"][data-part="content"]');
     const dialog = list.find((e) => {
+      if (deadScopes.has(e)) return false;
       if (e.closest('.video-js') && !e.classList.contains('vjs-modal-dialog')) return false;
+      if (e.closest('aside')) return false; // mobile drawer, parked off-screen with a transform
       const r = rectOf(e);
-      return r.width > 0 && r.height > 0 && styleVisible(e);
+      if (!(r.width > 0 && r.height > 0 && styleVisible(e))) return false;
+      if (r.right <= 0 || r.bottom <= 0 || r.left >= innerWidth || r.top >= innerHeight) return false; // off-screen
+      return $$(CAND, e).some((c) => c !== e && isVisibleBlock(c)); // has something to focus
     });
     if (dialog) return dialog; // a caption-settings modal opens on top of the subtitle panel
     const sp = subPanel();
@@ -289,14 +320,18 @@
     if (!canClick(btn)) return false;
     const item = block.closest('.shrink-0') || block;
     const sib = dir === A.RIGHT ? item.nextElementSibling : item.previousElementSibling;
+    trace('page click ' + dir);
     btn.click();
+    trace('page clicked');
     setTimeout(safe('page', () => {
       let t = sib && (sib.matches('.group') ? sib : sib.querySelector('.group'));
       if (!(t && isVisibleBlock(t))) {
         const vis = withScanCache(() => $$('.group', car.clip).filter(isVisibleBlock));
         t = dir === A.RIGHT ? vis[0] : vis[vis.length - 1];
       }
+      trace('page settled target=' + describe(t));
       if (t) setFocus(t); else badge('page: no card');
+      trace('page done');
     }), CFG.carouselAnimMs);
     return true;
   }
@@ -326,6 +361,7 @@
   }
   function setFocus(block, opts = {}) {
     if (!block) return;
+    trace('focus ' + describe(block));
     if (S.focused !== block) clearFocus();
     S.focused = block;
     if (isCard(block)) { block.classList.add('tv-focus'); (popupOf(block) || block).classList.add('tv-focus-ring'); }
@@ -697,7 +733,8 @@
     const scope = currentScope();
     const blocks = collectBlocks(scope);
     let t = pickTarget(f, dir, blocks);
-    if (!t && (dir === A.LEFT || dir === A.RIGHT) && pageCarousel(f, dir)) return;
+    trace('move ' + dir + ' scope=' + describe(scope) + ' blocks=' + blocks.length + ' target=' + describe(t));
+    if (!t && (dir === A.LEFT || dir === A.RIGHT) && pageCarousel(f, dir)) { trace('paging ' + dir); return; }
     if (!t && dir === A.UP && !scope && scrollY > 0) {
       window.scrollTo({ top: 0, behavior: 'smooth' });
       setTimeout(() => { const t2 = pickTarget(S.focused, A.UP, collectBlocks()); if (t2) setFocus(t2); }, 450);
@@ -715,7 +752,9 @@
     if (scope && scope.classList.contains('vjs-subtitle-panel')) return closeSubPanel();
     const hoverT = S.hoverTrigger;
     const finish = () => {
-      if (currentScope()) return; // still open, stay in scope
+      const still = currentScope();
+      if (still === scope) { deadScopes.add(scope); trace('scope refused to close, ignoring it'); } // never trap the user
+      else if (still) return; // a different dialog is open, stay in it
       if (S.returnMode) { const m = S.returnMode; S.returnMode = null; return m === 'PLAYER' ? enterPlayer() : enterBar(); }
       const back = S.beforeScope || hoverT; S.beforeScope = null;
       if (back && isVisibleBlock(back)) return setFocus(back, { noHover: true }); // don't re-open a hover menu
@@ -769,8 +808,16 @@
     badge('reset: ' + why, true);
   }
   function onKeySafe(e) {
+    const known = TIZEN_KEYS[e.keyCode] || (CFG.keyboardEmulation && KB_KEYS[e.keyCode]);
+    if (known) trace('key ' + e.keyCode + ' start mode=' + S.mode + ' sub=' + S.sub + ' focus=' + describe(S.focused));
     try { onKey(e); }
     catch (err) { report('key ' + e.keyCode, err); try { hardReset('error'); } catch (x) { report('reset', x); } }
+    if (known) trace('key end mode=' + S.mode + ' focus=' + describe(S.focused));
+  }
+  function describe(el) {
+    if (!el) return 'none';
+    const a = el.tagName === 'A' ? el : (el.querySelector && el.querySelector('a[href]'));
+    return el.tagName + (el.id ? '#' + el.id : '') + '.' + (el.className + '').trim().split(/\s+/).slice(0, 2).join('.') + (a && a.getAttribute('href') ? '[' + a.getAttribute('href').slice(0, 30) + ']' : '');
   }
   function onKey(e) {
     if (e.__tv) return;
@@ -810,6 +857,7 @@
       if (S.mode !== 'NAV') { S.returnMode = S.mode === 'SEEK' ? 'PLAYER' : S.mode; clearSeek(); S.mode = 'NAV'; S.sub = null; S.menu = null; }
       if (!S.focused || !scope.contains(S.focused)) {
         const bl = collectBlocks(scope);
+        trace('scope grabbed key: ' + describe(scope) + ' blocks=' + bl.length);
         if (bl.length) { S.beforeScope = S.focused; setFocus(bl[0]); if (act !== A.BACK) return; }
       }
     } else if (S.returnMode) {
@@ -936,6 +984,8 @@
   function init() {
     if (window.__tvNav && window.__tvNav.destroy) window.__tvNav.destroy(); // hot re-install (dev)
     injectCSS();
+    showPreviousTrace();
+    trace('init ' + location.pathname + ' ' + innerWidth + 'x' + innerHeight);
     addEventListener('keydown', onKeySafe, true);
     patchHistory();
     const onRouteSafe = safe('route', checkRoute);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "phimpal-tv",
-  "version": "0.2.1",
+  "version": "0.2.2",
   "description": "D-pad (TV remote) navigation for phimpal.com on Samsung Tizen TVs, as a TizenBrew site-modification module.",
   "appName": "PhimPal TV",
   "packageType": "mods",