phasegate 0.335.0 → 0.341.0

package/scripts/harness/installation/application/usecases/run-doctor-diagnostics.ts

@@ -6,7 +6,10 @@
 // @work-item-id WI-215
 // @work-item-id WI-330
 // @work-item-id WI-343
+// @work-item-id WI-385
+// @work-item-id WI-390
 
+import type { AgentTarget } from "../../domain/agent-target.js";
 import type { CheckId } from "../../domain/check-id.js";
 import type { ConfigStatus } from "../../domain/config-status.js";
 import type { DiagnosticFinding } from "../../domain/diagnostic-finding.js";
@@ -16,7 +19,7 @@ import type { ConfigStatusProbePort } from "../ports/config-status-probe-port.js
 import type { FileInspectorPort } from "../ports/file-inspector-port.js";
 import type { ManifestRepositoryPort } from "../ports/manifest-repository-port.js";
 
-export type DoctorAgentScope = "claude" | "codex" | "both";
+export type DoctorAgentScope = AgentTarget;
 
 export interface ScopedOutDiagnosticFinding {
   readonly finding: DiagnosticFinding;
@@ -40,10 +43,13 @@ export interface RunDoctorDiagnosticsOutput {
 
 const CLAUDE_ONLY_CHECKS = new Set<CheckId>(["claude-hook-missing", "claude-context-missing", "claude-skills-symlink"]);
 const CODEX_ONLY_CHECKS = new Set<CheckId>(["codex-hook-missing", "codex-context-missing", "codex-skills-symlink"]);
+const CLAUDE_COMPATIBLE_CHECKS = new Set<CheckId>(["grok-hook-missing"]);
+const ANTIGRAVITY_ONLY_CHECKS = new Set<CheckId>(["antigravity-hook-missing"]);
 const PERSONAL_SCOPED_OUT_CHECKS = new Set<CheckId>([
   "husky-pre-commit-missing",
   "husky-commit-msg-missing",
   "husky-pre-push-missing",
+  "husky-runtime-inactive",
   "ci-workflow-missing",
   "package-json-devdep-missing",
 ]);
@@ -65,9 +71,7 @@ export class RunDoctorDiagnosticsUseCase {
         : "project";
     const configStatus = (await this.configStatusProbe.probe(input.projectRoot)).status;
     const rawFindings = (
-      await Promise.all(
-        this.checks.map((check) => check.run(input.projectRoot, this.inspector, { installationMode })),
-      )
+      await Promise.all(this.checks.map((check) => check.run(input.projectRoot, this.inspector, { installationMode })))
     ).filter((finding) => finding !== null);
     const { findings, scopedOutFindings } = this.applyPersonalScope(
       this.applyAgentScope(rawFindings, agent),
@@ -91,12 +95,10 @@ export class RunDoctorDiagnosticsUseCase {
     readonly findings: readonly DiagnosticFinding[];
     readonly scopedOutFindings: readonly ScopedOutDiagnosticFinding[];
   } {
-    if (agent === "both") return { findings, scopedOutFindings: [] };
-    const scopedOutChecks = agent === "claude" ? CODEX_ONLY_CHECKS : CLAUDE_ONLY_CHECKS;
     const applicable: DiagnosticFinding[] = [];
     const scopedOut: ScopedOutDiagnosticFinding[] = [];
     for (const finding of findings) {
-      if (scopedOutChecks.has(finding.checkId)) {
+      if (!this.isApplicableAgentCheck(finding.checkId, agent)) {
         scopedOut.push({
           finding,
           scopeReason: `${finding.checkId} belongs to an unselected agent for doctor --agent ${agent}.`,
@@ -108,6 +110,15 @@ export class RunDoctorDiagnosticsUseCase {
     return { findings: applicable, scopedOutFindings: scopedOut };
   }
 
+  private isApplicableAgentCheck(checkId: CheckId, agent: DoctorAgentScope): boolean {
+    if (CLAUDE_ONLY_CHECKS.has(checkId)) return agent === "claude" || agent === "both" || agent === "all";
+    if (CODEX_ONLY_CHECKS.has(checkId)) return agent === "codex" || agent === "both" || agent === "all";
+    if (CLAUDE_COMPATIBLE_CHECKS.has(checkId))
+      return agent === "claude" || agent === "both" || agent === "grok" || agent === "all";
+    if (ANTIGRAVITY_ONLY_CHECKS.has(checkId)) return agent === "antigravity" || agent === "all";
+    return true;
+  }
+
   private applyPersonalScope(
     scoped: {
       readonly findings: readonly DiagnosticFinding[];

package/scripts/harness/installation/application/usecases/run-install.ts

@@ -19,6 +19,8 @@
 // @work-item-id WI-315
 // @work-item-id WI-326
 // @work-item-id WI-331
+// @work-item-id WI-385
+// @work-item-id WI-387
 
 import {
   access,
@@ -34,11 +36,13 @@ import {
   writeFile,
 } from "node:fs/promises";
 import { dirname, join } from "node:path";
+import { type AgentTarget, resolveAgentTarget } from "../../domain/agent-target.js";
 import { DeploymentEntry } from "../../domain/deployment-entry.js";
 import { DeploymentManifest, type InstallationFlags } from "../../domain/deployment-manifest.js";
 import type { ManagedBlockInput } from "../../domain/managed-block.js";
 import type { RepairMode } from "../../domain/repair-mode.js";
 import { getBundledSkillsForSet, type SkillSet } from "../bundled-skill-selection.js";
+import { mergeNamedHookJson } from "../named-hook-json.js";
 import type { HashCalculatorPort } from "../ports/hash-calculator-port.js";
 import type { ManifestRepositoryPort } from "../ports/manifest-repository-port.js";
 import type { ModelDelegationPort } from "../ports/model-delegation-port.js";
@@ -46,6 +50,7 @@ import type { ModelDelegationPort } from "../ports/model-delegation-port.js";
 type InstallAction = "missing" | "will-merge" | "will-skip" | "will-overwrite";
 type StrategyType =
   | "json"
+  | "json-named"
   | "shell"
   | "yaml-add"
   | "package-json"
@@ -81,9 +86,9 @@ export interface RunInstallInput {
   readonly includeCodex?: boolean;
   readonly includeHusky?: boolean;
   readonly includeCi?: boolean;
-  readonly skillSet?: "core" | "all";
+  readonly skillSet?: SkillSet;
   readonly workflow?: "standard" | "strict";
-  readonly agent?: "claude" | "codex" | "both";
+  readonly agent?: AgentTarget;
   readonly personal?: boolean;
 }
 
@@ -130,6 +135,7 @@ const PERSONAL_AGENT_RUNTIME_FILES = new Set([
   ".claude/settings.json",
   "AGENTS.md",
   ".codex/hooks.json",
+  ".agents/hooks.json",
 ]);
 const SHARED_SKILLS_VERSION_PATH = "skills/.harness-version";
 const PERSONAL_PRINCIPLES_DOCS = ".phasegate-local/docs/principles";
@@ -361,8 +367,8 @@ function mergeManagedMarkdown(existing: string | null, incoming: string): string
 function renderAgentContextTemplate(
   template: string,
   options: {
-    readonly agent: "claude" | "codex" | "both";
-    readonly skillSet: "core" | "all";
+    readonly agent: AgentTarget;
+    readonly skillSet: SkillSet;
     readonly workflow: "standard" | "strict";
     readonly includeHusky: boolean;
     readonly includeCi: boolean;
@@ -382,7 +388,7 @@ function renderAgentContextTemplate(
     .replaceAll("{{PHASEGATE_HUSKY_STATE}}", options.includeHusky ? "managed" : "not managed by this setup run")
     .replaceAll("{{PHASEGATE_CI_STATE}}", options.includeCi ? "managed" : "not managed by this setup run")
     .replaceAll("{{PHASEGATE_COMMANDS}}", commands)
-    .replaceAll("{{PHASEGATE_SKILLS}}", options.skillSet === "core" ? "- `core skills`" : "- `all bundled skills`")
+    .replaceAll("{{PHASEGATE_SKILLS}}", options.skillSet === "all" ? "- `all bundled skills`" : `- \`${options.skillSet} skills\``)
     .replaceAll("{{PHASEGATE_PRESETS}}", "- `minimal`\n- `standard`\n- `full`\n- `custom`")
     .replaceAll("{{PHASEGATE_USER_SECTION}}", USER_SECTION_PLACEHOLDER);
 }
@@ -409,20 +415,6 @@ function mergePackageJson(existing: Record<string, unknown>, version: string): R
   };
 }
 
-function hasCustomJson(content: string | null): boolean {
-  if (content === null) return false;
-  try {
-    const parsed = JSON.parse(content) as unknown;
-    if (!isRecord(parsed)) return true;
-    const withoutEmptyHooks = { ...parsed };
-    if (isRecord(withoutEmptyHooks.hooks) && Object.keys(withoutEmptyHooks.hooks).length === 0)
-      delete withoutEmptyHooks.hooks;
-    return Object.keys(withoutEmptyHooks).length > 0;
-  } catch {
-    return true;
-  }
-}
-
 function errorCode(error: unknown): string {
   if (isRecord(error) && typeof error.code === "string") return error.code;
   return "UNKNOWN";
@@ -471,17 +463,19 @@ export class RunInstallUseCase {
   ) {}
 
   async execute(input: RunInstallInput): Promise<RunInstallResult> {
-    const includeClaude = input.includeClaude ?? true;
-    const includeCodex = input.includeCodex ?? true;
+    const legacyIncludeClaude = input.includeClaude ?? true;
+    const legacyIncludeCodex = input.includeCodex ?? true;
     const includeHusky = input.includeHusky ?? true;
     const includeCi = input.includeCi ?? true;
     const skillSet = input.skillSet ?? "all";
     const workflow = input.workflow ?? "standard";
-    const agent = input.agent ?? (includeClaude && includeCodex ? "both" : includeCodex ? "codex" : "claude");
+    const agent =
+      input.agent ?? (legacyIncludeClaude && legacyIncludeCodex ? "both" : legacyIncludeCodex ? "codex" : "claude");
+    const selection = resolveAgentTarget(agent);
     const personal = input.personal ?? false;
     const targets = personal
-      ? this.createPersonalTargets({ includeClaude, includeCodex })
-      : this.createTargets({ includeClaude, includeCodex, includeHusky, includeCi });
+      ? this.createPersonalTargets(selection)
+      : this.createTargets({ ...selection, includeHusky, includeCi });
     // Persist the effective opt-in state so a later reconcile can honor the
     // original install options. Personal installs never deploy Husky/CI
     // targets, so their effective state is recorded as false regardless of
@@ -584,7 +578,7 @@ export class RunInstallUseCase {
       const mode = before === null ? "created" : "merged";
       const hash = this.hashCalculator.compute(next);
       const manifestEntry = baseManifest.findEntry(target.path);
-      if (manifestEntry !== null && manifestEntry.hash.equals(hash)) {
+      if (manifestEntry?.hash.equals(hash)) {
         manifest = manifest.addEntry(manifestEntry);
       } else {
         manifest = manifest.addEntry(
@@ -600,7 +594,11 @@ export class RunInstallUseCase {
     }
 
     const personalSkillTargets = input.personal
-      ? [...(includeClaude ? [".claude/skills"] : []), ...(includeCodex ? [".codex/skills"] : [])]
+      ? [
+          ...(selection.claudeSkills ? [".claude/skills"] : []),
+          ...(selection.codexSkills ? [".codex/skills"] : []),
+          ...(selection.antigravitySkills ? [".agents/skills"] : []),
+        ]
       : [];
     const selectedPersonalSkills = input.personal ? await listSelectedBundledSkills(input.harnessRoot, skillSet) : [];
     for (const skillPath of personalSkillTargets) {
@@ -644,7 +642,7 @@ export class RunInstallUseCase {
       }
     }
 
-    if (!input.personal && (includeClaude || includeCodex)) {
+    if (!input.personal && (selection.claudeSkills || selection.codexSkills || selection.antigravitySkills)) {
       const sharedSkills = await listSelectedBundledSkills(input.harnessRoot, skillSet);
       const item = await this.planSharedSkillDirectory(input, sharedSkills, baseManifest);
       plan.push(item);
@@ -673,8 +671,9 @@ export class RunInstallUseCase {
     const linkSpecs = input.personal
       ? []
       : [
-          ...(includeClaude ? [{ path: ".claude/skills", target: "../skills" }] : []),
-          ...(includeCodex ? [{ path: ".codex/skills", target: "../skills" }] : []),
+          ...(selection.claudeSkills ? [{ path: ".claude/skills", target: "../skills" }] : []),
+          ...(selection.codexSkills ? [{ path: ".codex/skills", target: "../skills" }] : []),
+          ...(selection.antigravitySkills ? [{ path: ".agents/skills", target: "../skills" }] : []),
         ];
     for (const linkSpec of linkSpecs) {
       const item = await this.planSkillLink(input.projectRoot, linkSpec.path, linkSpec.target);
@@ -703,7 +702,7 @@ export class RunInstallUseCase {
       });
     }
 
-    if (input.personal && includeCodex) {
+    if (input.personal && selection.codexHook) {
       plan.push({
         path: "~/.codex/config.toml",
         action: "will-skip",
@@ -770,8 +769,11 @@ export class RunInstallUseCase {
   }
 
   private createTargets(options: {
-    readonly includeClaude: boolean;
-    readonly includeCodex: boolean;
+    readonly claudeHook: boolean;
+    readonly claudeContext: boolean;
+    readonly codexHook: boolean;
+    readonly agentsContext: boolean;
+    readonly antigravityHook: boolean;
     readonly includeHusky: boolean;
     readonly includeCi: boolean;
   }): readonly InstallTarget[] {
@@ -781,7 +783,7 @@ export class RunInstallUseCase {
         strategy: "copy" as const,
         templatePath: "docs/templates/project/phasegate.config.json",
       },
-      ...(options.includeClaude
+      ...(options.claudeHook
         ? [
             {
               path: ".claude/settings.json",
@@ -789,16 +791,60 @@ export class RunInstallUseCase {
               templatePath: "templates/.claude/settings.json",
             },
             {
-              path: "CLAUDE.md",
-              strategy: "markdown-managed" as const,
-              templatePath: "docs/templates/agent-context/CLAUDE.md.template.md",
-              block: { start: MARKDOWN_BEGIN, end: MARKDOWN_END, content: "phasegate CLAUDE.md managed section" },
+              path: ".claude/scripts/deny-check.sh",
+              strategy: "shell" as const,
+              templatePath: "templates/.claude/scripts/deny-check.sh",
+              executable: true,
+            },
+            {
+              path: ".claude/scripts/format-settings-hook.sh",
+              strategy: "shell" as const,
+              templatePath: "templates/.claude/scripts/format-settings-hook.sh",
+              executable: true,
+            },
+            {
+              path: ".claude/scripts/format-typescript-hook.sh",
+              strategy: "shell" as const,
+              templatePath: "templates/.claude/scripts/format-typescript-hook.sh",
+              executable: true,
             },
+            {
+              path: ".claude/scripts/analyze-errors-hook.sh",
+              strategy: "shell" as const,
+              templatePath: "templates/.claude/scripts/analyze-errors-hook.sh",
+              executable: true,
+            },
+            {
+              path: ".claude/scripts/hook-config.json",
+              strategy: "copy" as const,
+              templatePath: "templates/.claude/scripts/hook-config.json",
+            },
+            ...(options.claudeContext
+              ? [
+                  {
+                    path: "CLAUDE.md",
+                    strategy: "markdown-managed" as const,
+                    templatePath: "docs/templates/agent-context/CLAUDE.md.template.md",
+                    block: { start: MARKDOWN_BEGIN, end: MARKDOWN_END, content: "phasegate CLAUDE.md managed section" },
+                  },
+                ]
+              : []),
           ]
         : []),
-      ...(options.includeCodex
+      ...(options.codexHook
+        ? [{ path: ".codex/hooks.json", strategy: "json" as const, templatePath: "templates/.codex/hooks.json" }]
+        : []),
+      ...(options.antigravityHook
+        ? [
+            {
+              path: ".agents/hooks.json",
+              strategy: "json-named" as const,
+              templatePath: "templates/.agents/hooks.json",
+            },
+          ]
+        : []),
+      ...(options.agentsContext
         ? [
-            { path: ".codex/hooks.json", strategy: "json" as const, templatePath: "templates/.codex/hooks.json" },
             {
               path: "AGENTS.md",
               strategy: "markdown-managed" as const,
@@ -846,8 +892,11 @@ export class RunInstallUseCase {
   }
 
   private createPersonalTargets(options: {
-    readonly includeClaude: boolean;
-    readonly includeCodex: boolean;
+    readonly claudeHook: boolean;
+    readonly claudeContext: boolean;
+    readonly codexHook: boolean;
+    readonly agentsContext: boolean;
+    readonly antigravityHook: boolean;
   }): readonly InstallTarget[] {
     return [
       {
@@ -855,27 +904,60 @@ export class RunInstallUseCase {
         strategy: "copy" as const,
         templatePath: "docs/templates/personal/phasegate-local-config.json",
       },
-      ...(options.includeClaude
+      ...(options.claudeHook
         ? [
-            {
-              path: ".claude/CLAUDE.md",
-              strategy: "markdown-managed" as const,
-              templatePath: "docs/templates/agent-context/CLAUDE.md.template.md",
-              block: {
-                start: MARKDOWN_BEGIN,
-                end: MARKDOWN_END,
-                content: "phasegate personal .claude/CLAUDE.md managed section",
-              },
-              personalManualIfUnmanaged: true,
-            },
+            ...(options.claudeContext
+              ? [
+                  {
+                    path: ".claude/CLAUDE.md",
+                    strategy: "markdown-managed" as const,
+                    templatePath: "docs/templates/agent-context/CLAUDE.md.template.md",
+                    block: {
+                      start: MARKDOWN_BEGIN,
+                      end: MARKDOWN_END,
+                      content: "phasegate personal .claude/CLAUDE.md managed section",
+                    },
+                    personalManualIfUnmanaged: true,
+                  },
+                ]
+              : []),
             {
               path: ".claude/settings.json",
               strategy: "copy" as const,
               templatePath: "templates/.claude/settings.json",
             },
+            {
+              path: ".claude/scripts/deny-check.sh",
+              strategy: "shell" as const,
+              templatePath: "templates/.claude/scripts/deny-check.sh",
+              executable: true,
+            },
+            {
+              path: ".claude/scripts/format-settings-hook.sh",
+              strategy: "shell" as const,
+              templatePath: "templates/.claude/scripts/format-settings-hook.sh",
+              executable: true,
+            },
+            {
+              path: ".claude/scripts/format-typescript-hook.sh",
+              strategy: "shell" as const,
+              templatePath: "templates/.claude/scripts/format-typescript-hook.sh",
+              executable: true,
+            },
+            {
+              path: ".claude/scripts/analyze-errors-hook.sh",
+              strategy: "shell" as const,
+              templatePath: "templates/.claude/scripts/analyze-errors-hook.sh",
+              executable: true,
+            },
+            {
+              path: ".claude/scripts/hook-config.json",
+              strategy: "copy" as const,
+              templatePath: "templates/.claude/scripts/hook-config.json",
+            },
           ]
         : []),
-      ...(options.includeCodex
+      ...(options.agentsContext
         ? [
             {
               path: "AGENTS.md",
@@ -888,6 +970,10 @@ export class RunInstallUseCase {
               },
               personalManualIfUnmanaged: true,
             },
+          ]
+        : []),
+      ...(options.codexHook
+        ? [
             {
               path: ".codex/hooks.json",
               strategy: "copy" as const,
@@ -895,6 +981,15 @@ export class RunInstallUseCase {
             },
           ]
         : []),
+      ...(options.antigravityHook
+        ? [
+            {
+              path: ".agents/hooks.json",
+              strategy: "json-named" as const,
+              templatePath: "templates/.agents/hooks.json",
+            },
+          ]
+        : []),
       {
         path: ".git/hooks/pre-commit",
         strategy: "copy" as const,
@@ -943,6 +1038,7 @@ export class RunInstallUseCase {
     if (target.strategy === "copy-dir") return "mechanical";
     if (target.strategy === "symlink") return "mechanical";
     if (target.strategy === "json") return jsonRepairMode(before);
+    if (target.strategy === "json-named") return jsonRepairMode(before);
     if (target.strategy === "markdown-managed") return "mechanical";
     return "mechanical";
   }
@@ -966,6 +1062,10 @@ export class RunInstallUseCase {
     }
     const existing = before === null ? {} : (JSON.parse(before) as unknown);
     const incoming = JSON.parse(template) as unknown;
+    if (target.strategy === "json-named") {
+      const merged = mergeNamedHookJson(isRecord(existing) ? existing : {}, isRecord(incoming) ? incoming : {});
+      return `${JSON.stringify(merged, null, 2)}\n`;
+    }
     const merged = mergeJsonObject(isRecord(existing) ? existing : {}, isRecord(incoming) ? incoming : {});
     return `${JSON.stringify(merged, null, 2)}\n`;
   }
@@ -1046,13 +1146,13 @@ export class RunInstallUseCase {
   private personalSkillsVersionHashInput(
     path: string,
     version: string,
-    skillSet: "core" | "all",
+    skillSet: SkillSet,
     skills: readonly string[],
   ): string {
     return `personal-skills-version:${path}:${version}:${skillSet}:${skills.join(",")}`;
   }
 
-  private personalSkillHashInput(path: string, skill: string, version: string, skillSet: "core" | "all"): string {
+  private personalSkillHashInput(path: string, skill: string, version: string, skillSet: SkillSet): string {
     return `personal-skill:${path}:${skill}:${version}:${skillSet}`;
   }
 
@@ -1124,7 +1224,7 @@ export class RunInstallUseCase {
   ): DeploymentManifest {
     const hash = this.hashCalculator.compute(input.contentForHash);
     const existingEntry = baseManifest.findEntry(input.path);
-    if (existingEntry !== null && existingEntry.hash.equals(hash)) {
+    if (existingEntry?.hash.equals(hash)) {
       return manifest.addEntry(existingEntry);
     }
     return manifest.addEntry(