phasegate 0.191.0 → 0.212.0

package/scripts/harness/config-foundation/application/mappers/validator-system-config-mapper.ts

@@ -4,50 +4,70 @@
  * @work-item-id WI-133 / WI-156
  * @work-item-id WI-217
  * @work-item-id WI-212
+ * @work-item-id WI-258
+ * @work-item-id WI-259
  */
-import type { HarnessConfigV2 } from '../../domain/harness-config.js';
+import type { HarnessConfigV2 } from "../../domain/harness-config.js";
 
 export function toValidatorSystemConfig(resolvedConfig: HarnessConfigV2 | undefined): object | undefined {
   if (!resolvedConfig) return undefined;
 
-  const l3Validators = normalizeValidators(resolvedConfig.layers.L3.validators, {
-    security: 'L3-001',
-    performance: 'L3-002',
-    coverage: 'L3-003',
-    nyquist: 'L3-004',
-    'ac-bound-coverage': 'L3-005',
-  }, /^L3-\d{3}$/);
-  const l4Validators = normalizeValidators(resolvedConfig.layers.L4.validators, {
-    'drift-detect': 'L4-001',
-    'drift-detector': 'L4-001',
-    'consistency-check': 'L4-002',
-    'consistency-checker': 'L4-002',
-    'dead-code': 'L4-003',
-    'dead-code-detector': 'L4-003',
-    'doc-freshness': 'L4-004',
-    'doc-freshness-checker': 'L4-004',
-    'pointer-validation': 'L4-005',
-    'pointer-validator': 'L4-005',
-    'skill-catalog-drift': 'L4-006',
-  }, /^L4-\d{3}$/);
+  const l3Validators = normalizeValidators(
+    resolvedConfig.layers.L3.validators,
+    {
+      security: "L3-001",
+      performance: "L3-002",
+      coverage: "L3-003",
+      nyquist: "L3-004",
+      "ac-bound-coverage": "L3-005",
+      "injection-scan": "L3-006",
+    },
+    /^L3-\d{3}$/,
+  );
+  const l4Validators = normalizeValidators(
+    resolvedConfig.layers.L4.validators,
+    {
+      "drift-detect": "L4-001",
+      "drift-detector": "L4-001",
+      "consistency-check": "L4-002",
+      "consistency-checker": "L4-002",
+      "dead-code": "L4-003",
+      "dead-code-detector": "L4-003",
+      "doc-freshness": "L4-004",
+      "doc-freshness-checker": "L4-004",
+      "pointer-validation": "L4-005",
+      "pointer-validator": "L4-005",
+      "skill-catalog-drift": "L4-006",
+    },
+    /^L4-\d{3}$/,
+  );
   const effectiveL4Validators = usesCustomDocumentRoots(resolvedConfig)
-    ? includeValidator(l4Validators, 'L4-002')
+    ? includeValidator(l4Validators, "L4-002")
     : l4Validators;
 
   return {
     project: {
       preset: resolvedConfig.project.preset,
-      languages: resolvedConfig.project.languages ?? ['typescript'],
+      languages: resolvedConfig.project.languages ?? ["typescript"],
     },
     paths: {
       designDocs: resolvedConfig.paths.designDocs,
       inceptionDocs: resolvedConfig.paths.inceptionDocs,
     },
     layers: {
-      L2: { enabled: resolvedConfig.layers.L2.enabled, validators: ['L2-001', 'L2-002', 'L2-003', 'L2-013', 'L2-014', 'L2-015'] },
+      // WI-258 / ADR-030 §Decision.3.②: L2-016 (coverage-attestation-gating) を default-ON でリストに含める。
+      L2: {
+        enabled: resolvedConfig.layers.L2.enabled,
+        validators: ["L2-001", "L2-002", "L2-003", "L2-013", "L2-014", "L2-015", "L2-016"],
+      },
       L3: {
         enabled: resolvedConfig.layers.L3.enabled,
-        validators: l3Validators.length > 0 ? l3Validators : ['L3-001', 'L3-002', 'L3-003', 'L3-004'],
+        // WI-259 / ADR-030 §Decision.3.④: L3-006 (injection-scan) は advisory default-ON。
+        // fallback 判定の後に force-include し、normalize 結果でも fallback でも常に含める（warning-only ゆえ安全）。
+        validators: includeValidator(
+          l3Validators.length > 0 ? l3Validators : ["L3-001", "L3-002", "L3-003", "L3-004"],
+          "L3-006",
+        ),
         coverageThreshold: resolvedConfig.layers.L3.coverageThreshold,
         requirementMatrixPath: resolvedConfig.layers.L3.requirementMatrixPath,
         // WI-227 / H16-03: L3-005 のスコープ（additive-safe。未設定は []）
@@ -55,7 +75,10 @@ export function toValidatorSystemConfig(resolvedConfig: HarnessConfigV2 | undefi
       },
       L4: {
         enabled: resolvedConfig.layers.L4.enabled,
-        validators: effectiveL4Validators.length > 0 ? effectiveL4Validators : ['L4-001', 'L4-002', 'L4-003', 'L4-004', 'L4-005', 'L4-006'],
+        validators:
+          effectiveL4Validators.length > 0
+            ? effectiveL4Validators
+            : ["L4-001", "L4-002", "L4-003", "L4-004", "L4-005", "L4-006"],
       },
     },
     harnesses: {
@@ -70,8 +93,10 @@ export function toValidatorSystemConfig(resolvedConfig: HarnessConfigV2 | undefi
 }
 
 function usesCustomDocumentRoots(resolvedConfig: HarnessConfigV2): boolean {
-  return resolvedConfig.paths.designDocs !== 'docs/product/construction'
-    || resolvedConfig.paths.inceptionDocs !== 'docs/inception';
+  return (
+    resolvedConfig.paths.designDocs !== "docs/product/construction" ||
+    resolvedConfig.paths.inceptionDocs !== "docs/inception"
+  );
 }
 
 function includeValidator(validators: readonly string[], validatorId: string): readonly string[] {

package/scripts/harness/harness-api/domain/value-objects/ci-check-result.ts

@@ -2,7 +2,7 @@
 // @unit harness-api
 // ci-check-result.ts — CiCheckResult Value Object
 
-import type { HarnessError } from './harness-api-response.js';
+import type { HarnessError } from "./harness-api-response.js";
 
 export interface ValidatorCheckItem {
   validatorId: string;
@@ -14,6 +14,30 @@ export interface ValidatorCheckItem {
 export interface CiCheckResultProps {
   validatorResults: readonly ValidatorCheckItem[];
   allPassed: boolean;
+  /** WI-260 / ADR-017: warning-only failure を fail 扱いにする opt-in（既定 false）。 */
+  failOnWarning?: boolean;
+}
+
+/**
+ * WI-260 / ADR-017: validator 1件が「実質 pass」か判定する severity-aware ルール。
+ * `validate` 経路の AggregateValidationResultsUseCase と同一の判定式を harness-api の
+ * domain VO 側に持たせ、ci-check と validate の集約挙動を一致させる（レイヤー越境回避のため
+ * usecase を直接 import せず判定ロジックを共有）。
+ *
+ * - skipped: 実質 pass
+ * - passed=true: 実質 pass
+ * - passed=false かつ error severity（!= warning）を含む: fail
+ * - passed=false かつ errors=[]（severity 判定不能）: 安全側に倒して fail
+ * - passed=false かつ warning のみ: failOnWarning=false（既定）で実質 pass、true で fail
+ */
+function isEffectivelyPassed(item: ValidatorCheckItem, failOnWarning: boolean): boolean {
+  if (item.skipped || item.passed) return true;
+  const errors = item.errors ?? [];
+  const hasNonWarningError = errors.some((e) => e.severity !== "warning");
+  const hasWarnings = errors.some((e) => e.severity === "warning");
+  const isEmptyFail = errors.length === 0;
+  const hasFail = isEmptyFail || hasNonWarningError || (failOnWarning && hasWarnings);
+  return !hasFail;
 }
 
 export class CiCheckResult {
@@ -29,23 +53,24 @@ export class CiCheckResult {
   static create(props: CiCheckResultProps): CiCheckResult {
     // INV-5: validatorResults は 1件以上
     if (!props.validatorResults || props.validatorResults.length === 0) {
-      throw new Error('EmptyValidatorResultsError: validatorResults must have at least one item (INV-5)');
+      throw new Error("EmptyValidatorResultsError: validatorResults must have at least one item (INV-5)");
     }
-    // INV-6: allPassed === validatorResults.every(r => r.passed || r.skipped)
-    const computedAllPassed = props.validatorResults.every((r) => r.passed || r.skipped);
+    // INV-6 (WI-260/ADR-017 更新): allPassed === validatorResults.every(実質pass)
+    const failOnWarning = props.failOnWarning ?? false;
+    const computedAllPassed = props.validatorResults.every((r) => isEffectivelyPassed(r, failOnWarning));
     if (props.allPassed !== computedAllPassed) {
       throw new Error(
-        `HarnessApiDomainError: allPassed=${props.allPassed} does not match validatorResults state (computed: ${computedAllPassed})`
+        `HarnessApiDomainError: allPassed=${props.allPassed} does not match validatorResults state (computed: ${computedAllPassed})`,
       );
     }
     return new CiCheckResult(props.validatorResults, props.allPassed);
   }
 
-  static fromResults(validatorResults: readonly ValidatorCheckItem[]): CiCheckResult {
+  static fromResults(validatorResults: readonly ValidatorCheckItem[], failOnWarning = false): CiCheckResult {
     if (!validatorResults || validatorResults.length === 0) {
-      throw new Error('EmptyValidatorResultsError: validatorResults must have at least one item (INV-5)');
+      throw new Error("EmptyValidatorResultsError: validatorResults must have at least one item (INV-5)");
     }
-    const allPassed = validatorResults.every((r) => r.passed || r.skipped);
+    const allPassed = validatorResults.every((r) => isEffectivelyPassed(r, failOnWarning));
     return new CiCheckResult(validatorResults, allPassed);
   }
 

package/scripts/harness/harness-api/domain/value-objects/known-harness-commands.ts

@@ -0,0 +1,90 @@
+// @unit harness-api
+// @layer domain
+// @work-item-id WI-250
+// known-harness-commands.ts — CLI 実サーフェスの canonical 既知コマンド一覧
+//
+// main.ts の CLI dispatch（`switch (command)`）が受理する全トップレベルコマンド名の
+// 単一ソース。`phasegate:` prefix 必須の CommandRegistry では表現できない
+// 非 prefix コマンド（lint / init / baseline 等）を含む完全なサーフェスを表す。
+//
+// 不変条件（conformance テストで強制）:
+// - main.ts の `case "..."` ラベル集合と集合一致すること
+//   （__tests__/integration/harness-api/known-harness-commands-conformance.test.ts）
+// - エントリは重複なくソート済みであること
+//
+// main.ts にコマンドを追加/削除した場合は、必ずこのリストも同期更新すること。
+
+export const KNOWN_HARNESS_COMMANDS: readonly string[] = Object.freeze([
+  "baseline",
+  "bypass:audit",
+  "check-change-category",
+  "check-phase-gate",
+  "ci-check",
+  "ci:auto-refresh-agent-context",
+  "ci:check-repetition",
+  "ci:generate-template",
+  "ci:migrate-agents-md",
+  "commit-msg",
+  "complete-check",
+  "config:plan",
+  "delegate-sonnet",
+  "disable-feature",
+  "doctor",
+  "emit-agent-rules",
+  "enable-feature",
+  "hook",
+  "init",
+  "install",
+  "integrity:pin",
+  "integrity:verify",
+  "lint",
+  "list-adrs",
+  "list-errors",
+  "list-features",
+  "migrate",
+  "p2:check-agent-context",
+  "p2:check-freshness",
+  "p2:check-initial-creation",
+  "p2:generate-e2e-template",
+  "p2:validate-pointers",
+  "phasegate:attest",
+  "phasegate:check-phase",
+  "phasegate:check-ready",
+  "phasegate:ci-check",
+  "phasegate:complete-check",
+  "phasegate:detect-drift",
+  "phasegate:generate-matrix",
+  "phasegate:impact-analysis",
+  "phasegate:lint",
+  "phasegate:status",
+  "phasegate:verify-attestation",
+  "pre-commit",
+  "reconcile",
+  "refresh-claude-md",
+  "regression:analyze-migration",
+  "regression:configure-ci-gate",
+  "regression:migrate-v0-tests",
+  "regression:run-agent-guard",
+  "regression:run-gng-gate",
+  "regression:run-k-requirements",
+  "regression:run-k14-k15",
+  "render-errors",
+  "scaffold-design",
+  "scaffold-wi",
+  "session",
+  "setup:agent",
+  "skill:apply-cascade-update",
+  "skill:check-coverage",
+  "skill:collect-lessons",
+  "skill:execute-tdd-cycle",
+  "skill:validate-structure",
+  "skills",
+  "status",
+  "uninstall",
+  "update-skills",
+  "validate",
+  "validate-adr",
+  "validate-fix",
+  "validate-metadata",
+  "work-items:status",
+]);

package/scripts/harness/installation/application/bundled-skill-selection.ts

@@ -8,17 +8,15 @@ const CORE_SKILLS = [
   "cascade-updater",
   "codebase-mapper",
   "consistency-checker",
-  "doc-freshness-checker",
+  "doc-health-checker",
   "engineering-perspective",
   "implementation-readiness-checker",
-  "pointer-validator",
   "test-coverage-checker",
 ] as const;
 
 const AIDLC_SKILLS = [
   "domain-designer",
   "environment-designer",
-  "implementation-planner",
   "it-test-designer",
   "it-test-logic-designer",
   "logical-designer",
@@ -37,10 +35,9 @@ const AIDLC_SKILLS = [
 ] as const;
 
 const UTILITY_SKILLS = ["codex-delegator", "skill-creator"] as const;
-const GUIDANCE_SKILLS = ["phasegate-toolkit-guide", "phasegate-config-doctor"] as const;
+const GUIDANCE_SKILLS = ["phasegate-toolkit-guide", "phasegate-config-doctor", "release-publisher"] as const;
 
 export function getBundledSkillsForSet(skillSet: SkillSet): string[] {
   if (skillSet === "core") return [...CORE_SKILLS];
   return [...CORE_SKILLS, ...AIDLC_SKILLS, ...UTILITY_SKILLS, ...GUIDANCE_SKILLS];
 }
-